RFR(XXS) 8223184: Shenandoah: Missing roots in SRP::process_all_roots_slow

[Zhengyu Gu]

On 5/1/19 8:34 AM, Aleksey Shipilev wrote:
> On 5/1/19 2:32 PM, Zhengyu Gu wrote:
>> Added missing roots in SRP::process_all_root_slow().
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8223184
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8223184/webrev.00/
> 
> Looks good.

Thanks for reviewing.
> 
> We have JvmtiExport::oops_do call in the same method, it does not catch what
> JvmtiExport::weak_oops_do does?

No, they scan different things.

void JvmtiExport::oops_do(OopClosure* f) {
   JvmtiCurrentBreakpoints::oops_do(f);
   JvmtiObjectAllocEventCollector::oops_do_for_all_threads(f);
}

void JvmtiExport::weak_oops_do(BoolObjectClosure* is_alive, OopClosure* f) {
   JvmtiTagMap::weak_oops_do(is_alive, f);
}

-Zhengyu

> 
> -Aleksey
>