RFR: JDK-8222926: Unify cpu related part of shenandoahBarrierSetC1 and fix build when compiler1 is disabled

[Ao Qi]

On Wed, May 8, 2019 at 4:49 PM Aleksey Shipilev <shade at redhat.com> wrote:
>
> On 5/8/19 10:43 AM, Ao Qi wrote:
> > The patch [1] dose not apply cleanly again because of JDK-8223449. And
> > src/hotspot/share/jvmci/vmStructs_jvmci.cpp needs to be updated. Here
> > is a new version:
> >
> > http://cr.openjdk.java.net/~aoqi/8222926/webrev.02/
>
> I understand the need for fixing -compiler1 configuration. I am, however, against cobbling together
> x86 and aarch64 code with sprinkled #ifdefs. It would be another story if the code was indeed the
> same, but they are not.
>
> What is the fix for -compiler1 build issue? Can it be done on its own?

Thanks for your reply, Aleksey.

If we want to fix -compiler1 build without cobbling together x86 and
aarch64 code, I think one way is to put all of the code in
shenandoahBarrierSetC1_x86.cpp and shenandoahBarrierSetC1_aarch64.cpp
into #ifdef COMPILER1 ... #endif. What do you think about this method?

>
> -Aleksey
>