RFR: JDK-8222926: Unify cpu related part of shenandoahBarrierSetC1 and fix build when compiler1 is disabled

Ao Qi aoqi at loongson.cn
Wed May 8 13:05:00 UTC 2019


On Wed, May 8, 2019 at 8:52 PM Aleksey Shipilev <shade at redhat.com> wrote:
>
> On 5/8/19 2:47 PM, Ao Qi wrote:
> > http://cr.openjdk.java.net/~aoqi/8222926/webrev.04/
>
> Yes, this looks right. To be extra sure, ask Mercurial if it knows the file history:
>
> $ hg log -f src/hotspot/cpu/aarch64/gc/shenandoah/c1/shenandoahBarrierSetC1_aarch64.cpp
> $ hg log src/hotspot/cpu/x86/gc/shenandoah/c1/shenandoahBarrierSetC1_x86.cpp
>
> ...it should go back all the way to:
>
> changeset:   52925:9c18c9d839d3
> user:        rkennke
> date:        Mon Dec 10 15:47:44 2018 +0100
> summary:     8214259: Implementation: JEP 189: Shenandoah: A Low-Pause-Time Garbage Collector
> (Experimental)

$ hg log -f src/hotspot/cpu/aarch64/gc/shenandoah/c1/shenandoahBarrierSetC1_aarch64.cpp
changeset:   54760:a1a250da545f
tag:         tip
user:        aoqi
date:        Wed May 08 20:57:12 2019 +0800
summary:     8222926: Shenandoah build fails with --with-jvm-features=-compiler1

changeset:   54423:6c0ab8bd8da5
user:        rkennke
date:        Tue Apr 02 23:00:22 2019 +0200
summary:     8221766: Load-reference barriers for Shenandoah

changeset:   53519:74a5ef4c81cc
user:        rkennke
date:        Sat Jan 26 01:21:33 2019 +0100
summary:     8217016: Shenandoah: Streamline generation of CAS barriers

changeset:   52925:9c18c9d839d3
user:        rkennke
date:        Mon Dec 10 15:47:44 2018 +0100
summary:     8214259: Implementation: JEP 189: Shenandoah: A
Low-Pause-Time Garbage Collector (Experimental)

$ hg log src/hotspot/cpu/x86/gc/shenandoah/c1/shenandoahBarrierSetC1_x86.cpp
changeset:   54760:a1a250da545f
tag:         tip
user:        aoqi
date:        Wed May 08 20:57:12 2019 +0800
summary:     8222926: Shenandoah build fails with --with-jvm-features=-compiler1

$ hg log src/hotspot/cpu/aarch64/gc/shenandoah/c1/shenandoahBarrierSetC1_aarch64.cpp
changeset:   54760:a1a250da545f
tag:         tip
user:        aoqi
date:        Wed May 08 20:57:12 2019 +0800
summary:     8222926: Shenandoah build fails with --with-jvm-features=-compiler1

$ hg log -f src/hotspot/cpu/aarch64/gc/shenandoah/c1/shenandoahBarrierSetC1_aarch64.cpp
changeset:   54760:a1a250da545f
tag:         tip
user:        aoqi
date:        Wed May 08 20:57:12 2019 +0800
summary:     8222926: Shenandoah build fails with --with-jvm-features=-compiler1

changeset:   54423:6c0ab8bd8da5
user:        rkennke
date:        Tue Apr 02 23:00:22 2019 +0200
summary:     8221766: Load-reference barriers for Shenandoah

changeset:   53519:74a5ef4c81cc
user:        rkennke
date:        Sat Jan 26 01:21:33 2019 +0100
summary:     8217016: Shenandoah: Streamline generation of CAS barriers

changeset:   52925:9c18c9d839d3
user:        rkennke
date:        Mon Dec 10 15:47:44 2018 +0100
summary:     8214259: Implementation: JEP 189: Shenandoah: A
Low-Pause-Time Garbage Collector (Experimental)

$ hg summ
parent: 54760:a1a250da545f tip
 8222926: Shenandoah build fails with --with-jvm-features=-compiler1
branch: default
commit: 350 unknown (clean)
update: (current)
phases: 1 draft

>
> I changed the synopsis for the bug to: "Shenandoah build fails with --with-jvm-features=-compiler1"
> -- please change it for the changeset you are pushing.

Updated: http://cr.openjdk.java.net/~aoqi/8222926/webrev.05/

I am not a Committers. I need a sponsor:(

Thanks,
Ao Qi
>
> -Aleksey
>


More information about the shenandoah-dev mailing list