RFR: Remove superfluous verifier line

Roman Kennke rkennke at redhat.com
Tue May 14 17:27:31 UTC 2019


Yep. Good spot!
Thanks,
Roman


> There is a weird change in Verifier here:
> 
> https://builds.shipilev.net/patch-openjdk-shenandoah-jdk/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp.sdiff.html
> 
> Roman does not know how it got there. I don't know what purpose would it serve. Anyhow, this does
> not seem related to nofwdptr patch that is currently in sh/jdk stabilization. Let's ditch it.
> 
> diff -r a6e1d65b71d1 src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp
> --- a/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp    Tue May 14 17:32:18 2019 +0200
> +++ b/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp    Tue May 14 19:15:25 2019 +0200
> @@ -276,11 +276,10 @@
>     * Verify oop fields from this object.
>     * @param obj host object for verified fields
>     */
>    void verify_oops_from(oop obj) {
>      _loc = obj;
> -    obj = ShenandoahBarrierSet::resolve_forwarded_not_null(obj);
>      obj->oop_iterate(this);
>      _loc = NULL;
>    }
> 
>    virtual void do_oop(oop* p) { do_oop_work(p); }
> 
> Testing: hotspot_gc_shenandoah (x86_64)
> 



More information about the shenandoah-dev mailing list