RFR: Backport JDK-8221435 and JDK-8221629
Aleksey Shipilev
shade at redhat.com
Thu May 16 08:47:04 UTC 2019
On 5/15/19 9:25 PM, Roman Kennke wrote:
> Webrev:
> http://cr.openjdk.java.net/~rkennke/backport-jdk11-2019-05-15/webrev.00/
Looks okay. Feels like a risky backport, are we good on testing?
Metadata does not follow our "[backport] ..." format:
8221435: Shenandoah should not mark through weak roots
8221629: Shenandoah: Cleanup class unloading logic
Also here:
460 // And finally finish class unloading
461 if (_heap->unload_classes()) {
462 _heap->unload_classes_and_cleanup_tables(full_gc);
463 } else if (ShenandoahStringDedup::is_enabled()) {
464 ShenandoahIsAliveSelector alive;
465 BoolObjectClosure* is_alive = alive.is_alive_closure();
466 ShenandoahStringDedup::unlink_or_oops_do(is_alive, NULL, false);
467 }
Are we sure class unloading and strdedup are exclusive here?
-Aleksey
More information about the shenandoah-dev
mailing list