RFR 8223774: Shenandoah: Refactor ShenandoahRootProcessor and family
Roman Kennke
rkennke at redhat.com
Thu May 16 14:39:39 UTC 2019
> On 5/16/19 9:30 AM, Roman Kennke wrote:
>>>> *) shenandoahArguments.cpp: this block is better be in
>>>> ShenandoahTraversalHeuristics?
>>>>
>>>> 186 if (strcmp(ShenandoahGCHeuristics, "traversal") == 0) {
>>>> 187 FLAG_SET_DEFAULT(ShenandoahConcurrentScanCodeRoots, false);
>>>> 188 }
>>>> 189
>>>
>>> We don't have this heuristic, let's do it in follow up RFE.
>>
>> We do:
>> src/hotspot/share/gc/shenandoah/heuristics/shenandoahTraversalHeuristics.hpp
>>
>>
>> and
>>
>> src/hotspot/share/gc/shenandoah/heuristics/shenandoahTraversalHeuristics.cpp
>>
>>
>
> Sorry, I meant can_concurrent_scan_code_roots() in heuristics ...
>
But you can put the line:
FLAG_SET_DEFAULT(ShenandoahConcurrentScanCodeRoots, false);
in the constructor of the ShenandoahTraversalHeuristics, together with
other similar lines.
Roman
More information about the shenandoah-dev
mailing list