RFR: 8223767: Shenandoah fails to build on Solaris x86_64

[Roman Kennke]

Hi Boris,

> I prepared backporting patch to sh/jdk11 and sh/jdk8:
> 
> http://cr.openjdk.java.net/~bulasevich/8223767/webrev.00.shenandoah.jdk11
> - added minor change in shared code: share/opto/compile.hpp
> 
> http://cr.openjdk.java.net/~bulasevich/8223767/webrev.00.shenandoah.jdk8.hotspot
> 
> - stdarg.h include added to satisfy va_list in shenandoahLogging.hpp
> 
> Both backports passed hotspot_gc_shenandoah on Solaris 11. For Solaris
> 10 JDK-8223980 (Refactor and fix ObjArrayChunkedTask verification) needs
> to be backported as well.

Cool! Thanks you!!

> What is the correct backport procedure?

I think for the Shenandoah parts it's fine to post them here for review,
and one of us can integrate them to shenandoah/jdk11 and shenandoah/jdk8
for you. Please prepare the changesets with prefixed [backport] in the
commit msg, e.g.:

[backport] 8223767: Shenandoah fails to build on Solaris x86_64


To be honest, I am not sure about the rather trivial change in
compile.hpp. I guess ideally this would have to go via separate change
through jdk-updates/jdk11u.

Thanks,
Roman

> regards,
> Boris
> 
> On 14.05.2019 12:25, Roman Kennke wrote:
>> Hi Boris,
>>
>> Would you help backporting the patch to sh/jdk11 and sh/jdk8 at some
>> point? It would be cool to have there, but we have no way to test it...
>>
>> Thanks,
>> Roman
>>
>>> Thanks for the review!
>>>
>>> 13.05.2019 18:43, Aleksey Shipilev:
>>>> On 5/13/19 5:27 PM, Boris Ulasevich wrote:
>>>>> http://bugs.openjdk.java.net/browse/JDK-8223767
>>>>> http://cr.openjdk.java.net/~bulasevich/8223767/webrev.00
>>>> Thank you, this looks good.
>>>>
>>>> -Aleksey
>>