RFR: Remaining Shenandoah backports jdk/jdk -> sh/jdk11
Aleksey Shipilev
shade at redhat.com
Thu May 16 18:04:04 UTC 2019
On 5/16/19 8:02 PM, Roman Kennke wrote:
>> *) The indenting is weird here in shenandoahBarrierSetAssembler_aarch64.cpp -- is it the same way in
>> upstream?
>>
>> 90 if (is_oop) {
>> 91 Label done;
>> 92
>> 93 // Avoid calling runtime if count == 0
>> 94 __ cbz(count, done);
>> 95
>> 96 // Is updating references?
>> 97 Address gc_state(rthread, in_bytes(ShenandoahThreadLocalData::gc_state_offset()));
>> 98 __ ldrb(rscratch1, gc_state);
>> 99 __ tbz(rscratch1, ShenandoahHeap::UPDATEREFS_BITPOS, done);
>> 100
>> 101 __ push(saved_regs, sp);
>>
> Yes:
> http://hg.openjdk.java.net/jdk/jdk/file/b6ee58ec8814/src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp#l90
>
> Want me to change it for 11 now?
No. Better have the same code. Reformats would apply later as we refactor code nearby in upstream.
--
Thanks,
-Aleksey
More information about the shenandoah-dev
mailing list