RFR(XS) 8224679: Shenandoah: Make ShenandoahParallelCodeCacheIterator noncopyable

[Zhengyu Gu]

On 5/23/19 11:19 AM, Roman Kennke wrote:
>>> Are there no users of iterator() and cset_iterator()? Or which part am I
>>> missing?
>>
>> We no longer use them since SRP refactor.
> 
> If we don't use them, why bother? Why not remove it instead?

Yes, we are removing them


diff --git a/src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp 
b/src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp
--- a/src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp
+++ b/src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp
@@ -245,14 +245,6 @@
    }
  }

-ShenandoahAllCodeRootsIterator ShenandoahCodeRoots::iterator() {
-  return ShenandoahAllCodeRootsIterator();
-}
-
-ShenandoahCsetCodeRootsIterator ShenandoahCodeRoots::cset_iterator() {
-  return ShenandoahCsetCodeRootsIterator();
-}
-

-Zhengyu
> 
> Roman
> 
>>
>> -Zhengyu
>>
>>>
>>> Roman
>>>
>>>
>>>> Copies may cause its member '_iters' to be freed multiple times.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224679
>>>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224679/webrev.00/
>>>>
>>>> Test:
>>>>     hotspot_gc_shenandoah (fastdebug and release)
>>>>
>>>> Thanks,
>>>>
>>>> -Zhengyu
>>>
>