RFR(XS) 8224679: Shenandoah: Make ShenandoahParallelCodeCacheIterator noncopyable

Aleksey Shipilev shade at redhat.com
Thu May 23 19:28:16 UTC 2019


On 5/23/19 5:01 PM, Zhengyu Gu wrote:
> Copies may cause its member '_iters' to be freed multiple times.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8224679

Please link the issue that made these redundant.

> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224679/webrev.00/

Please match what ShenandoahRegionIterator does, notably, declare variables? I remember the absence
of those tripped some compilers.

  // No implicit copying: iterators should be passed by reference to capture the state
  ShenandoahRegionIterator(const ShenandoahRegionIterator& that);
  ShenandoahRegionIterator& operator=(const ShenandoahRegionIterator& o);

Otherwise good.

-Aleksey



More information about the shenandoah-dev mailing list