[8u] RFR: [backport] 8222403: Shenandoah: Remove ShenandoahAlwaysTrueClosure, use AlwaysTrueClosure instead

Aleksey Shipilev shade at redhat.com
Mon May 27 12:11:07 UTC 2019


We have upstream change now that gives us AlwaysTrueClosure, so we can finally backport this change:

diff -r 5182332fe753 src/share/vm/gc_implementation/shenandoah/shenandoahHeap.hpp
--- a/src/share/vm/gc_implementation/shenandoah/shenandoahHeap.hpp   Mon May 20 12:04:27 2019
+++ b/src/share/vm/gc_implementation/shenandoah/shenandoahHeap.hpp   Mon May 27 14:09:23 2019
@@ -98,9 +98,4 @@
 #endif

-class ShenandoahAlwaysTrueClosure : public BoolObjectClosure {
-public:
-  bool do_object_b(oop p) { return true; }
-};
-
 // Shenandoah GC is low-pause concurrent GC that uses Brooks forwarding pointers
 // to encode forwarding data. See BrooksPointer for details on forwarding data encoding.
diff -r 5182332fe753 src/share/vm/gc_implementation/shenandoah/shenandoahRootProcessor.cpp
--- a/src/share/vm/gc_implementation/shenandoah/shenandoahRootProcessor.cpp  Mon May 20 12:04:27
+++ b/src/share/vm/gc_implementation/shenandoah/shenandoahRootProcessor.cpp  Mon May 27 14:09:23
@@ -65,5 +65,5 @@

 void ShenandoahRootProcessor::process_all_roots_slow(OopClosure* oops) {
-  ShenandoahAlwaysTrueClosure always_true;
+  AlwaysTrueClosure always_true;

   CLDToOopClosure clds(oops);
@@ -195,5 +195,5 @@
   if (jni_weak_roots != NULL) {
     if (!_process_strong_tasks->is_task_claimed(SHENANDOAH_RP_PS_JNIHandles_weak_oops_do)) {
-      ShenandoahAlwaysTrueClosure always_true;
+      AlwaysTrueClosure always_true;
       ShenandoahWorkerTimingsTracker timer(worker_times, ShenandoahPhaseTimings::JNIWeakRoots,
worker_id);
       JNIHandles::weak_oops_do(&always_true, jni_weak_roots);

Testing: hotspot_gc_shenandoah {fastdebug|release}

-- 
Thanks,
-Aleksey



More information about the shenandoah-dev mailing list