RFR(S) 8224932: Shenandoah: Rename ShenandoahHeapLock, make it general purpose lock

Zhengyu Gu zgu at redhat.com
Wed May 29 11:43:34 UTC 2019



On 5/29/19 7:26 AM, Aleksey Shipilev wrote:
> On 5/29/19 1:13 PM, Zhengyu Gu wrote:
>> Please review this refactor ShenandoahHeapLock to general purpose spin lock (I kept
>> ShenandoahSpinLock, cause ShenandoahLock was taken in another changeset. Any other suggestions for
>> the name?)
> 
> I don't understand. What does it mean "cause ShenandoahLock was taken in another changeset"? There
> are no conflicts in current jdk/jdk I can see.

Right, it is in concurrent class unloading changeset, and not yet here.

Thanks,

-Zhengyu

> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224932
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224932/webrev.00/
> 
> Otherwise looks good.
> 
> -Aleksey
> 


More information about the shenandoah-dev mailing list