RFR(S) 8224932: Shenandoah: Rename ShenandoahHeapLock, make it general purpose lock

Zhengyu Gu zgu at redhat.com
Wed May 29 13:44:53 UTC 2019


Okay, renamed and pushed.

Thanks,

-Zhengyu

On 5/29/19 9:07 AM, Aleksey Shipilev wrote:
> On 5/29/19 1:43 PM, Zhengyu Gu wrote:
>> On 5/29/19 7:26 AM, Aleksey Shipilev wrote:
>>> On 5/29/19 1:13 PM, Zhengyu Gu wrote:
>>>> Please review this refactor ShenandoahHeapLock to general purpose spin lock (I kept
>>>> ShenandoahSpinLock, cause ShenandoahLock was taken in another changeset. Any other suggestions for
>>>> the name?)
>>>
>>> I don't understand. What does it mean "cause ShenandoahLock was taken in another changeset"? There
>>> are no conflicts in current jdk/jdk I can see.
>>
>> Right, it is in concurrent class unloading changeset, and not yet here.
> 
> Well, that means *that* changeset should use another identifier. It has no business hoarding the
> generic "ShenandoahLock", IMO.
> 
> -Aleksey
> 


More information about the shenandoah-dev mailing list