RFR(S) 8224978: Shenandoah: Allows root verifier to verify some roots outside safepoints with proper locks

[Aleksey Shipilev]

On 5/30/19 5:10 PM, Zhengyu Gu wrote:
> Updated and retested:
>   http://cr.openjdk.java.net/~zgu/JDK-8224978/webrev.01/

*) Synopsis is missing "S": "8224978: henandoah: Allows root verifier to verify some roots outside
safepoints with proper locks"

*) This include in shenandoahRootVerifier.cpp is not needed anymore, right?

  36 #include "gc/shenandoah/shenandoahUtils.hpp"

*) Excess capitalization. Suggestion for rewording: "Should be at Shenandoah safepoint":

 132  assert(ShenandoahSafepoint::is_at_shenandoah_safepoint(), "Only at Shenandoah Safepoints");

*) Also here: "Must be at Shenandoah safepoint or hold %s lock":

 375   ShenandoahMessageBuffer msg("Must at a Shenandoah safepoint or held %s lock", lock->name());

Fix it, and the patch is good to go.

-Aleksey