[8] Heads-up: Borked EA after LRB backports?

[Aleksey Shipilev]

I believe EA in sh/jdk8 is borked. This reproduces reliably with sh/jdk8 with Shenandoah enabled. It
does not reproduce with sh/jdk11 or jdk/jdk.

$ hg diff
diff -r 2b8e8b2f5181 src/share/vm/opto/escape.cpp
--- a/src/share/vm/opto/escape.cpp      Tue Aug 13 14:59:29 2019 +0200
+++ b/src/share/vm/opto/escape.cpp      Fri Oct 25 12:10:22 2019 +0200
@@ -3005,10 +3005,11 @@
 #endif
         _compile->record_failure(C2Compiler::retry_no_escape_analysis());
         return;
       } else {
         Node *val = get_map(jobj->idx());   // CheckCastPP node
+        assert(n->is_Type(), err_msg("sanity: %s", NodeClassNames[n->Opcode()]));
         TypeNode *tn = n->as_Type();
         const TypeOopPtr* tinst = igvn->type(val)->isa_oopptr();
         assert(tinst != NULL && tinst->is_known_instance() &&
                tinst->instance_id() == jobj->idx() , "instance type expected.");


$ build/linux-x86_64-normal-server-slowdebug/images/j2sdk-image/bin/java
-XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC -jar ~/Downloads/renaissance-gpl-0.10.0.jar
neo4j-analytics -r 5
Checking previous DB remnants in
/home/shade/trunks/shenandoah-jdk8/target/modules/neo4j/neo4j-analytics.db
DB remnants detected, deleting ...
Creating indices...
Populating vertices...
# To suppress the following error report, specify this argument
# after -XX: or in .hotspotrc:  SuppressErrorAt=/escape.cpp:3011
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  Internal Error (/home/shade/trunks/shenandoah-jdk8/hotspot/src/share/vm/opto/escape.cpp:3011),
pid=473, tid=0x00007feef63aa700
#  assert(n->is_Type()) failed: sanity: ShenandoahLoadReferenceBarrier
#
# JRE version: OpenJDK Runtime Environment (8.0) (build 1.8.0-internal-debug-shade_2019_10_25_11_54-b00)
# Java VM: OpenJDK 64-Bit Server VM (25.71-b00-debug mixed mode linux-amd64 compressed oops)
# Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c
unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /home/shade/trunks/shenandoah-jdk8/hs_err_pid473.log
#
# Compiler replay data is saved as:
# /home/shade/trunks/shenandoah-jdk8/replay_pid473.log
#
# If you would like to submit a bug report, please visit:
#   http://bugreport.java.com/bugreport/crash.jsp
#
Current thread is 140664309982976
Dumping core ...
Aborted (core dumped)



-- 
Thanks,
-Aleksey