RFR [sh/8u]: Correct order between load, LRB and membar nodes

[Aleksey Shipilev]

On 10/28/19 3:43 PM, Roman Kennke wrote:
>>> Right. That is a problem. Let's do something else then:
>>> http://cr.openjdk.java.net/~rkennke/lrb-membars/webrev.01/
>>>
>>> This extracts the original load from the LRB before feeding into the membar.
>>
>> Um, no. This applies LRB only when is_volatile is true, which is obviously incorrect.
>>
>> Don't we need to feed the LRB result to set_result too? Or is it handled in some non-obvious way?
> 
> We do. And we also feed the LRB into the pre-barrier and into
> set_result(). We only extract the original load in order to feed it into
> the membar.

Ah! The old LRB is still in place, I forgot about that. Okay then!

Let's see what post-integration testing says about this :)

-- 
Thanks,
-Aleksey