From shade at redhat.com  Mon Sep  2 08:31:26 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 2 Sep 2019 10:31:26 +0200
Subject: RFR (XS) 8230425: Shenandoah forces +UseNUMAInterleaving even after
 explicitly disabled
Message-ID: <1be69480-6b62-4f73-7e09-4a74d794a74e@redhat.com>

Bug:
  https://bugs.openjdk.java.net/browse/JDK-8230425

Shenandoah enables NUMA when possible, but it also unconditionally sets UseNUMAInterleaving, which
is not correct and overrides user setting.

Fix:

diff -r a333fdeb8de0 src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
--- a/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp   Fri Aug 30 09:37:41 2019 +0200
+++ b/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp   Mon Sep 02 10:29:49 2019 +0200
@@ -65,5 +65,7 @@
   if (FLAG_IS_DEFAULT(UseNUMA)) {
     FLAG_SET_DEFAULT(UseNUMA, true);
-    FLAG_SET_DEFAULT(UseNUMAInterleaving, true);
+    if (FLAG_IS_DEFAULT(UseNUMAInterleaving)) {
+      FLAG_SET_DEFAULT(UseNUMAInterleaving, true);
+    }
   }

Testing: manual testing, hotspot_gc_shenandoah

-- 
Thanks,
-Aleksey


From shade at redhat.com  Mon Sep  2 08:47:42 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 2 Sep 2019 10:47:42 +0200
Subject: RFR (XS) 8230425: Shenandoah forces +UseNUMAInterleaving even
 after explicitly disabled
In-Reply-To: <1be69480-6b62-4f73-7e09-4a74d794a74e@redhat.com>
References: <1be69480-6b62-4f73-7e09-4a74d794a74e@redhat.com>
Message-ID: <08772877-880c-2d15-a661-603402606eea@redhat.com>

On 9/2/19 10:31 AM, Aleksey Shipilev wrote:
> Bug:
>   https://bugs.openjdk.java.net/browse/JDK-8230425
> 
> Shenandoah enables NUMA when possible, but it also unconditionally sets UseNUMAInterleaving, which
> is not correct and overrides user setting.
> 
> Fix:
> 
> diff -r a333fdeb8de0 src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
> --- a/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp   Fri Aug 30 09:37:41 2019 +0200
> +++ b/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp   Mon Sep 02 10:29:49 2019 +0200
> @@ -65,5 +65,7 @@
>    if (FLAG_IS_DEFAULT(UseNUMA)) {
>      FLAG_SET_DEFAULT(UseNUMA, true);
> -    FLAG_SET_DEFAULT(UseNUMAInterleaving, true);
> +    if (FLAG_IS_DEFAULT(UseNUMAInterleaving)) {
> +      FLAG_SET_DEFAULT(UseNUMAInterleaving, true);
> +    }
>    }

Even better, after observing that Arguments::adjust_after_os does enable UseNUMAInterleaving once
OS-specific code had chance to act:

diff -r a333fdeb8de0 src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
--- a/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp   Fri Aug 30 09:37:41 2019 +0200
+++ b/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp   Mon Sep 02 10:38:49 2019 +0200
@@ -60,11 +60,9 @@
   }

   // Enable NUMA by default. While Shenandoah is not NUMA-aware, enabling NUMA makes
-  // storage allocation code NUMA-aware, and NUMA interleaving makes the storage
-  // allocated in consistent manner (interleaving) to minimize run-to-run variance.
+  // storage allocation code NUMA-aware.
   if (FLAG_IS_DEFAULT(UseNUMA)) {
     FLAG_SET_DEFAULT(UseNUMA, true);
-    FLAG_SET_DEFAULT(UseNUMAInterleaving, true);
   }

Testing: more manual testing on NUMA-enabled machines

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Mon Sep  2 10:06:56 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 02 Sep 2019 12:06:56 +0200
Subject: RFR (XS) 8230425: Shenandoah forces +UseNUMAInterleaving even
 after explicitly disabled
In-Reply-To: <08772877-880c-2d15-a661-603402606eea@redhat.com>
References: <1be69480-6b62-4f73-7e09-4a74d794a74e@redhat.com>
 <08772877-880c-2d15-a661-603402606eea@redhat.com>
Message-ID: <1E66F814-6270-4901-857F-CB8FD3851DB9@redhat.com>

Looks good. Thanks!

Am 2. September 2019 10:47:42 MESZ schrieb Aleksey Shipilev <shade at redhat.com>:
>On 9/2/19 10:31 AM, Aleksey Shipilev wrote:
>> Bug:
>>   https://bugs.openjdk.java.net/browse/JDK-8230425
>> 
>> Shenandoah enables NUMA when possible, but it also unconditionally
>sets UseNUMAInterleaving, which
>> is not correct and overrides user setting.
>> 
>> Fix:
>> 
>> diff -r a333fdeb8de0
>src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
>> --- a/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp   Fri
>Aug 30 09:37:41 2019 +0200
>> +++ b/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp   Mon
>Sep 02 10:29:49 2019 +0200
>> @@ -65,5 +65,7 @@
>>    if (FLAG_IS_DEFAULT(UseNUMA)) {
>>      FLAG_SET_DEFAULT(UseNUMA, true);
>> -    FLAG_SET_DEFAULT(UseNUMAInterleaving, true);
>> +    if (FLAG_IS_DEFAULT(UseNUMAInterleaving)) {
>> +      FLAG_SET_DEFAULT(UseNUMAInterleaving, true);
>> +    }
>>    }
>
>Even better, after observing that Arguments::adjust_after_os does
>enable UseNUMAInterleaving once
>OS-specific code had chance to act:
>
>diff -r a333fdeb8de0
>src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
>--- a/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp   Fri Aug
>30 09:37:41 2019 +0200
>+++ b/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp   Mon Sep
>02 10:38:49 2019 +0200
>@@ -60,11 +60,9 @@
>   }
>
>// Enable NUMA by default. While Shenandoah is not NUMA-aware, enabling
>NUMA makes
>-  // storage allocation code NUMA-aware, and NUMA interleaving makes
>the storage
>-  // allocated in consistent manner (interleaving) to minimize
>run-to-run variance.
>+  // storage allocation code NUMA-aware.
>   if (FLAG_IS_DEFAULT(UseNUMA)) {
>     FLAG_SET_DEFAULT(UseNUMA, true);
>-    FLAG_SET_DEFAULT(UseNUMAInterleaving, true);
>   }
>
>Testing: more manual testing on NUMA-enabled machines
>
>-- 
>Thanks,
>-Aleksey

-- 
Diese Nachricht wurde von meinem Android-Ger?t mit K-9 Mail gesendet.

From shade at redhat.com  Mon Sep  2 10:10:48 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 2 Sep 2019 12:10:48 +0200
Subject: RFR (XS) 8230425: Shenandoah forces +UseNUMAInterleaving even
 after explicitly disabled
In-Reply-To: <1E66F814-6270-4901-857F-CB8FD3851DB9@redhat.com>
References: <1be69480-6b62-4f73-7e09-4a74d794a74e@redhat.com>
 <08772877-880c-2d15-a661-603402606eea@redhat.com>
 <1E66F814-6270-4901-857F-CB8FD3851DB9@redhat.com>
Message-ID: <0a48f1bb-0b55-64db-d161-124bc953f9a0@redhat.com>

On 9/2/19 12:06 PM, Roman Kennke wrote:
> Looks good. Thanks!

Thanks, pushed.

-- 
-Aleksey


From shade at redhat.com  Mon Sep  2 10:49:26 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 2 Sep 2019 12:49:26 +0200
Subject: RFR (XS) 8230425: Shenandoah forces +UseNUMAInterleaving even
 after explicitly disabled
In-Reply-To: <0a48f1bb-0b55-64db-d161-124bc953f9a0@redhat.com>
References: <1be69480-6b62-4f73-7e09-4a74d794a74e@redhat.com>
 <08772877-880c-2d15-a661-603402606eea@redhat.com>
 <1E66F814-6270-4901-857F-CB8FD3851DB9@redhat.com>
 <0a48f1bb-0b55-64db-d161-124bc953f9a0@redhat.com>
Message-ID: <81767a29-61d7-9581-6b7b-82a10888c986@redhat.com>

On 9/2/19 12:10 PM, Aleksey Shipilev wrote:
> On 9/2/19 12:06 PM, Roman Kennke wrote:
>> Looks good. Thanks!
> 
> Thanks, pushed.

I would also backport it to sh/jdk8 and sh/jdk11 immediately. The patches apply cleanly there (with
reshuffling in 8u), and pass my manual tests. Ok?

-- 
Thanks,
-Aleksey


From shade at redhat.com  Mon Sep  2 11:23:35 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 2 Sep 2019 13:23:35 +0200
Subject: RFR: sh/jdk11 assert failure because IfNode input is a Phi
In-Reply-To: <87v9uhnybo.fsf@redhat.com>
References: <87ftmo29tz.fsf@redhat.com> <87a7c2sxjj.fsf@redhat.com>
 <87v9uhnybo.fsf@redhat.com>
Message-ID: <c28b2bdc-c497-afad-bd0a-ac6b4f327e10@redhat.com>

On 8/28/19 4:45 PM, Roland Westrelin wrote:
>> I was trying to write a test case for that bug so I could fix it in
>> jdk/jdk and then I realized that the fix above was addressing the
>> consequence of logic that was missing and should have been
>> backported. So I'd like to back it out and backport what's missing
>> instead:
>>
>> http://cr.openjdk.java.net/~roland/shenandoah/LRBafterCallUseBool/webrev.01/
> 
> Anyone to approve this?

This seems to be partially backporting this change, right?
  8213381: Hook to allow GC to inject Node::Ideal() calls

We would need to pick that up in 11.0.6 to minimize upstream differences. The current patch seems
okay for sh/jdk11, as it is pretty straight-forward. If we want to be extra-clean, I'd wait for
8213381 backport to arrive via 11u.

-- 
Thanks,
-Aleksey


From rwestrel at redhat.com  Mon Sep  2 15:29:44 2019
From: rwestrel at redhat.com (Roland Westrelin)
Date: Mon, 02 Sep 2019 17:29:44 +0200
Subject: RFR: sh/jdk11 assert failure because IfNode input is a Phi
In-Reply-To: <c28b2bdc-c497-afad-bd0a-ac6b4f327e10@redhat.com>
References: <87ftmo29tz.fsf@redhat.com> <87a7c2sxjj.fsf@redhat.com>
 <87v9uhnybo.fsf@redhat.com> <c28b2bdc-c497-afad-bd0a-ac6b4f327e10@redhat.com>
Message-ID: <87woeqn2c7.fsf@redhat.com>


> This seems to be partially backporting this change, right?
>   8213381: Hook to allow GC to inject Node::Ideal() calls

Yes.

> We would need to pick that up in 11.0.6 to minimize upstream differences. The current patch seems
> okay for sh/jdk11, as it is pretty straight-forward. If we want to be extra-clean, I'd wait for
> 8213381 backport to arrive via 11u.

I'm fine with that but we will have to remember that we need to undo the
previous fix too.

Roland.

From shade at redhat.com  Mon Sep  2 15:38:54 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 2 Sep 2019 17:38:54 +0200
Subject: RFR: sh/jdk11 assert failure because IfNode input is a Phi
In-Reply-To: <87woeqn2c7.fsf@redhat.com>
References: <87ftmo29tz.fsf@redhat.com> <87a7c2sxjj.fsf@redhat.com>
 <87v9uhnybo.fsf@redhat.com> <c28b2bdc-c497-afad-bd0a-ac6b4f327e10@redhat.com>
 <87woeqn2c7.fsf@redhat.com>
Message-ID: <d2764be4-e771-6b14-fa1a-d00ccca48397@redhat.com>

On 9/2/19 5:29 PM, Roland Westrelin wrote:
>> This seems to be partially backporting this change, right?
>>   8213381: Hook to allow GC to inject Node::Ideal() calls
> 
> Yes.

I have just requested the backport for it. It should be in 11.0.6.

>> We would need to pick that up in 11.0.6 to minimize upstream differences. The current patch seems
>> okay for sh/jdk11, as it is pretty straight-forward. If we want to be extra-clean, I'd wait for
>> 8213381 backport to arrive via 11u.
> 
> I'm fine with that but we will have to remember that we need to undo the
> previous fix too.

Meahwhile, I think we are clear to push your patch to sh/jdk11, even though it means accepting a bit
of upstream deviation. We already have it with BarrierSetC2::ideal_node nearby.

Roman, do you concur?

-- 
Thanks,
-Aleksey


From roman at kennke.org  Tue Sep  3 12:03:17 2019
From: roman at kennke.org (Roman Kennke)
Date: Tue, 03 Sep 2019 14:03:17 +0200
Subject: RFR (XS) 8230425: Shenandoah forces +UseNUMAInterleaving even
 after explicitly disabled
In-Reply-To: <81767a29-61d7-9581-6b7b-82a10888c986@redhat.com>
References: <1be69480-6b62-4f73-7e09-4a74d794a74e@redhat.com>
 <08772877-880c-2d15-a661-603402606eea@redhat.com>
 <1E66F814-6270-4901-857F-CB8FD3851DB9@redhat.com>
 <0a48f1bb-0b55-64db-d161-124bc953f9a0@redhat.com>
 <81767a29-61d7-9581-6b7b-82a10888c986@redhat.com>
Message-ID: <5D6152EC-1DE7-4B3B-91AC-1CF1F56DEE02@kennke.org>

OK. Thanks.

Am 2. September 2019 12:49:26 MESZ schrieb Aleksey Shipilev <shade at redhat.com>:
>On 9/2/19 12:10 PM, Aleksey Shipilev wrote:
>> On 9/2/19 12:06 PM, Roman Kennke wrote:
>>> Looks good. Thanks!
>> 
>> Thanks, pushed.
>
>I would also backport it to sh/jdk8 and sh/jdk11 immediately. The
>patches apply cleanly there (with
>reshuffling in 8u), and pass my manual tests. Ok?
>
>-- 
>Thanks,
>-Aleksey

-- 
Diese Nachricht wurde von meinem Android-Ger?t mit K-9 Mail gesendet.

From shade at redhat.com  Tue Sep  3 12:41:20 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 3 Sep 2019 14:41:20 +0200
Subject: RFR: sh/jdk11 assert failure because IfNode input is a Phi
In-Reply-To: <d2764be4-e771-6b14-fa1a-d00ccca48397@redhat.com>
References: <87ftmo29tz.fsf@redhat.com> <87a7c2sxjj.fsf@redhat.com>
 <87v9uhnybo.fsf@redhat.com> <c28b2bdc-c497-afad-bd0a-ac6b4f327e10@redhat.com>
 <87woeqn2c7.fsf@redhat.com> <d2764be4-e771-6b14-fa1a-d00ccca48397@redhat.com>
Message-ID: <9e0def54-95c2-9a51-ab53-3d3ce3ebecb4@redhat.com>

On 9/2/19 5:38 PM, Aleksey Shipilev wrote:
> On 9/2/19 5:29 PM, Roland Westrelin wrote:
>>> We would need to pick that up in 11.0.6 to minimize upstream differences. The current patch seems
>>> okay for sh/jdk11, as it is pretty straight-forward. If we want to be extra-clean, I'd wait for
>>> 8213381 backport to arrive via 11u.
>>
>> I'm fine with that but we will have to remember that we need to undo the
>> previous fix too.
> 
> Meahwhile, I think we are clear to push your patch to sh/jdk11, even though it means accepting a bit
> of upstream deviation. We already have it with BarrierSetC2::ideal_node nearby.
> 
> Roman, do you concur?

Roman is not replying. Let's assume this is fine. Please push the fix to sh/jdk11.

-- 
Thanks,
-Aleksey


From roman at kennke.org  Tue Sep  3 12:57:00 2019
From: roman at kennke.org (Roman Kennke)
Date: Tue, 03 Sep 2019 14:57:00 +0200
Subject: RFR: sh/jdk11 assert failure because IfNode input is a Phi
In-Reply-To: <9e0def54-95c2-9a51-ab53-3d3ce3ebecb4@redhat.com>
References: <87ftmo29tz.fsf@redhat.com> <87a7c2sxjj.fsf@redhat.com>
 <87v9uhnybo.fsf@redhat.com> <c28b2bdc-c497-afad-bd0a-ac6b4f327e10@redhat.com>
 <87woeqn2c7.fsf@redhat.com> <d2764be4-e771-6b14-fa1a-d00ccca48397@redhat.com>
 <9e0def54-95c2-9a51-ab53-3d3ce3ebecb4@redhat.com>
Message-ID: <20775AEB-10E4-459E-AE53-9BE45AA310A1@kennke.org>

It's good.
Thanks, Roman

Am 3. September 2019 14:41:20 MESZ schrieb Aleksey Shipilev <shade at redhat.com>:
>On 9/2/19 5:38 PM, Aleksey Shipilev wrote:
>> On 9/2/19 5:29 PM, Roland Westrelin wrote:
>>>> We would need to pick that up in 11.0.6 to minimize upstream
>differences. The current patch seems
>>>> okay for sh/jdk11, as it is pretty straight-forward. If we want to
>be extra-clean, I'd wait for
>>>> 8213381 backport to arrive via 11u.
>>>
>>> I'm fine with that but we will have to remember that we need to undo
>the
>>> previous fix too.
>> 
>> Meahwhile, I think we are clear to push your patch to sh/jdk11, even
>though it means accepting a bit
>> of upstream deviation. We already have it with
>BarrierSetC2::ideal_node nearby.
>> 
>> Roman, do you concur?
>
>Roman is not replying. Let's assume this is fine. Please push the fix
>to sh/jdk11.
>
>-- 
>Thanks,
>-Aleksey

-- 
Diese Nachricht wurde von meinem Android-Ger?t mit K-9 Mail gesendet.

From rwestrel at redhat.com  Tue Sep  3 15:25:00 2019
From: rwestrel at redhat.com (rwestrel at redhat.com)
Date: Tue, 03 Sep 2019 15:25:00 +0000
Subject: hg: shenandoah/jdk11: CmpP with null: missing LRB optimization
Message-ID: <201909031525.x83FP1S1016617@aojmv0008.oracle.com>

Changeset: fd7d59fadd89
Author:    roland
Date:      2019-08-20 17:43 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/fd7d59fadd89

CmpP with null: missing LRB optimization

! src/hotspot/share/gc/shared/c2/barrierSetC2.hpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp
! src/hotspot/share/opto/cfgnode.hpp
! src/hotspot/share/opto/loopnode.cpp
! src/hotspot/share/opto/loopopts.cpp
! src/hotspot/share/opto/memnode.cpp
! src/hotspot/share/opto/phaseX.cpp
! src/hotspot/share/opto/phaseX.hpp


From shade at redhat.com  Tue Sep  3 15:41:53 2019
From: shade at redhat.com (shade at redhat.com)
Date: Tue, 03 Sep 2019 15:41:53 +0000
Subject: hg: shenandoah/jdk8/hotspot: [backport] 8230425: Shenandoah forces
 +UseNUMAInterleaving even after explicitly disabled
Message-ID: <201909031541.x83Ffs68026498@aojmv0008.oracle.com>

Changeset: cb1418759e55
Author:    shade
Date:      2019-09-02 12:10 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/cb1418759e55

[backport] 8230425: Shenandoah forces +UseNUMAInterleaving even after explicitly disabled

! src/share/vm/runtime/arguments.cpp


From shade at redhat.com  Tue Sep  3 15:46:53 2019
From: shade at redhat.com (shade at redhat.com)
Date: Tue, 03 Sep 2019 15:46:53 +0000
Subject: hg: shenandoah/jdk11: [backport] 8230425: Shenandoah forces
 +UseNUMAInterleaving even after explicitly disabled
Message-ID: <201909031546.x83Fksep028157@aojmv0008.oracle.com>

Changeset: bd3ca82fabbd
Author:    shade
Date:      2019-09-02 12:10 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/bd3ca82fabbd

[backport] 8230425: Shenandoah forces +UseNUMAInterleaving even after explicitly disabled

! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp


From zgu at redhat.com  Tue Sep  3 16:56:39 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Tue, 3 Sep 2019 12:56:39 -0400
Subject: RFR 8230483: Shenandoah: Shenandoah assert_correct failed; Object
 klass pointer should not be NULL
Message-ID: <e5357b81-3411-64e7-cad6-e451413fbffd@redhat.com>

SAP reported shenandoah assertion failure since 2019-07-14.

I could not reproduce locally. I did find an instance of failure in our 
nightlies dated back to 2019-08-27.

I believe it is caused by JDK-8226757, which changed behavior of 
SH:is_concurrent_traversal_in_progress().

We do have the fix in shenandoah/jdk, but has yet upstreamed.

Webrev: http://cr.openjdk.java.net/~zgu/JDK-8230483/webev.00/

Test:
   hotspot_gc_shenandoah (fastdebug and release) on Linux x86_64.

Thanks,

-Zhengyu

From shade at redhat.com  Tue Sep  3 17:00:51 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 3 Sep 2019 19:00:51 +0200
Subject: RFR 8230483: Shenandoah: Shenandoah assert_correct failed; Object
 klass pointer should not be NULL
In-Reply-To: <e5357b81-3411-64e7-cad6-e451413fbffd@redhat.com>
References: <e5357b81-3411-64e7-cad6-e451413fbffd@redhat.com>
Message-ID: <d4292b6e-c277-26c6-4533-c42642b94ef7@redhat.com>

On 9/3/19 6:56 PM, Zhengyu Gu wrote:
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8230483/webev.00/

D'uh. Looks good!

Maybe change the synopsis? E.g.:
 "Shenandoah: consistently disable concurrent roots for Traversal mode"

-- 
Thanks,
-Aleksey


From zgu at redhat.com  Tue Sep  3 17:57:17 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Tue, 3 Sep 2019 13:57:17 -0400
Subject: RFR 8230483: Shenandoah: Shenandoah assert_correct failed; Object
 klass pointer should not be NULL
In-Reply-To: <d4292b6e-c277-26c6-4533-c42642b94ef7@redhat.com>
References: <e5357b81-3411-64e7-cad6-e451413fbffd@redhat.com>
 <d4292b6e-c277-26c6-4533-c42642b94ef7@redhat.com>
Message-ID: <7a0444d3-7955-8c50-0715-0237642e1964@redhat.com>

Thanks for reviewing.

On 9/3/19 1:00 PM, Aleksey Shipilev wrote:
> On 9/3/19 6:56 PM, Zhengyu Gu wrote:
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8230483/webev.00/
> 
> D'uh. Looks good!
> 
> Maybe change the synopsis? E.g.:
>   "Shenandoah: consistently disable concurrent roots for Traversal mode"
> 

Changed and pushed.

-Zhengyu


From shade at redhat.com  Tue Sep  3 18:16:10 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 3 Sep 2019 20:16:10 +0200
Subject: RFC: Pick up jdk-11.0.5+5 to sh/jdk11
Message-ID: <3e312362-b48e-9129-aee2-5c7430d28360@redhat.com>

Let's pick up jdk-11.0.5+5 to sh/jdk11.

The merge is not trivial in aarch64 parts, because this change landed:
  8209420: Track membars for volatile accesses so they can be properly optimized

It conflicts with changes in aarch64.ad and compile.cpp. I merged them by ditching changes in
"leading_to_normal" we have in aarch64.ad [1] and adding a few new cases in compile.cpp. We would
need to see what testing says about the success of that merge.

Full change list:
  https://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.5%2b5/changesets.txt

Testing: x86_64 hotspot_gc_shenandoah; aarch64 cross-build

-- 
Thanks,
-Aleksey

[1]
https://builds.shipilev.net/patch-openjdk-shenandoah-jdk11/src/hotspot/cpu/aarch64/aarch64.ad.sdiff.html


From zgu at redhat.com  Tue Sep  3 19:52:35 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Tue, 3 Sep 2019 15:52:35 -0400
Subject: RFC: Pick up jdk-11.0.5+5 to sh/jdk11
In-Reply-To: <3e312362-b48e-9129-aee2-5c7430d28360@redhat.com>
References: <3e312362-b48e-9129-aee2-5c7430d28360@redhat.com>
Message-ID: <3dc1818b-6489-92f9-bbc7-f3d0cfc3b1cc@redhat.com>

Okay.

Thanks,

-Zhengyu

On 9/3/19 2:16 PM, Aleksey Shipilev wrote:
> Let's pick up jdk-11.0.5+5 to sh/jdk11.
> 
> The merge is not trivial in aarch64 parts, because this change landed:
>    8209420: Track membars for volatile accesses so they can be properly optimized
> 
> It conflicts with changes in aarch64.ad and compile.cpp. I merged them by ditching changes in
> "leading_to_normal" we have in aarch64.ad [1] and adding a few new cases in compile.cpp. We would
> need to see what testing says about the success of that merge.
> 
> Full change list:
>    https://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.5%2b5/changesets.txt
> 
> Testing: x86_64 hotspot_gc_shenandoah; aarch64 cross-build
> 

From shade at redhat.com  Tue Sep  3 19:53:30 2019
From: shade at redhat.com (shade at redhat.com)
Date: Tue, 03 Sep 2019 19:53:30 +0000
Subject: hg: shenandoah/jdk11: 58 new changesets
Message-ID: <201909031953.x83JraFw028078@aojmv0008.oracle.com>

Changeset: b2bbfc3c59dc
Author:    mseledtsov
Date:      2019-03-07 13:20 -0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/b2bbfc3c59dc

8219997: [TESTBUG] Create test for JFR events in Docker container: CPU, Memory and Process Info
Summary: Start docker with limits on CPU/Mem, verify JFR reports correct data
Reviewed-by: egahlin

+ test/hotspot/jtreg/runtime/containers/docker/JfrReporter.java
+ test/hotspot/jtreg/runtime/containers/docker/TestJFREvents.java

Changeset: 787c9f1e0203
Author:    jiefu
Date:      2019-04-09 06:11 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/787c9f1e0203

8221894: Add comments for docker tests in the test doc
Reviewed-by: erikj, dholmes, shade

! doc/testing.html
! doc/testing.md

Changeset: cebdce120ff3
Author:    mseledtsov
Date:      2019-04-12 12:26 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/cebdce120ff3

8222299: [TESTBUG] move hotspot container tests to hotspot/containers
Summary: Moved the tests, updated relevant files
Reviewed-by: dholmes, iignatyev, shade

! doc/testing.html
! doc/testing.md
! test/hotspot/jtreg/TEST.groups
+ test/hotspot/jtreg/containers/cgroup/PlainRead.java
+ test/hotspot/jtreg/containers/docker/AttemptOOM.java
+ test/hotspot/jtreg/containers/docker/CheckContainerized.java
+ test/hotspot/jtreg/containers/docker/DockerBasicTest.java
+ test/hotspot/jtreg/containers/docker/HelloDocker.java
+ test/hotspot/jtreg/containers/docker/JfrReporter.java
+ test/hotspot/jtreg/containers/docker/PrintContainerInfo.java
+ test/hotspot/jtreg/containers/docker/TEST.properties
+ test/hotspot/jtreg/containers/docker/TestCPUAwareness.java
+ test/hotspot/jtreg/containers/docker/TestCPUSets.java
+ test/hotspot/jtreg/containers/docker/TestJFREvents.java
+ test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
+ test/hotspot/jtreg/containers/docker/TestMisc.java
- test/hotspot/jtreg/runtime/containers/cgroup/PlainRead.java
- test/hotspot/jtreg/runtime/containers/docker/AttemptOOM.java
- test/hotspot/jtreg/runtime/containers/docker/CheckContainerized.java
- test/hotspot/jtreg/runtime/containers/docker/DockerBasicTest.java
- test/hotspot/jtreg/runtime/containers/docker/HelloDocker.java
- test/hotspot/jtreg/runtime/containers/docker/JfrReporter.java
- test/hotspot/jtreg/runtime/containers/docker/PrintContainerInfo.java
- test/hotspot/jtreg/runtime/containers/docker/TEST.properties
- test/hotspot/jtreg/runtime/containers/docker/TestCPUAwareness.java
- test/hotspot/jtreg/runtime/containers/docker/TestCPUSets.java
- test/hotspot/jtreg/runtime/containers/docker/TestJFREvents.java
- test/hotspot/jtreg/runtime/containers/docker/TestMemoryAwareness.java
- test/hotspot/jtreg/runtime/containers/docker/TestMisc.java
! test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java

Changeset: 4b78edce84fe
Author:    fmatte
Date:      2019-07-02 08:43 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/4b78edce84fe

8225715: jhsdb jmap fails to write binary heap dump of a jshell process
Summary: Add a Null check for getSourceFileName() before writing into thread dump.
Reviewed-by: cjplummer, kevinw

! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java
+ test/jdk/sun/tools/jhsdb/JShellHeapDumpTest.java

Changeset: 65bb816a5bbc
Author:    pliden
Date:      2019-08-12 10:49 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/65bb816a5bbc

8229406: ZGC: Fix incorrect statistics
Reviewed-by: pliden, eosterlund
Contributed-by: albert.th at alibaba-inc.com

! src/hotspot/share/gc/z/zStat.cpp

Changeset: 6ad83ea7dda7
Author:    vlivanov
Date:      2019-01-22 18:14 -0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/6ad83ea7dda7

8202952: C2: Unexpected dead nodes after matching
Reviewed-by: kvn

! src/hotspot/cpu/x86/x86.ad
+ test/hotspot/jtreg/compiler/c2/TestMatcherLargeOffset.java

Changeset: 52d84a263f1e
Author:    goetz
Date:      2019-08-21 09:14 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/52d84a263f1e

Merge

- test/hotspot/jtreg/runtime/containers/cgroup/PlainRead.java
- test/hotspot/jtreg/runtime/containers/docker/AttemptOOM.java
- test/hotspot/jtreg/runtime/containers/docker/CheckContainerized.java
- test/hotspot/jtreg/runtime/containers/docker/DockerBasicTest.java
- test/hotspot/jtreg/runtime/containers/docker/HelloDocker.java
- test/hotspot/jtreg/runtime/containers/docker/PrintContainerInfo.java
- test/hotspot/jtreg/runtime/containers/docker/TEST.properties
- test/hotspot/jtreg/runtime/containers/docker/TestCPUAwareness.java
- test/hotspot/jtreg/runtime/containers/docker/TestCPUSets.java
- test/hotspot/jtreg/runtime/containers/docker/TestMemoryAwareness.java
- test/hotspot/jtreg/runtime/containers/docker/TestMisc.java

Changeset: 4f787d0086fc
Author:    roland
Date:      2018-08-14 16:54 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/4f787d0086fc

8209420: Track membars for volatile accesses so they can be properly optimized
Reviewed-by: adinn, aph, thartmann

! src/hotspot/cpu/aarch64/aarch64.ad
! src/hotspot/share/gc/shared/c2/barrierSetC2.cpp
! src/hotspot/share/opto/compile.cpp
! src/hotspot/share/opto/memnode.cpp
! src/hotspot/share/opto/memnode.hpp

Changeset: 4cf59897e14f
Author:    roland
Date:      2018-09-27 17:46 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/4cf59897e14f

8211233: MemBarNode::trailing_membar() and MemBarNode::leading_membar() need to handle dying subgraphs better
Reviewed-by: kvn, thartmann

! src/hotspot/share/opto/memnode.cpp

Changeset: 04dd2501a9df
Author:    roland
Date:      2018-12-03 10:51 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/04dd2501a9df

8214857: "bad trailing membar" assert failure at memnode.cpp:3220
Reviewed-by: adinn, thartmann

! src/hotspot/share/opto/memnode.cpp

Changeset: 87d0acb9f1d7
Author:    lancea
Date:      2019-06-11 13:04 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/87d0acb9f1d7

8225189: Multiple JNI calls within critical region in ZIP Library
Reviewed-by: alanb

! src/java.base/share/native/libzip/Deflater.c
! src/java.base/share/native/libzip/Inflater.c

Changeset: c40094e3ef04
Author:    dpochepk
Date:      2019-08-21 16:20 +0300
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/c40094e3ef04

8215792: AArch64: String.indexOf generates incorrect result
Reviewed-by: dsamersoff

! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp
+ test/hotspot/jtreg/compiler/intrinsics/Test8215792.java

Changeset: aea199a3609c
Author:    vlivanov
Date:      2019-02-14 15:27 -0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/aea199a3609c

8218879: Keep track of memory accesses originated from Unsafe
Reviewed-by: thartmann

! src/hotspot/share/c1/c1_Decorators.hpp
! src/hotspot/share/c1/c1_LIRGenerator.cpp
! src/hotspot/share/gc/shared/c2/barrierSetC2.cpp
! src/hotspot/share/opto/graphKit.cpp
! src/hotspot/share/opto/graphKit.hpp
! src/hotspot/share/opto/memnode.cpp
! src/hotspot/share/opto/memnode.hpp

Changeset: 17dfeb9ddb7d
Author:    thartmann
Date:      2019-06-12 14:06 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/17dfeb9ddb7d

8224658: Unsafe access C2 compile fails with assert(flat != TypePtr::BOTTOM) failed: cannot alias-analyze an untyped ptr: adr_type = NULL
Summary: Handle unsafe off-heap access with constant zero address.
Reviewed-by: vlivanov, roland

! src/hotspot/share/opto/graphKit.hpp
! src/hotspot/share/opto/library_call.cpp
! src/hotspot/share/opto/memnode.cpp
! src/hotspot/share/opto/output.cpp
+ test/hotspot/jtreg/compiler/unsafe/TestUnsafeLoadWithZeroAddress.java

Changeset: a29a36e5a2df
Author:    lmesnik
Date:      2019-07-30 17:28 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/a29a36e5a2df

8225388: Running jcmd Compiler.CodeHeap_Analytics all 0 cause crash.
Reviewed-by: thartmann, sspitsyn

! src/hotspot/share/code/codeCache.cpp
! src/hotspot/share/code/codeCache.hpp
! src/hotspot/share/code/codeHeapState.cpp
! src/hotspot/share/code/codeHeapState.hpp
! src/hotspot/share/compiler/compileBroker.cpp
! src/hotspot/share/compiler/compileBroker.hpp
! src/hotspot/share/runtime/java.cpp
! src/hotspot/share/services/diagnosticCommand.cpp
! src/hotspot/share/services/diagnosticCommand.hpp
+ test/hotspot/jtreg/serviceability/dcmd/compiler/CodeHeapAnalyticsParams.java

Changeset: 9eafbb5f6288
Author:    ngasson
Date:      2019-08-21 11:58 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/9eafbb5f6288

8209413: AArch64: NPE in clhsdb jstack command
Reviewed-by: aph

! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp
! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp
! src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/aarch64/AARCH64CurrentFrameGuess.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/aarch64/AARCH64Frame.java

Changeset: 51c94b611e63
Author:    adinn
Date:      2019-08-23 13:20 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/51c94b611e63

8230099: Prepare for backport of JDK-8217368
Reviewed-by: aph

! src/hotspot/cpu/aarch64/aarch64.ad

Changeset: 97701c7e0bca
Author:    ngasson
Date:      2019-08-23 13:22 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/97701c7e0bca

8217368: AArch64: C2 recursive stack locking optimisation not triggered
Reviewed-by: aph, drwhite

! src/hotspot/cpu/aarch64/aarch64.ad

Changeset: f035048a2e6f
Author:    dsamersoff
Date:      2019-08-25 15:24 +0000
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/f035048a2e6f

8229352: Use of an uninitialized register in 32-bit ARM template interpreter
Reviewed-by: dlong, shade
Contributed-by: christoph.goettschkes at microdoc.com

! src/hotspot/cpu/arm/templateTable_arm.cpp

Changeset: 0a4e238dc769
Author:    xuelei
Date:      2019-05-29 13:39 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/0a4e238dc769

8224991: Problemlist javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java
Reviewed-by: mullan

! test/jdk/ProblemList.txt

Changeset: db863c1149c0
Author:    roland
Date:      2018-09-18 20:41 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/db863c1149c0

8210389: C2: assert(n->outcnt() != 0 || C->top() == n || n->is_Proj()) failed: No dead instructions after post-alloc
Reviewed-by: kvn, thartmann

! src/hotspot/share/opto/compile.cpp
+ test/hotspot/jtreg/compiler/regalloc/VolatileLoadMemBarsOnlyUses.java

Changeset: 66c682c0d972
Author:    ysuenaga
Date:      2019-07-13 20:55 +0900
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/66c682c0d972

8227594: sadebugd/DebugdConnectTest.java fails due to "java.rmi.NotBoundException: SARemoteDebugger"
Reviewed-by: cjplummer, sspitsyn

+ test/hotspot/jtreg/serviceability/sa/sadebugd/TEST.properties

Changeset: e0dd17f50860
Author:    ysuenaga
Date:      2019-05-29 13:50 +0900
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/e0dd17f50860

8223814: SA: jhsdb common help needs to be more detailed
Reviewed-by: dholmes, sspitsyn, ysuenaga
Contributed-by: Osamu Sakamoto <sakamoto.osamu at nttcom.co.jp>

! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/SALauncher.java

Changeset: 68df20da18d3
Author:    alanb
Date:      2019-02-03 10:00 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/68df20da18d3

8216046: test/jdk/java/beans/PropertyEditor/Test6397609.java failing
Reviewed-by: alanb, serb
Contributed-by: fujie at loongson.cn

! test/jdk/java/beans/PropertyEditor/Test6397609.java

Changeset: 787cc6280ea7
Author:    rriggs
Date:      2019-01-31 10:05 -0500
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/787cc6280ea7

8216528: test/jdk/java/rmi/transport/runtimeThreadInheritanceLeak/RuntimeThreadInheritanceLeak.java failing with Xcomp
Reviewed-by: dholmes, alanb
Contributed-by: fujie at loongson.cn

! test/jdk/java/rmi/transport/runtimeThreadInheritanceLeak/RuntimeThreadInheritanceLeak.java

Changeset: bd4fa194cffa
Author:    mbaesken
Date:      2019-08-01 08:59 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/bd4fa194cffa

8228658: test GetTotalSafepointTime.java fails on fast Linux machines with Total safepoint time 0 ms
Reviewed-by: dholmes, jcbeyler

! test/jdk/sun/management/HotspotRuntimeMBean/GetTotalSafepointTime.java

Changeset: 28c4c2291637
Author:    mbaesken
Date:      2019-07-17 15:40 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/28c4c2291637

8227869: fix wrong format specifiers in os_aix.cpp
Reviewed-by: dholmes, mdoerr, clanger

! src/hotspot/os/aix/os_aix.cpp

Changeset: e380a9cc90f3
Author:    mbaesken
Date:      2019-07-12 12:19 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/e380a9cc90f3

8227630: adjust format specifiers in loadlib_aix.cpp
Reviewed-by: mdoerr, shade

! src/hotspot/os/aix/loadlib_aix.cpp

Changeset: 6b2fcd869c34
Author:    dpochepk
Date:      2019-08-26 15:34 +0300
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/6b2fcd869c34

8218966: AArch64: String.compareTo() can read memory after string
Reviewed-by: adinn, dsamersoff

! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp
+ test/hotspot/jtreg/compiler/intrinsics/string/TestStringCompareToDifferentLength.java
+ test/hotspot/jtreg/compiler/intrinsics/string/TestStringCompareToSameLength.java

Changeset: eb4cd8cad920
Author:    mbaesken
Date:      2019-05-23 15:15 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/eb4cd8cad920

8224221: add memprotect calls to event log
Reviewed-by: dholmes, mdoerr

! src/hotspot/os/aix/os_aix.cpp
! src/hotspot/os/bsd/os_bsd.cpp
! src/hotspot/os/linux/os_linux.cpp
! src/hotspot/os/solaris/os_solaris.cpp
! src/hotspot/share/runtime/globals.hpp
! src/hotspot/share/utilities/events.hpp

Changeset: b7b360bdc2b5
Author:    redestad
Date:      2019-05-23 18:43 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/b7b360bdc2b5

8224202: Speed up Properties.load
Reviewed-by: rriggs, igerasim

! src/java.base/share/classes/java/util/Properties.java

Changeset: 6a7ef9f11c3f
Author:    mdoerr
Date:      2019-08-22 15:52 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/6a7ef9f11c3f

8229925: [s390, PPC64] Exception check missing in interpreter
Reviewed-by: dholmes, rrich

! src/hotspot/cpu/ppc/interp_masm_ppc_64.cpp
! src/hotspot/cpu/s390/interp_masm_s390.cpp

Changeset: 21e81280a42d
Author:    erikj
Date:      2018-11-14 09:26 -0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/21e81280a42d

8211727: Adjust default concurrency settings for running tests on Sparc
Reviewed-by: ctornqvi, tbell, mikael

! make/RunTests.gmk

Changeset: a0baa2f5e98d
Author:    erikj
Date:      2018-11-16 09:49 -0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/a0baa2f5e98d

8214003: Limit default test jobs based on memory size
Reviewed-by: shade, tbell

! make/RunTests.gmk
! make/RunTestsPrebuilt.gmk

Changeset: d0c9869783ca
Author:    bpb
Date:      2019-04-29 07:39 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/d0c9869783ca

8218280: LineNumberReader throws "Mark invalid" exception if CRLF straddles buffer.
Reviewed-by: dfuchs, prappo

! src/java.base/share/classes/java/io/LineNumberReader.java
+ test/jdk/java/io/LineNumberReader/MarkSplitCRLF.java

Changeset: 185839250713
Author:    aivanov
Date:      2019-08-18 21:36 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/185839250713

8222108: Reduce minRefreshTime for updating remote printer list on Windows
Reviewed-by: prr, serb

! src/java.desktop/windows/classes/sun/print/PrintServiceLookupProvider.java
! test/jdk/java/awt/print/RemotePrinterStatusRefresh/RemotePrinterStatusRefresh.java

Changeset: f59397b4eb32
Author:    weijun
Date:      2019-05-10 09:39 +0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/f59397b4eb32

8200400: Restrict Sasl mechanisms
Reviewed-by: mullan

! src/java.base/share/conf/security/java.security
! src/java.security.sasl/share/classes/javax/security/sasl/Sasl.java
+ test/jdk/javax/security/sasl/Sasl/DisabledMechanisms.java

Changeset: 3cc8ce23883a
Author:    coffeys
Date:      2019-02-07 12:09 +0000
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/3cc8ce23883a

8218553: Enhance keystore load debug output
Reviewed-by: weijun

! src/java.base/macosx/classes/apple/security/KeychainStore.java
! src/java.base/share/classes/com/sun/crypto/provider/JceKeyStore.java
! src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java
! src/java.base/share/classes/sun/security/provider/JavaKeyStore.java
! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyStore.java
! src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/KeyStore.java

Changeset: d406af4cbb1e
Author:    weijun
Date:      2019-08-15 15:39 +0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/d406af4cbb1e

8229767: Typo in java.security: Sasl.createClient and Sasl.createServer
Reviewed-by: xuelei

! src/java.base/share/conf/security/java.security

Changeset: 7375edafd3e8
Author:    vromero
Date:      2019-06-05 16:01 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/7375edafd3e8

8216261: Javap ignores default modifier on interfaces
Reviewed-by: jjg, darcy

! src/jdk.jdeps/share/classes/com/sun/tools/javap/ClassWriter.java
+ test/langtools/tools/javap/default_methods/JavapNotPrintingDefaultModifierTest.java

Changeset: 15a23811b8cd
Author:    vromero
Date:      2019-06-05 21:50 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/15a23811b8cd

8225386: test for JDK-8216261 fails in Windows
Reviewed-by: jjg

! test/langtools/tools/javap/default_methods/JavapNotPrintingDefaultModifierTest.java

Changeset: fd53b157559d
Author:    kvn
Date:      2018-08-08 18:38 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/fd53b157559d

8207965: C2-only debug build fails
Reviewed-by: kvn, iignatyev
Contributed-by: xxinliu at amazon.com

! make/hotspot/src/native/dtrace/generateJvmOffsets.cpp
! src/hotspot/share/aot/aotCodeHeap.cpp
! src/hotspot/share/aot/aotCompiledMethod.cpp
! src/hotspot/share/aot/aotCompiledMethod.hpp
! src/hotspot/share/compiler/compilerDirectives.cpp
! src/hotspot/share/gc/z/zBarrierSet.cpp
! test/hotspot/jtreg/compiler/cpuflags/TestAESIntrinsicsOnUnsupportedConfig.java
! test/hotspot/jtreg/compiler/onSpinWait/TestOnSpinWait.java
+ test/hotspot/jtreg/compiler/onSpinWait/TestOnSpinWaitC1.java
! test/hotspot/jtreg/compiler/runtime/Test6859338.java
! test/hotspot/jtreg/compiler/types/TestMeetIncompatibleInterfaceArrays.java
! test/hotspot/jtreg/compiler/whitebox/BlockingCompilation.java
! test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java
! test/hotspot/jtreg/vmTestbase/jit/tiered/tieredTest.sh

Changeset: 682ac3ecaa03
Author:    serb
Date:      2019-01-05 10:13 -0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/682ac3ecaa03

8215756: Memory leaks in the AWT on macOS
Reviewed-by: dmarkov

! src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m
! src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m
! src/java.desktop/macosx/native/libawt_lwawt/awt/CGraphicsEnv.m

Changeset: 866ba51a6e67
Author:    michaelm
Date:      2019-06-28 11:26 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/866ba51a6e67

8222968: ByteArrayPublisher is not thread-safe resulting in broken re-use of HttpRequests
Reviewed-by: chegar, dfuchs

! src/java.net.http/share/classes/jdk/internal/net/http/RequestPublishers.java
+ test/jdk/java/net/httpclient/ByteArrayPublishers.java

Changeset: 699509c7afdb
Author:    dchuyko
Date:      2019-05-22 21:33 +0300
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/699509c7afdb

8220072: GCC 8.3 reports errors in java.base
Reviewed-by: rriggs

! src/java.base/unix/native/libjava/canonicalize_md.c

Changeset: 42ff03a51827
Author:    dchuyko
Date:      2019-02-08 16:37 +0300
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/42ff03a51827

8215130: Fix errors in LittleCMS 2.9 reported by GCC 8
Reviewed-by: prr

! src/java.desktop/share/native/liblcms/cmsxform.c

Changeset: e24d573c677f
Author:    mikael
Date:      2019-02-21 16:56 -0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/e24d573c677f

8214777: Avoid some GCC 8.X strncpy() errors in HotSpot
Reviewed-by: kbarrett, rehn

! src/hotspot/os/aix/os_perf_aix.cpp
! src/hotspot/os/linux/os_perf_linux.cpp
! src/hotspot/os/posix/os_posix.cpp
! src/hotspot/os/solaris/os_perf_solaris.cpp
! src/hotspot/os/windows/os_perf_windows.cpp
! src/hotspot/os/windows/os_windows.cpp
! src/hotspot/share/classfile/classFileParser.cpp
! src/hotspot/share/classfile/classLoaderExt.cpp
! src/hotspot/share/classfile/verifier.cpp
! src/hotspot/share/runtime/arguments.cpp
! src/hotspot/share/services/diagnosticArgument.cpp
! src/hotspot/share/utilities/xmlstream.cpp

Changeset: 82a70d3f91ec
Author:    shade
Date:      2019-02-23 10:55 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/82a70d3f91ec

8219583: Windows build failure after JDK-8214777 (Avoid some GCC 8.X strncpy() errors in HotSpot)
Reviewed-by: kbarrett, mikael

! src/hotspot/share/classfile/classFileParser.cpp
! src/hotspot/share/classfile/classLoaderExt.cpp
! src/hotspot/share/classfile/verifier.cpp
! src/hotspot/share/services/diagnosticArgument.cpp
! src/hotspot/share/utilities/xmlstream.cpp

Changeset: 12816fdce66d
Author:    dpochepk
Date:      2019-08-23 12:57 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/12816fdce66d

8216989: CardTableBarrierSetAssembler::gen_write_ref_array_post_barrier() does not check for zero length on AARCH64
Reviewed-by: adinn

! src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.hpp
! src/hotspot/cpu/aarch64/gc/shared/cardTableBarrierSetAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shared/cardTableBarrierSetAssembler_aarch64.hpp
! src/hotspot/cpu/aarch64/gc/shared/modRefBarrierSetAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shared/modRefBarrierSetAssembler_aarch64.hpp
! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp

Changeset: 3571ef738508
Author:    aph
Date:      2019-04-05 09:53 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/3571ef738508

8219993: AArch64: Compiled CI stubs are unsafely modified
Reviewed-by: adinn

! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.hpp
! src/hotspot/cpu/aarch64/compiledIC_aarch64.cpp
! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp
! src/hotspot/cpu/aarch64/nativeInst_aarch64.cpp

Changeset: 7d1e0d1be3bd
Author:    joehw
Date:      2019-04-16 21:29 +0000
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/7d1e0d1be3bd

8222415: Xerces 2.12.0: Parsing Configuration
Reviewed-by: lancea

! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java
! test/jaxp/javax/xml/jaxp/unittest/parsers/BaseParsingTest.java

Changeset: 05505202e967
Author:    joehw
Date:      2019-04-25 15:54 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/05505202e967

8222743: Xerces 2.12.0: DOM Implementation
Reviewed-by: lancea

! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/AttrImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/AttrNSImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/ChildNode.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/CoreDOMImplementationImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DOMNormalizer.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredDocumentImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DocumentTypeImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/ElementImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/ElementNSImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/NodeImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/PSVIDOMImplementationImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/ParentNode.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/TextImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/ParserConfigurationSettings.java
! test/jaxp/javax/xml/jaxp/unittest/dom/DocumentTest.java

Changeset: c527992e3e21
Author:    joehw
Date:      2019-05-09 09:23 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/c527992e3e21

8222991: Xerces 2.12.0: Validation
Reviewed-by: lancea

! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/TypeValidator.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages.properties
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDAbstractTraverser.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDComplexTypeTraverser.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDHandler.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDSimpleTypeTraverser.java
! test/jaxp/javax/xml/jaxp/unittest/validation/SchemaTest.java

Changeset: 59470dac9ff3
Author:    joehw
Date:      2019-05-29 11:58 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/59470dac9ff3

8225005: Xerces 2.12.0: License file
Reviewed-by: lancea

! src/java.xml/share/legal/xerces.md

Changeset: 11811b48a625
Author:    ngasson
Date:      2019-08-15 14:00 +0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/11811b48a625

8229118: [TESTBUG] serviceability/sa/ClhsdbFindPC fails on AArch64
Reviewed-by: cjplummer, adinn

! test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java
+ test/hotspot/jtreg/serviceability/sa/LingeredAppWithTrivialMain.java

Changeset: d43c5ab1a337
Author:    aph
Date:      2018-12-21 18:26 +0000
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/d43c5ab1a337

8215879: AArch64: ReservedStackAccess may leave stack guard in inconsistent state
Reviewed-by: aph, dholmes
Contributed-by: Andrey Petushkov <andrey.petushkov at gmail.com>

! src/hotspot/os_cpu/linux_aarch64/os_linux_aarch64.cpp
! src/hotspot/share/runtime/thread.cpp

Changeset: 7431ec494a29
Author:    goetz
Date:      2019-08-28 10:59 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/7431ec494a29

Added tag jdk-11.0.5+5 for changeset d43c5ab1a337

! .hgtags

Changeset: b8e6deb9e763
Author:    shade
Date:      2019-09-03 21:52 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/b8e6deb9e763

Merge

! .hgtags
! src/hotspot/cpu/aarch64/aarch64.ad
! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp
! src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp
! src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp
! src/hotspot/os/linux/os_linux.cpp
! src/hotspot/share/c1/c1_LIRGenerator.cpp
! src/hotspot/share/code/codeCache.cpp
! src/hotspot/share/code/codeCache.hpp
! src/hotspot/share/compiler/compileBroker.cpp
! src/hotspot/share/opto/compile.cpp
! src/hotspot/share/opto/graphKit.cpp
! src/hotspot/share/opto/graphKit.hpp
! src/hotspot/share/opto/library_call.cpp
! src/hotspot/share/opto/memnode.cpp
! src/hotspot/share/opto/memnode.hpp
! src/hotspot/share/runtime/thread.cpp
! test/hotspot/jtreg/TEST.groups
- test/hotspot/jtreg/runtime/containers/cgroup/PlainRead.java
- test/hotspot/jtreg/runtime/containers/docker/AttemptOOM.java
- test/hotspot/jtreg/runtime/containers/docker/CheckContainerized.java
- test/hotspot/jtreg/runtime/containers/docker/DockerBasicTest.java
- test/hotspot/jtreg/runtime/containers/docker/HelloDocker.java
- test/hotspot/jtreg/runtime/containers/docker/PrintContainerInfo.java
- test/hotspot/jtreg/runtime/containers/docker/TEST.properties
- test/hotspot/jtreg/runtime/containers/docker/TestCPUAwareness.java
- test/hotspot/jtreg/runtime/containers/docker/TestCPUSets.java
- test/hotspot/jtreg/runtime/containers/docker/TestMemoryAwareness.java
- test/hotspot/jtreg/runtime/containers/docker/TestMisc.java


From shade at redhat.com  Wed Sep  4 08:31:23 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 4 Sep 2019 10:31:23 +0200
Subject: [11] RFR: Fix AArch64, add Shenandoah parts of JDK-8216989
Message-ID: <3561312d-4306-c395-6de6-c5b570795ca4@redhat.com>

We have massive AArch64 failures in sh/jdk11 after recent merge, because we miss the
Shenandoah-specific parts of JDK-8216989 [1] backport. This fixes it:
  http://cr.openjdk.java.net/~shade/8216989/webrev.11-sh.01/

The shape of the affected method is a bit different in sh/jdk11, so I had to adapt it.

Testing: aarch64 hotspot_gc_shenandoah

-- 
Thanks,
-Aleksey

[1] https://bugs.openjdk.java.net/browse/JDK-8216989


From zgu at redhat.com  Wed Sep  4 13:31:49 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 4 Sep 2019 09:31:49 -0400
Subject: [11] RFR: Fix AArch64, add Shenandoah parts of JDK-8216989
In-Reply-To: <3561312d-4306-c395-6de6-c5b570795ca4@redhat.com>
References: <3561312d-4306-c395-6de6-c5b570795ca4@redhat.com>
Message-ID: <1463c996-f24e-c1d5-d402-54c53c1b271a@redhat.com>

Okay.

-Zhengyu

On 9/4/19 4:31 AM, Aleksey Shipilev wrote:
> We have massive AArch64 failures in sh/jdk11 after recent merge, because we miss the
> Shenandoah-specific parts of JDK-8216989 [1] backport. This fixes it:
>    http://cr.openjdk.java.net/~shade/8216989/webrev.11-sh.01/
> 
> The shape of the affected method is a bit different in sh/jdk11, so I had to adapt it.
> 
> Testing: aarch64 hotspot_gc_shenandoah
> 

From shade at redhat.com  Wed Sep  4 13:33:28 2019
From: shade at redhat.com (shade at redhat.com)
Date: Wed, 04 Sep 2019 13:33:28 +0000
Subject: hg: shenandoah/jdk11: [backport] 8216989:
 CardTableBarrierSetAssembler::gen_write_ref_array_post_barrier()
 does not check for zero length on AARCH64
Message-ID: <201909041333.x84DXTH8004431@aojmv0008.oracle.com>

Changeset: 42686e3ea552
Author:    shade
Date:      2019-09-04 10:34 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/42686e3ea552

[backport] 8216989: CardTableBarrierSetAssembler::gen_write_ref_array_post_barrier() does not check for zero length on AARCH64

! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp


From shade at redhat.com  Wed Sep  4 14:28:42 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 4 Sep 2019 16:28:42 +0200
Subject: RFC: Pick up jdk-11.0.5+6 to sh/jdk11
Message-ID: <f2178469-d6e4-c4f8-f5ce-6b56db9ceede@redhat.com>

This time, it is a trivial merge, because 11.0.5 is in rampdown.

Changesets:
  https://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.5%2b6/changesets.txt

Testing: x86_64 hotspot_gc_shenandoah {fastdebug,release}

-- 
Thanks,
-Aleksey


From zgu at redhat.com  Wed Sep  4 14:37:47 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 4 Sep 2019 10:37:47 -0400
Subject: RFC: Pick up jdk-11.0.5+6 to sh/jdk11
In-Reply-To: <f2178469-d6e4-c4f8-f5ce-6b56db9ceede@redhat.com>
References: <f2178469-d6e4-c4f8-f5ce-6b56db9ceede@redhat.com>
Message-ID: <7678998c-0146-579d-7527-62d27a3c50d5@redhat.com>

Okay.

Thanks,

-Zhengyu

On 9/4/19 10:28 AM, Aleksey Shipilev wrote:
> This time, it is a trivial merge, because 11.0.5 is in rampdown.
> 
> Changesets:
>    https://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.5%2b6/changesets.txt
> 
> Testing: x86_64 hotspot_gc_shenandoah {fastdebug,release}
> 

From shade at redhat.com  Wed Sep  4 16:59:18 2019
From: shade at redhat.com (shade at redhat.com)
Date: Wed, 04 Sep 2019 16:59:18 +0000
Subject: hg: shenandoah/jdk11: 4 new changesets
Message-ID: <201909041659.x84GxJBI011373@aojmv0008.oracle.com>

Changeset: 1e1f1cbe462d
Author:    shade
Date:      2019-09-04 15:34 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/1e1f1cbe462d

Added tag shenandoah-jdk-11.0.5+5 for changeset 42686e3ea552

! .hgtags

Changeset: deaef57bf366
Author:    redestad
Date:      2018-09-12 11:13 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/deaef57bf366

8224589: Improve startup behavior of SecurityProperties
Reviewed-by: alanb

! src/java.base/share/classes/sun/net/util/SocketExceptions.java
+ src/java.base/share/classes/sun/security/util/SecurityProperties.java

Changeset: e02a4cc70365
Author:    shade
Date:      2019-09-04 16:23 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/e02a4cc70365

Merge


Changeset: 534d51072d0e
Author:    shade
Date:      2019-09-04 16:23 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/534d51072d0e

Added tag shenandoah-jdk-11.0.5+6 for changeset e02a4cc70365

! .hgtags


From shade at redhat.com  Thu Sep  5 19:45:36 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 5 Sep 2019 21:45:36 +0200
Subject: RFR: ShenandoahRuntime::load_reference_barrier_native should not
 accept second parameter
Message-ID: <5eba4d7e-6598-47ec-65f2-be20ce79a5bc@redhat.com>

Hi,

There are massive x86_32 failures with sh/jdk, but only in release mode. Zhengyu pinpointed it to
this changeset:

 changeset:   56771:40c0f1f47ca5
 parent:      56666:af48b07d0312
 parent:      56770:28ab01c06755
 user:        rkennke
 date:        Sun Jul 28 22:14:16 2019 +0200
 summary:     Merge

However, both parents (af48b07d0312 and 28ab01c06755) are running fine! So whatever broke it was
done in the merge itself.

I believe the cause is calling ShenandoahRuntime::load_reference_barrier_native from everywhere with
only one argument (the object itself), but the native method signature actually expects another
argument. So calling convention gets foobared. This might be why we only see it with x86_32, where
second argument is passed on stack, and so stack becomes foobared after this call.

Fix:

diff -r 40c0f1f47ca5 src/hotspot/share/gc/shenandoah/shenandoahRuntime.cpp
--- a/src/hotspot/share/gc/shenandoah/shenandoahRuntime.cpp     Sun Jul 28 22:14:16 2019 +0200
+++ b/src/hotspot/share/gc/shenandoah/shenandoahRuntime.cpp     Thu Sep 05 21:38:06 2019 +0200
@@ -74,5 +74,5 @@
 JRT_END

-JRT_LEAF(oopDesc*, ShenandoahRuntime::load_reference_barrier_native(oopDesc * src, oop* load_addr))
+JRT_LEAF(oopDesc*, ShenandoahRuntime::load_reference_barrier_native(oopDesc * src))
   return (oopDesc*) ShenandoahBarrierSet::barrier_set()->oop_load_from_native_barrier(oop(src));
 JRT_END
diff -r 40c0f1f47ca5 src/hotspot/share/gc/shenandoah/shenandoahRuntime.hpp
--- a/src/hotspot/share/gc/shenandoah/shenandoahRuntime.hpp     Sun Jul 28 22:14:16 2019 +0200
+++ b/src/hotspot/share/gc/shenandoah/shenandoahRuntime.hpp     Thu Sep 05 21:38:06 2019 +0200
@@ -42,5 +42,5 @@
   static oopDesc* load_reference_barrier_fixup_narrow(oopDesc* src, narrowOop* load_addr);

-  static oopDesc* load_reference_barrier_native(oopDesc* src, oop* load_addr);
+  static oopDesc* load_reference_barrier_native(oopDesc* src);

   static void shenandoah_clone_barrier(oopDesc* obj);

Testing: hotspot_gc_shenandoah x86_32 {fastdebug,release}

-- 
Thanks,
-Aleksey


From zgu at redhat.com  Thu Sep  5 20:12:04 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Thu, 5 Sep 2019 16:12:04 -0400
Subject: RFR: ShenandoahRuntime::load_reference_barrier_native should not
 accept second parameter
In-Reply-To: <5eba4d7e-6598-47ec-65f2-be20ce79a5bc@redhat.com>
References: <5eba4d7e-6598-47ec-65f2-be20ce79a5bc@redhat.com>
Message-ID: <3a848ff5-8012-1d27-b80a-c5e225ba8e42@redhat.com>

Looks good.

Thanks,

-Zhengyu

On 9/5/19 3:45 PM, Aleksey Shipilev wrote:
> Hi,
> 
> There are massive x86_32 failures with sh/jdk, but only in release mode. Zhengyu pinpointed it to
> this changeset:
> 
>   changeset:   56771:40c0f1f47ca5
>   parent:      56666:af48b07d0312
>   parent:      56770:28ab01c06755
>   user:        rkennke
>   date:        Sun Jul 28 22:14:16 2019 +0200
>   summary:     Merge
> 
> However, both parents (af48b07d0312 and 28ab01c06755) are running fine! So whatever broke it was
> done in the merge itself.
> 
> I believe the cause is calling ShenandoahRuntime::load_reference_barrier_native from everywhere with
> only one argument (the object itself), but the native method signature actually expects another
> argument. So calling convention gets foobared. This might be why we only see it with x86_32, where
> second argument is passed on stack, and so stack becomes foobared after this call.
> 
> Fix:
> 
> diff -r 40c0f1f47ca5 src/hotspot/share/gc/shenandoah/shenandoahRuntime.cpp
> --- a/src/hotspot/share/gc/shenandoah/shenandoahRuntime.cpp     Sun Jul 28 22:14:16 2019 +0200
> +++ b/src/hotspot/share/gc/shenandoah/shenandoahRuntime.cpp     Thu Sep 05 21:38:06 2019 +0200
> @@ -74,5 +74,5 @@
>   JRT_END
> 
> -JRT_LEAF(oopDesc*, ShenandoahRuntime::load_reference_barrier_native(oopDesc * src, oop* load_addr))
> +JRT_LEAF(oopDesc*, ShenandoahRuntime::load_reference_barrier_native(oopDesc * src))
>     return (oopDesc*) ShenandoahBarrierSet::barrier_set()->oop_load_from_native_barrier(oop(src));
>   JRT_END
> diff -r 40c0f1f47ca5 src/hotspot/share/gc/shenandoah/shenandoahRuntime.hpp
> --- a/src/hotspot/share/gc/shenandoah/shenandoahRuntime.hpp     Sun Jul 28 22:14:16 2019 +0200
> +++ b/src/hotspot/share/gc/shenandoah/shenandoahRuntime.hpp     Thu Sep 05 21:38:06 2019 +0200
> @@ -42,5 +42,5 @@
>     static oopDesc* load_reference_barrier_fixup_narrow(oopDesc* src, narrowOop* load_addr);
> 
> -  static oopDesc* load_reference_barrier_native(oopDesc* src, oop* load_addr);
> +  static oopDesc* load_reference_barrier_native(oopDesc* src);
> 
>     static void shenandoah_clone_barrier(oopDesc* obj);
> 
> Testing: hotspot_gc_shenandoah x86_32 {fastdebug,release}
> 

From shade at redhat.com  Thu Sep  5 20:24:59 2019
From: shade at redhat.com (shade at redhat.com)
Date: Thu, 05 Sep 2019 20:24:59 +0000
Subject: hg: shenandoah/jdk: ShenandoahRuntime::load_reference_barrier_native
 should not accept second parameter
Message-ID: <201909052025.x85KP0ds002111@aojmv0008.oracle.com>

Changeset: 7175c0025de1
Author:    shade
Date:      2019-09-05 22:10 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/7175c0025de1

ShenandoahRuntime::load_reference_barrier_native should not accept second parameter

! src/hotspot/share/gc/shenandoah/shenandoahRuntime.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRuntime.hpp


From gnu.andrew at redhat.com  Fri Sep  6 04:11:09 2019
From: gnu.andrew at redhat.com (Andrew John Hughes)
Date: Fri, 6 Sep 2019 05:11:09 +0100
Subject: RFR] [8u] 8u232-b05 Upstream Sync
Message-ID: <99cd9153-74b5-3cbf-7327-9b59510acfcf@redhat.com>

Webrevs: https://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/

Merge changesets:

http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/corba/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/jaxp/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/jaxws/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/jdk/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/hotspot/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/langtools/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/nashorn/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/root/merge.changeset

Changes in aarch64-shenandoah-jdk8u232-b05:
  - S8080157: assert(allocates2(pc)) failed: not in CodeBuffer memory
  - S8087128: C2: Disallow definition split on MachCopySpill nodes
  - S8139965: Hang seen when using com.sun.jndi.ldap.search.replyQueueSize
  - S8141570: Fix Zero interpreter build for --disable-precompiled-headers
  - S8147502: Digest is incorrectly truncated for ECDSA signatures when
the bit length of n is less than the field size
  - S8147611: G1 - Missing memory barrier in start_cset_region_for_worker
  - S8151066: assert(0 <= i && i < length()) failed: index out of bounds
  - S8155951: VM crash in nsk/jvmti/RedefineClasses/StressRedefine:
assert failed: Corrupted constant pool
  - S8179954: AArch64: C1 and C2 volatile accesses are not sequentially
consistent
  - S8202948: C2: assert(init_offset >= 0) failed: positive offset from
object start
  - S8203324: Use out of scope in getMacOSXLocale of java_props_macosx.c:120
  - S8206163: AArch64: incorrect code generation for StoreCM
  - S8206879: Currency decimal marker incorrect for Peru
  - S8209420: Track membars for volatile accesses so they can be
properly optimized
  - S8211232: GraphKit::make_runtime_call() sometimes attaches wrong
memory state to call
  - S8211233: MemBarNode::trailing_membar() and
MemBarNode::leading_membar() need to handle dying subgraphs better
  - S8214687: Optimize Collections.nCopies().hashCode() and equals()
  - S8214702: Wrong text position for whitespaced string in printing
Swing text
  - S8214857: "bad trailing membar" assert failure at memnode.cpp:3220
  - S8215130: Fix errors in LittleCMS 2.9 reported by GCC 8
  - S8215265: C2: range check elimination may allow illegal out of bound
access
  - S8216350: AArch64: monitor unlock fast path not called
  - S8217359: C2 compiler triggers SIGSEGV after transformation in
ConvI2LNode::Ideal
  - S8217731: Font rendering and glyph spacing changed from jdk-8 to jdk-11
  - S8217896: Make better use of LCPUs when building on AIX
  - S8218201: Failures when vmIntrinsics::_getClass is not inlined
  - S8218280: LineNumberReader throws "Mark invalid" exception if CRLF
straddles buffer.
  - S8218780: Update MUSCLE PCSC-Lite header files
  - S8219517: assert(false) failed: infinite loop in PhaseIterGVN::optimize
  - S8220072: GCC 8.3 reports errors in java.base
  - S8222980: Upgrade IANA Language Subtag Registry to Version 2019-04-03
  - S8223177: Data race on JvmtiEnvBase::_tag_map in double-checked locking
  - S8223227: Rename acquire_tag_map() to tag_map_acquire() in jvmtiEnvBase
  - S8225423: GTK L&F: JSplitPane: There is no divider shown
  - S8226798: JVM crash in
klassItable::initialize_itable_for_interface(int, InstanceKlass*, bool,
Thread*)
  - S8226964: [Yaru] GTK L&F: There is no difference between menu
selected and de-selected
  - S8228440: TestAESCiphers tests fail with "access denied" trying to
access ArrayUtil

Main issues of note:
* 8179954, 8206163, 8209420, 8211233, 8214857 & 8216350 are already
upstream and not part of this merge.
* There was a conflict with 8080157 in
hotspot/src/cpu/x86/vm/stubRoutines_x86_64.hpp as code_size2 had already
been increased to the higher value of 46700 by "Adjust code stub sizes
for Shenandoah and future backports". That change was thus simply
dropped. The rest of 8080157 is still useful in adding asserts for when
buffer.insts_remaining() reaches 200 or less.

diffstat for root
 b/.hgtags                                |    1 +
 b/common/autoconf/build-performance.m4   |    9 ++++++---
 b/common/autoconf/generated-configure.sh |   11 +++++++----
 3 files changed, 14 insertions(+), 7 deletions(-)

diffstat for corba
 b/.hgtags |    1 +
 1 file changed, 1 insertion(+)

diffstat for jaxp
 b/.hgtags |    1 +
 1 file changed, 1 insertion(+)

diffstat for jaxws
 b/.hgtags |    1 +
 1 file changed, 1 insertion(+)

diffstat for langtools
 b/.hgtags |    1 +
 1 file changed, 1 insertion(+)

diffstat for nashorn
 b/.hgtags |    1 +
 1 file changed, 1 insertion(+)

diffstat for jdk
 a/src/solaris/native/sun/security/smartcardio/MUSCLE/COPYING         |
  28
 b/.hgtags                                                            |
   1
 b/make/data/lsrdata/language-subtag-registry.txt                     |
  15
 b/src/share/classes/com/sun/crypto/provider/CipherBlockChaining.java |
  14
 b/src/share/classes/com/sun/crypto/provider/CipherFeedback.java      |
  13
 b/src/share/classes/com/sun/crypto/provider/CounterMode.java         |
   6
 b/src/share/classes/com/sun/crypto/provider/ElectronicCodeBook.java  |
  13
 b/src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java   |
  19
 b/src/share/classes/com/sun/crypto/provider/OutputFeedback.java      |
  11
 b/src/share/classes/com/sun/crypto/provider/PCBC.java                |
  14
 b/src/share/classes/com/sun/crypto/provider/Preconditions.java       |
   2
 b/src/share/classes/com/sun/crypto/provider/RangeUtil.java           |
  53
 b/src/share/classes/com/sun/java/swing/plaf/gtk/GTKPainter.java      |
  79 +
 b/src/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java        |
   8
 b/src/share/classes/com/sun/jndi/ldap/BerDecoder.java                |
  12
 b/src/share/classes/com/sun/jndi/ldap/Connection.java                |
  67 -
 b/src/share/classes/com/sun/jndi/ldap/LdapRequest.java               |
  88 -
 b/src/share/classes/java/io/LineNumberReader.java                    |
   7
 b/src/share/classes/java/util/Collections.java                       |
  49
 b/src/share/classes/sun/security/ec/ECDSASignature.java              |
   6
 b/src/share/classes/sun/security/util/ArrayUtil.java                 |
  22
 b/src/share/classes/sun/swing/SwingUtilities2.java                   |
  24
 b/src/share/classes/sun/text/resources/es/FormatData_es_PE.java      |
  17
 b/src/share/native/sun/font/freetypeScaler.c                         |
  53
 b/src/share/native/sun/java2d/cmm/lcms/cmsxform.c                    |
   2
 b/src/share/native/sun/security/ec/impl/ec.c                         |
  18
 b/src/share/native/sun/security/smartcardio/pcsc.c                   |
   6
 b/src/solaris/native/java/io/canonicalize_md.c                       |
  11
 b/src/solaris/native/java/lang/java_props_macosx.c                   |
   5
 b/src/solaris/native/sun/awt/gtk3_interface.c                        |
  35
 b/src/solaris/native/sun/awt/gtk3_interface.h                        |
   4
 b/src/solaris/native/sun/security/smartcardio/MUSCLE/pcsclite.h      |
 556 ++++------
 b/src/solaris/native/sun/security/smartcardio/MUSCLE/winscard.h      |
 135 +-
 b/src/solaris/native/sun/security/smartcardio/MUSCLE/wintypes.h      |
 115 ++
 b/src/solaris/native/sun/security/smartcardio/pcsc_md.h              |
  69 -
 b/test/java/io/LineNumberReader/MarkSplitCRLF.java                   |
  99 +
 b/test/java/text/Format/NumberFormat/TestPeruCurrencyFormat.java     |
  47
 b/test/java/util/Collections/NCopies.java                            |
  56 -
 b/test/java/util/Locale/Bug8040211.java                              |
   9
 b/test/java/util/Objects/CheckIndex.java                             |
   5
 b/test/javax/swing/JComboBox/8033069/bug8033069NoScrollBar.java      |
   5
 b/test/javax/swing/JComboBox/8033069/bug8033069ScrollBar.java        |
   4
 b/test/javax/swing/SwingUtilities/TestTextPosInPrint.java            |
 244 ++++
 b/test/lib/testlibrary/jdk/testlibrary/Convert.java                  |
  84 +
 b/test/sun/security/ec/SignatureDigestTruncate.java                  |
 125 ++
 b/test/sun/text/resources/LocaleData                                 |
   7
 46 files changed, 1599 insertions(+), 663 deletions(-)

diffstat for hotspot
 b/.hgtags                                                         |    1
 b/make/linux/makefiles/zeroshark.make                             |   16 +
 b/src/share/vm/ci/bcEscapeAnalyzer.cpp                            |
42 +---
 b/src/share/vm/ci/bcEscapeAnalyzer.hpp                            |    4
 b/src/share/vm/ci/ciStreams.cpp                                   |    9
 b/src/share/vm/ci/ciStreams.hpp                                   |    4
 b/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp           |    1
 b/src/share/vm/oops/instanceKlass.hpp                             |    5
 b/src/share/vm/oops/klassVtable.cpp                               |   22 ++
 b/src/share/vm/opto/connode.cpp                                   |    6
 b/src/share/vm/opto/graphKit.cpp                                  |    9
 b/src/share/vm/opto/graphKit.hpp                                  |    2
 b/src/share/vm/opto/loopTransform.cpp                             |   20 +-
 b/src/share/vm/opto/loopnode.hpp                                  |    2
 b/src/share/vm/opto/memnode.cpp                                   |    8
 b/src/share/vm/opto/reg_split.cpp                                 |    3
 b/src/share/vm/opto/superword.cpp                                 |    4
 b/src/share/vm/prims/jvmtiEnvBase.hpp                             |   10 -
 b/src/share/vm/prims/jvmtiRedefineClasses.cpp                     |
73 +++++--
 b/src/share/vm/prims/jvmtiRedefineClasses.hpp                     |    4
 b/src/share/vm/prims/jvmtiTagMap.cpp                              |    6
 b/src/share/vm/runtime/java.cpp                                   |    1
 b/src/share/vm/runtime/mutexLocker.cpp                            |    2
 b/src/share/vm/runtime/mutexLocker.hpp                            |    1
 b/src/share/vm/runtime/stubRoutines.cpp                           |    6
 b/test/compiler/c2/Test8217359.java                               |
74 +++++++
 b/test/compiler/escapeAnalysis/TestGetClass.java                  |
52 +++++
 b/test/compiler/loopopts/superword/TestNegBaseOffset.java         |
59 +++++
 b/test/compiler/rangechecks/RangeCheckEliminationScaleNotOne.java |
100 ++++++++++
 b/test/runtime/VtableTests/VTableTest.java                        |
50 +++++
 b/test/runtime/VtableTests/pkg/A.java                             |   28 ++
 31 files changed, 549 insertions(+), 75 deletions(-)

Successfully built on x86, x86_64, s390, s390x, ppc64, ppc64le & aarch64.

Ok to push?
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew


From shade at redhat.com  Fri Sep  6 07:36:51 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 6 Sep 2019 09:36:51 +0200
Subject: [aarch64-port-dev ] RFR] [8u] 8u232-b05 Upstream Sync
In-Reply-To: <99cd9153-74b5-3cbf-7327-9b59510acfcf@redhat.com>
References: <99cd9153-74b5-3cbf-7327-9b59510acfcf@redhat.com>
Message-ID: <68e8c8aa-4410-6a52-b9b1-282cf7ce122b@redhat.com>

On 9/6/19 6:11 AM, Andrew John Hughes wrote:
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/corba/merge.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/jaxp/merge.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/jaxws/merge.changeset

Looks trivially good.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/jdk/merge.changeset

Looks good.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/hotspot/merge.changeset

Looks good.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/langtools/merge.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/nashorn/merge.changeset

Looks trivially good.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/root/merge.changeset

Looks good.

Thumbs up! Good to go in.


Thanks,
-Aleksey


From zgu at redhat.com  Fri Sep  6 14:50:34 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Fri, 6 Sep 2019 10:50:34 -0400
Subject: RFR: Cherry-pick: 8230401: ClassLoaderData::_keep_alive is read with
 wrong type in c2i entry barrier
Message-ID: <4f99fc45-5e3e-d797-8af2-b5282b511246@redhat.com>

I would like to cherry pick this patch to shenandoah/jdk. It is needed 
for x86_32 nmethod barrier work.

http://cr.openjdk.java.net/~zgu/shenandoah/JDK-8230401_CLD-keep_alive/webrev.00/

Test:
   hotspot_gc_shenandoah x86_64 (fastdebug and release)


Thanks,

-Zhengyu

From shade at redhat.com  Fri Sep  6 14:52:40 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 6 Sep 2019 16:52:40 +0200
Subject: RFR: Cherry-pick: 8230401: ClassLoaderData::_keep_alive is read
 with wrong type in c2i entry barrier
In-Reply-To: <4f99fc45-5e3e-d797-8af2-b5282b511246@redhat.com>
References: <4f99fc45-5e3e-d797-8af2-b5282b511246@redhat.com>
Message-ID: <2737c2db-523d-b503-d24f-8f9db375d5f3@redhat.com>

On 9/6/19 4:50 PM, Zhengyu Gu wrote:
> I would like to cherry pick this patch to shenandoah/jdk. It is needed for x86_32 nmethod barrier work.
> 
> http://cr.openjdk.java.net/~zgu/shenandoah/JDK-8230401_CLD-keep_alive/webrev.00/

Sure, go.

-- 
Thanks,
-Aleksey


From zgu at redhat.com  Fri Sep  6 14:54:16 2019
From: zgu at redhat.com (zgu at redhat.com)
Date: Fri, 06 Sep 2019 14:54:16 +0000
Subject: hg: shenandoah/jdk: Cherry-pick: 8230401:
 ClassLoaderData::_keep_alive is read with wrong type in c2i
 entry barrier
Message-ID: <201909061454.x86EsHQI011540@aojmv0008.oracle.com>

Changeset: ea686a5ec33c
Author:    eosterlund
Date:      2019-09-04 15:05 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/ea686a5ec33c

Cherry-pick: 8230401: ClassLoaderData::_keep_alive is read with wrong type in c2i entry barrier
Reviewed-by: zgu, tschatzl, iklam

! src/hotspot/share/classfile/classLoaderData.hpp


From shade at redhat.com  Fri Sep  6 14:58:11 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 6 Sep 2019 16:58:11 +0200
Subject: [11] RFR: Fix ShenandoahBarrierSetC2::enqueue_useful_gc_barrier (part
 of JDK-8212611)
Message-ID: <6f7660a4-286b-610d-3f7b-a93067e8171a@redhat.com>

There is a discrepancy between jdk/jdk and sh/jdk11 definition of BSC2::enqueue_useful_gc_barrier,
where one thing adds the node to the IGVN worklist [1], and another adds all users to it [2]. It was
introduced by JDK-8212611 [3], and we should consider backporting it to 11u.

Meanwhile, sh/jdk11 x86_32 CTW fails without that patch:

$ CONF=linux-x86-normal-server-fastdebug make run-test TEST_VM_OPTS="-XX:-TieredCompilation
-XX:+UseShenandoahGC" TEST=applications/ctw/modules/jdk_scripting_nashorn.java

#
#  Internal Error (/home/shade/trunks/shenandoah-jdk11/src/hotspot/share/opto/compile.cpp:2851),
pid=23210, tid=23220
#  assert(!ShenandoahBarrierSetC2::has_only_shenandoah_wb_pre_uses(addp)) failed: useless address
computation?
#

I believe the best course of action would be to pick up safer parts of JDK-8212611 to sh/jdk11:
  https://cr.openjdk.java.net/~shade/shenandoah/11u-fix-bsc2-eugcb/webrev.01/

Testing: {x86_64, x86_32} CTW tests, {x86_64, x86_32} hotspot_gc_shenandoah (running)

-- 
Thanks,
-Aleksey


[1] sh/jdk11:
void ShenandoahBarrierSetC2::enqueue_useful_gc_barrier(Unique_Node_List &worklist, Node* node) const {
  if (node->Opcode() == Op_AddP && ShenandoahBarrierSetC2::has_only_shenandoah_wb_pre_uses(node)) {
    worklist.push(node);
  }
}

[2] jdk/jdk:
void ShenandoahBarrierSetC2::enqueue_useful_gc_barrier(PhaseIterGVN* igvn, Node* node) const {
  if (node->Opcode() == Op_AddP && ShenandoahBarrierSetC2::has_only_shenandoah_wb_pre_uses(node)) {
    igvn->add_users_to_worklist(node);
  }
}

[3] 8212611: Small collection of simple changes from shenandoah
 https://bugs.openjdk.java.net/browse/JDK-8212611


From rwestrel at redhat.com  Fri Sep  6 15:01:56 2019
From: rwestrel at redhat.com (Roland Westrelin)
Date: Fri, 06 Sep 2019 17:01:56 +0200
Subject: [11] RFR: Fix ShenandoahBarrierSetC2::enqueue_useful_gc_barrier
 (part of JDK-8212611)
In-Reply-To: <6f7660a4-286b-610d-3f7b-a93067e8171a@redhat.com>
References: <6f7660a4-286b-610d-3f7b-a93067e8171a@redhat.com>
Message-ID: <87mufhlb8b.fsf@redhat.com>


>   https://cr.openjdk.java.net/~shade/shenandoah/11u-fix-bsc2-eugcb/webrev.01/

Good.

Roland.

From gnu.andrew at redhat.com  Fri Sep  6 15:43:34 2019
From: gnu.andrew at redhat.com (Andrew John Hughes)
Date: Fri, 6 Sep 2019 16:43:34 +0100
Subject: [aarch64-port-dev ] RFR] [8u] 8u232-b05 Upstream Sync
In-Reply-To: <68e8c8aa-4410-6a52-b9b1-282cf7ce122b@redhat.com>
References: <99cd9153-74b5-3cbf-7327-9b59510acfcf@redhat.com>
 <68e8c8aa-4410-6a52-b9b1-282cf7ce122b@redhat.com>
Message-ID: <adc1460f-57d5-f466-ee6a-64e30c8f266d@redhat.com>



On 06/09/2019 08:36, Aleksey Shipilev wrote:
> On 9/6/19 6:11 AM, Andrew John Hughes wrote:
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/corba/merge.changeset
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/jaxp/merge.changeset
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/jaxws/merge.changeset
> 
> Looks trivially good.
> 
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/jdk/merge.changeset
> 
> Looks good.
> 
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/hotspot/merge.changeset
> 
> Looks good.
> 
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/langtools/merge.changeset
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/nashorn/merge.changeset
> 
> Looks trivially good.
> 
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b05/root/merge.changeset
> 
> Looks good.
> 
> Thumbs up! Good to go in.
> 
> 
> Thanks,
> -Aleksey
> 

Pushed.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew


From shade at redhat.com  Fri Sep  6 16:15:14 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 6 Sep 2019 18:15:14 +0200
Subject: [8u] RFC: Pick up 8u232-b05 to sh/jdk8
Message-ID: <4c187c60-4756-4fd9-a327-8351a33bb84f@redhat.com>

Let's pick up 8u232-b05 to sh/jdk8, and do at least one nightly spin of testing it. Then I am going
to propose the sync back to integration forest (aarch64-port/shenandoah-jdk8u) for 8u232 release.

Merge is trivial. Changeset list:
  http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk8-8u232-b05/changesets.txt

Testing: hotspot_gc_shenandoah {fastdebug,release}

-- 
Thanks,
-Aleksey


From zgu at redhat.com  Fri Sep  6 16:23:19 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Fri, 6 Sep 2019 12:23:19 -0400
Subject: [8u] RFC: Pick up 8u232-b05 to sh/jdk8
In-Reply-To: <4c187c60-4756-4fd9-a327-8351a33bb84f@redhat.com>
References: <4c187c60-4756-4fd9-a327-8351a33bb84f@redhat.com>
Message-ID: <913ac02f-f66c-bd41-a46a-61eeac083739@redhat.com>

Okay.

Thanks,

-Zhengyu

On 9/6/19 12:15 PM, Aleksey Shipilev wrote:
> Let's pick up 8u232-b05 to sh/jdk8, and do at least one nightly spin of testing it. Then I am going
> to propose the sync back to integration forest (aarch64-port/shenandoah-jdk8u) for 8u232 release.
> 
> Merge is trivial. Changeset list:
>    http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk8-8u232-b05/changesets.txt
> 
> Testing: hotspot_gc_shenandoah {fastdebug,release}
> 

From shade at redhat.com  Fri Sep  6 16:27:39 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 6 Sep 2019 18:27:39 +0200
Subject: ANN: aarch64-port/jdk8u-shenandoah is frozen -- DO NOT PUSH
Message-ID: <20ad8ab8-160e-a9f1-7b45-b57c5172bf0c@redhat.com>

Hi,

With the power vested upon me by Andrew Hughes:

Please refrain from pushing new changes to aarch64-port/jdk8u-shenandoah until further notice. We
are planning to have a drop of Shenandoah 8u code for 8u232, and would like to merge-build-test
current drop against the stable target.

ETA for that work to complete is Monday, Sep 9, 22:00 CEST.

I would notify separately when this freeze lifts.

-- 
Thanks,
-Aleksey


From shade at redhat.com  Fri Sep  6 16:28:52 2019
From: shade at redhat.com (shade at redhat.com)
Date: Fri, 06 Sep 2019 16:28:52 +0000
Subject: hg: shenandoah/jdk8/jaxp: 3 new changesets
Message-ID: <201909061628.x86GSqOc009764@aojmv0008.oracle.com>

Changeset: 7b44b5f468a4
Author:    andrew
Date:      2019-09-04 19:40 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jaxp/rev/7b44b5f468a4

Added tag jdk8u232-b05 for changeset 2b9fdc450085

! .hgtags

Changeset: 6868f2da45d5
Author:    andrew
Date:      2019-09-05 17:38 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jaxp/rev/6868f2da45d5

Merge jdk8u232-b05

! .hgtags

Changeset: 56563fa62d18
Author:    andrew
Date:      2019-09-05 17:38 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jaxp/rev/56563fa62d18

Added tag aarch64-shenandoah-jdk8u232-b05 for changeset 6868f2da45d5

! .hgtags


From shade at redhat.com  Fri Sep  6 16:28:53 2019
From: shade at redhat.com (shade at redhat.com)
Date: Fri, 06 Sep 2019 16:28:53 +0000
Subject: hg: shenandoah/jdk8/jaxws: 3 new changesets
Message-ID: <201909061628.x86GSrTU009823@aojmv0008.oracle.com>

Changeset: 60e3a82a9973
Author:    andrew
Date:      2019-09-04 19:40 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jaxws/rev/60e3a82a9973

Added tag jdk8u232-b05 for changeset 298981215ad0

! .hgtags

Changeset: 16f8c93c0dcf
Author:    andrew
Date:      2019-09-05 17:38 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jaxws/rev/16f8c93c0dcf

Merge jdk8u232-b05

! .hgtags

Changeset: fe92f572d4f1
Author:    andrew
Date:      2019-09-05 17:38 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jaxws/rev/fe92f572d4f1

Added tag aarch64-shenandoah-jdk8u232-b05 for changeset 16f8c93c0dcf

! .hgtags


From shade at redhat.com  Fri Sep  6 16:28:50 2019
From: shade at redhat.com (shade at redhat.com)
Date: Fri, 06 Sep 2019 16:28:50 +0000
Subject: hg: shenandoah/jdk8/langtools: 3 new changesets
Message-ID: <201909061628.x86GSo3x009674@aojmv0008.oracle.com>

Changeset: 2338eb5fa755
Author:    andrew
Date:      2019-09-04 19:40 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/langtools/rev/2338eb5fa755

Added tag jdk8u232-b05 for changeset 415c49110391

! .hgtags

Changeset: b7758faf1af0
Author:    andrew
Date:      2019-09-05 17:38 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/langtools/rev/b7758faf1af0

Merge jdk8u232-b05

! .hgtags

Changeset: 31a70fb38ae4
Author:    andrew
Date:      2019-09-05 17:38 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/langtools/rev/31a70fb38ae4

Added tag aarch64-shenandoah-jdk8u232-b05 for changeset b7758faf1af0

! .hgtags


From shade at redhat.com  Fri Sep  6 16:28:58 2019
From: shade at redhat.com (shade at redhat.com)
Date: Fri, 06 Sep 2019 16:28:58 +0000
Subject: hg: shenandoah/jdk8/hotspot: 24 new changesets
Message-ID: <201909061628.x86GSwRp010094@aojmv0008.oracle.com>

Changeset: b9380e010fdc
Author:    aph
Date:      2017-05-11 13:11 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/b9380e010fdc

8179954: AArch64: C1 and C2 volatile accesses are not sequentially consistent
Reviewed-by: roland

! src/cpu/aarch64/vm/c1_LIRGenerator_aarch64.cpp
! src/cpu/aarch64/vm/templateTable_aarch64.cpp

Changeset: 6ff3bed6d8fa
Author:    adinn
Date:      2018-07-09 09:38 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/6ff3bed6d8fa

8206163: AArch64: incorrect code generation for StoreCM
Summary: StoreCM may require planting a StoreStore barrier
Reviewed-by: aph, zyao, roland

! src/cpu/aarch64/vm/aarch64.ad

Changeset: f498b25d9c30
Author:    roland
Date:      2018-08-14 16:54 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/f498b25d9c30

8209420: Track membars for volatile accesses so they can be properly optimized
Reviewed-by: adinn, aph, thartmann

! src/cpu/aarch64/vm/aarch64.ad
! src/share/vm/opto/compile.cpp
! src/share/vm/opto/library_call.cpp
! src/share/vm/opto/memnode.cpp
! src/share/vm/opto/memnode.hpp
! src/share/vm/opto/parse3.cpp

Changeset: ffa9ff5b9217
Author:    roland
Date:      2018-09-27 17:46 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/ffa9ff5b9217

8211233: MemBarNode::trailing_membar() and MemBarNode::leading_membar() need to handle dying subgraphs better
Reviewed-by: kvn, thartmann

! src/share/vm/opto/memnode.cpp

Changeset: 7e641cd3d5b4
Author:    roland
Date:      2018-12-03 10:51 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/7e641cd3d5b4

8214857: "bad trailing membar" assert failure at memnode.cpp:3220
Reviewed-by: adinn, thartmann

! src/share/vm/opto/memnode.cpp

Changeset: c99ce621059e
Author:    ngasson
Date:      2019-08-27 15:54 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/c99ce621059e

8216350: AArch64: monitor unlock fast path not called
Reviewed-by: aph, drwhite, fyang

! src/cpu/aarch64/vm/aarch64.ad
! src/cpu/aarch64/vm/assembler_aarch64.hpp

Changeset: c61a86859323
Author:    manc
Date:      2019-04-30 18:44 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/c61a86859323

8223177: Data race on JvmtiEnvBase::_tag_map in double-checked locking
Summary: Add memory fences on accesses to JvmtiEnvBase::_tag_map
Reviewed-by: dholmes, jcbeyler, sspitsyn

! src/share/vm/prims/jvmtiEnvBase.hpp
! src/share/vm/prims/jvmtiTagMap.cpp

Changeset: 25738d7267c3
Author:    manc
Date:      2019-05-01 20:25 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/25738d7267c3

8223227: Rename acquire_tag_map() to tag_map_acquire() in jvmtiEnvBase
Reviewed-by: dholmes, jcbeyler

! src/share/vm/prims/jvmtiEnvBase.hpp
! src/share/vm/prims/jvmtiTagMap.cpp

Changeset: bd6ec847115e
Author:    neliasso
Date:      2019-08-19 17:36 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/bd6ec847115e

8219517: assert(false) failed: infinite loop in PhaseIterGVN::optimize
Reviewed-by: kvn, thartmann

! src/share/vm/opto/memnode.cpp

Changeset: 940791dabea2
Author:    thartmann
Date:      2019-03-11 11:42 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/940791dabea2

8218201: Failures when vmIntrinsics::_getClass is not inlined
Summary: Fix BCEscapeAnalyzer to correctly handle _getClass intrinsic.
Reviewed-by: kvn, dlong, redestad, neliasso

! src/share/vm/ci/bcEscapeAnalyzer.cpp
! src/share/vm/ci/bcEscapeAnalyzer.hpp
+ test/compiler/escapeAnalysis/TestGetClass.java

Changeset: c06dc174d786
Author:    fyang
Date:      2019-01-21 13:31 +0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/c06dc174d786

8217359: C2 compiler triggers SIGSEGV after transformation in ConvI2LNode::Ideal
Reviewed-by: thartmann
Contributed-by: jitao8 at huawei.com

! src/share/vm/opto/connode.cpp
+ test/compiler/c2/Test8217359.java

Changeset: 18fd6d87f16f
Author:    roland
Date:      2018-09-28 14:24 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/18fd6d87f16f

8211232: GraphKit::make_runtime_call() sometimes attaches wrong memory state to call
Reviewed-by: kvn

! src/share/vm/opto/graphKit.cpp
! src/share/vm/opto/graphKit.hpp

Changeset: bf9503046dd4
Author:    roland
Date:      2018-12-14 11:22 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/bf9503046dd4

8215265: C2: range check elimination may allow illegal out of bound access
Reviewed-by: thartmann, kvn

! src/share/vm/opto/loopTransform.cpp
! src/share/vm/opto/loopnode.hpp
+ test/compiler/rangechecks/RangeCheckEliminationScaleNotOne.java

Changeset: b290489738b8
Author:    kvn
Date:      2018-06-15 08:28 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/b290489738b8

8202948: C2: assert(init_offset >= 0) failed: positive offset from object start
Summary: convert the assert into compilation check which will skip superword optimization
Reviewed-by: roland, thartmann

! src/share/vm/opto/superword.cpp
+ test/compiler/loopopts/superword/TestNegBaseOffset.java

Changeset: 7e0a4478e80f
Author:    neliasso
Date:      2019-02-14 14:31 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/7e0a4478e80f

8087128: C2: Disallow definition split on MachCopySpill nodes
Reviewed-by: kvn

! src/share/vm/opto/reg_split.cpp

Changeset: 9f614da5f371
Author:    kvn
Date:      2015-06-19 17:46 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/9f614da5f371

8080157: assert(allocates2(pc)) failed: not in CodeBuffer memory
Summary: increase code_size2 for stubs
Reviewed-by: iveresov

! src/cpu/x86/vm/stubRoutines_x86_64.hpp
! src/share/vm/runtime/stubRoutines.cpp

Changeset: 657162a310c4
Author:    hseigel
Date:      2019-07-11 09:26 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/657162a310c4

8226798: JVM crash in klassItable::initialize_itable_for_interface(int, InstanceKlass*, bool, Thread*)
Summary: When calculating vtable size at class load time, do not look for miranda method if matching package private method is found in a super class.
Reviewed-by: acorn, lfoltan

! src/share/vm/oops/klassVtable.cpp
+ test/runtime/VtableTests/VTableTest.java
+ test/runtime/VtableTests/pkg/A.java

Changeset: b02fb6a07ed5
Author:    andrew
Date:      2019-09-03 06:41 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/b02fb6a07ed5

8141570: Fix Zero interpreter build for --disable-precompiled-headers
Summary: Prepare Zero build for backport of JDK-8062808.
Reviewed-by: sgehwolf

! make/linux/makefiles/zeroshark.make
! src/share/vm/runtime/java.cpp

Changeset: 0e3d6188f198
Author:    zgu
Date:      2019-09-03 06:57 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/0e3d6188f198

8155951: VM crash in nsk/jvmti/RedefineClasses/StressRedefine: assert failed: Corrupted constant pool
8151066: assert(0 <= i && i < length()) failed: index out of bounds
Summary: lock classes for redefinition because constant pool merging isn't thread safe, use method constant pool because constant pool merging doesn't make equivalent cpCaches because of invokedynamic
Reviewed-by: shade, andrew

! src/share/vm/ci/ciStreams.cpp
! src/share/vm/ci/ciStreams.hpp
! src/share/vm/oops/instanceKlass.hpp
! src/share/vm/prims/jvmtiRedefineClasses.cpp
! src/share/vm/prims/jvmtiRedefineClasses.hpp
! src/share/vm/runtime/mutexLocker.cpp
! src/share/vm/runtime/mutexLocker.hpp

Changeset: b13d79420363
Author:    andrew
Date:      2019-09-04 17:48 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/b13d79420363

8147611: G1 - Missing memory barrier in start_cset_region_for_worker
Reviewed-by: mgerdin, tschatzl

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp

Changeset: 760b28d87178
Author:    andrew
Date:      2019-09-04 19:40 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/760b28d87178

Added tag jdk8u232-b05 for changeset b13d79420363

! .hgtags

Changeset: a047aebf12df
Author:    andrew
Date:      2019-09-05 17:38 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/a047aebf12df

Merge jdk8u232-b05

! .hgtags
! src/cpu/x86/vm/stubRoutines_x86_64.hpp
! src/share/vm/ci/ciStreams.hpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/oops/instanceKlass.hpp
! src/share/vm/oops/klassVtable.cpp
! src/share/vm/opto/connode.cpp
! src/share/vm/opto/graphKit.cpp
! src/share/vm/opto/graphKit.hpp
! src/share/vm/opto/loopTransform.cpp
! src/share/vm/opto/loopnode.hpp
! src/share/vm/opto/memnode.cpp
! src/share/vm/opto/reg_split.cpp
! src/share/vm/opto/superword.cpp
! src/share/vm/prims/jvmtiRedefineClasses.cpp
! src/share/vm/prims/jvmtiTagMap.cpp
! src/share/vm/runtime/java.cpp
! src/share/vm/runtime/mutexLocker.cpp
! src/share/vm/runtime/mutexLocker.hpp
! src/share/vm/runtime/stubRoutines.cpp

Changeset: a06870b3894d
Author:    andrew
Date:      2019-09-05 17:38 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/a06870b3894d

Added tag aarch64-shenandoah-jdk8u232-b05 for changeset a047aebf12df

! .hgtags

Changeset: 4eeba56c8984
Author:    shade
Date:      2019-09-06 17:34 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/4eeba56c8984

Merge



From shade at redhat.com  Fri Sep  6 16:29:00 2019
From: shade at redhat.com (shade at redhat.com)
Date: Fri, 06 Sep 2019 16:29:00 +0000
Subject: hg: shenandoah/jdk8/nashorn: 3 new changesets
Message-ID: <201909061629.x86GT0IL010097@aojmv0008.oracle.com>

Changeset: 8a951fd037e2
Author:    andrew
Date:      2019-09-04 19:40 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/nashorn/rev/8a951fd037e2

Added tag jdk8u232-b05 for changeset 52afbdfa7852

! .hgtags

Changeset: 828104703b57
Author:    andrew
Date:      2019-09-05 17:38 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/nashorn/rev/828104703b57

Merge jdk8u232-b05

! .hgtags

Changeset: 4f2eb0f865a1
Author:    andrew
Date:      2019-09-05 17:38 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/nashorn/rev/4f2eb0f865a1

Added tag aarch64-shenandoah-jdk8u232-b05 for changeset 828104703b57

! .hgtags


From shade at redhat.com  Fri Sep  6 16:28:58 2019
From: shade at redhat.com (shade at redhat.com)
Date: Fri, 06 Sep 2019 16:28:58 +0000
Subject: hg: shenandoah/jdk8/corba: 3 new changesets
Message-ID: <201909061628.x86GSwsM010090@aojmv0008.oracle.com>

Changeset: 75ad72ef4f68
Author:    andrew
Date:      2019-09-04 19:40 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/corba/rev/75ad72ef4f68

Added tag jdk8u232-b05 for changeset 836e5e2e10a5

! .hgtags

Changeset: f0ddb831f236
Author:    andrew
Date:      2019-09-05 17:38 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/corba/rev/f0ddb831f236

Merge jdk8u232-b05

! .hgtags

Changeset: adc7b87f88ff
Author:    andrew
Date:      2019-09-05 17:38 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/corba/rev/adc7b87f88ff

Added tag aarch64-shenandoah-jdk8u232-b05 for changeset f0ddb831f236

! .hgtags


From shade at redhat.com  Fri Sep  6 16:29:01 2019
From: shade at redhat.com (shade at redhat.com)
Date: Fri, 06 Sep 2019 16:29:01 +0000
Subject: hg: shenandoah/jdk8: 4 new changesets
Message-ID: <201909061629.x86GT1XX010100@aojmv0008.oracle.com>

Changeset: 2cd484c5b7f8
Author:    aleonard
Date:      2019-08-22 17:51 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/rev/2cd484c5b7f8

8217896: Make better use of LCPUs when building on AIX
Reviewed-by: sgehwolf, andrew
Contributed-by: andrew_m_leonard at uk.ibm.com

! common/autoconf/build-performance.m4
! common/autoconf/generated-configure.sh

Changeset: a29e19e1c0ee
Author:    andrew
Date:      2019-09-04 19:40 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/rev/a29e19e1c0ee

Added tag jdk8u232-b05 for changeset 2cd484c5b7f8

! .hgtags

Changeset: e13d6e0a18a8
Author:    andrew
Date:      2019-09-05 17:38 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/rev/e13d6e0a18a8

Merge jdk8u232-b05

! .hgtags
! common/autoconf/generated-configure.sh

Changeset: f66b886d7e95
Author:    andrew
Date:      2019-09-05 17:38 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/rev/f66b886d7e95

Added tag aarch64-shenandoah-jdk8u232-b05 for changeset e13d6e0a18a8

! .hgtags


From shade at redhat.com  Fri Sep  6 16:29:21 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 6 Sep 2019 18:29:21 +0200
Subject: [8u] RFC: Pick up 8u232-b05 to sh/jdk8
In-Reply-To: <913ac02f-f66c-bd41-a46a-61eeac083739@redhat.com>
References: <4c187c60-4756-4fd9-a327-8351a33bb84f@redhat.com>
 <913ac02f-f66c-bd41-a46a-61eeac083739@redhat.com>
Message-ID: <5dfcb2d1-55e1-06b3-aa34-835b043cecc4@redhat.com>

Thank you, pushed.

On 9/6/19 6:23 PM, Zhengyu Gu wrote:
> Okay.
> 
> Thanks,
> 
> -Zhengyu
> 
> On 9/6/19 12:15 PM, Aleksey Shipilev wrote:
>> Let's pick up 8u232-b05 to sh/jdk8, and do at least one nightly spin of testing it. Then I am going
>> to propose the sync back to integration forest (aarch64-port/shenandoah-jdk8u) for 8u232 release.
>>
>> Merge is trivial. Changeset list:
>> ?? http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk8-8u232-b05/changesets.txt
>>
>> Testing: hotspot_gc_shenandoah {fastdebug,release}

-- 
-Aleksey


From shade at redhat.com  Fri Sep  6 16:30:01 2019
From: shade at redhat.com (shade at redhat.com)
Date: Fri, 06 Sep 2019 16:30:01 +0000
Subject: hg: shenandoah/jdk8/jdk: 18 new changesets
Message-ID: <201909061630.x86GU1Yu010571@aojmv0008.oracle.com>

Changeset: c41a8edbaefa
Author:    pbansal
Date:      2019-08-03 13:53 +0530
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/c41a8edbaefa

8226964: [Yaru] GTK L&F: There is no difference between menu selected and de-selected
Reviewed-by: prr, kcr

! src/share/classes/com/sun/java/swing/plaf/gtk/GTKPainter.java
! src/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java

Changeset: 23784e697ad8
Author:    psadhukhan
Date:      2019-07-12 09:27 +0530
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/23784e697ad8

8225423: GTK L&F: JSplitPane: There is no divider shown
Reviewed-by: prr, serb

! src/solaris/native/sun/awt/gtk3_interface.c
! src/solaris/native/sun/awt/gtk3_interface.h

Changeset: 00df83826341
Author:    tvaleev
Date:      2018-12-30 08:57 +0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/00df83826341

8214687: Optimize Collections.nCopies().hashCode() and equals()
Reviewed-by: igerasim, smarks

! src/share/classes/java/util/Collections.java
! test/java/util/Collections/NCopies.java

Changeset: 1417d2539c57
Author:    psadhukhan
Date:      2019-08-23 20:14 +0000
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/1417d2539c57

8214702: Wrong text position for whitespaced string in printing Swing text
Summary: Do not use justification if string width of text is within screenWidth
Reviewed-by: prr, serb
Contributed-by: verghese at amazon.com

! src/share/classes/sun/swing/SwingUtilities2.java
! test/javax/swing/JComboBox/8033069/bug8033069NoScrollBar.java
! test/javax/swing/JComboBox/8033069/bug8033069ScrollBar.java
+ test/javax/swing/SwingUtilities/TestTextPosInPrint.java

Changeset: 73f36e28d254
Author:    bpb
Date:      2019-04-29 07:39 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/73f36e28d254

8218280: LineNumberReader throws "Mark invalid" exception if CRLF straddles buffer.
Reviewed-by: dfuchs, prappo

! src/share/classes/java/io/LineNumberReader.java
+ test/java/io/LineNumberReader/MarkSplitCRLF.java

Changeset: ecee3eb54bbd
Author:    prr
Date:      2019-08-28 15:59 +0000
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/ecee3eb54bbd

8217731: Font rendering and glyph spacing changed from jdk-8 to jdk-11
Summary: Prefer the older v35 freetype byte code interpreter.
Reviewed-by: serb, neugens
Contributed-by: alvdavi at amazon.com

! src/share/native/sun/font/freetypeScaler.c

Changeset: dd92678639b9
Author:    naoto
Date:      2019-08-22 14:40 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/dd92678639b9

8222980: Upgrade IANA Language Subtag Registry to Version 2019-04-03
Reviewed-by: bpb, lancea

! make/data/lsrdata/language-subtag-registry.txt
! test/java/util/Locale/Bug8040211.java

Changeset: c4ced5cebbee
Author:    dkejriwal
Date:      2019-05-16 12:14 +0530
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/c4ced5cebbee

8206879: Currency decimal marker incorrect for Peru
Reviewed-by: naoto, rpatil

! src/share/classes/sun/text/resources/es/FormatData_es_PE.java
+ test/java/text/Format/NumberFormat/TestPeruCurrencyFormat.java
! test/sun/text/resources/LocaleData

Changeset: b4522ab88a12
Author:    andrew
Date:      2019-09-03 05:19 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/b4522ab88a12

8139965: Hang seen when using com.sun.jndi.ldap.search.replyQueueSize
Reviewed-by: dfuchs

! src/share/classes/com/sun/jndi/ldap/BerDecoder.java
! src/share/classes/com/sun/jndi/ldap/Connection.java
! src/share/classes/com/sun/jndi/ldap/LdapRequest.java

Changeset: 136bcee0955a
Author:    stooke
Date:      2019-09-03 06:45 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/136bcee0955a

8203324: Use out of scope in getMacOSXLocale of java_props_macosx.c:120
Reviewed-by: shade, andrew

! src/solaris/native/java/lang/java_props_macosx.c

Changeset: d44a3f4b841f
Author:    andrew
Date:      2019-09-04 05:41 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/d44a3f4b841f

8228440: TestAESCiphers tests fail with "access denied" trying to access ArrayUtil
Summary: Move dependencies into the com.sun.crypto.provider package
Reviewed-by: shade

! src/share/classes/com/sun/crypto/provider/CipherBlockChaining.java
! src/share/classes/com/sun/crypto/provider/CipherFeedback.java
! src/share/classes/com/sun/crypto/provider/CounterMode.java
! src/share/classes/com/sun/crypto/provider/ElectronicCodeBook.java
! src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
! src/share/classes/com/sun/crypto/provider/OutputFeedback.java
! src/share/classes/com/sun/crypto/provider/PCBC.java
+ src/share/classes/com/sun/crypto/provider/Preconditions.java
+ src/share/classes/com/sun/crypto/provider/RangeUtil.java
- src/share/classes/jdk/internal/util/Preconditions.java
! src/share/classes/sun/security/util/ArrayUtil.java
! test/java/util/Objects/CheckIndex.java

Changeset: 345ef0469dd6
Author:    dchuyko
Date:      2019-05-22 21:33 +0300
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/345ef0469dd6

8220072: GCC 8.3 reports errors in java.base
Reviewed-by: rriggs

! src/solaris/native/java/io/canonicalize_md.c

Changeset: 08c46bf8a620
Author:    sgehwolf
Date:      2019-09-04 06:03 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/08c46bf8a620

8218780: Update MUSCLE PCSC-Lite header files
Summary: Update the PCSC-lite header files to 1.8.24 release
Reviewed-by: andrew

! src/share/native/sun/security/smartcardio/pcsc.c
- src/solaris/native/sun/security/smartcardio/MUSCLE/COPYING
! src/solaris/native/sun/security/smartcardio/MUSCLE/pcsclite.h
! src/solaris/native/sun/security/smartcardio/MUSCLE/winscard.h
+ src/solaris/native/sun/security/smartcardio/MUSCLE/wintypes.h
! src/solaris/native/sun/security/smartcardio/pcsc_md.h

Changeset: 2f26ef228073
Author:    dchuyko
Date:      2019-02-08 16:37 +0300
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/2f26ef228073

8215130: Fix errors in LittleCMS 2.9 reported by GCC 8
Reviewed-by: prr

! src/share/native/sun/java2d/cmm/lcms/cmsxform.c

Changeset: 6d60b8cf1bd4
Author:    mbalao
Date:      2019-09-04 19:08 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/6d60b8cf1bd4

8147502: Digest is incorrectly truncated for ECDSA signatures when the bit length of n is less than the field size
Summary: Truncate the digest according to the group order, not the field size
Reviewed-by: shade, andrew

! src/share/classes/sun/security/ec/ECDSASignature.java
! src/share/native/sun/security/ec/impl/ec.c
+ test/lib/testlibrary/jdk/testlibrary/Convert.java
+ test/sun/security/ec/SignatureDigestTruncate.java

Changeset: 1e8cdf311133
Author:    andrew
Date:      2019-09-04 19:40 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/1e8cdf311133

Added tag jdk8u232-b05 for changeset 6d60b8cf1bd4

! .hgtags

Changeset: 242b6eef5a90
Author:    andrew
Date:      2019-09-05 17:38 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/242b6eef5a90

Merge jdk8u232-b05

! .hgtags
! make/data/lsrdata/language-subtag-registry.txt
! src/share/classes/com/sun/crypto/provider/CipherBlockChaining.java
! src/share/classes/com/sun/crypto/provider/CipherFeedback.java
! src/share/classes/com/sun/crypto/provider/CounterMode.java
! src/share/classes/com/sun/crypto/provider/ElectronicCodeBook.java
! src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
! src/share/classes/com/sun/crypto/provider/OutputFeedback.java
! src/share/classes/com/sun/crypto/provider/PCBC.java
! src/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java
! src/share/classes/com/sun/jndi/ldap/Connection.java
- src/share/classes/jdk/internal/util/Preconditions.java
! src/share/classes/sun/swing/SwingUtilities2.java
! src/share/native/sun/font/freetypeScaler.c
! src/solaris/native/java/lang/java_props_macosx.c
- src/solaris/native/sun/security/smartcardio/MUSCLE/COPYING
! src/solaris/native/sun/security/smartcardio/MUSCLE/pcsclite.h
! test/sun/text/resources/LocaleData

Changeset: 6cadd119a62e
Author:    andrew
Date:      2019-09-05 17:38 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/6cadd119a62e

Added tag aarch64-shenandoah-jdk8u232-b05 for changeset 242b6eef5a90

! .hgtags


From roman at kennke.org  Sat Sep  7 09:02:05 2019
From: roman at kennke.org (Roman Kennke)
Date: Sat, 07 Sep 2019 11:02:05 +0200
Subject: [11] RFR: Fix ShenandoahBarrierSetC2::enqueue_useful_gc_barrier
 (part of JDK-8212611)
In-Reply-To: <6f7660a4-286b-610d-3f7b-a93067e8171a@redhat.com>
References: <6f7660a4-286b-610d-3f7b-a93067e8171a@redhat.com>
Message-ID: <7A9B5FFF-B049-453E-B1E0-319A0E315454@kennke.org>

OK. Thanks!

Am 6. September 2019 16:58:11 MESZ schrieb Aleksey Shipilev <shade at redhat.com>:
>There is a discrepancy between jdk/jdk and sh/jdk11 definition of
>BSC2::enqueue_useful_gc_barrier,
>where one thing adds the node to the IGVN worklist [1], and another
>adds all users to it [2]. It was
>introduced by JDK-8212611 [3], and we should consider backporting it to
>11u.
>
>Meanwhile, sh/jdk11 x86_32 CTW fails without that patch:
>
>$ CONF=linux-x86-normal-server-fastdebug make run-test
>TEST_VM_OPTS="-XX:-TieredCompilation
>-XX:+UseShenandoahGC"
>TEST=applications/ctw/modules/jdk_scripting_nashorn.java
>
>#
>#  Internal Error
>(/home/shade/trunks/shenandoah-jdk11/src/hotspot/share/opto/compile.cpp:2851),
>pid=23210, tid=23220
># 
>assert(!ShenandoahBarrierSetC2::has_only_shenandoah_wb_pre_uses(addp))
>failed: useless address
>computation?
>#
>
>I believe the best course of action would be to pick up safer parts of
>JDK-8212611 to sh/jdk11:
>https://cr.openjdk.java.net/~shade/shenandoah/11u-fix-bsc2-eugcb/webrev.01/
>
>Testing: {x86_64, x86_32} CTW tests, {x86_64, x86_32}
>hotspot_gc_shenandoah (running)
>
>-- 
>Thanks,
>-Aleksey
>
>
>[1] sh/jdk11:
>void ShenandoahBarrierSetC2::enqueue_useful_gc_barrier(Unique_Node_List
>&worklist, Node* node) const {
>if (node->Opcode() == Op_AddP &&
>ShenandoahBarrierSetC2::has_only_shenandoah_wb_pre_uses(node)) {
>    worklist.push(node);
>  }
>}
>
>[2] jdk/jdk:
>void ShenandoahBarrierSetC2::enqueue_useful_gc_barrier(PhaseIterGVN*
>igvn, Node* node) const {
>if (node->Opcode() == Op_AddP &&
>ShenandoahBarrierSetC2::has_only_shenandoah_wb_pre_uses(node)) {
>    igvn->add_users_to_worklist(node);
>  }
>}
>
>[3] 8212611: Small collection of simple changes from shenandoah
> https://bugs.openjdk.java.net/browse/JDK-8212611

-- 
Diese Nachricht wurde von meinem Android-Ger?t mit K-9 Mail gesendet.

From shade at redhat.com  Sun Sep  8 17:21:16 2019
From: shade at redhat.com (shade at redhat.com)
Date: Sun, 08 Sep 2019 17:21:16 +0000
Subject: hg: shenandoah/jdk11: Fix
 ShenandoahBarrierSetC2::enqueue_useful_gc_barrier (part of
 JDK-8212611)
Message-ID: <201909081721.x88HLGUc021075@aojmv0008.oracle.com>

Changeset: 6e1a7d16773c
Author:    roland
Date:      2018-10-17 10:19 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/6e1a7d16773c

Fix ShenandoahBarrierSetC2::enqueue_useful_gc_barrier (part of JDK-8212611)

! src/hotspot/share/gc/shared/c2/barrierSetC2.hpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.hpp
! src/hotspot/share/gc/z/c2/zBarrierSetC2.cpp
! src/hotspot/share/gc/z/c2/zBarrierSetC2.hpp
! src/hotspot/share/opto/node.cpp
! src/hotspot/share/opto/phaseX.cpp


From shade at redhat.com  Mon Sep  9 17:01:20 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 9 Sep 2019 19:01:20 +0200
Subject: ANN: aarch64-port/jdk8u-shenandoah is un-frozen -- and open again
In-Reply-To: <20ad8ab8-160e-a9f1-7b45-b57c5172bf0c@redhat.com>
References: <20ad8ab8-160e-a9f1-7b45-b57c5172bf0c@redhat.com>
Message-ID: <c0432acc-6aae-8170-e1ab-3c16526b0a53@redhat.com>

On 9/6/19 6:27 PM, Aleksey Shipilev wrote:
> Please refrain from pushing new changes to aarch64-port/jdk8u-shenandoah until further notice. We
> are planning to have a drop of Shenandoah 8u code for 8u232, and would like to merge-build-test
> current drop against the stable target.
> 
> ETA for that work to complete is Monday, Sep 9, 22:00 CEST.
> 
> I would notify separately when this freeze lifts.

The merge is complete, repository is unfrozen.

It is stabilizing for 8u232, so cross-check if you can push your changes anyway.

-- 
Thanks,
-Aleksey


From shade at redhat.com  Mon Sep  9 17:04:54 2019
From: shade at redhat.com (shade at redhat.com)
Date: Mon, 09 Sep 2019 17:04:54 +0000
Subject: hg: shenandoah/jdk8/corba: Added tag
 aarch64-shenandoah-jdk8u232-b05-shenandoah-merge-2019-09-09 for
 changeset adc7b87f88ff
Message-ID: <201909091704.x89H4sSb003832@aojmv0008.oracle.com>

Changeset: 2240e8da8382
Author:    shade
Date:      2019-09-09 18:54 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/corba/rev/2240e8da8382

Added tag aarch64-shenandoah-jdk8u232-b05-shenandoah-merge-2019-09-09 for changeset adc7b87f88ff

! .hgtags


From shade at redhat.com  Mon Sep  9 17:04:56 2019
From: shade at redhat.com (shade at redhat.com)
Date: Mon, 09 Sep 2019 17:04:56 +0000
Subject: hg: shenandoah/jdk8/hotspot: Added tag
 aarch64-shenandoah-jdk8u232-b05-shenandoah-merge-2019-09-09 for
 changeset 4eeba56c8984
Message-ID: <201909091704.x89H4uuf003933@aojmv0008.oracle.com>

Changeset: a1986eb5d5fd
Author:    shade
Date:      2019-09-09 18:54 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/a1986eb5d5fd

Added tag aarch64-shenandoah-jdk8u232-b05-shenandoah-merge-2019-09-09 for changeset 4eeba56c8984

! .hgtags


From shade at redhat.com  Mon Sep  9 17:04:54 2019
From: shade at redhat.com (shade at redhat.com)
Date: Mon, 09 Sep 2019 17:04:54 +0000
Subject: hg: shenandoah/jdk8/langtools: Added tag
 aarch64-shenandoah-jdk8u232-b05-shenandoah-merge-2019-09-09 for
 changeset 31a70fb38ae4
Message-ID: <201909091704.x89H4sGa003837@aojmv0008.oracle.com>

Changeset: be29e0166e2e
Author:    shade
Date:      2019-09-09 18:54 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/langtools/rev/be29e0166e2e

Added tag aarch64-shenandoah-jdk8u232-b05-shenandoah-merge-2019-09-09 for changeset 31a70fb38ae4

! .hgtags


From shade at redhat.com  Mon Sep  9 17:04:58 2019
From: shade at redhat.com (shade at redhat.com)
Date: Mon, 09 Sep 2019 17:04:58 +0000
Subject: hg: shenandoah/jdk8/jdk: Added tag
 aarch64-shenandoah-jdk8u232-b05-shenandoah-merge-2019-09-09 for
 changeset 6cadd119a62e
Message-ID: <201909091704.x89H4wgr004016@aojmv0008.oracle.com>

Changeset: cb50c3c8a2f4
Author:    shade
Date:      2019-09-09 18:54 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/cb50c3c8a2f4

Added tag aarch64-shenandoah-jdk8u232-b05-shenandoah-merge-2019-09-09 for changeset 6cadd119a62e

! .hgtags


From shade at redhat.com  Mon Sep  9 17:05:01 2019
From: shade at redhat.com (shade at redhat.com)
Date: Mon, 09 Sep 2019 17:05:01 +0000
Subject: hg: shenandoah/jdk8/jaxws: Added tag
 aarch64-shenandoah-jdk8u232-b05-shenandoah-merge-2019-09-09 for
 changeset fe92f572d4f1
Message-ID: <201909091705.x89H511N004199@aojmv0008.oracle.com>

Changeset: 789555e16545
Author:    shade
Date:      2019-09-09 18:54 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jaxws/rev/789555e16545

Added tag aarch64-shenandoah-jdk8u232-b05-shenandoah-merge-2019-09-09 for changeset fe92f572d4f1

! .hgtags


From shade at redhat.com  Mon Sep  9 17:05:04 2019
From: shade at redhat.com (shade at redhat.com)
Date: Mon, 09 Sep 2019 17:05:04 +0000
Subject: hg: shenandoah/jdk8/jaxp: Added tag
 aarch64-shenandoah-jdk8u232-b05-shenandoah-merge-2019-09-09 for
 changeset 56563fa62d18
Message-ID: <201909091705.x89H55Ix004698@aojmv0008.oracle.com>

Changeset: 92a9e402f9a5
Author:    shade
Date:      2019-09-09 18:54 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/jaxp/rev/92a9e402f9a5

Added tag aarch64-shenandoah-jdk8u232-b05-shenandoah-merge-2019-09-09 for changeset 56563fa62d18

! .hgtags


From shade at redhat.com  Mon Sep  9 17:05:06 2019
From: shade at redhat.com (shade at redhat.com)
Date: Mon, 09 Sep 2019 17:05:06 +0000
Subject: hg: shenandoah/jdk8: Added tag
 aarch64-shenandoah-jdk8u232-b05-shenandoah-merge-2019-09-09 for
 changeset f66b886d7e95
Message-ID: <201909091705.x89H56AL004700@aojmv0008.oracle.com>

Changeset: e9c01de63dbc
Author:    shade
Date:      2019-09-09 18:54 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/rev/e9c01de63dbc

Added tag aarch64-shenandoah-jdk8u232-b05-shenandoah-merge-2019-09-09 for changeset f66b886d7e95

! .hgtags


From shade at redhat.com  Mon Sep  9 17:05:19 2019
From: shade at redhat.com (shade at redhat.com)
Date: Mon, 09 Sep 2019 17:05:19 +0000
Subject: hg: shenandoah/jdk8/nashorn: Added tag
 aarch64-shenandoah-jdk8u232-b05-shenandoah-merge-2019-09-09 for
 changeset 4f2eb0f865a1
Message-ID: <201909091705.x89H5JJX005206@aojmv0008.oracle.com>

Changeset: 5c27333a36ab
Author:    shade
Date:      2019-09-09 18:54 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk8/nashorn/rev/5c27333a36ab

Added tag aarch64-shenandoah-jdk8u232-b05-shenandoah-merge-2019-09-09 for changeset 4f2eb0f865a1

! .hgtags


From zgu at redhat.com  Tue Sep 10 17:17:35 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Tue, 10 Sep 2019 13:17:35 -0400
Subject: Shenandoah: nmethod barrier needs to abandon per-nmethod lock before
 entering OOM protocol
Message-ID: <fc3f3345-85d4-a1a4-10f0-21971cc63821@redhat.com>

There can be deadlock when nmethod barrier fails to evacuate oops and 
enter OOM protocol while holding per-nmethod lock, cause concurrent 
nmethod processing may try to obtain the specific lock while under OOM 
protocol.

The solution is to have nmethod barrier temporary abandon the lock 
before it enters OOM protocol, let concurrent thread to process the 
nmethod. Upon completion of OOM, nmethod barrier can continue to 
evacuate/disarm the nmethod, since the operations are idempotent.

Webrev: 
http://cr.openjdk.java.net/~zgu/shenandoah/nmeth_barrier_deadlock/webrev.00/


Test:
   hotspot_gc_shenandoah (fastdebug and release)

   specjvm (fastdebug and release) with options:
${JAVA_HOME}/bin/java -jar jmh-specjvm2016.jar -foe true -f 1 -wi 5 -i 5 
-t 1 -w 1s -r 1s --jvmArgs "-Xmx1g -Xms1g 
-XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC 
-XX:+UnlockDiagnosticVMOptions -XX:ShenandoahGCHeuristics=aggressive 
-XX:+ShenandoahOOMDuringEvacALot"

Thanks,

-Zhengyu

From rkennke at redhat.com  Tue Sep 10 17:28:32 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 10 Sep 2019 19:28:32 +0200
Subject: Shenandoah: nmethod barrier needs to abandon per-nmethod lock
 before entering OOM protocol
In-Reply-To: <fc3f3345-85d4-a1a4-10f0-21971cc63821@redhat.com>
References: <fc3f3345-85d4-a1a4-10f0-21971cc63821@redhat.com>
Message-ID: <75a1c273-45e8-5ca6-bc11-72acc27425a0@redhat.com>

Do you need to store the lock in the thread-local data? Can't you simply
keep it in the evac-scope-object?

Roman

> There can be deadlock when nmethod barrier fails to evacuate oops and
> enter OOM protocol while holding per-nmethod lock, cause concurrent
> nmethod processing may try to obtain the specific lock while under OOM
> protocol.
> 
> The solution is to have nmethod barrier temporary abandon the lock
> before it enters OOM protocol, let concurrent thread to process the
> nmethod. Upon completion of OOM, nmethod barrier can continue to
> evacuate/disarm the nmethod, since the operations are idempotent.
> 
> Webrev:
> http://cr.openjdk.java.net/~zgu/shenandoah/nmeth_barrier_deadlock/webrev.00/
> 
> 
> 
> Test:
> ? hotspot_gc_shenandoah (fastdebug and release)
> 
> ? specjvm (fastdebug and release) with options:
> ${JAVA_HOME}/bin/java -jar jmh-specjvm2016.jar -foe true -f 1 -wi 5 -i 5
> -t 1 -w 1s -r 1s --jvmArgs "-Xmx1g -Xms1g
> -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC
> -XX:+UnlockDiagnosticVMOptions -XX:ShenandoahGCHeuristics=aggressive
> -XX:+ShenandoahOOMDuringEvacALot"
> 
> Thanks,
> 
> -Zhengyu


From zgu at redhat.com  Tue Sep 10 17:33:20 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Tue, 10 Sep 2019 13:33:20 -0400
Subject: Shenandoah: nmethod barrier needs to abandon per-nmethod lock
 before entering OOM protocol
In-Reply-To: <75a1c273-45e8-5ca6-bc11-72acc27425a0@redhat.com>
References: <fc3f3345-85d4-a1a4-10f0-21971cc63821@redhat.com>
 <75a1c273-45e8-5ca6-bc11-72acc27425a0@redhat.com>
Message-ID: <7fd25a91-9f81-9d36-fb5f-949728cfe1d4@redhat.com>



On 9/10/19 1:28 PM, Roman Kennke wrote:
> Do you need to store the lock in the thread-local data? Can't you simply
> keep it in the evac-scope-object?

Is there a way to get to evac-scope from OOM handler?

-Zhengyu

> 
> Roman
> 
>> There can be deadlock when nmethod barrier fails to evacuate oops and
>> enter OOM protocol while holding per-nmethod lock, cause concurrent
>> nmethod processing may try to obtain the specific lock while under OOM
>> protocol.
>>
>> The solution is to have nmethod barrier temporary abandon the lock
>> before it enters OOM protocol, let concurrent thread to process the
>> nmethod. Upon completion of OOM, nmethod barrier can continue to
>> evacuate/disarm the nmethod, since the operations are idempotent.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~zgu/shenandoah/nmeth_barrier_deadlock/webrev.00/
>>
>>
>>
>> Test:
>>  ? hotspot_gc_shenandoah (fastdebug and release)
>>
>>  ? specjvm (fastdebug and release) with options:
>> ${JAVA_HOME}/bin/java -jar jmh-specjvm2016.jar -foe true -f 1 -wi 5 -i 5
>> -t 1 -w 1s -r 1s --jvmArgs "-Xmx1g -Xms1g
>> -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC
>> -XX:+UnlockDiagnosticVMOptions -XX:ShenandoahGCHeuristics=aggressive
>> -XX:+ShenandoahOOMDuringEvacALot"
>>
>> Thanks,
>>
>> -Zhengyu
> 

From rkennke at redhat.com  Tue Sep 10 18:04:29 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 10 Sep 2019 20:04:29 +0200
Subject: Shenandoah: nmethod barrier needs to abandon per-nmethod lock
 before entering OOM protocol
In-Reply-To: <7fd25a91-9f81-9d36-fb5f-949728cfe1d4@redhat.com>
References: <fc3f3345-85d4-a1a4-10f0-21971cc63821@redhat.com>
 <75a1c273-45e8-5ca6-bc11-72acc27425a0@redhat.com>
 <7fd25a91-9f81-9d36-fb5f-949728cfe1d4@redhat.com>
Message-ID: <896050fe-e8a6-e525-0be7-b2344b8421b1@redhat.com>

> On 9/10/19 1:28 PM, Roman Kennke wrote:
>> Do you need to store the lock in the thread-local data? Can't you simply
>> keep it in the evac-scope-object?
> 
> Is there a way to get to evac-scope from OOM handler?

Hmm, right.

So we have a whole bunch of stuff already in TLD that is there for
dealing with OOM-during-evac. You are about to add another one.

Maybe it makes sense to put the OOM scope object in TLD instead, and let
that keep the fields? It doesn't have to be a pointer, it can be flat,
and effectively have the same layout as it is now, but it would be clearer.

Also, I am not convinced that this is safe. Would the code that held the
lock still be good after it comes back from OOM handler?

Roman


> 
> -Zhengyu
> 
>>
>> Roman
>>
>>> There can be deadlock when nmethod barrier fails to evacuate oops and
>>> enter OOM protocol while holding per-nmethod lock, cause concurrent
>>> nmethod processing may try to obtain the specific lock while under OOM
>>> protocol.
>>>
>>> The solution is to have nmethod barrier temporary abandon the lock
>>> before it enters OOM protocol, let concurrent thread to process the
>>> nmethod. Upon completion of OOM, nmethod barrier can continue to
>>> evacuate/disarm the nmethod, since the operations are idempotent.
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~zgu/shenandoah/nmeth_barrier_deadlock/webrev.00/
>>>
>>>
>>>
>>>
>>> Test:
>>> ?? hotspot_gc_shenandoah (fastdebug and release)
>>>
>>> ?? specjvm (fastdebug and release) with options:
>>> ${JAVA_HOME}/bin/java -jar jmh-specjvm2016.jar -foe true -f 1 -wi 5 -i 5
>>> -t 1 -w 1s -r 1s --jvmArgs "-Xmx1g -Xms1g
>>> -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC
>>> -XX:+UnlockDiagnosticVMOptions -XX:ShenandoahGCHeuristics=aggressive
>>> -XX:+ShenandoahOOMDuringEvacALot"
>>>
>>> Thanks,
>>>
>>> -Zhengyu
>>


From rkennke at redhat.com  Tue Sep 10 18:11:18 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 10 Sep 2019 20:11:18 +0200
Subject: Shenandoah: nmethod barrier needs to abandon per-nmethod lock
 before entering OOM protocol
In-Reply-To: <fc3f3345-85d4-a1a4-10f0-21971cc63821@redhat.com>
References: <fc3f3345-85d4-a1a4-10f0-21971cc63821@redhat.com>
Message-ID: <acea2967-6a2f-9566-fe87-bced95612996@redhat.com>

So maybe the deadlock can be resolved somehow else? E.g. by entering the
scopes/locks always in the same order? E.g.:

nmethod-barrier does:
 1. per-nmethod-lock 2. OOM scope

concurrent nmethod processing does:
 1. OOM scope 2. per-nmethod-lock

Can this be changed that concurrent nmethod processing does grab the OOM
scope *after* taking the per-nmethod-lock, just like the barrier does?

Roman

> There can be deadlock when nmethod barrier fails to evacuate oops and
> enter OOM protocol while holding per-nmethod lock, cause concurrent
> nmethod processing may try to obtain the specific lock while under OOM
> protocol.
> 
> The solution is to have nmethod barrier temporary abandon the lock
> before it enters OOM protocol, let concurrent thread to process the
> nmethod. Upon completion of OOM, nmethod barrier can continue to
> evacuate/disarm the nmethod, since the operations are idempotent.
> 
> Webrev:
> http://cr.openjdk.java.net/~zgu/shenandoah/nmeth_barrier_deadlock/webrev.00/
> 
> 
> 
> Test:
> ? hotspot_gc_shenandoah (fastdebug and release)
> 
> ? specjvm (fastdebug and release) with options:
> ${JAVA_HOME}/bin/java -jar jmh-specjvm2016.jar -foe true -f 1 -wi 5 -i 5
> -t 1 -w 1s -r 1s --jvmArgs "-Xmx1g -Xms1g
> -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC
> -XX:+UnlockDiagnosticVMOptions -XX:ShenandoahGCHeuristics=aggressive
> -XX:+ShenandoahOOMDuringEvacALot"
> 
> Thanks,
> 
> -Zhengyu


From zgu at redhat.com  Tue Sep 10 18:15:18 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Tue, 10 Sep 2019 14:15:18 -0400
Subject: Shenandoah: nmethod barrier needs to abandon per-nmethod lock
 before entering OOM protocol
In-Reply-To: <acea2967-6a2f-9566-fe87-bced95612996@redhat.com>
References: <fc3f3345-85d4-a1a4-10f0-21971cc63821@redhat.com>
 <acea2967-6a2f-9566-fe87-bced95612996@redhat.com>
Message-ID: <9c01fb03-ac50-27cb-994d-eebe5b7b4876@redhat.com>



On 9/10/19 2:11 PM, Roman Kennke wrote:
> So maybe the deadlock can be resolved somehow else? E.g. by entering the
> scopes/locks always in the same order? E.g.:
> 
> nmethod-barrier does:
>   1. per-nmethod-lock 2. OOM scope
> 
> concurrent nmethod processing does:
>   1. OOM scope 2. per-nmethod-lock
> 
> Can this be changed that concurrent nmethod processing does grab the OOM
> scope *after* taking the per-nmethod-lock, just like the barrier does?

It is possible to have concurrent thread does:
   1. per-nmethod-lock, 2. OOM scope

but it is quite expensive, it requires setting up/tearing down OOM scope 
for each nmethod.


-Zhengyu

> 
> Roman
> 
>> There can be deadlock when nmethod barrier fails to evacuate oops and
>> enter OOM protocol while holding per-nmethod lock, cause concurrent
>> nmethod processing may try to obtain the specific lock while under OOM
>> protocol.
>>
>> The solution is to have nmethod barrier temporary abandon the lock
>> before it enters OOM protocol, let concurrent thread to process the
>> nmethod. Upon completion of OOM, nmethod barrier can continue to
>> evacuate/disarm the nmethod, since the operations are idempotent.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~zgu/shenandoah/nmeth_barrier_deadlock/webrev.00/
>>
>>
>>
>> Test:
>>  ? hotspot_gc_shenandoah (fastdebug and release)
>>
>>  ? specjvm (fastdebug and release) with options:
>> ${JAVA_HOME}/bin/java -jar jmh-specjvm2016.jar -foe true -f 1 -wi 5 -i 5
>> -t 1 -w 1s -r 1s --jvmArgs "-Xmx1g -Xms1g
>> -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC
>> -XX:+UnlockDiagnosticVMOptions -XX:ShenandoahGCHeuristics=aggressive
>> -XX:+ShenandoahOOMDuringEvacALot"
>>
>> Thanks,
>>
>> -Zhengyu
> 

From rkennke at redhat.com  Tue Sep 10 18:19:07 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 10 Sep 2019 20:19:07 +0200
Subject: Shenandoah: nmethod barrier needs to abandon per-nmethod lock
 before entering OOM protocol
In-Reply-To: <9c01fb03-ac50-27cb-994d-eebe5b7b4876@redhat.com>
References: <fc3f3345-85d4-a1a4-10f0-21971cc63821@redhat.com>
 <acea2967-6a2f-9566-fe87-bced95612996@redhat.com>
 <9c01fb03-ac50-27cb-994d-eebe5b7b4876@redhat.com>
Message-ID: <87cda82d-7d16-6598-c4ae-2a2829c185fc@redhat.com>

>> So maybe the deadlock can be resolved somehow else? E.g. by entering the
>> scopes/locks always in the same order? E.g.:
>>
>> nmethod-barrier does:
>> ? 1. per-nmethod-lock 2. OOM scope
>>
>> concurrent nmethod processing does:
>> ? 1. OOM scope 2. per-nmethod-lock
>>
>> Can this be changed that concurrent nmethod processing does grab the OOM
>> scope *after* taking the per-nmethod-lock, just like the barrier does?
> 
> It is possible to have concurrent thread does:
> ? 1. per-nmethod-lock, 2. OOM scope
> 
> but it is quite expensive, it requires setting up/tearing down OOM scope
> for each nmethod.

Is that so bad? barriers do that per-oop.

*or* change the nmethod barrier to do:

 1. OOM scope 2. per-nmethod-lock

instead?

Roman



> -Zhengyu
> 
>>
>> Roman
>>
>>> There can be deadlock when nmethod barrier fails to evacuate oops and
>>> enter OOM protocol while holding per-nmethod lock, cause concurrent
>>> nmethod processing may try to obtain the specific lock while under OOM
>>> protocol.
>>>
>>> The solution is to have nmethod barrier temporary abandon the lock
>>> before it enters OOM protocol, let concurrent thread to process the
>>> nmethod. Upon completion of OOM, nmethod barrier can continue to
>>> evacuate/disarm the nmethod, since the operations are idempotent.
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~zgu/shenandoah/nmeth_barrier_deadlock/webrev.00/
>>>
>>>
>>>
>>>
>>> Test:
>>> ?? hotspot_gc_shenandoah (fastdebug and release)
>>>
>>> ?? specjvm (fastdebug and release) with options:
>>> ${JAVA_HOME}/bin/java -jar jmh-specjvm2016.jar -foe true -f 1 -wi 5 -i 5
>>> -t 1 -w 1s -r 1s --jvmArgs "-Xmx1g -Xms1g
>>> -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC
>>> -XX:+UnlockDiagnosticVMOptions -XX:ShenandoahGCHeuristics=aggressive
>>> -XX:+ShenandoahOOMDuringEvacALot"
>>>
>>> Thanks,
>>>
>>> -Zhengyu
>>


From zgu at redhat.com  Tue Sep 10 18:23:05 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Tue, 10 Sep 2019 14:23:05 -0400
Subject: Shenandoah: nmethod barrier needs to abandon per-nmethod lock
 before entering OOM protocol
In-Reply-To: <87cda82d-7d16-6598-c4ae-2a2829c185fc@redhat.com>
References: <fc3f3345-85d4-a1a4-10f0-21971cc63821@redhat.com>
 <acea2967-6a2f-9566-fe87-bced95612996@redhat.com>
 <9c01fb03-ac50-27cb-994d-eebe5b7b4876@redhat.com>
 <87cda82d-7d16-6598-c4ae-2a2829c185fc@redhat.com>
Message-ID: <799d8ecd-a660-412e-d368-b670fbdbec17@redhat.com>



On 9/10/19 2:19 PM, Roman Kennke wrote:
>>> So maybe the deadlock can be resolved somehow else? E.g. by entering the
>>> scopes/locks always in the same order? E.g.:
>>>
>>> nmethod-barrier does:
>>>  ? 1. per-nmethod-lock 2. OOM scope
>>>
>>> concurrent nmethod processing does:
>>>  ? 1. OOM scope 2. per-nmethod-lock
>>>
>>> Can this be changed that concurrent nmethod processing does grab the OOM
>>> scope *after* taking the per-nmethod-lock, just like the barrier does?
>>
>> It is possible to have concurrent thread does:
>>  ? 1. per-nmethod-lock, 2. OOM scope
>>
>> but it is quite expensive, it requires setting up/tearing down OOM scope
>> for each nmethod.
> 
> Is that so bad? barriers do that per-oop.
Donn't know, but could have thousands nmethods.


> 
> *or* change the nmethod barrier to do:
> 
>   1. OOM scope 2. per-nmethod-lock

This won't work.

The  thread, that causeed OOM, will wait other threads get out of OOM 
scope while holding the lock, and another thread can stick waiting for 
the lock inside OOM scope.

-Zhengyu

> 
> instead?
> 
> Roman
> 
> 
> 
>> -Zhengyu
>>
>>>
>>> Roman
>>>
>>>> There can be deadlock when nmethod barrier fails to evacuate oops and
>>>> enter OOM protocol while holding per-nmethod lock, cause concurrent
>>>> nmethod processing may try to obtain the specific lock while under OOM
>>>> protocol.
>>>>
>>>> The solution is to have nmethod barrier temporary abandon the lock
>>>> before it enters OOM protocol, let concurrent thread to process the
>>>> nmethod. Upon completion of OOM, nmethod barrier can continue to
>>>> evacuate/disarm the nmethod, since the operations are idempotent.
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~zgu/shenandoah/nmeth_barrier_deadlock/webrev.00/
>>>>
>>>>
>>>>
>>>>
>>>> Test:
>>>>  ?? hotspot_gc_shenandoah (fastdebug and release)
>>>>
>>>>  ?? specjvm (fastdebug and release) with options:
>>>> ${JAVA_HOME}/bin/java -jar jmh-specjvm2016.jar -foe true -f 1 -wi 5 -i 5
>>>> -t 1 -w 1s -r 1s --jvmArgs "-Xmx1g -Xms1g
>>>> -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC
>>>> -XX:+UnlockDiagnosticVMOptions -XX:ShenandoahGCHeuristics=aggressive
>>>> -XX:+ShenandoahOOMDuringEvacALot"
>>>>
>>>> Thanks,
>>>>
>>>> -Zhengyu
>>>
> 

From zgu at redhat.com  Tue Sep 10 18:25:46 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Tue, 10 Sep 2019 14:25:46 -0400
Subject: Shenandoah: nmethod barrier needs to abandon per-nmethod lock
 before entering OOM protocol
In-Reply-To: <896050fe-e8a6-e525-0be7-b2344b8421b1@redhat.com>
References: <fc3f3345-85d4-a1a4-10f0-21971cc63821@redhat.com>
 <75a1c273-45e8-5ca6-bc11-72acc27425a0@redhat.com>
 <7fd25a91-9f81-9d36-fb5f-949728cfe1d4@redhat.com>
 <896050fe-e8a6-e525-0be7-b2344b8421b1@redhat.com>
Message-ID: <b34179d7-b53f-9569-1efb-3a09579c1487@redhat.com>



On 9/10/19 2:04 PM, Roman Kennke wrote:
>> On 9/10/19 1:28 PM, Roman Kennke wrote:
>>> Do you need to store the lock in the thread-local data? Can't you simply
>>> keep it in the evac-scope-object?
>>
>> Is there a way to get to evac-scope from OOM handler?
> 
> Hmm, right.
> 
> So we have a whole bunch of stuff already in TLD that is there for
> dealing with OOM-during-evac. You are about to add another one.
> 
> Maybe it makes sense to put the OOM scope object in TLD instead, and let
> that keep the fields? It doesn't have to be a pointer, it can be flat,
> and effectively have the same layout as it is now, but it would be clearer.
> 
> Also, I am not convinced that this is safe. Would the code that held the
> lock still be good after it comes back from OOM handler?

I think it is safe. As I mentioned, oop evacuation and nmethod disarming 
are idempotent.

So, nmethod barrier -> [1] evacuate oops -> [2] OOM -> [3] unlock -> [4] 
lock -> [5] continue evacuating oops -> [6] disarm nmethod.

[5][6] are idempotent.


-Zhengyu

> 
> Roman
> 
> 
>>
>> -Zhengyu
>>
>>>
>>> Roman
>>>
>>>> There can be deadlock when nmethod barrier fails to evacuate oops and
>>>> enter OOM protocol while holding per-nmethod lock, cause concurrent
>>>> nmethod processing may try to obtain the specific lock while under OOM
>>>> protocol.
>>>>
>>>> The solution is to have nmethod barrier temporary abandon the lock
>>>> before it enters OOM protocol, let concurrent thread to process the
>>>> nmethod. Upon completion of OOM, nmethod barrier can continue to
>>>> evacuate/disarm the nmethod, since the operations are idempotent.
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~zgu/shenandoah/nmeth_barrier_deadlock/webrev.00/
>>>>
>>>>
>>>>
>>>>
>>>> Test:
>>>>  ?? hotspot_gc_shenandoah (fastdebug and release)
>>>>
>>>>  ?? specjvm (fastdebug and release) with options:
>>>> ${JAVA_HOME}/bin/java -jar jmh-specjvm2016.jar -foe true -f 1 -wi 5 -i 5
>>>> -t 1 -w 1s -r 1s --jvmArgs "-Xmx1g -Xms1g
>>>> -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC
>>>> -XX:+UnlockDiagnosticVMOptions -XX:ShenandoahGCHeuristics=aggressive
>>>> -XX:+ShenandoahOOMDuringEvacALot"
>>>>
>>>> Thanks,
>>>>
>>>> -Zhengyu
>>>
> 

From zgu at redhat.com  Tue Sep 10 18:42:48 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Tue, 10 Sep 2019 14:42:48 -0400
Subject: Shenandoah: nmethod barrier needs to abandon per-nmethod lock
 before entering OOM protocol
In-Reply-To: <896050fe-e8a6-e525-0be7-b2344b8421b1@redhat.com>
References: <fc3f3345-85d4-a1a4-10f0-21971cc63821@redhat.com>
 <75a1c273-45e8-5ca6-bc11-72acc27425a0@redhat.com>
 <7fd25a91-9f81-9d36-fb5f-949728cfe1d4@redhat.com>
 <896050fe-e8a6-e525-0be7-b2344b8421b1@redhat.com>
Message-ID: <8008555d-eaf4-5e61-5457-77a40716c8bb@redhat.com>



On 9/10/19 2:04 PM, Roman Kennke wrote:
>> On 9/10/19 1:28 PM, Roman Kennke wrote:
>>> Do you need to store the lock in the thread-local data? Can't you simply
>>> keep it in the evac-scope-object?
>>
>> Is there a way to get to evac-scope from OOM handler?
> 
> Hmm, right.
> 
> So we have a whole bunch of stuff already in TLD that is there for
> dealing with OOM-during-evac. You are about to add another one.
> 
> Maybe it makes sense to put the OOM scope object in TLD instead, and let
> that keep the fields? It doesn't have to be a pointer, it can be flat,
> and effectively have the same layout as it is now, but it would be clearer.
Make sense. Can we do it in separate CR?

Thanks,

-Zhengyu


> 
> Also, I am not convinced that this is safe. Would the code that held the
> lock still be good after it comes back from OOM handler?
> 
> Roman
> 
> 
>>
>> -Zhengyu
>>
>>>
>>> Roman
>>>
>>>> There can be deadlock when nmethod barrier fails to evacuate oops and
>>>> enter OOM protocol while holding per-nmethod lock, cause concurrent
>>>> nmethod processing may try to obtain the specific lock while under OOM
>>>> protocol.
>>>>
>>>> The solution is to have nmethod barrier temporary abandon the lock
>>>> before it enters OOM protocol, let concurrent thread to process the
>>>> nmethod. Upon completion of OOM, nmethod barrier can continue to
>>>> evacuate/disarm the nmethod, since the operations are idempotent.
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~zgu/shenandoah/nmeth_barrier_deadlock/webrev.00/
>>>>
>>>>
>>>>
>>>>
>>>> Test:
>>>>  ?? hotspot_gc_shenandoah (fastdebug and release)
>>>>
>>>>  ?? specjvm (fastdebug and release) with options:
>>>> ${JAVA_HOME}/bin/java -jar jmh-specjvm2016.jar -foe true -f 1 -wi 5 -i 5
>>>> -t 1 -w 1s -r 1s --jvmArgs "-Xmx1g -Xms1g
>>>> -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC
>>>> -XX:+UnlockDiagnosticVMOptions -XX:ShenandoahGCHeuristics=aggressive
>>>> -XX:+ShenandoahOOMDuringEvacALot"
>>>>
>>>> Thanks,
>>>>
>>>> -Zhengyu
>>>
> 

From roman at kennke.org  Tue Sep 10 19:22:09 2019
From: roman at kennke.org (Roman Kennke)
Date: Tue, 10 Sep 2019 21:22:09 +0200
Subject: Shenandoah: nmethod barrier needs to abandon per-nmethod lock
 before entering OOM protocol
In-Reply-To: <8008555d-eaf4-5e61-5457-77a40716c8bb@redhat.com>
References: <fc3f3345-85d4-a1a4-10f0-21971cc63821@redhat.com>
 <75a1c273-45e8-5ca6-bc11-72acc27425a0@redhat.com>
 <7fd25a91-9f81-9d36-fb5f-949728cfe1d4@redhat.com>
 <896050fe-e8a6-e525-0be7-b2344b8421b1@redhat.com>
 <8008555d-eaf4-5e61-5457-77a40716c8bb@redhat.com>
Message-ID: <31738a4f-3148-454f-72e5-5f655ae4c898@kennke.org>

>>>> Do you need to store the lock in the thread-local data? Can't you
>>>> simply
>>>> keep it in the evac-scope-object?
>>>
>>> Is there a way to get to evac-scope from OOM handler?
>>
>> Hmm, right.
>>
>> So we have a whole bunch of stuff already in TLD that is there for
>> dealing with OOM-during-evac. You are about to add another one.
>>
>> Maybe it makes sense to put the OOM scope object in TLD instead, and let
>> that keep the fields? It doesn't have to be a pointer, it can be flat,
>> and effectively have the same layout as it is now, but it would be
>> clearer.
> Make sense. Can we do it in separate CR?

Yes, ok.

> Thanks,
> 
> -Zhengyu
> 
> 
>>
>> Also, I am not convinced that this is safe. Would the code that held the
>> lock still be good after it comes back from OOM handler?
>>
>> Roman
>>
>>
>>>
>>> -Zhengyu
>>>
>>>>
>>>> Roman
>>>>
>>>>> There can be deadlock when nmethod barrier fails to evacuate oops and
>>>>> enter OOM protocol while holding per-nmethod lock, cause concurrent
>>>>> nmethod processing may try to obtain the specific lock while under OOM
>>>>> protocol.
>>>>>
>>>>> The solution is to have nmethod barrier temporary abandon the lock
>>>>> before it enters OOM protocol, let concurrent thread to process the
>>>>> nmethod. Upon completion of OOM, nmethod barrier can continue to
>>>>> evacuate/disarm the nmethod, since the operations are idempotent.
>>>>>
>>>>> Webrev:
>>>>> http://cr.openjdk.java.net/~zgu/shenandoah/nmeth_barrier_deadlock/webrev.00/
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> Test:
>>>>> ??? hotspot_gc_shenandoah (fastdebug and release)
>>>>>
>>>>> ??? specjvm (fastdebug and release) with options:
>>>>> ${JAVA_HOME}/bin/java -jar jmh-specjvm2016.jar -foe true -f 1 -wi 5
>>>>> -i 5
>>>>> -t 1 -w 1s -r 1s --jvmArgs "-Xmx1g -Xms1g
>>>>> -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC
>>>>> -XX:+UnlockDiagnosticVMOptions -XX:ShenandoahGCHeuristics=aggressive
>>>>> -XX:+ShenandoahOOMDuringEvacALot"
>>>>>
>>>>> Thanks,
>>>>>
>>>>> -Zhengyu
>>>>
>>
> 

From roman at kennke.org  Tue Sep 10 19:23:44 2019
From: roman at kennke.org (Roman Kennke)
Date: Tue, 10 Sep 2019 21:23:44 +0200
Subject: Shenandoah: nmethod barrier needs to abandon per-nmethod lock
 before entering OOM protocol
In-Reply-To: <799d8ecd-a660-412e-d368-b670fbdbec17@redhat.com>
References: <fc3f3345-85d4-a1a4-10f0-21971cc63821@redhat.com>
 <acea2967-6a2f-9566-fe87-bced95612996@redhat.com>
 <9c01fb03-ac50-27cb-994d-eebe5b7b4876@redhat.com>
 <87cda82d-7d16-6598-c4ae-2a2829c185fc@redhat.com>
 <799d8ecd-a660-412e-d368-b670fbdbec17@redhat.com>
Message-ID: <3b8558dd-c691-e1fb-3207-0c77628e66d7@kennke.org>

>>>> So maybe the deadlock can be resolved somehow else? E.g. by entering
>>>> the
>>>> scopes/locks always in the same order? E.g.:
>>>>
>>>> nmethod-barrier does:
>>>> ?? 1. per-nmethod-lock 2. OOM scope
>>>>
>>>> concurrent nmethod processing does:
>>>> ?? 1. OOM scope 2. per-nmethod-lock
>>>>
>>>> Can this be changed that concurrent nmethod processing does grab the
>>>> OOM
>>>> scope *after* taking the per-nmethod-lock, just like the barrier does?
>>>
>>> It is possible to have concurrent thread does:
>>> ?? 1. per-nmethod-lock, 2. OOM scope
>>>
>>> but it is quite expensive, it requires setting up/tearing down OOM scope
>>> for each nmethod.
>>
>> Is that so bad? barriers do that per-oop.
> Donn't know, but could have thousands nmethods.

I think it should be ok to do that. Setting up / leaving OOM scope
shouldn't be more expensive than acquiring/releasing a lock. It would
keep the change much simpler/cleaner, wouldn't it?

Roman


>>
>> *or* change the nmethod barrier to do:
>>
>> ? 1. OOM scope 2. per-nmethod-lock
> 
> This won't work.
> 
> The? thread, that causeed OOM, will wait other threads get out of OOM
> scope while holding the lock, and another thread can stick waiting for
> the lock inside OOM scope.
> 
> -Zhengyu
> 
>>
>> instead?
>>
>> Roman
>>
>>
>>
>>> -Zhengyu
>>>
>>>>
>>>> Roman
>>>>
>>>>> There can be deadlock when nmethod barrier fails to evacuate oops and
>>>>> enter OOM protocol while holding per-nmethod lock, cause concurrent
>>>>> nmethod processing may try to obtain the specific lock while under OOM
>>>>> protocol.
>>>>>
>>>>> The solution is to have nmethod barrier temporary abandon the lock
>>>>> before it enters OOM protocol, let concurrent thread to process the
>>>>> nmethod. Upon completion of OOM, nmethod barrier can continue to
>>>>> evacuate/disarm the nmethod, since the operations are idempotent.
>>>>>
>>>>> Webrev:
>>>>> http://cr.openjdk.java.net/~zgu/shenandoah/nmeth_barrier_deadlock/webrev.00/
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> Test:
>>>>> ??? hotspot_gc_shenandoah (fastdebug and release)
>>>>>
>>>>> ??? specjvm (fastdebug and release) with options:
>>>>> ${JAVA_HOME}/bin/java -jar jmh-specjvm2016.jar -foe true -f 1 -wi 5
>>>>> -i 5
>>>>> -t 1 -w 1s -r 1s --jvmArgs "-Xmx1g -Xms1g
>>>>> -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC
>>>>> -XX:+UnlockDiagnosticVMOptions -XX:ShenandoahGCHeuristics=aggressive
>>>>> -XX:+ShenandoahOOMDuringEvacALot"
>>>>>
>>>>> Thanks,
>>>>>
>>>>> -Zhengyu
>>>>
>>
> 

From zgu at redhat.com  Tue Sep 10 20:21:40 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Tue, 10 Sep 2019 16:21:40 -0400
Subject: Shenandoah: nmethod barrier needs to abandon per-nmethod lock
 before entering OOM protocol
In-Reply-To: <3b8558dd-c691-e1fb-3207-0c77628e66d7@kennke.org>
References: <fc3f3345-85d4-a1a4-10f0-21971cc63821@redhat.com>
 <acea2967-6a2f-9566-fe87-bced95612996@redhat.com>
 <9c01fb03-ac50-27cb-994d-eebe5b7b4876@redhat.com>
 <87cda82d-7d16-6598-c4ae-2a2829c185fc@redhat.com>
 <799d8ecd-a660-412e-d368-b670fbdbec17@redhat.com>
 <3b8558dd-c691-e1fb-3207-0c77628e66d7@kennke.org>
Message-ID: <38cb4c8d-830d-7f6a-6aa4-5bf95a7bb7f0@redhat.com>


> I think it should be ok to do that. Setting up / leaving OOM scope
> shouldn't be more expensive than acquiring/releasing a lock. It would
> keep the change much simpler/cleaner, wouldn't it?

In that case, of course, it is much simpler ..

http://cr.openjdk.java.net/~zgu/shenandoah/nmeth_barrier_deadlock/webrev.01/

passed specjvm tests, other tests in progress.

Thanks,

-Zhengyu


> 
> Roman
> 
> 
>>>
>>> *or* change the nmethod barrier to do:
>>>
>>>  ? 1. OOM scope 2. per-nmethod-lock
>>
>> This won't work.
>>
>> The? thread, that causeed OOM, will wait other threads get out of OOM
>> scope while holding the lock, and another thread can stick waiting for
>> the lock inside OOM scope.
>>
>> -Zhengyu
>>
>>>
>>> instead?
>>>
>>> Roman
>>>
>>>
>>>
>>>> -Zhengyu
>>>>
>>>>>
>>>>> Roman
>>>>>
>>>>>> There can be deadlock when nmethod barrier fails to evacuate oops and
>>>>>> enter OOM protocol while holding per-nmethod lock, cause concurrent
>>>>>> nmethod processing may try to obtain the specific lock while under OOM
>>>>>> protocol.
>>>>>>
>>>>>> The solution is to have nmethod barrier temporary abandon the lock
>>>>>> before it enters OOM protocol, let concurrent thread to process the
>>>>>> nmethod. Upon completion of OOM, nmethod barrier can continue to
>>>>>> evacuate/disarm the nmethod, since the operations are idempotent.
>>>>>>
>>>>>> Webrev:
>>>>>> http://cr.openjdk.java.net/~zgu/shenandoah/nmeth_barrier_deadlock/webrev.00/
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> Test:
>>>>>>  ??? hotspot_gc_shenandoah (fastdebug and release)
>>>>>>
>>>>>>  ??? specjvm (fastdebug and release) with options:
>>>>>> ${JAVA_HOME}/bin/java -jar jmh-specjvm2016.jar -foe true -f 1 -wi 5
>>>>>> -i 5
>>>>>> -t 1 -w 1s -r 1s --jvmArgs "-Xmx1g -Xms1g
>>>>>> -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC
>>>>>> -XX:+UnlockDiagnosticVMOptions -XX:ShenandoahGCHeuristics=aggressive
>>>>>> -XX:+ShenandoahOOMDuringEvacALot"
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> -Zhengyu
>>>>>
>>>
>>

From rkennke at redhat.com  Tue Sep 10 20:36:29 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 10 Sep 2019 22:36:29 +0200
Subject: Shenandoah: nmethod barrier needs to abandon per-nmethod lock
 before entering OOM protocol
In-Reply-To: <38cb4c8d-830d-7f6a-6aa4-5bf95a7bb7f0@redhat.com>
References: <fc3f3345-85d4-a1a4-10f0-21971cc63821@redhat.com>
 <acea2967-6a2f-9566-fe87-bced95612996@redhat.com>
 <9c01fb03-ac50-27cb-994d-eebe5b7b4876@redhat.com>
 <87cda82d-7d16-6598-c4ae-2a2829c185fc@redhat.com>
 <799d8ecd-a660-412e-d368-b670fbdbec17@redhat.com>
 <3b8558dd-c691-e1fb-3207-0c77628e66d7@kennke.org>
 <38cb4c8d-830d-7f6a-6aa4-5bf95a7bb7f0@redhat.com>
Message-ID: <e6566ea0-cb4d-a62c-00da-31d00edbd69f@redhat.com>

Looks good.

If it really turns out to be a performance problem, then we can still do
what you originally proposed.

BTW, we do skip nmethods that we know have no oops at all, do we?

Roman

>> I think it should be ok to do that. Setting up / leaving OOM scope
>> shouldn't be more expensive than acquiring/releasing a lock. It would
>> keep the change much simpler/cleaner, wouldn't it?
> 
> In that case, of course, it is much simpler ..
> 
> http://cr.openjdk.java.net/~zgu/shenandoah/nmeth_barrier_deadlock/webrev.01/
> 
> 
> passed specjvm tests, other tests in progress.
> 
> Thanks,
> 
> -Zhengyu
> 
> 
>>
>> Roman
>>
>>
>>>>
>>>> *or* change the nmethod barrier to do:
>>>>
>>>> ?? 1. OOM scope 2. per-nmethod-lock
>>>
>>> This won't work.
>>>
>>> The? thread, that causeed OOM, will wait other threads get out of OOM
>>> scope while holding the lock, and another thread can stick waiting for
>>> the lock inside OOM scope.
>>>
>>> -Zhengyu
>>>
>>>>
>>>> instead?
>>>>
>>>> Roman
>>>>
>>>>
>>>>
>>>>> -Zhengyu
>>>>>
>>>>>>
>>>>>> Roman
>>>>>>
>>>>>>> There can be deadlock when nmethod barrier fails to evacuate oops
>>>>>>> and
>>>>>>> enter OOM protocol while holding per-nmethod lock, cause concurrent
>>>>>>> nmethod processing may try to obtain the specific lock while
>>>>>>> under OOM
>>>>>>> protocol.
>>>>>>>
>>>>>>> The solution is to have nmethod barrier temporary abandon the lock
>>>>>>> before it enters OOM protocol, let concurrent thread to process the
>>>>>>> nmethod. Upon completion of OOM, nmethod barrier can continue to
>>>>>>> evacuate/disarm the nmethod, since the operations are idempotent.
>>>>>>>
>>>>>>> Webrev:
>>>>>>> http://cr.openjdk.java.net/~zgu/shenandoah/nmeth_barrier_deadlock/webrev.00/
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Test:
>>>>>>> ???? hotspot_gc_shenandoah (fastdebug and release)
>>>>>>>
>>>>>>> ???? specjvm (fastdebug and release) with options:
>>>>>>> ${JAVA_HOME}/bin/java -jar jmh-specjvm2016.jar -foe true -f 1 -wi 5
>>>>>>> -i 5
>>>>>>> -t 1 -w 1s -r 1s --jvmArgs "-Xmx1g -Xms1g
>>>>>>> -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC
>>>>>>> -XX:+UnlockDiagnosticVMOptions -XX:ShenandoahGCHeuristics=aggressive
>>>>>>> -XX:+ShenandoahOOMDuringEvacALot"
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> -Zhengyu
>>>>>>
>>>>
>>>


From zgu at redhat.com  Tue Sep 10 20:41:47 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Tue, 10 Sep 2019 16:41:47 -0400
Subject: Shenandoah: nmethod barrier needs to abandon per-nmethod lock
 before entering OOM protocol
In-Reply-To: <e6566ea0-cb4d-a62c-00da-31d00edbd69f@redhat.com>
References: <fc3f3345-85d4-a1a4-10f0-21971cc63821@redhat.com>
 <acea2967-6a2f-9566-fe87-bced95612996@redhat.com>
 <9c01fb03-ac50-27cb-994d-eebe5b7b4876@redhat.com>
 <87cda82d-7d16-6598-c4ae-2a2829c185fc@redhat.com>
 <799d8ecd-a660-412e-d368-b670fbdbec17@redhat.com>
 <3b8558dd-c691-e1fb-3207-0c77628e66d7@kennke.org>
 <38cb4c8d-830d-7f6a-6aa4-5bf95a7bb7f0@redhat.com>
 <e6566ea0-cb4d-a62c-00da-31d00edbd69f@redhat.com>
Message-ID: <a6d94545-20a5-0a67-da3e-603c1915edcf@redhat.com>



On 9/10/19 4:36 PM, Roman Kennke wrote:
> Looks good.
> 
> If it really turns out to be a performance problem, then we can still do
> what you originally proposed.
> 
> BTW, we do skip nmethods that we know have no oops at all, do we?

No, because we still have to disarm them and following 
NMethod::unload_nmethod_caches() may potential invoke native barrier, so 
we still need to setup OOM scope.

-Zhengyu


> 
> Roman
> 
>>> I think it should be ok to do that. Setting up / leaving OOM scope
>>> shouldn't be more expensive than acquiring/releasing a lock. It would
>>> keep the change much simpler/cleaner, wouldn't it?
>>
>> In that case, of course, it is much simpler ..
>>
>> http://cr.openjdk.java.net/~zgu/shenandoah/nmeth_barrier_deadlock/webrev.01/
>>
>>
>> passed specjvm tests, other tests in progress.
>>
>> Thanks,
>>
>> -Zhengyu
>>
>>
>>>
>>> Roman
>>>
>>>
>>>>>
>>>>> *or* change the nmethod barrier to do:
>>>>>
>>>>>  ?? 1. OOM scope 2. per-nmethod-lock
>>>>
>>>> This won't work.
>>>>
>>>> The? thread, that causeed OOM, will wait other threads get out of OOM
>>>> scope while holding the lock, and another thread can stick waiting for
>>>> the lock inside OOM scope.
>>>>
>>>> -Zhengyu
>>>>
>>>>>
>>>>> instead?
>>>>>
>>>>> Roman
>>>>>
>>>>>
>>>>>
>>>>>> -Zhengyu
>>>>>>
>>>>>>>
>>>>>>> Roman
>>>>>>>
>>>>>>>> There can be deadlock when nmethod barrier fails to evacuate oops
>>>>>>>> and
>>>>>>>> enter OOM protocol while holding per-nmethod lock, cause concurrent
>>>>>>>> nmethod processing may try to obtain the specific lock while
>>>>>>>> under OOM
>>>>>>>> protocol.
>>>>>>>>
>>>>>>>> The solution is to have nmethod barrier temporary abandon the lock
>>>>>>>> before it enters OOM protocol, let concurrent thread to process the
>>>>>>>> nmethod. Upon completion of OOM, nmethod barrier can continue to
>>>>>>>> evacuate/disarm the nmethod, since the operations are idempotent.
>>>>>>>>
>>>>>>>> Webrev:
>>>>>>>> http://cr.openjdk.java.net/~zgu/shenandoah/nmeth_barrier_deadlock/webrev.00/
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Test:
>>>>>>>>  ???? hotspot_gc_shenandoah (fastdebug and release)
>>>>>>>>
>>>>>>>>  ???? specjvm (fastdebug and release) with options:
>>>>>>>> ${JAVA_HOME}/bin/java -jar jmh-specjvm2016.jar -foe true -f 1 -wi 5
>>>>>>>> -i 5
>>>>>>>> -t 1 -w 1s -r 1s --jvmArgs "-Xmx1g -Xms1g
>>>>>>>> -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC
>>>>>>>> -XX:+UnlockDiagnosticVMOptions -XX:ShenandoahGCHeuristics=aggressive
>>>>>>>> -XX:+ShenandoahOOMDuringEvacALot"
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>>
>>>>>>>> -Zhengyu
>>>>>>>
>>>>>
>>>>
> 

From rkennke at redhat.com  Tue Sep 10 20:44:40 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 10 Sep 2019 22:44:40 +0200
Subject: Shenandoah: nmethod barrier needs to abandon per-nmethod lock
 before entering OOM protocol
In-Reply-To: <a6d94545-20a5-0a67-da3e-603c1915edcf@redhat.com>
References: <fc3f3345-85d4-a1a4-10f0-21971cc63821@redhat.com>
 <acea2967-6a2f-9566-fe87-bced95612996@redhat.com>
 <9c01fb03-ac50-27cb-994d-eebe5b7b4876@redhat.com>
 <87cda82d-7d16-6598-c4ae-2a2829c185fc@redhat.com>
 <799d8ecd-a660-412e-d368-b670fbdbec17@redhat.com>
 <3b8558dd-c691-e1fb-3207-0c77628e66d7@kennke.org>
 <38cb4c8d-830d-7f6a-6aa4-5bf95a7bb7f0@redhat.com>
 <e6566ea0-cb4d-a62c-00da-31d00edbd69f@redhat.com>
 <a6d94545-20a5-0a67-da3e-603c1915edcf@redhat.com>
Message-ID: <549630c0-1564-48e9-8ed6-3de4f26588be@redhat.com>

> On 9/10/19 4:36 PM, Roman Kennke wrote:
>> Looks good.
>>
>> If it really turns out to be a performance problem, then we can still do
>> what you originally proposed.
>>
>> BTW, we do skip nmethods that we know have no oops at all, do we?
> 
> No, because we still have to disarm them and following
> NMethod::unload_nmethod_caches() may potential invoke native barrier, so
> we still need to setup OOM scope.

Hmm. Ok then.

Thanks,
Roman

> -Zhengyu
> 
> 
>>
>> Roman
>>
>>>> I think it should be ok to do that. Setting up / leaving OOM scope
>>>> shouldn't be more expensive than acquiring/releasing a lock. It would
>>>> keep the change much simpler/cleaner, wouldn't it?
>>>
>>> In that case, of course, it is much simpler ..
>>>
>>> http://cr.openjdk.java.net/~zgu/shenandoah/nmeth_barrier_deadlock/webrev.01/
>>>
>>>
>>>
>>> passed specjvm tests, other tests in progress.
>>>
>>> Thanks,
>>>
>>> -Zhengyu
>>>
>>>
>>>>
>>>> Roman
>>>>
>>>>
>>>>>>
>>>>>> *or* change the nmethod barrier to do:
>>>>>>
>>>>>> ??? 1. OOM scope 2. per-nmethod-lock
>>>>>
>>>>> This won't work.
>>>>>
>>>>> The? thread, that causeed OOM, will wait other threads get out of OOM
>>>>> scope while holding the lock, and another thread can stick waiting for
>>>>> the lock inside OOM scope.
>>>>>
>>>>> -Zhengyu
>>>>>
>>>>>>
>>>>>> instead?
>>>>>>
>>>>>> Roman
>>>>>>
>>>>>>
>>>>>>
>>>>>>> -Zhengyu
>>>>>>>
>>>>>>>>
>>>>>>>> Roman
>>>>>>>>
>>>>>>>>> There can be deadlock when nmethod barrier fails to evacuate oops
>>>>>>>>> and
>>>>>>>>> enter OOM protocol while holding per-nmethod lock, cause
>>>>>>>>> concurrent
>>>>>>>>> nmethod processing may try to obtain the specific lock while
>>>>>>>>> under OOM
>>>>>>>>> protocol.
>>>>>>>>>
>>>>>>>>> The solution is to have nmethod barrier temporary abandon the lock
>>>>>>>>> before it enters OOM protocol, let concurrent thread to process
>>>>>>>>> the
>>>>>>>>> nmethod. Upon completion of OOM, nmethod barrier can continue to
>>>>>>>>> evacuate/disarm the nmethod, since the operations are idempotent.
>>>>>>>>>
>>>>>>>>> Webrev:
>>>>>>>>> http://cr.openjdk.java.net/~zgu/shenandoah/nmeth_barrier_deadlock/webrev.00/
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Test:
>>>>>>>>> ????? hotspot_gc_shenandoah (fastdebug and release)
>>>>>>>>>
>>>>>>>>> ????? specjvm (fastdebug and release) with options:
>>>>>>>>> ${JAVA_HOME}/bin/java -jar jmh-specjvm2016.jar -foe true -f 1
>>>>>>>>> -wi 5
>>>>>>>>> -i 5
>>>>>>>>> -t 1 -w 1s -r 1s --jvmArgs "-Xmx1g -Xms1g
>>>>>>>>> -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC
>>>>>>>>> -XX:+UnlockDiagnosticVMOptions
>>>>>>>>> -XX:ShenandoahGCHeuristics=aggressive
>>>>>>>>> -XX:+ShenandoahOOMDuringEvacALot"
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>>
>>>>>>>>> -Zhengyu
>>>>>>>>
>>>>>>
>>>>>
>>


From zgu at redhat.com  Tue Sep 10 23:36:50 2019
From: zgu at redhat.com (zgu at redhat.com)
Date: Tue, 10 Sep 2019 23:36:50 +0000
Subject: hg: shenandoah/jdk: Shenandoah: heal nmethod under per-nmethod lock
Message-ID: <201909102336.x8ANaoMi020972@aojmv0008.oracle.com>

Changeset: a6bd5535b718
Author:    zgu
Date:      2019-09-10 19:35 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/a6bd5535b718

Shenandoah: heal nmethod under per-nmethod lock
Reviewed-by: rkennke

! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp


From zgu at redhat.com  Tue Sep 10 23:37:45 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Tue, 10 Sep 2019 19:37:45 -0400
Subject: Shenandoah: nmethod barrier needs to abandon per-nmethod lock
 before entering OOM protocol
In-Reply-To: <549630c0-1564-48e9-8ed6-3de4f26588be@redhat.com>
References: <fc3f3345-85d4-a1a4-10f0-21971cc63821@redhat.com>
 <acea2967-6a2f-9566-fe87-bced95612996@redhat.com>
 <9c01fb03-ac50-27cb-994d-eebe5b7b4876@redhat.com>
 <87cda82d-7d16-6598-c4ae-2a2829c185fc@redhat.com>
 <799d8ecd-a660-412e-d368-b670fbdbec17@redhat.com>
 <3b8558dd-c691-e1fb-3207-0c77628e66d7@kennke.org>
 <38cb4c8d-830d-7f6a-6aa4-5bf95a7bb7f0@redhat.com>
 <e6566ea0-cb4d-a62c-00da-31d00edbd69f@redhat.com>
 <a6d94545-20a5-0a67-da3e-603c1915edcf@redhat.com>
 <549630c0-1564-48e9-8ed6-3de4f26588be@redhat.com>
Message-ID: <2ed5e94c-4dc4-177c-5934-435776275ad5@redhat.com>



On 9/10/19 4:44 PM, Roman Kennke wrote:
>> On 9/10/19 4:36 PM, Roman Kennke wrote:
>>> Looks good.
Pushed.

Thanks,

-Zhengyu

>>>
>>> If it really turns out to be a performance problem, then we can still do
>>> what you originally proposed.
>>>
>>> BTW, we do skip nmethods that we know have no oops at all, do we?
>>
>> No, because we still have to disarm them and following
>> NMethod::unload_nmethod_caches() may potential invoke native barrier, so
>> we still need to setup OOM scope.
> 
> Hmm. Ok then.
> 
> Thanks,
> Roman
> 
>> -Zhengyu
>>
>>
>>>
>>> Roman
>>>
>>>>> I think it should be ok to do that. Setting up / leaving OOM scope
>>>>> shouldn't be more expensive than acquiring/releasing a lock. It would
>>>>> keep the change much simpler/cleaner, wouldn't it?
>>>>
>>>> In that case, of course, it is much simpler ..
>>>>
>>>> http://cr.openjdk.java.net/~zgu/shenandoah/nmeth_barrier_deadlock/webrev.01/
>>>>
>>>>
>>>>
>>>> passed specjvm tests, other tests in progress.
>>>>
>>>> Thanks,
>>>>
>>>> -Zhengyu
>>>>
>>>>
>>>>>
>>>>> Roman
>>>>>
>>>>>
>>>>>>>
>>>>>>> *or* change the nmethod barrier to do:
>>>>>>>
>>>>>>>  ??? 1. OOM scope 2. per-nmethod-lock
>>>>>>
>>>>>> This won't work.
>>>>>>
>>>>>> The? thread, that causeed OOM, will wait other threads get out of OOM
>>>>>> scope while holding the lock, and another thread can stick waiting for
>>>>>> the lock inside OOM scope.
>>>>>>
>>>>>> -Zhengyu
>>>>>>
>>>>>>>
>>>>>>> instead?
>>>>>>>
>>>>>>> Roman
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> -Zhengyu
>>>>>>>>
>>>>>>>>>
>>>>>>>>> Roman
>>>>>>>>>
>>>>>>>>>> There can be deadlock when nmethod barrier fails to evacuate oops
>>>>>>>>>> and
>>>>>>>>>> enter OOM protocol while holding per-nmethod lock, cause
>>>>>>>>>> concurrent
>>>>>>>>>> nmethod processing may try to obtain the specific lock while
>>>>>>>>>> under OOM
>>>>>>>>>> protocol.
>>>>>>>>>>
>>>>>>>>>> The solution is to have nmethod barrier temporary abandon the lock
>>>>>>>>>> before it enters OOM protocol, let concurrent thread to process
>>>>>>>>>> the
>>>>>>>>>> nmethod. Upon completion of OOM, nmethod barrier can continue to
>>>>>>>>>> evacuate/disarm the nmethod, since the operations are idempotent.
>>>>>>>>>>
>>>>>>>>>> Webrev:
>>>>>>>>>> http://cr.openjdk.java.net/~zgu/shenandoah/nmeth_barrier_deadlock/webrev.00/
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Test:
>>>>>>>>>>  ????? hotspot_gc_shenandoah (fastdebug and release)
>>>>>>>>>>
>>>>>>>>>>  ????? specjvm (fastdebug and release) with options:
>>>>>>>>>> ${JAVA_HOME}/bin/java -jar jmh-specjvm2016.jar -foe true -f 1
>>>>>>>>>> -wi 5
>>>>>>>>>> -i 5
>>>>>>>>>> -t 1 -w 1s -r 1s --jvmArgs "-Xmx1g -Xms1g
>>>>>>>>>> -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC
>>>>>>>>>> -XX:+UnlockDiagnosticVMOptions
>>>>>>>>>> -XX:ShenandoahGCHeuristics=aggressive
>>>>>>>>>> -XX:+ShenandoahOOMDuringEvacALot"
>>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>>
>>>>>>>>>> -Zhengyu
>>>>>>>>>
>>>>>>>
>>>>>>
>>>
> 

From shade at redhat.com  Wed Sep 11 13:45:44 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 11 Sep 2019 15:45:44 +0200
Subject: RFC: Pick up jdk-11.0.5+7 to sh/jdk11
Message-ID: <356dc4f0-6d4f-c133-7aa5-8199e945efb8@redhat.com>

11.0.5 is stabilizing for release. Let's pick up 11.0.5+7 published today.

The merge to sh/jdk11 is trivial. I would tag the merge as shenandoah-jdk-11.0.5+7 right away.

Changeset list:
  https://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.5%2b7/changesets.txt

Testing: hotspot_gc_shenandoah {fastdebug,release}

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Wed Sep 11 15:49:30 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 11 Sep 2019 17:49:30 +0200
Subject: RFC: Pick up jdk-11.0.5+7 to sh/jdk11
In-Reply-To: <356dc4f0-6d4f-c133-7aa5-8199e945efb8@redhat.com>
References: <356dc4f0-6d4f-c133-7aa5-8199e945efb8@redhat.com>
Message-ID: <1c34075e-bb22-d866-5ba4-b8a621e24f2d@redhat.com>

Good!

Thanks,
Roman


> 11.0.5 is stabilizing for release. Let's pick up 11.0.5+7 published today.
> 
> The merge to sh/jdk11 is trivial. I would tag the merge as shenandoah-jdk-11.0.5+7 right away.
> 
> Changeset list:
>   https://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.5%2b7/changesets.txt
> 
> Testing: hotspot_gc_shenandoah {fastdebug,release}
> 


From shade at redhat.com  Wed Sep 11 16:49:22 2019
From: shade at redhat.com (shade at redhat.com)
Date: Wed, 11 Sep 2019 16:49:22 +0000
Subject: hg: shenandoah/jdk11: 12 new changesets
Message-ID: <201909111649.x8BGnN1D009858@aojmv0008.oracle.com>

Changeset: 9c23fb3cbad1
Author:    martin
Date:      2018-11-28 14:28 -0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/9c23fb3cbad1

8213406: (fs) More than one instance of built-in FileSystem observed in heap
Reviewed-by: alanb, cushon, weijun

! src/java.base/aix/classes/sun/nio/fs/AixFileSystemProvider.java
! src/java.base/aix/classes/sun/nio/fs/DefaultFileSystemProvider.java
! src/java.base/linux/classes/sun/nio/fs/DefaultFileSystemProvider.java
! src/java.base/linux/classes/sun/nio/fs/LinuxFileSystemProvider.java
! src/java.base/macosx/classes/sun/nio/fs/BsdFileSystemProvider.java
! src/java.base/macosx/classes/sun/nio/fs/DefaultFileSystemProvider.java
! src/java.base/macosx/classes/sun/nio/fs/MacOSXFileSystemProvider.java
! src/java.base/share/classes/java/io/FilePermission.java
! src/java.base/share/classes/java/nio/file/FileSystems.java
! src/java.base/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java
! src/java.base/solaris/classes/sun/nio/fs/SolarisFileSystemProvider.java
! src/java.base/unix/classes/sun/nio/fs/UnixFileSystemProvider.java
! src/java.base/windows/classes/sun/nio/fs/DefaultFileSystemProvider.java
! src/java.base/windows/classes/sun/nio/fs/WindowsFileSystemProvider.java

Changeset: f2b9d74567d8
Author:    stuefe
Date:      2019-03-26 15:52 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/f2b9d74567d8

8221407: Windows 32bit build error in libsunmscapi/security.cpp
Reviewed-by: clanger

! src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp

Changeset: 22b943469471
Author:    goetz
Date:      2019-09-04 10:02 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/22b943469471

Added tag jdk-11.0.5+6 for changeset deaef57bf366

! .hgtags

Changeset: 030e08cd59a1
Author:    goetz
Date:      2019-09-04 10:08 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/030e08cd59a1

Merge


Changeset: 343f922e2fbe
Author:    chegar
Date:      2019-08-19 14:28 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/343f922e2fbe

8225425: java.lang.UnsatisfiedLinkError: net.dll: Can't find dependent libraries
Reviewed-by: dfuchs, alanb, erikj

! make/lib/Lib-java.base.gmk
! src/java.base/windows/classes/sun/net/www/protocol/http/ntlm/NTLMAuthentication.java
! src/java.base/windows/native/libnet/NTLMAuthentication.c
+ test/jdk/sun/net/www/protocol/http/TestTransparentNTLM.java
+ test/lib/jdk/test/lib/net/URIBuilder.java

Changeset: caa57e349340
Author:    weijun
Date:      2019-05-07 10:21 +0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/caa57e349340

8219013: Update Apache Santuario (XML Signature) to version 2.1.3
Reviewed-by: mullan

! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/IntegrityHmac.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/SignatureDSA.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/SignatureECDSA.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer20010315.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer20010315Excl.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/KeyInfo.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/content/KeyValue.java
+ src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/content/keyvalues/ECKeyValue.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509SKI.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/KeyResolver.java
+ src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/ECKeyValueResolver.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/RSAKeyValueResolver.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/implementations/CertsInFilesystemDirectoryResolver.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/resource/config.xml
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/signature/Manifest.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/signature/Reference.java
+ src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/signature/VerifiedReference.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/signature/XMLSignature.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformBase64Decode.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformXSLT.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/transforms/params/XPathFilterCHGPContainer.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/Constants.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/ElementProxy.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/Signature11ElementProxy.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/XMLUtils.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/ResourceResolver.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/ResolverDirectHTTP.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/ApacheCanonicalizer.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/ApacheOctetStreamData.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/ApacheTransform.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMCanonicalXMLC14NMethod.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMCryptoBinary.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMDigestMethod.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMEnvelopedTransform.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMExcC14NMethod.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMHMACSignatureMethod.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyInfo.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyInfoFactory.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyName.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyValue.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMManifest.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMPGPData.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMReference.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMRetrievalMethod.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureMethod.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureProperties.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureProperty.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignedInfo.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMStructure.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMTransform.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMURIDereferencer.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMUtils.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMX509Data.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMX509IssuerSerial.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLObject.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignature.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignatureFactory.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathFilter2Transform.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathTransform.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXSLTTransform.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XMLDSigRI.java
! src/java.xml.crypto/share/legal/santuario.md

Changeset: 345c7799d16b
Author:    jjiang
Date:      2019-05-03 15:57 +0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/345c7799d16b

8204203: Many pkcs11 tests failed in Provider initialization, after compiler on Windows changed
Summary: Build NSS 3.41 with VS2017 and also upgrade to this NSS for macosx
Reviewed-by: valeriep

! test/jdk/ProblemList.txt
! test/jdk/sun/security/pkcs11/PKCS11Test.java

Changeset: 1ee6067f27b1
Author:    jjiang
Date:      2019-06-06 10:11 +0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/1ee6067f27b1

8225390: ProblemList sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java due to JDK-8161536
Reviewed-by: xuelei

! test/jdk/ProblemList.txt

Changeset: 046604d257d7
Author:    lancea
Date:      2019-08-22 10:43 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/046604d257d7

8229887: (zipfs) zip file corruption when replacing an existing STORED entry
Reviewed-by: alanb, redestad, dfuchs

! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java
+ test/jdk/jdk/nio/zipfs/UpdateEntryTest.java

Changeset: 8d44692fec45
Author:    goetz
Date:      2019-09-11 07:38 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/8d44692fec45

Added tag jdk-11.0.5+7 for changeset 046604d257d7

! .hgtags

Changeset: f1cf42eb922f
Author:    shade
Date:      2019-09-11 15:30 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/f1cf42eb922f

Merge

! .hgtags

Changeset: 22f86cff83ea
Author:    shade
Date:      2019-09-11 15:30 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/22f86cff83ea

Added tag shenandoah-jdk-11.0.5+7 for changeset f1cf42eb922f

! .hgtags


From quy.d.x.nguyen at gmail.com  Mon Sep 16 04:14:36 2019
From: quy.d.x.nguyen at gmail.com (Quy Nguyen)
Date: Sun, 15 Sep 2019 23:14:36 -0500
Subject: Building JDK 11 Shenandoah on ARM32
Message-ID: <CAGY2vp7btZfjXkXRUGn1jX9ea_s8KOc5e-wqty7u81X4D5fSXQ@mail.gmail.com>

Hello,

I'm trying to build Shenandoah on JDK11 for a small embedded control
system, and I'm not sure why my build fails with: checking if shenandoah
can be built... no, platform not supported

bash configure \
--openjdk-target=arm-frc2020-linux-gnueabi \
--with-abi-profile=arm-vfp-sflt \
--with-jvm-variants=client \
--with-jvm-features=shenandoahgc \
--with-native-debug-symbols=zipped \
--enable-unlimited-crypto \
--with-sysroot=/usr/local/arm-frc2020-linux-gnueabi \
--with-version-pre=frc \
--with-version-patch=7 \
--with-version-opt=2020-11.0.5u7 \
--disable-warnings-as-errors \

I'm on shenandoah/jdk11 hg 22f86cff83ea, and I'm trying to wonder if it is
the soft floating point or the custom openjdk-target that's causing issues.
I know Aleksey Shipilev built Shenandoah (JDK 11) on arm32 hard-fp, so I'm
just trying to figure if this is the dreaded soft-fp curse.

Thanks,
Quy

From rkennke at redhat.com  Mon Sep 16 06:11:50 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 16 Sep 2019 08:11:50 +0200
Subject: Building JDK 11 Shenandoah on ARM32
In-Reply-To: <CAGY2vp7btZfjXkXRUGn1jX9ea_s8KOc5e-wqty7u81X4D5fSXQ@mail.gmail.com>
References: <CAGY2vp7btZfjXkXRUGn1jX9ea_s8KOc5e-wqty7u81X4D5fSXQ@mail.gmail.com>
Message-ID: <BE34117C-5D2B-405E-8AAA-C35D4622BFB1@redhat.com>

Hello Quy,

Shenandoah does not build on any arm32. Where did you get the info about building hard-fp from? It is new to me, and I'm sure I would know.

Thanks,
Roman


Am 16. September 2019 06:14:36 MESZ schrieb Quy Nguyen <quy.d.x.nguyen at gmail.com>:
>Hello,
>
>I'm trying to build Shenandoah on JDK11 for a small embedded control
>system, and I'm not sure why my build fails with: checking if
>shenandoah
>can be built... no, platform not supported
>
>bash configure \
>--openjdk-target=arm-frc2020-linux-gnueabi \
>--with-abi-profile=arm-vfp-sflt \
>--with-jvm-variants=client \
>--with-jvm-features=shenandoahgc \
>--with-native-debug-symbols=zipped \
>--enable-unlimited-crypto \
>--with-sysroot=/usr/local/arm-frc2020-linux-gnueabi \
>--with-version-pre=frc \
>--with-version-patch=7 \
>--with-version-opt=2020-11.0.5u7 \
>--disable-warnings-as-errors \
>
>I'm on shenandoah/jdk11 hg 22f86cff83ea, and I'm trying to wonder if it
>is
>the soft floating point or the custom openjdk-target that's causing
>issues.
>I know Aleksey Shipilev built Shenandoah (JDK 11) on arm32 hard-fp, so
>I'm
>just trying to figure if this is the dreaded soft-fp curse.
>
>Thanks,
>Quy

-- 
Diese Nachricht wurde von meinem Android-Ger?t mit K-9 Mail gesendet.

From rkennke at redhat.com  Tue Sep 17 14:02:42 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 17 Sep 2019 16:02:42 +0200
Subject: RFR: JDK-8231086: Shenandoah: Stronger invariant for object-arraycopy
Message-ID: <5891bb2e-52ba-b3af-c89a-dfb60ac4e4ac@redhat.com>

Currently, arraycopy operations can cause temporary
from-space-references in the destination array. Those would be
subsequently updated by an arraycopy-post-barrier, but it's awkward
because this temporary from-space references need to be dealt with, e.g.
in the CAS-obj barrier, and a few other places.
We can update the src array before copying, and therefore ensure to
never see a from-space-reference in the dst array, ever. This opens up a
couple of opportunities for simplification and optimization.

The change depends on JDK-8231085, which is under review too:
http://cr.openjdk.java.net/~rkennke/JDK-8231085/webrev.00/

It removes the huge single-loop that has been used for runtime and
interpreter arraycopy, and makes all (c2, c1, interpreter, runtime) use
the same pre-barrier.

Jira issue:
https://bugs.openjdk.java.net/browse/JDK-8231086
Webrev:
https://bugs.openjdk.java.net/browse/JDK-8231086
Testing: hotspot_gc_shenandoah

Performance testing with specjvm showed no significant pessimizations,
and in few cases we came out around 7% improved.

I intend to push this together with JDK-8231085, once both are reviewed.

Can I please get a review?

Thanks,
Roman


From zgu at redhat.com  Tue Sep 17 14:13:47 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Tue, 17 Sep 2019 10:13:47 -0400
Subject: RFR(T) 8230350: Shenandoah: Assertion failed when GC is cancelled by
 a worker thread
Message-ID: <0841b841-863a-cab1-d0a1-53de76bb11da@redhat.com>

This assertion failure rarely happens, because 
ShenandoahSuspendibleWorkers is off by default, so this path is rarely 
executed in jdk/jdk.

Now, ShenandoahSuspendibleWorkers is on when concurrent class unloading 
is enabled in shenandoah/jdk, but I only saw this once, so it is still rare.

Bug: https://bugs.openjdk.java.net/browse/JDK-8230350
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8230350/webrev.00/


Test:
   hotspot_gc_shenandoah (fastdebug and release)

Thanks,

-Zhengyu


From rkennke at redhat.com  Tue Sep 17 15:40:32 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 17 Sep 2019 17:40:32 +0200
Subject: RFR(T) 8230350: Shenandoah: Assertion failed when GC is cancelled
 by a worker thread
In-Reply-To: <0841b841-863a-cab1-d0a1-53de76bb11da@redhat.com>
References: <0841b841-863a-cab1-d0a1-53de76bb11da@redhat.com>
Message-ID: <f0ce2af6-76a0-07a7-a898-d2fdb79a77c3@redhat.com>

Looks good. Thanks!

Roman

> This assertion failure rarely happens, because
> ShenandoahSuspendibleWorkers is off by default, so this path is rarely
> executed in jdk/jdk.
> 
> Now, ShenandoahSuspendibleWorkers is on when concurrent class unloading
> is enabled in shenandoah/jdk, but I only saw this once, so it is still
> rare.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8230350
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8230350/webrev.00/
> 
> 
> Test:
> ? hotspot_gc_shenandoah (fastdebug and release)
> 
> Thanks,
> 
> -Zhengyu
> 


From rkennke at redhat.com  Tue Sep 17 17:31:58 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 17 Sep 2019 19:31:58 +0200
Subject: RFR: JDK-8231087: Shenandoah: Self-fixing references
Message-ID: <f7916eab-414c-656c-b8d3-d376d8f2487b@redhat.com>

One significant contributor to Shenandoah's barrier performance is the
LRB-midpath performance: when heap is unstable *and* the loaded
reference is in cset, we then check if the object is forwarded and if
not, call out into the slow-path. A way to avoid this is to update
references right in the slow-path. This avoids triggering the cset-check
on next access of the same field.

Depending on the workload, this provides throughput speedup of up to
15%. On the other hand, the additional work of updating the field
doesn't seem to impact noticably, presumably because it's on the
slow-path. An additional advantage is faster update-refs phase, because
fewer references are remaining that point to from-space.

Jira issue:
https://bugs.openjdk.java.net/browse/JDK-8231087
Webrev:
http://cr.openjdk.java.net/~rkennke/JDK-8231087/webrev.00/

Testing: This has baked for several weeks in sh/jdk and undergone deep
CI testing for a while, including several related bugfixes. The rebased
patch has been tested with hotspot_gc_shenandoah locally

Can I please get a review?

Thanks,
Roman


From shade at redhat.com  Wed Sep 18 10:44:52 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 18 Sep 2019 12:44:52 +0200
Subject: RFC: Pick up jdk-11.0.5+8 to sh/jdk11
Message-ID: <1864c89b-23bf-7675-5453-c0aa9721ef22@redhat.com>

Upstream published jdk-11.0.5+8, let's pick it up.

Merge is trivial. I would tag it shenandoah-jdk-11.0.5+8 immediately.

Changelist:
  http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.5%2b8/changesets.txt

Testing: hotspot_gc_shenandoah {fastdebug, release}

-- 
Thanks,
-Aleksey


From shade at redhat.com  Wed Sep 18 10:50:30 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 18 Sep 2019 12:50:30 +0200
Subject: RFR: JDK-8231086: Shenandoah: Stronger invariant for
 object-arraycopy
In-Reply-To: <5891bb2e-52ba-b3af-c89a-dfb60ac4e4ac@redhat.com>
References: <5891bb2e-52ba-b3af-c89a-dfb60ac4e4ac@redhat.com>
Message-ID: <4bb05092-ca60-af20-0c40-f7175e97541f@redhat.com>

On 9/17/19 4:02 PM, Roman Kennke wrote:
> Webrev:
> https://bugs.openjdk.java.net/browse/JDK-8231086

The webrev seems to be actually here:
  http://cr.openjdk.java.net/~rkennke/JDK-8231086/webrev.00/

*) src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp

Indenting is bad at L63-65 here:

  60       if (dest_uninitialized) {
  61         __ tbz(rscratch2, ShenandoahHeap::HAS_FORWARDED_BITPOS, done);
  62       } else {
  63       __ mov(rscratch2, ShenandoahHeap::HAS_FORWARDED | ShenandoahHeap::MARKING);
  64       __ tst(rscratch1, rscratch2);
  65       __ br(Assembler::EQ, done);
  66       }

*) src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp

I think we can do this to simplify the code and expose x86_32 path early:

#ifdef _LP64
  assert(src == rdi, "expected");
  assert(dst == rsi, "expected");
  assert(count == rdx, "expected");
  if (UseCompressedOops) {
    if (dest_uninitialized) {
       ....call write_ref_array_pre_duinit_narrow_oop_entry
     } else {
       ... call write_ref_array_pre_narrow_oop_entry
     }
  } else
 #endif
  {
    if (dest_uninitialized) {
      ... call write_ref_array_pre_duinit_oop_entry
    } else {
      ... call write_ref_array_pre_oop_entry
    }
  }

*) src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp

Do these locals serve any purpose?

  const char* copyfunc_name = "shenandoah_clone";
  address     copyfunc_addr = CAST_FROM_FN_PTR(address, ShenandoahRuntime::shenandoah_clone_barrier);
  const TypePtr* raw_adr_type = TypeRawPtr::BOTTOM;
  const TypeFunc* call_type = ShenandoahBarrierSetC2::shenandoah_clone_barrier_Type();
  Node* call = phase->make_leaf_call(ctrl, mem, call_type, copyfunc_addr, copyfunc_name,
raw_adr_type, src, dest, length);

Seems to be cleaner to inline them:

  Node* call = phase->make_leaf_call(ctrl, mem,
                  ShenandoahBarrierSetC2::shenandoah_clone_barrier_Type(),
                  CAST_FROM_FN_PTR(address, ShenandoahRuntime::shenandoah_clone_barrier),
                  "shenandoah_clone",
                  TypeRawPtr::BOTTOM,
                  src, dest, length);

*) src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp

Having this one is a cute trick:
   static inline oop cas_oop(oop n, narrowOop* addr, narrowOop c);

Otherwise looks good to me.

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Wed Sep 18 11:05:00 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 18 Sep 2019 13:05:00 +0200
Subject: RFC: Pick up jdk-11.0.5+8 to sh/jdk11
In-Reply-To: <1864c89b-23bf-7675-5453-c0aa9721ef22@redhat.com>
References: <1864c89b-23bf-7675-5453-c0aa9721ef22@redhat.com>
Message-ID: <9c3a2ecc-c002-76a4-66c8-bcb303e3efa8@redhat.com>

Good!

Roman


> Upstream published jdk-11.0.5+8, let's pick it up.
> 
> Merge is trivial. I would tag it shenandoah-jdk-11.0.5+8 immediately.
> 
> Changelist:
>    http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.5%2b8/changesets.txt
> 
> Testing: hotspot_gc_shenandoah {fastdebug, release}
> 

From shade at redhat.com  Wed Sep 18 11:17:29 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 18 Sep 2019 13:17:29 +0200
Subject: RFR: JDK-8231087: Shenandoah: Self-fixing references
In-Reply-To: <f7916eab-414c-656c-b8d3-d376d8f2487b@redhat.com>
References: <f7916eab-414c-656c-b8d3-d376d8f2487b@redhat.com>
Message-ID: <ba8107fd-6ddf-16c3-58f0-ef538b718d8c@redhat.com>

On 9/17/19 7:31 PM, Roman Kennke wrote:
> Jira issue:
> https://bugs.openjdk.java.net/browse/JDK-8231087
> Webrev:
> http://cr.openjdk.java.net/~rkennke/JDK-8231087/webrev.00/

Looks cool.

We are still doing the full non-fixing LRB from assembler, because it is much harder to do there,
or? And that version still does resolve-fwdptr path, so it does not call to slowpath all that often?

*) gc/shenandoah/shenandoahRuntime.(cpp|hpp)

I think your squashed patch misses this important follow-up:
  https://hg.openjdk.java.net/shenandoah/jdk/rev/7175c0025de1

In other words, we should not extend SHR::load_reference_barrier_native without changing all the
uses too, because it wrecks up calling convention when called from assembler.


*) Should be diagnostic. Also, description: "Fix references with load reference barrier. Disabling
this might degrade performance". (It would, because we remove the resolve-fwdptr parts from everywhere):

 395   experimental(bool, ShenandoahSelfFixing, true,                            \
 396           "Load-reference-barrier also fixes references")                   \

-- 
Thanks,
-Aleksey


From shade at redhat.com  Wed Sep 18 11:19:32 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 18 Sep 2019 13:19:32 +0200
Subject: RFR: JDK-8231087: Shenandoah: Self-fixing references
In-Reply-To: <ba8107fd-6ddf-16c3-58f0-ef538b718d8c@redhat.com>
References: <f7916eab-414c-656c-b8d3-d376d8f2487b@redhat.com>
 <ba8107fd-6ddf-16c3-58f0-ef538b718d8c@redhat.com>
Message-ID: <6a3c2ccf-b73d-88c2-0a9b-9a04fd0a30f5@redhat.com>

On 9/18/19 1:17 PM, Aleksey Shipilev wrote:
> On 9/17/19 7:31 PM, Roman Kennke wrote:
>> Jira issue:
>> https://bugs.openjdk.java.net/browse/JDK-8231087
>> Webrev:
>> http://cr.openjdk.java.net/~rkennke/JDK-8231087/webrev.00/
> 
> Looks cool.

Oh, and synopsis: "Shenandoah: self-fixing load reference barriers for C1/C2"? Because "self-fixing
references" sounds odd. Maybe drop "C1/C2", but it seems to catch that assembler paths are untouched.

-- 
Thanks,
-Aleksey


From shade at redhat.com  Wed Sep 18 11:23:13 2019
From: shade at redhat.com (shade at redhat.com)
Date: Wed, 18 Sep 2019 11:23:13 +0000
Subject: hg: shenandoah/jdk11: 5 new changesets
Message-ID: <201909181123.x8IBNEHp016373@aojmv0008.oracle.com>

Changeset: e2612889bbae
Author:    iignatyev
Date:      2019-05-16 12:16 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/e2612889bbae

8222154: upgrade gtest to 1.8.1
Reviewed-by: jwilhelm, rwestberg

! make/hotspot/lib/CompileGtest.gmk
+ test/fmw/gtest/CONTRIBUTORS
- test/fmw/gtest/README
+ test/fmw/gtest/README.md
! test/fmw/gtest/include/gtest/gtest-death-test.h
! test/fmw/gtest/include/gtest/gtest-message.h
! test/fmw/gtest/include/gtest/gtest-param-test.h
! test/fmw/gtest/include/gtest/gtest-param-test.h.pump
! test/fmw/gtest/include/gtest/gtest-printers.h
! test/fmw/gtest/include/gtest/gtest-spi.h
! test/fmw/gtest/include/gtest/gtest-test-part.h
! test/fmw/gtest/include/gtest/gtest-typed-test.h
! test/fmw/gtest/include/gtest/gtest.h
! test/fmw/gtest/include/gtest/gtest_pred_impl.h
! test/fmw/gtest/include/gtest/gtest_prod.h
+ test/fmw/gtest/include/gtest/internal/custom/README.md
+ test/fmw/gtest/include/gtest/internal/custom/gtest-port.h
+ test/fmw/gtest/include/gtest/internal/custom/gtest-printers.h
+ test/fmw/gtest/include/gtest/internal/custom/gtest.h
! test/fmw/gtest/include/gtest/internal/gtest-death-test-internal.h
! test/fmw/gtest/include/gtest/internal/gtest-filepath.h
! test/fmw/gtest/include/gtest/internal/gtest-internal.h
! test/fmw/gtest/include/gtest/internal/gtest-linked_ptr.h
! test/fmw/gtest/include/gtest/internal/gtest-param-util-generated.h
! test/fmw/gtest/include/gtest/internal/gtest-param-util-generated.h.pump
! test/fmw/gtest/include/gtest/internal/gtest-param-util.h
+ test/fmw/gtest/include/gtest/internal/gtest-port-arch.h
! test/fmw/gtest/include/gtest/internal/gtest-port.h
! test/fmw/gtest/include/gtest/internal/gtest-string.h
! test/fmw/gtest/include/gtest/internal/gtest-tuple.h
! test/fmw/gtest/include/gtest/internal/gtest-tuple.h.pump
! test/fmw/gtest/include/gtest/internal/gtest-type-util.h
! test/fmw/gtest/include/gtest/internal/gtest-type-util.h.pump
! test/fmw/gtest/src/gtest-all.cc
! test/fmw/gtest/src/gtest-death-test.cc
! test/fmw/gtest/src/gtest-filepath.cc
! test/fmw/gtest/src/gtest-internal-inl.h
! test/fmw/gtest/src/gtest-port.cc
! test/fmw/gtest/src/gtest-printers.cc
! test/fmw/gtest/src/gtest-test-part.cc
! test/fmw/gtest/src/gtest-typed-test.cc
! test/fmw/gtest/src/gtest.cc
! test/fmw/gtest/src/gtest_main.cc

Changeset: 2c29e9b3a285
Author:    rhalade
Date:      2019-07-17 16:13 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/2c29e9b3a285

8228337: problemList failing/ignored manual tests in security-libs
Reviewed-by: ascarpino

! test/jdk/ProblemList.txt

Changeset: f7e8e150d1d0
Author:    goetz
Date:      2019-09-18 08:03 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/f7e8e150d1d0

Added tag jdk-11.0.5+8 for changeset 2c29e9b3a285

! .hgtags

Changeset: 3d65c371698b
Author:    shade
Date:      2019-09-18 12:07 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/3d65c371698b

Merge

! .hgtags
- test/fmw/gtest/README

Changeset: 6e0bd7ffab09
Author:    shade
Date:      2019-09-18 12:07 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/6e0bd7ffab09

Added tag shenandoah-jdk-11.0.5+8 for changeset 3d65c371698b

! .hgtags


From rkennke at redhat.com  Wed Sep 18 14:00:06 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 18 Sep 2019 16:00:06 +0200
Subject: RFR: JDK-8231087: Shenandoah: Self-fixing references
In-Reply-To: <ba8107fd-6ddf-16c3-58f0-ef538b718d8c@redhat.com>
References: <f7916eab-414c-656c-b8d3-d376d8f2487b@redhat.com>
 <ba8107fd-6ddf-16c3-58f0-ef538b718d8c@redhat.com>
Message-ID: <6db05eeb-dcde-24f3-168b-510e66283079@redhat.com>

>> Jira issue:
>> https://bugs.openjdk.java.net/browse/JDK-8231087
>> Webrev:
>> http://cr.openjdk.java.net/~rkennke/JDK-8231087/webrev.00/
> 
> Looks cool.
> 
> We are still doing the full non-fixing LRB from assembler, because it is much harder to do there,
> or? And that version still does resolve-fwdptr path, so it does not call to slowpath all that often?

Correct. The register shuffling in interpreter to get the load-addr to 
the runtime call would be aweful, especially in x86_32. E.g. some loads 
override the base register of the load-addr, it would have to be lea'd 
and saved acrossed the load, plus we need an actual register for that, 
etc. Sorry, I forgot that in the original description.

> *) gc/shenandoah/shenandoahRuntime.(cpp|hpp)
> 
> I think your squashed patch misses this important follow-up:
>    https://hg.openjdk.java.net/shenandoah/jdk/rev/7175c0025de1
> 
> In other words, we should not extend SHR::load_reference_barrier_native without changing all the
> uses too, because it wrecks up calling convention when called from assembler.
> 

Ok, fixed.

> *) Should be diagnostic. Also, description: "Fix references with load reference barrier. Disabling
> this might degrade performance". (It would, because we remove the resolve-fwdptr parts from everywhere):
> 
>   395   experimental(bool, ShenandoahSelfFixing, true,                            \
>   396           "Load-reference-barrier also fixes references")                   \

Fixed.

Incremental diff:
http://cr.openjdk.java.net/~rkennke/JDK-8231087/webrev.01.diff/
Full:
http://cr.openjdk.java.net/~rkennke/JDK-8231087/webrev.01/

Ok now?

Roman


From rkennke at redhat.com  Wed Sep 18 14:16:37 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 18 Sep 2019 16:16:37 +0200
Subject: RFR: JDK-8231086: Shenandoah: Stronger invariant for
 object-arraycopy
In-Reply-To: <4bb05092-ca60-af20-0c40-f7175e97541f@redhat.com>
References: <5891bb2e-52ba-b3af-c89a-dfb60ac4e4ac@redhat.com>
 <4bb05092-ca60-af20-0c40-f7175e97541f@redhat.com>
Message-ID: <621178e0-b4f8-1a24-09e9-3d7852ef56f1@redhat.com>

Hi Aleksey,

>> Webrev:
>> https://bugs.openjdk.java.net/browse/JDK-8231086
> 
> The webrev seems to be actually here:
>    http://cr.openjdk.java.net/~rkennke/JDK-8231086/webrev.00/
> 
> *) src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp
> 
> Indenting is bad at L63-65 here:
> 
>    60       if (dest_uninitialized) {
>    61         __ tbz(rscratch2, ShenandoahHeap::HAS_FORWARDED_BITPOS, done);
>    62       } else {
>    63       __ mov(rscratch2, ShenandoahHeap::HAS_FORWARDED | ShenandoahHeap::MARKING);
>    64       __ tst(rscratch1, rscratch2);
>    65       __ br(Assembler::EQ, done);
>    66       }

Right, fixed!

> *) src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp
> 
> I think we can do this to simplify the code and expose x86_32 path early:
> 
> #ifdef _LP64
>    assert(src == rdi, "expected");
>    assert(dst == rsi, "expected");
>    assert(count == rdx, "expected");
>    if (UseCompressedOops) {
>      if (dest_uninitialized) {
>         ....call write_ref_array_pre_duinit_narrow_oop_entry
>       } else {
>         ... call write_ref_array_pre_narrow_oop_entry
>       }
>    } else
>   #endif
>    {
>      if (dest_uninitialized) {
>        ... call write_ref_array_pre_duinit_oop_entry
>      } else {
>        ... call write_ref_array_pre_oop_entry
>      }
>    }

Good point! Fixed.

> *) src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp
> 
> Do these locals serve any purpose?

No. Probably left-over from somewhere during dev.

>    const char* copyfunc_name = "shenandoah_clone";
>    address     copyfunc_addr = CAST_FROM_FN_PTR(address, ShenandoahRuntime::shenandoah_clone_barrier);
>    const TypePtr* raw_adr_type = TypeRawPtr::BOTTOM;
>    const TypeFunc* call_type = ShenandoahBarrierSetC2::shenandoah_clone_barrier_Type();
>    Node* call = phase->make_leaf_call(ctrl, mem, call_type, copyfunc_addr, copyfunc_name,
> raw_adr_type, src, dest, length);
> 
> Seems to be cleaner to inline them:
> 
>    Node* call = phase->make_leaf_call(ctrl, mem,
>                    ShenandoahBarrierSetC2::shenandoah_clone_barrier_Type(),
>                    CAST_FROM_FN_PTR(address, ShenandoahRuntime::shenandoah_clone_barrier),
>                    "shenandoah_clone",
>                    TypeRawPtr::BOTTOM,
>                    src, dest, length);

Yeah, fixed.

> *) src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp
> 
> Having this one is a cute trick:
>     static inline oop cas_oop(oop n, narrowOop* addr, narrowOop c);

Right? :-)

Incremental diff:
http://cr.openjdk.java.net/~rkennke/JDK-8231086/webrev.01.diff/
Full:
http://cr.openjdk.java.net/~rkennke/JDK-8231086/webrev.01/

Ok?

Roman

From shade at redhat.com  Wed Sep 18 14:24:45 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 18 Sep 2019 16:24:45 +0200
Subject: RFR: JDK-8231086: Shenandoah: Stronger invariant for
 object-arraycopy
In-Reply-To: <621178e0-b4f8-1a24-09e9-3d7852ef56f1@redhat.com>
References: <5891bb2e-52ba-b3af-c89a-dfb60ac4e4ac@redhat.com>
 <4bb05092-ca60-af20-0c40-f7175e97541f@redhat.com>
 <621178e0-b4f8-1a24-09e9-3d7852ef56f1@redhat.com>
Message-ID: <f6a84c28-a8a0-244f-ce2f-d89f8d3922e1@redhat.com>

On 9/18/19 4:16 PM, Roman Kennke wrote:
> Incremental diff:
> http://cr.openjdk.java.net/~rkennke/JDK-8231086/webrev.01.diff/
> Full:
> http://cr.openjdk.java.net/~rkennke/JDK-8231086/webrev.01/

Looks fine to me.

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Wed Sep 18 14:46:57 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 18 Sep 2019 16:46:57 +0200
Subject: RFR 8229919: Support JNI Critical functions in object pinning API
 on x86_32 platforms
In-Reply-To: <6f6afdc5-cb13-6c8c-98f8-47917793545c@redhat.com>
References: <6f6afdc5-cb13-6c8c-98f8-47917793545c@redhat.com>
Message-ID: <34499f22-9db4-38d5-abf6-f0aed6c99795@redhat.com>

Hi Zhengyu,

It looks good to me!

Thanks,
Roman


> Please review this patch that supports JNI critical functions in object 
> pinning capable GCs on x86_32 platforms.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8229919
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8229919/webrev.00/
> 
> Test:
>  ? hotspot_gc_shenandoah (fastdebug and release) with 32-bit VM on Linux 
> x86_64.
>  ? hotspot_gc, hotspot_runtime and hotspot_compiler
>  ? Submit tests in progress.
> 
> Thanks,
> 
> -Zhengyu

From zgu at redhat.com  Wed Sep 18 14:48:06 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 18 Sep 2019 10:48:06 -0400
Subject: RFR 8229919: Support JNI Critical functions in object pinning API
 on x86_32 platforms
In-Reply-To: <34499f22-9db4-38d5-abf6-f0aed6c99795@redhat.com>
References: <6f6afdc5-cb13-6c8c-98f8-47917793545c@redhat.com>
 <34499f22-9db4-38d5-abf6-f0aed6c99795@redhat.com>
Message-ID: <bdb7eaf9-2dce-16ec-a2c7-af70125bb6f4@redhat.com>

Thanks, Roman.

-Zhengyu

On 9/18/19 10:46 AM, Roman Kennke wrote:
> Hi Zhengyu,
> 
> It looks good to me!
> 
> Thanks,
> Roman
> 
> 
>> Please review this patch that supports JNI critical functions in 
>> object pinning capable GCs on x86_32 platforms.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8229919
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8229919/webrev.00/
>>
>> Test:
>> ?? hotspot_gc_shenandoah (fastdebug and release) with 32-bit VM on 
>> Linux x86_64.
>> ?? hotspot_gc, hotspot_runtime and hotspot_compiler
>> ?? Submit tests in progress.
>>
>> Thanks,
>>
>> -Zhengyu

From shade at redhat.com  Wed Sep 18 15:07:32 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 18 Sep 2019 17:07:32 +0200
Subject: RFR: JDK-8231087: Shenandoah: Self-fixing references
In-Reply-To: <6db05eeb-dcde-24f3-168b-510e66283079@redhat.com>
References: <f7916eab-414c-656c-b8d3-d376d8f2487b@redhat.com>
 <ba8107fd-6ddf-16c3-58f0-ef538b718d8c@redhat.com>
 <6db05eeb-dcde-24f3-168b-510e66283079@redhat.com>
Message-ID: <603f1c75-ddee-59cb-24b8-b6f128cad29e@redhat.com>

On 9/18/19 4:00 PM, Roman Kennke wrote:
> Incremental diff:
> http://cr.openjdk.java.net/~rkennke/JDK-8231087/webrev.01.diff/
> Full:
> http://cr.openjdk.java.net/~rkennke/JDK-8231087/webrev.01/

*) shenandoah_globals.hpp:

Please make sure indenting on L396-397 matches other options:

 395   diagnostic(bool, ShenandoahSelfFixing, true,                              \
 396              "Fix references with load reference barrier. Disabling this "  \
 397              "might degrade performance.")                                  \

...for example:

 381   diagnostic(bool, ShenandoahOptimizeStaticFinals, true,                    \
 382           "Optimize barriers on static final fields. "                      \
 383           "Turn it off for maximum compatibility with reflection or JNI "   \
 384           "code that manipulates final fields.")                            \

Otherwise looks good. No need for another review.

-- 
Thanks,
-Aleksey


From zgu at redhat.com  Wed Sep 18 18:39:15 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 18 Sep 2019 14:39:15 -0400
Subject: Shenandoah: assert(klass->is_loader_alive()) failed: must be alive
Message-ID: <c5a6384c-fdb0-6f57-8a20-3a72cab86a48@redhat.com>

We have seen above assertion failures in shenandoah/jdk nightly tests 
periodically, especially after JDK-8230401.

It actually became quite reproducible on my local machine with 
tier3_gc_shenandoah after JDK-8230401.

The problem appears to be missing proper synchronization of metadata of 
newly registered nmethod.  Initially, I thought new nmethod is 
registered under CodeCahe_lock and concurrent codecache iteration always 
starts with acquiring CodeCache_lock lock. What I missed is that, the 
actual codecache iteration is done by worker thread, while the 
CodeCache_lock is acquired by VMThread. Therefore, it never establishes 
synchronization of newly created nmethod metadata (ShenandoahNMethod) 
between compiler thread (registering the nmethod) and worker thread 
(processing the nmethod).

The solution is to always acquire per-nmethod lock when changing and 
iterating the metadata.

Webrev: 
http://cr.openjdk.java.net/~zgu/shenandoah/assert_is_loader_alive/webrev.00/

Test:
   hotspot_gc_shenandoah (fastdebug and release)

   hotspot_gc_shenandoah/tier3_gc_shenandoah (fastdebug) with 10+ 
iterations on my local machine and gotland respectively.

Thanks,

-Zhengyu



From rkennke at redhat.com  Wed Sep 18 19:14:25 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 18 Sep 2019 21:14:25 +0200
Subject: Shenandoah: assert(klass->is_loader_alive()) failed: must be alive
In-Reply-To: <c5a6384c-fdb0-6f57-8a20-3a72cab86a48@redhat.com>
References: <c5a6384c-fdb0-6f57-8a20-3a72cab86a48@redhat.com>
Message-ID: <2e188577-6ee8-d127-d6cb-0707894519cc@redhat.com>

The locking in ShenandoahNMethodTable::register_nmethod() is dirty. I 
would *very* much prefer to shuffle that code around to use scoped 
lockers. It's also buggy, because there is an early return there, which 
would miss the unlock. A way to do this would be to pull the disarm into 
the if-else blocks, and put scope inside the if-else too.

Roman

> We have seen above assertion failures in shenandoah/jdk nightly tests 
> periodically, especially after JDK-8230401.
> 
> It actually became quite reproducible on my local machine with 
> tier3_gc_shenandoah after JDK-8230401.
> 
> The problem appears to be missing proper synchronization of metadata of 
> newly registered nmethod.? Initially, I thought new nmethod is 
> registered under CodeCahe_lock and concurrent codecache iteration always 
> starts with acquiring CodeCache_lock lock. What I missed is that, the 
> actual codecache iteration is done by worker thread, while the 
> CodeCache_lock is acquired by VMThread. Therefore, it never establishes 
> synchronization of newly created nmethod metadata (ShenandoahNMethod) 
> between compiler thread (registering the nmethod) and worker thread 
> (processing the nmethod).
> 
> The solution is to always acquire per-nmethod lock when changing and 
> iterating the metadata.
> 
> Webrev: 
> http://cr.openjdk.java.net/~zgu/shenandoah/assert_is_loader_alive/webrev.00/ 
> 
> 
> Test:
>  ? hotspot_gc_shenandoah (fastdebug and release)
> 
>  ? hotspot_gc_shenandoah/tier3_gc_shenandoah (fastdebug) with 10+ 
> iterations on my local machine and gotland respectively.
> 
> Thanks,
> 
> -Zhengyu
> 
> 

From zgu at redhat.com  Wed Sep 18 21:22:57 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 18 Sep 2019 17:22:57 -0400
Subject: Shenandoah: assert(klass->is_loader_alive()) failed: must be alive
In-Reply-To: <2e188577-6ee8-d127-d6cb-0707894519cc@redhat.com>
References: <c5a6384c-fdb0-6f57-8a20-3a72cab86a48@redhat.com>
 <2e188577-6ee8-d127-d6cb-0707894519cc@redhat.com>
Message-ID: <027ff2c2-61a3-95f3-065e-9f102534a7b2@redhat.com>

Nevermind, failed in 32-bit JVM again. Sigh!

-Zhengyu


On 9/18/19 3:14 PM, Roman Kennke wrote:
> The locking in ShenandoahNMethodTable::register_nmethod() is dirty. I 
> would *very* much prefer to shuffle that code around to use scoped 
> lockers. It's also buggy, because there is an early return there, which 
> would miss the unlock. A way to do this would be to pull the disarm into 
> the if-else blocks, and put scope inside the if-else too.
> 
> Roman
> 
>> We have seen above assertion failures in shenandoah/jdk nightly tests 
>> periodically, especially after JDK-8230401.
>>
>> It actually became quite reproducible on my local machine with 
>> tier3_gc_shenandoah after JDK-8230401.
>>
>> The problem appears to be missing proper synchronization of metadata 
>> of newly registered nmethod.? Initially, I thought new nmethod is 
>> registered under CodeCahe_lock and concurrent codecache iteration 
>> always starts with acquiring CodeCache_lock lock. What I missed is 
>> that, the actual codecache iteration is done by worker thread, while 
>> the CodeCache_lock is acquired by VMThread. Therefore, it never 
>> establishes synchronization of newly created nmethod metadata 
>> (ShenandoahNMethod) between compiler thread (registering the nmethod) 
>> and worker thread (processing the nmethod).
>>
>> The solution is to always acquire per-nmethod lock when changing and 
>> iterating the metadata.
>>
>> Webrev: 
>> http://cr.openjdk.java.net/~zgu/shenandoah/assert_is_loader_alive/webrev.00/ 
>>
>>
>> Test:
>> ?? hotspot_gc_shenandoah (fastdebug and release)
>>
>> ?? hotspot_gc_shenandoah/tier3_gc_shenandoah (fastdebug) with 10+ 
>> iterations on my local machine and gotland respectively.
>>
>> Thanks,
>>
>> -Zhengyu
>>
>>

From rkennke at redhat.com  Thu Sep 19 14:20:24 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 19 Sep 2019 16:20:24 +0200
Subject: RFR: Merge upstream jdk-14+15
Message-ID: <85275a03-faf0-5b6e-5e16-4a66618b4dfb@redhat.com>

Let's merge up to last tag from upstream jdk14 from today, jdk-14+15. It 
includes yesterday's sfx and arraycopy fixes, so required some easy 
merges around those, otherwise clean.

Testing: hotspot_gc_shenandoah

http://cr.openjdk.java.net/~rkennke/upstream-jdk14-merge-2019-09-19/changes.txt

Ok?

Roman


From shade at redhat.com  Thu Sep 19 14:30:49 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 19 Sep 2019 16:30:49 +0200
Subject: RFR: Merge upstream jdk-14+15
In-Reply-To: <85275a03-faf0-5b6e-5e16-4a66618b4dfb@redhat.com>
References: <85275a03-faf0-5b6e-5e16-4a66618b4dfb@redhat.com>
Message-ID: <d2e21f82-d725-c7b1-9c9e-b45c3e5a6660@redhat.com>

On 9/19/19 4:20 PM, Roman Kennke wrote:
> Let's merge up to last tag from upstream jdk14 from today, jdk-14+15. It includes yesterday's sfx
> and arraycopy fixes, so required some easy merges around those, otherwise clean.
> 
> Testing: hotspot_gc_shenandoah
> 
> http://cr.openjdk.java.net/~rkennke/upstream-jdk14-merge-2019-09-19/changes.txt

OK, let's do it.

-- 
Thanks,
-Aleksey


From shade at redhat.com  Thu Sep 19 14:54:34 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 19 Sep 2019 16:54:34 +0200
Subject: RFR (S) 8231197: Shenandoah: JVMTI heap walking cleanup crashes with
 NULL forwardee
Message-ID: <48c5540a-7691-ae93-9a89-4d87f414a82e@redhat.com>

Bug:
  https://bugs.openjdk.java.net/browse/JDK-8231197

Fix:
  https://cr.openjdk.java.net/~shade/8231197/webrev.02/

This reliably reproduces with vmTestbase_nsk_jvmti. The reason is described in the comment there:
weird clash between JVMTI-own walk of heap and Shenandoah. ShenandoahCodeRoots assert also needs
relaxing, and I relaxed it only for JVMTI heap walk.

Testing: hotspot_gc_shenandoah, vmTestbase_nsk_jvmti

-- 
Thanks,
-Aleksey


From shade at redhat.com  Thu Sep 19 14:55:06 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 19 Sep 2019 16:55:06 +0200
Subject: RFR (S) 8231244: Shenandoah: all-roots heap walking misses some weak
 roots
Message-ID: <22183e57-1301-5a9d-dc23-66f433d2feee@redhat.com>

Bug:
  https://bugs.openjdk.java.net/browse/JDK-8231244

Fix:
  https://cr.openjdk.java.net/~shade/8231244/webrev.02/

This reliably reproduces with vmTestbase_nsk_jvmti. We miss some weak roots, apparently. New code
tries to match how ShenandoahRoot{Evacuator,Adjuster}::roots_do handle it.

Testing: hotspot_gc_shenandoah, vmTestbase_nsk_jvmti

-- 
Thanks,
-Aleksey


From shade at redhat.com  Thu Sep 19 14:54:59 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 19 Sep 2019 16:54:59 +0200
Subject: RFR (S) 8231198: Shenandoah: heap walking should visit all roots most
 of the time
Message-ID: <b2748f06-84b5-d919-ab13-670857f687b1@redhat.com>

Bug:
  https://bugs.openjdk.java.net/browse/JDK-8231198

Fix:
  https://cr.openjdk.java.net/~shade/8231198/webrev.01/

This reliably reproduces with vmTestbase_nsk_jvmti. We have to match the objects that we walk with
what JVMTI is doing there. Unfortunately, our current code sometimes discovers that unload_classes
is true, and so skips some weak roots, while JVMTI visits them. As the result, the marks for objects
in those weak roots is never reset, and we crash later. The easy way out is to avoid scanning weak
roots only when it matters: during evacuation.

Testing: hotspot_gc_shenandoah, vmTestbase_nsk_jvmti

-- 
Thanks,
-Aleksey


From zgu at redhat.com  Thu Sep 19 15:03:54 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Thu, 19 Sep 2019 11:03:54 -0400
Subject: RFR (S) 8231198: Shenandoah: heap walking should visit all roots
 most of the time
In-Reply-To: <b2748f06-84b5-d919-ab13-670857f687b1@redhat.com>
References: <b2748f06-84b5-d919-ab13-670857f687b1@redhat.com>
Message-ID: <5f5fa982-dbeb-0790-a35b-a92ef675840f@redhat.com>

Good.

-Zhengyu

On 9/19/19 10:54 AM, Aleksey Shipilev wrote:
> Bug:
>    https://bugs.openjdk.java.net/browse/JDK-8231198
> 
> Fix:
>    https://cr.openjdk.java.net/~shade/8231198/webrev.01/
> 
> This reliably reproduces with vmTestbase_nsk_jvmti. We have to match the objects that we walk with
> what JVMTI is doing there. Unfortunately, our current code sometimes discovers that unload_classes
> is true, and so skips some weak roots, while JVMTI visits them. As the result, the marks for objects
> in those weak roots is never reset, and we crash later. The easy way out is to avoid scanning weak
> roots only when it matters: during evacuation.
> 
> Testing: hotspot_gc_shenandoah, vmTestbase_nsk_jvmti
> 

From rkennke at redhat.com  Thu Sep 19 17:39:38 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 19 Sep 2019 19:39:38 +0200
Subject: RFR (S) 8231197: Shenandoah: JVMTI heap walking cleanup crashes
 with NULL forwardee
In-Reply-To: <48c5540a-7691-ae93-9a89-4d87f414a82e@redhat.com>
References: <48c5540a-7691-ae93-9a89-4d87f414a82e@redhat.com>
Message-ID: <d3c1a071-9147-8bbe-eef9-102a8ab03b33@redhat.com>

I think it's ok for now.

Long-term, the JVMTI heapwalking should be done by GC as well to ensure 
consistency. I can already spot some subtle bugs there concerning 
concurrent roots cleaning.

Roman


> Bug:
>    https://bugs.openjdk.java.net/browse/JDK-8231197
> 
> Fix:
>    https://cr.openjdk.java.net/~shade/8231197/webrev.02/
> 
> This reliably reproduces with vmTestbase_nsk_jvmti. The reason is described in the comment there:
> weird clash between JVMTI-own walk of heap and Shenandoah. ShenandoahCodeRoots assert also needs
> relaxing, and I relaxed it only for JVMTI heap walk.
> 
> Testing: hotspot_gc_shenandoah, vmTestbase_nsk_jvmti
> 

From rkennke at redhat.com  Thu Sep 19 17:41:06 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 19 Sep 2019 19:41:06 +0200
Subject: RFR (S) 8231198: Shenandoah: heap walking should visit all roots
 most of the time
In-Reply-To: <b2748f06-84b5-d919-ab13-670857f687b1@redhat.com>
References: <b2748f06-84b5-d919-ab13-670857f687b1@redhat.com>
Message-ID: <acdded41-6344-0c98-b046-1ffc45d4fe7e@redhat.com>

That makes sense. ok. For the same reason described in JDK-8231197, 
JVMTI should not actually do heapwalking of its own.

Roman


> Bug:
>    https://bugs.openjdk.java.net/browse/JDK-8231198
> 
> Fix:
>    https://cr.openjdk.java.net/~shade/8231198/webrev.01/
> 
> This reliably reproduces with vmTestbase_nsk_jvmti. We have to match the objects that we walk with
> what JVMTI is doing there. Unfortunately, our current code sometimes discovers that unload_classes
> is true, and so skips some weak roots, while JVMTI visits them. As the result, the marks for objects
> in those weak roots is never reset, and we crash later. The easy way out is to avoid scanning weak
> roots only when it matters: during evacuation.
> 
> Testing: hotspot_gc_shenandoah, vmTestbase_nsk_jvmti
> 

From rkennke at redhat.com  Thu Sep 19 17:41:27 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 19 Sep 2019 19:41:27 +0200
Subject: RFR (S) 8231244: Shenandoah: all-roots heap walking misses some
 weak roots
In-Reply-To: <22183e57-1301-5a9d-dc23-66f433d2feee@redhat.com>
References: <22183e57-1301-5a9d-dc23-66f433d2feee@redhat.com>
Message-ID: <4d0ec821-d94f-3eba-7b77-62a87b73cba8@redhat.com>

Looks good. Thanks!

Roman


> Bug:
>    https://bugs.openjdk.java.net/browse/JDK-8231244
> 
> Fix:
>    https://cr.openjdk.java.net/~shade/8231244/webrev.02/
> 
> This reliably reproduces with vmTestbase_nsk_jvmti. We miss some weak roots, apparently. New code
> tries to match how ShenandoahRoot{Evacuator,Adjuster}::roots_do handle it.
> 
> Testing: hotspot_gc_shenandoah, vmTestbase_nsk_jvmti
> 

From rkennke at redhat.com  Thu Sep 19 17:41:04 2019
From: rkennke at redhat.com (rkennke at redhat.com)
Date: Thu, 19 Sep 2019 17:41:04 +0000
Subject: hg: shenandoah/jdk: 267 new changesets
Message-ID: <201909191741.x8JHfUMb006574@aojmv0008.oracle.com>

Changeset: 425412369353
Author:    rriggs
Date:      2019-08-21 16:19 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/425412369353

8207814: (proxy) upgrade the proxy class generator
Reviewed-by: mchung

! src/java.base/share/classes/java/lang/reflect/Method.java
! src/java.base/share/classes/java/lang/reflect/Proxy.java
! src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java
+ src/java.base/share/classes/java/lang/reflect/ProxyGenerator_v49.java
+ test/jdk/java/lang/reflect/Proxy/ProxyGeneratorCombo.java
+ test/micro/org/openjdk/bench/java/lang/reflect/Proxy/ProxyBench.java
+ test/micro/org/openjdk/bench/java/lang/reflect/Proxy/ProxyPerf.java

Changeset: 35db8fba55f9
Author:    kbarrett
Date:      2019-08-21 18:42 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/35db8fba55f9

8227054: ServiceThread needs to know about all OopStorage objects
8227053: ServiceThread cleanup of OopStorage is missing some
Summary: OopStorages provides named access and iteration.
Reviewed-by: eosterlund, pliden, coleenp

! src/hotspot/share/classfile/stringTable.cpp
! src/hotspot/share/classfile/stringTable.hpp
! src/hotspot/share/classfile/systemDictionary.cpp
! src/hotspot/share/classfile/systemDictionary.hpp
! src/hotspot/share/gc/shared/oopStorageParState.hpp
+ src/hotspot/share/gc/shared/oopStorageSet.cpp
+ src/hotspot/share/gc/shared/oopStorageSet.hpp
! src/hotspot/share/gc/shared/weakProcessor.cpp
! src/hotspot/share/gc/shared/weakProcessor.inline.hpp
! src/hotspot/share/gc/shared/weakProcessorPhaseTimes.cpp
! src/hotspot/share/gc/shared/weakProcessorPhaseTimes.hpp
! src/hotspot/share/gc/shared/weakProcessorPhases.cpp
! src/hotspot/share/gc/shared/weakProcessorPhases.hpp
! src/hotspot/share/gc/z/zRootsIterator.cpp
! src/hotspot/share/jvmci/jvmci.cpp
! src/hotspot/share/jvmci/jvmci.hpp
! src/hotspot/share/memory/universe.cpp
! src/hotspot/share/oops/weakHandle.cpp
! src/hotspot/share/prims/resolvedMethodTable.cpp
! src/hotspot/share/prims/resolvedMethodTable.hpp
! src/hotspot/share/runtime/init.cpp
! src/hotspot/share/runtime/jniHandles.cpp
! src/hotspot/share/runtime/jniHandles.hpp
! src/hotspot/share/runtime/mutexLocker.cpp
! src/hotspot/share/runtime/mutexLocker.hpp
! src/hotspot/share/runtime/serviceThread.cpp
+ test/hotspot/gtest/gc/shared/test_oopStorageSet.cpp
! test/hotspot/jtreg/gc/g1/TestGCLogMessages.java

Changeset: 58891103f9cc
Author:    kbarrett
Date:      2019-08-21 19:21 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/58891103f9cc

8189633: Missing -Xcheck:jni checking for DeleteWeakGlobalRef
Summary: Added validity check on the handle before deleting it.
Reviewed-by: dholmes, dcubed

! src/hotspot/share/prims/jniCheck.cpp

Changeset: 26ada504269a
Author:    jwilhelm
Date:      2019-08-22 02:05 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/26ada504269a

Added tag jdk-14+11 for changeset bf4c808a4488

! .hgtags

Changeset: d41c18a68257
Author:    kvn
Date:      2019-08-21 18:03 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/d41c18a68257

8229848: [Graal] missing Graal intrinsics for Electronic Code Book (ECB) encryption
Summary: new intrinsics were added to Graal test
Reviewed-by: dlong

! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java

Changeset: da4cf75505a7
Author:    ngasson
Date:      2019-08-22 10:53 +0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/da4cf75505a7

8229912: [TESTBUG] java/net/Socks/SocksIPv6Test fails without IPv6
Reviewed-by: alanb, dfuchs

! test/jdk/java/net/Socks/SocksIPv6Test.java

Changeset: 3283cff319c8
Author:    thartmann
Date:      2019-08-22 12:22 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/3283cff319c8

8230020: [BACKOUT] compiler/types/correctness/* tests fail with "assert(recv == __null || recv->is_klass()) failed: wrong type"
Summary: Back out JDK-8225670 due to performance regressions.
Reviewed-by: roland

! src/hotspot/share/ci/ciMethodData.cpp
! test/hotspot/jtreg/ProblemList.txt

Changeset: e686b661fa05
Author:    thartmann
Date:      2019-08-22 12:24 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/e686b661fa05

8224624: Inefficiencies in CodeStrings::add_comment cause timeouts
Summary: Changing CodeStrings to a doubly-linked-list and searching for the comment with the right offset in reverse.
Reviewed-by: kvn

! src/hotspot/share/asm/codeBuffer.cpp
! src/hotspot/share/asm/codeBuffer.hpp

Changeset: c2bc7b07c67a
Author:    rehn
Date:      2019-08-22 12:46 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/c2bc7b07c67a

8229967: Enable thread local handshakes on zero
Reviewed-by: sgehwolf, shade

! src/hotspot/cpu/zero/globalDefinitions_zero.hpp
! src/hotspot/cpu/zero/globals_zero.hpp

Changeset: e70dec4229e9
Author:    shade
Date:      2019-08-22 13:47 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/e70dec4229e9

8230024: Shenandoah: remove unnecessary ShenandoahTimingConverter
Reviewed-by: rkennke, zgu

! src/hotspot/share/gc/shenandoah/shenandoahUtils.cpp
! src/hotspot/share/gc/shenandoah/shenandoahUtils.hpp

Changeset: 2227a0cfd6b3
Author:    shade
Date:      2019-08-22 13:47 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/2227a0cfd6b3

8229998: Build failure after JDK-8227054
Reviewed-by: rkennke, zgu

! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp

Changeset: 78844dceede6
Author:    michaelm
Date:      2019-08-22 14:36 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/78844dceede6

8199849: Add support for UTF-8 encoded credentials in HTTP Basic Authentication
Reviewed-by: chegar, dfuchs

! src/java.base/share/classes/sun/net/www/protocol/http/BasicAuthentication.java
! src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java
! src/java.net.http/share/classes/jdk/internal/net/http/AuthenticationFilter.java
! src/jdk.httpserver/share/classes/com/sun/net/httpserver/BasicAuthenticator.java
+ test/jdk/com/sun/net/httpserver/bugs/8199849/BasicAuthenticatorCharset.java
+ test/jdk/com/sun/net/httpserver/bugs/8199849/ParamTest.java
+ test/jdk/com/sun/net/httpserver/bugs/8199849/TestHttpUnicode.java

Changeset: de0ccdc4db13
Author:    mdoerr
Date:      2019-08-22 15:52 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/de0ccdc4db13

8229925: [s390, PPC64] Exception check missing in interpreter
Reviewed-by: dholmes, rrich

! src/hotspot/cpu/ppc/interp_masm_ppc_64.cpp
! src/hotspot/cpu/s390/interp_masm_s390.cpp

Changeset: 4863a802a7c1
Author:    coleenp
Date:      2019-08-22 09:51 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/4863a802a7c1

8230003: Make Monitor inherit from Mutex
Summary: Reverse inheritance that makes more sense.
Reviewed-by: dholmes, rehn, pchilanomate

! src/hotspot/share/compiler/compileBroker.cpp
! src/hotspot/share/jfr/recorder/repository/jfrEmergencyDump.cpp
! src/hotspot/share/logging/logTag.hpp
! src/hotspot/share/runtime/interfaceSupport.inline.hpp
! src/hotspot/share/runtime/mutex.cpp
! src/hotspot/share/runtime/mutex.hpp
! src/hotspot/share/runtime/mutexLocker.cpp
! src/hotspot/share/runtime/mutexLocker.hpp
! src/hotspot/share/runtime/thread.cpp
! src/hotspot/share/runtime/thread.hpp

Changeset: 0094711309c3
Author:    coleenp
Date:      2019-08-22 09:53 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/0094711309c3

Merge


Changeset: abf6ee4c477c
Author:    lancea
Date:      2019-08-22 10:43 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/abf6ee4c477c

8229887: (zipfs) zip file corruption when replacing an existing STORED entry
Reviewed-by: alanb, redestad, dfuchs

! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java
+ test/jdk/jdk/nio/zipfs/UpdateEntryTest.java

Changeset: d6a422987d86
Author:    mseledtsov
Date:      2019-08-22 10:35 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/d6a422987d86

8226779: [TESTBUG] Test JFR API from Java agent
Summary: Created new tests for JFR plus Java Agent
Reviewed-by: egahlin

+ test/jdk/jdk/jfr/javaagent/EventEmitterAgent.java
+ test/jdk/jdk/jfr/javaagent/JavaAgentBuilder.java
+ test/jdk/jdk/jfr/javaagent/TestLoadedAgent.java
+ test/jdk/jdk/jfr/javaagent/TestPremainAgent.java

Changeset: 3bc26ffdf001
Author:    lmesnik
Date:      2019-08-22 10:40 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/3bc26ffdf001

8229957: Harden pid verification in attach mechanism
Reviewed-by: sspitsyn, ysuenaga, sgehwolf

! src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java
! src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java
! src/jdk.attach/macosx/classes/sun/tools/attach/VirtualMachineImpl.java
! src/jdk.attach/solaris/classes/sun/tools/attach/VirtualMachineImpl.java
+ test/hotspot/jtreg/serviceability/attach/AttachNegativePidTest.java

Changeset: db6829c1cc3a
Author:    lmesnik
Date:      2019-08-22 10:41 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/db6829c1cc3a

Merge


Changeset: 01d9a1cff83a
Author:    aefimov
Date:      2019-08-22 18:54 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/01d9a1cff83a

8078219: Verify lack of @test tag in files in java/net test directory
Reviewed-by: alanb
Contributed-by: Patrick Concannon <patrick.concannon at oracle.com>

! test/jdk/java/net/MulticastSocket/MulticastAddresses.java
! test/jdk/java/net/MulticastSocket/Reuse.java
! test/jdk/java/net/URLClassLoader/GetURLsTest.java

Changeset: bc14eec6f4bc
Author:    shade
Date:      2019-08-22 20:22 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/bc14eec6f4bc

8230046: Build failure after JDK-8230003
Reviewed-by: zgu, coleenp

! src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp
! src/hotspot/share/gc/shenandoah/shenandoahAsserts.hpp

Changeset: e1269de19aa5
Author:    jnimeh
Date:      2019-08-22 14:09 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/e1269de19aa5

8225436: Stapled OCSPResponses should be added to PKIXRevocationChecker irrespective of revocationEnabled flag
Reviewed-by: mullan

! src/java.base/share/classes/sun/security/validator/PKIXValidator.java
+ test/jdk/sun/security/validator/PKIXValAndRevCheckTests.java

Changeset: b2b77f6922dc
Author:    pliden
Date:      2019-08-23 08:48 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/b2b77f6922dc

8227226: ZGC: Segmented array clearing
Reviewed-by: eosterlund
Contributed-by: stefan.karlsson at oracle.com, erik.osterlund at oracle.com, per.liden at oracle.com, sci at amazon.com

! src/hotspot/share/gc/shared/memAllocator.cpp
! src/hotspot/share/gc/shared/memAllocator.hpp
! src/hotspot/share/gc/z/zCollectedHeap.cpp
! src/hotspot/share/gc/z/zCollectedHeap.hpp
+ src/hotspot/share/gc/z/zObjArrayAllocator.cpp
+ src/hotspot/share/gc/z/zObjArrayAllocator.hpp

Changeset: 6728c41f2a08
Author:    pliden
Date:      2019-08-23 08:48 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/6728c41f2a08

8229451: ZGC: Make some roots invisible to the heap iterator
Reviewed-by: eosterlund

! src/hotspot/share/gc/shared/gcThreadLocalData.hpp
! src/hotspot/share/gc/z/zHeapIterator.cpp
! src/hotspot/share/gc/z/zMark.cpp
! src/hotspot/share/gc/z/zObjArrayAllocator.cpp
! src/hotspot/share/gc/z/zRelocate.cpp
! src/hotspot/share/gc/z/zRootsIterator.cpp
! src/hotspot/share/gc/z/zRootsIterator.hpp
! src/hotspot/share/gc/z/zThreadLocalData.hpp

Changeset: 92f994585e25
Author:    pliden
Date:      2019-08-23 08:48 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/92f994585e25

8229127: Make some methods in the allocation path non-virtual
Reviewed-by: eosterlund

! src/hotspot/share/gc/shared/collectedHeap.hpp
! src/hotspot/share/gc/shared/memAllocator.hpp

Changeset: 3029be26f9ea
Author:    neliasso
Date:      2019-08-23 10:11 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/3029be26f9ea

8228839: Non-CFG nodes have control edges to calls, instead of the call's control projection
Reviewed-by: kvn, thartmann

! src/hotspot/share/gc/z/c2/zBarrierSetC2.cpp

Changeset: 8b8d8a1621f2
Author:    neliasso
Date:      2019-08-23 10:11 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/8b8d8a1621f2

8229970: ZGC: C2: fixup_uses_in_catch may fail when expanding many uses
Reviewed-by: kvn, thartmann

! src/hotspot/share/gc/z/c2/zBarrierSetC2.cpp

Changeset: 00bf1e66de11
Author:    afarley
Date:      2019-08-23 03:06 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/00bf1e66de11

8227021: VM fails if any sun.boot.library.path paths are longer than JVM_MAXPATHLEN
Summary: The size of each path in sun.boot.library.path property should not exceed JVM_MAXPATHLEN
Reviewed-by: dholmes, coleenp, sspitsyn

! src/hotspot/share/runtime/os.cpp
! src/hotspot/share/runtime/os.hpp
+ test/hotspot/jtreg/runtime/LoadLibrary/TestSunBootLibraryPath.java

Changeset: cf45b7945e4b
Author:    dfuchs
Date:      2019-08-23 18:40 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/cf45b7945e4b

8229337: java.lang.Math class doc should be adjusted regarding -Exact methods
Reviewed-by: rriggs, bpb
Contributed-by: Julia Boes <julia.boes at oracle.com>

! src/java.base/share/classes/java/lang/Math.java

Changeset: c370cc1b2a86
Author:    joehw
Date:      2019-08-23 17:57 +0000
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/c370cc1b2a86

8229388: ErrorHandler and ContentHandler contain ambiguous/unfinished specification
Reviewed-by: lancea

! src/java.xml/share/classes/org/xml/sax/ContentHandler.java
! src/java.xml/share/classes/org/xml/sax/ErrorHandler.java

Changeset: 489b8e142559
Author:    iklam
Date:      2019-08-23 10:39 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/489b8e142559

8230011: Consolidate duplicated classpath parsing code in classLoader.cpp
Reviewed-by: ccheung, fparain

! src/hotspot/share/classfile/classLoader.cpp

Changeset: 1e85670cb9ee
Author:    rriggs
Date:      2019-08-23 14:04 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/1e85670cb9ee

8230058: Replace exception from sun.rmi.runtime.Log#getSource() with StackWalker
Reviewed-by: mchung, rriggs
Contributed-by: kustos at gmx.net

! src/java.rmi/share/classes/sun/rmi/runtime/Log.java

Changeset: 36f5e20be69a
Author:    dfuchs
Date:      2019-08-23 19:55 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/36f5e20be69a

8229485: Add decrementExact(), incrementExact(), and negateExact() to java.lang.StrictMath
Summary: three methods are added to StrictMath for consistency with Math. Tests are updated accordingly.
Reviewed-by: bpb, lancea, igerasim, dfuchs, joehw, rriggs
Contributed-by: Julia Boes <julia.boes at oracle.com>

! src/java.base/share/classes/java/lang/StrictMath.java
! test/jdk/java/lang/Math/ExactArithTests.java
! test/jdk/java/lang/StrictMath/ExactArithTests.java

Changeset: 7ae075afc72f
Author:    rriggs
Date:      2019-08-23 15:24 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/7ae075afc72f

8230104: JNU_IsInstanceOfByName needs const parameter
Reviewed-by: alanb, rriggs
Contributed-by: andrewluotechnologies at outlook.com

! src/java.base/share/native/libjava/jni_util.c
! src/java.base/share/native/libjava/jni_util.h

Changeset: 2d2c2428bf52
Author:    coleenp
Date:      2019-08-23 23:27 +0000
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/2d2c2428bf52

8230116: Test workaround to Klass::_class_loader_data sometimes NULL problem
Summary: This is a low frequency problem that we are seeing internally, this patch is mostly to rule out one theory.
Reviewed-by: dcubed

! src/hotspot/share/oops/klass.cpp

Changeset: 427b38332f20
Author:    stefank
Date:      2019-08-26 09:13 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/427b38332f20

8229836: Remove include of globals.hpp from allocation.hpp
Reviewed-by: coleenp, kbarrett

! src/hotspot/os/linux/gc/z/zNUMA_linux.cpp
! src/hotspot/os/linux/osContainer_linux.cpp
! src/hotspot/os_cpu/linux_x86/gc/z/zPhysicalMemoryBacking_linux_x86.cpp
! src/hotspot/share/code/vmreg.hpp
! src/hotspot/share/gc/cms/allocationStats.hpp
! src/hotspot/share/gc/g1/g1Analytics.cpp
! src/hotspot/share/gc/shared/gcOverheadChecker.hpp
! src/hotspot/share/gc/z/zValue.hpp
! src/hotspot/share/memory/allocation.hpp
! src/hotspot/share/memory/allocation.inline.hpp
! src/hotspot/share/memory/metaspace.hpp
! src/hotspot/share/oops/accessBackend.hpp
! src/hotspot/share/oops/markWord.hpp
! src/hotspot/share/oops/oopsHierarchy.hpp
! src/hotspot/share/runtime/perfMemory.hpp
! src/hotspot/share/utilities/globalDefinitions.cpp
! src/hotspot/share/utilities/virtualizationSupport.cpp
! test/hotspot/gtest/runtime/test_os_linux.cpp
! test/hotspot/gtest/utilities/test_globalDefinitions.cpp

Changeset: 30db6422848b
Author:    stefank
Date:      2019-08-26 09:15 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/30db6422848b

8224878: Use JVMFlag parameters instead of name strings
Reviewed-by: gziemski, dholmes, jrose

! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp
! src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp
! src/hotspot/share/prims/whitebox.cpp
! src/hotspot/share/runtime/arguments.cpp
! src/hotspot/share/runtime/flags/jvmFlag.cpp
! src/hotspot/share/runtime/flags/jvmFlag.hpp
! src/hotspot/share/runtime/flags/jvmFlagConstraintList.cpp
! src/hotspot/share/runtime/flags/jvmFlagConstraintList.hpp
! src/hotspot/share/runtime/flags/jvmFlagRangeList.cpp
! src/hotspot/share/runtime/flags/jvmFlagRangeList.hpp
! src/hotspot/share/runtime/globals_extension.hpp
! src/hotspot/share/services/attachListener.cpp
! src/hotspot/share/services/dtraceAttacher.cpp
! src/hotspot/share/services/management.cpp
! src/hotspot/share/services/writeableFlags.cpp

Changeset: eebdf6aa4907
Author:    michaelm
Date:      2019-08-26 11:46 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/eebdf6aa4907

8222363: Update ServerSocket.isBound spec to reflect implementation after close
Reviewed-by: dfuchs

! src/java.base/share/classes/java/net/ServerSocket.java

Changeset: 095c2f21dd10
Author:    michaelm
Date:      2019-08-26 12:25 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/095c2f21dd10

8177648: getResponseCode() throws IllegalArgumentException caused by protocol error while following redirect
Reviewed-by: michaelm, chegar, dfuchs
Contributed-by: jai.forums2013 at gmail.com

! src/java.base/share/classes/java/net/ProxySelector.java
! src/java.base/share/classes/sun/net/www/protocol/ftp/FtpURLConnection.java
! src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java
+ test/jdk/java/net/HttpURLConnection/HttpURLProxySelectionTest.java
+ test/jdk/sun/net/spi/DefaultProxySelectorTest.java

Changeset: ff08db52ad92
Author:    dfuchs
Date:      2019-08-26 14:48 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/ff08db52ad92

8230000: some httpclients testng tests run zero test
Summary: two tests needed to declared their test methods public, the last one was a simple abstract framework for subclasses and needed its @test keyword removed.
Reviewed-by: chegar, aefimov, dfuchs
Contributed-by: Julia Boes <julia.boes at oracle.com>

! test/jdk/java/net/httpclient/AbstractThrowingPushPromises.java
! test/jdk/java/net/httpclient/LineStreamsAndSurrogatesTest.java
! test/jdk/java/net/httpclient/LineSubscribersAndSurrogatesTest.java

Changeset: c414c554b38b
Author:    erikj
Date:      2019-08-26 07:14 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/c414c554b38b

8230079: Update test document by changing "TIMEOUT" to "TIMEOUT_FACTOR"
Reviewed-by: erikj
Contributed-by: Wang Xue <wangxue at loongson.cn>

! doc/building.html
! doc/testing.html
! doc/testing.md

Changeset: 85fbdb87baad
Author:    mbaesken
Date:      2019-08-14 15:07 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/85fbdb87baad

8229706: java/net/MulticastSocket/NoLoopbackPackets.java fails on some AIX machines
Reviewed-by: chegar, clanger

! test/jdk/java/net/MulticastSocket/NoLoopbackPackets.java

Changeset: cb836bd08d58
Author:    shade
Date:      2019-08-27 11:15 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/cb836bd08d58

8230214: AArch64 build failures after JDK-8229836 (Remove include of globals.hpp from allocation.hpp)
Reviewed-by: dholmes

! src/hotspot/os_cpu/linux_aarch64/gc/z/zPhysicalMemoryBacking_linux_aarch64.cpp

Changeset: 41b68dc5e0b9
Author:    jpai
Date:      2019-08-27 16:17 +0530
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/41b68dc5e0b9

8230220: java/net/HttpURLConnection/HttpURLProxySelectionTest.java fails intermittently
Summary: Fix the test to use volatile on members which are accessed across threads
Reviewed-by: dfuchs

! test/jdk/java/net/HttpURLConnection/HttpURLProxySelectionTest.java

Changeset: e6d7c5fbf09d
Author:    shade
Date:      2019-08-27 17:02 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/e6d7c5fbf09d

8230215: MacOS debug build is broken after JDK-8230003
Reviewed-by: zgu, mdoerr

! src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp
! src/hotspot/share/gc/shenandoah/shenandoahAsserts.hpp

Changeset: 6bb824c45df1
Author:    kbarrett
Date:      2019-08-27 11:05 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/6bb824c45df1

8230192: Rename G1RedirtyCardsBufferList to G1BufferNodeList
Summary: Rename class and move to new files.
Reviewed-by: sjohanss, lkorinth

+ src/hotspot/share/gc/g1/g1BufferNodeList.cpp
+ src/hotspot/share/gc/g1/g1BufferNodeList.hpp
! src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp
! src/hotspot/share/gc/g1/g1RedirtyCardsQueue.cpp
! src/hotspot/share/gc/g1/g1RedirtyCardsQueue.hpp

Changeset: 460f412c1358
Author:    eosterlund
Date:      2019-08-27 16:35 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/460f412c1358

8219708: Stop flushing OSR nmethods earlier in the sweeper
Reviewed-by: neliasso, thartmann

! src/hotspot/share/runtime/sweeper.cpp

Changeset: fb6cd98e4dec
Author:    shade
Date:      2019-08-27 19:22 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/fb6cd98e4dec

8230118: 32-bit build failures after JDK-8227054
Reviewed-by: zgu, kbarrett

! src/hotspot/share/gc/shared/weakProcessor.cpp

Changeset: 49fea19f0726
Author:    pchilanomate
Date:      2019-08-27 20:10 +0000
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/49fea19f0726

8229844: Remove attempt_rebias parameter from revoke_and_rebias()
Summary: Removed attempt_rebias parameter and merged fast_enter() and slow_enter() into enter()
Reviewed-by: dholmes, rehn, coleenp, dcubed

! src/hotspot/cpu/aarch64/aarch64.ad
! src/hotspot/cpu/sparc/macroAssembler_sparc.cpp
! src/hotspot/cpu/x86/macroAssembler_x86.cpp
! src/hotspot/share/c1/c1_Runtime1.cpp
! src/hotspot/share/interpreter/interpreterRuntime.cpp
! src/hotspot/share/jvmci/jvmciRuntime.cpp
! src/hotspot/share/prims/jvmtiEnvBase.cpp
! src/hotspot/share/runtime/biasedLocking.cpp
! src/hotspot/share/runtime/biasedLocking.hpp
! src/hotspot/share/runtime/deoptimization.cpp
! src/hotspot/share/runtime/sharedRuntime.cpp
! src/hotspot/share/runtime/synchronizer.cpp
! src/hotspot/share/runtime/synchronizer.hpp
! test/hotspot/gtest/oops/test_markOop.cpp

Changeset: 01b9c26e2651
Author:    redestad
Date:      2019-08-27 22:26 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/01b9c26e2651

8228507: Archive FDBigInteger
Reviewed-by: jiangli, bpb

! make/jdk/src/classes/build/tools/classlist/HelloClasslist.java
! src/hotspot/share/memory/heapShared.cpp
! src/java.base/share/classes/jdk/internal/math/FDBigInteger.java
! src/java.base/share/classes/jdk/internal/math/FloatingDecimal.java

Changeset: 82a71d82e326
Author:    igerasim
Date:      2019-08-27 14:44 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/82a71d82e326

8226831: Use Objects.equals() when appropriate
Reviewed-by: rriggs, bpb

! src/java.base/share/classes/java/net/InterfaceAddress.java
! src/java.base/share/classes/java/net/URLStreamHandler.java
! src/java.base/share/classes/java/text/AttributedString.java
! src/java.base/share/classes/java/util/TreeMap.java
! src/java.base/share/classes/java/util/TreeSet.java
! src/java.base/share/classes/sun/net/www/protocol/ftp/Handler.java
! src/java.base/share/classes/sun/security/x509/AlgorithmId.java

Changeset: 48f52ad5a2c3
Author:    fyuan
Date:      2019-08-28 11:00 +0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/48f52ad5a2c3

8230010: Remove jdk8037819/BasicTest1.java
8230002: javax/xml/jaxp/unittest/transform/SecureProcessingTest.java runs zero test
Reviewed-by: joehw, vtewari

! test/jaxp/javax/xml/jaxp/unittest/transform/SecureProcessingTest.java
- test/jdk/javax/xml/jaxp/testng/validation/jdk8037819/BasicTest1.java

Changeset: e2e315f1aa63
Author:    iklam
Date:      2019-08-27 22:14 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/e2e315f1aa63

8230168: Use ClasspathStream for FileMapInfo::create_path_array
Reviewed-by: lfoltan, fparain

! src/hotspot/share/classfile/classLoader.cpp
! src/hotspot/share/memory/filemap.cpp
! src/hotspot/share/memory/filemap.hpp
+ src/hotspot/share/utilities/classpathStream.cpp
+ src/hotspot/share/utilities/classpathStream.hpp

Changeset: 5ddb746d45e0
Author:    iklam
Date:      2019-08-27 22:14 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/5ddb746d45e0

8227370: Remove SharedPathsMiscInfo
Reviewed-by: ccheung, jiangli

! src/hotspot/share/classfile/classLoader.cpp
! src/hotspot/share/classfile/classLoader.hpp
! src/hotspot/share/classfile/classLoaderExt.cpp
! src/hotspot/share/classfile/classLoaderExt.hpp
- src/hotspot/share/classfile/sharedPathsMiscInfo.cpp
- src/hotspot/share/classfile/sharedPathsMiscInfo.hpp
! src/hotspot/share/include/cds.h
! src/hotspot/share/memory/filemap.cpp
! src/hotspot/share/memory/filemap.hpp
! src/hotspot/share/prims/cdsoffsets.cpp
! test/hotspot/jtreg/runtime/cds/appcds/AppendClasspath.java
! test/hotspot/jtreg/runtime/cds/appcds/ClassPathAttr.java
+ test/hotspot/jtreg/runtime/cds/appcds/NonExistClasspath.java
! test/hotspot/jtreg/runtime/cds/appcds/SharedArchiveConsistency.java
! test/hotspot/jtreg/runtime/cds/appcds/TraceLongClasspath.java
+ test/hotspot/jtreg/runtime/cds/appcds/test-classes/CpAttr6.java

Changeset: 54845835747f
Author:    pliden
Date:      2019-08-28 09:50 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/54845835747f

8230090: ZGC: Introduce ZSyscall
Reviewed-by: stefank

+ src/hotspot/os/linux/gc/z/zSyscall_linux.cpp
+ src/hotspot/os/linux/gc/z/zSyscall_linux.hpp
! src/hotspot/os_cpu/linux_aarch64/gc/z/zBackingFile_linux_aarch64.cpp
+ src/hotspot/os_cpu/linux_aarch64/gc/z/zSyscall_linux_aarch64.hpp
! src/hotspot/os_cpu/linux_x86/gc/z/zBackingFile_linux_x86.cpp
+ src/hotspot/os_cpu/linux_x86/gc/z/zSyscall_linux_x86.hpp

Changeset: 0cd210d5cb9c
Author:    pliden
Date:      2019-08-28 09:50 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/0cd210d5cb9c

8230092: ZGC: Consolidate ZBackingFile, ZBackingPath and ZPhysicalMemoryBacking on Linux
Reviewed-by: stefank

! src/hotspot/os/linux/gc/z/zBackingFile_linux.cpp < src/hotspot/os_cpu/linux_x86/gc/z/zBackingFile_linux_x86.cpp
+ src/hotspot/os/linux/gc/z/zBackingFile_linux.hpp
+ src/hotspot/os/linux/gc/z/zBackingPath_linux.cpp
+ src/hotspot/os/linux/gc/z/zBackingPath_linux.hpp
+ src/hotspot/os/linux/gc/z/zPhysicalMemoryBacking_linux.cpp
+ src/hotspot/os/linux/gc/z/zPhysicalMemoryBacking_linux.hpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zBackingFile_linux_aarch64.cpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zBackingFile_linux_aarch64.hpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zBackingPath_linux_aarch64.cpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zBackingPath_linux_aarch64.hpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zPhysicalMemoryBacking_linux_aarch64.cpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zPhysicalMemoryBacking_linux_aarch64.hpp
- src/hotspot/os_cpu/linux_x86/gc/z/zBackingFile_linux_x86.hpp
- src/hotspot/os_cpu/linux_x86/gc/z/zBackingPath_linux_x86.cpp
- src/hotspot/os_cpu/linux_x86/gc/z/zBackingPath_linux_x86.hpp
- src/hotspot/os_cpu/linux_x86/gc/z/zPhysicalMemoryBacking_linux_x86.cpp
- src/hotspot/os_cpu/linux_x86/gc/z/zPhysicalMemoryBacking_linux_x86.hpp
! src/hotspot/share/gc/z/zPhysicalMemory.hpp

Changeset: 53ed0cf870b0
Author:    pliden
Date:      2019-08-28 09:50 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/53ed0cf870b0

8230096: ZGC: Remove unused ZObjectAllocator::_nworkers
Reviewed-by: stefank

! src/hotspot/share/gc/z/zHeap.cpp
! src/hotspot/share/gc/z/zObjectAllocator.cpp
! src/hotspot/share/gc/z/zObjectAllocator.hpp

Changeset: 5e2576c303a2
Author:    eosterlund
Date:      2019-08-28 11:19 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/5e2576c303a2

8229278: Improve hs_err location printing to assume less about GC internals
Reviewed-by: stefank, kbarrett

! src/hotspot/share/gc/epsilon/epsilonHeap.cpp
! src/hotspot/share/gc/epsilon/epsilonHeap.hpp
! src/hotspot/share/gc/g1/g1CollectedHeap.cpp
! src/hotspot/share/gc/g1/g1CollectedHeap.hpp
! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp
! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp
! src/hotspot/share/gc/shared/collectedHeap.hpp
! src/hotspot/share/gc/shared/genCollectedHeap.cpp
! src/hotspot/share/gc/shared/genCollectedHeap.hpp
+ src/hotspot/share/gc/shared/locationPrinter.cpp
+ src/hotspot/share/gc/shared/locationPrinter.hpp
+ src/hotspot/share/gc/shared/locationPrinter.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp
! src/hotspot/share/gc/z/zCollectedHeap.cpp
! src/hotspot/share/gc/z/zCollectedHeap.hpp
! src/hotspot/share/gc/z/zHeap.cpp
! src/hotspot/share/gc/z/zHeap.hpp
! src/hotspot/share/gc/z/zPage.hpp
! src/hotspot/share/gc/z/zPage.inline.hpp
! src/hotspot/share/oops/oop.cpp
! src/hotspot/share/oops/oop.hpp
! src/hotspot/share/runtime/os.cpp

Changeset: 4f38fcd65577
Author:    neliasso
Date:      2019-08-26 11:36 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/4f38fcd65577

8230091: Add verification of clean_catch_blocks
Reviewed-by: rbackman, kvn

! src/hotspot/share/gc/z/c2/zBarrierSetC2.cpp
! src/hotspot/share/gc/z/c2/zBarrierSetC2.hpp

Changeset: 55723932d06e
Author:    iklam
Date:      2019-08-28 07:41 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/55723932d06e

8230294: runtime/cds/appcds/ClassPathAttr.java failed with jar operation failed
Reviewed-by: lfoltan

+ test/hotspot/jtreg/runtime/cds/appcds/test-classes/cpattr6.mf

Changeset: e17f768b3b71
Author:    dcubed
Date:      2019-08-28 10:56 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/e17f768b3b71

8230184: rename, whitespace, indent and comments changes in preparation for lock free Monitor lists
Reviewed-by: kbarrett, dholmes

! src/hotspot/share/oops/instanceKlass.cpp
! src/hotspot/share/runtime/objectMonitor.hpp
! src/hotspot/share/runtime/serviceThread.cpp
! src/hotspot/share/runtime/synchronizer.cpp
! src/hotspot/share/runtime/synchronizer.hpp
! src/hotspot/share/runtime/thread.cpp
! src/hotspot/share/runtime/thread.hpp
! src/hotspot/share/runtime/vmStructs.cpp
! src/hotspot/share/runtime/vmStructs.hpp
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/ObjectMonitor.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/ObjectSynchronizer.java
! test/hotspot/gtest/runtime/test_synchronizer.cpp

Changeset: f080150a6a7e
Author:    dcubed
Date:      2019-08-28 12:53 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/f080150a6a7e

8230317: serviceability/sa/ClhsdbPrintStatics.java fails after 8230184
Reviewed-by: eosterlund

! test/hotspot/jtreg/serviceability/sa/ClhsdbPrintStatics.java

Changeset: d1a6f72e4aec
Author:    kbarrett
Date:      2019-08-28 14:06 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/d1a6f72e4aec

8230126: delay_to_keep_mmu can delay shutdown
Summary: Wait on CGC_lock instead of sleeping to provide the delay.
Reviewed-by: sangheki, sjohanss

! src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp
! src/hotspot/share/gc/g1/g1ConcurrentMarkThread.hpp

Changeset: 9c98f8788762
Author:    godin
Date:      2019-08-28 14:37 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/9c98f8788762

8215166: Remove unused G1PretouchAuxiliaryMemory option
Summary: Removed experimental option.
Reviewed-by: kbarrett

! src/hotspot/share/gc/g1/g1_globals.hpp

Changeset: 8570f22b9b6a
Author:    joehw
Date:      2019-08-28 19:02 +0000
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/8570f22b9b6a

8230094: CCE in createXMLEventWriter(Result) over an arbitrary XMLStreamWriter
Reviewed-by: lancea

! src/java.xml/share/classes/com/sun/xml/internal/stream/XMLOutputFactoryImpl.java
! src/java.xml/share/classes/com/sun/xml/internal/stream/writers/XMLEventWriterImpl.java
+ test/jaxp/javax/xml/jaxp/unittest/stream/XMLStreamWriterTest/CustomImplTest.java

Changeset: 97257da4ac8d
Author:    amenkov
Date:      2019-08-28 13:34 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/97257da4ac8d

8228554: Accessibility errors in jdwp-protocol.html
Reviewed-by: dholmes, sspitsyn

! make/jdk/src/classes/build/tools/jdwpgen/AbstractTypeListNode.java
! make/jdk/src/classes/build/tools/jdwpgen/AbstractTypeNode.java
! make/jdk/src/classes/build/tools/jdwpgen/AltNode.java
! make/jdk/src/classes/build/tools/jdwpgen/ConstantNode.java
! make/jdk/src/classes/build/tools/jdwpgen/ConstantSetNode.java
! make/jdk/src/classes/build/tools/jdwpgen/ErrorNode.java
! make/jdk/src/classes/build/tools/jdwpgen/ErrorSetNode.java
! make/jdk/src/classes/build/tools/jdwpgen/Node.java
! make/jdk/src/classes/build/tools/jdwpgen/RepeatNode.java
! make/jdk/src/classes/build/tools/jdwpgen/RootNode.java

Changeset: da87424384eb
Author:    mseledtsov
Date:      2019-08-28 15:15 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/da87424384eb

8230115: Problemlist JFR TestNetworkUtilization test
Summary: Added test to the problem list
Reviewed-by: dcubed

! test/jdk/ProblemList.txt

Changeset: edc00278955d
Author:    jiefu
Date:      2019-08-28 08:47 +0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/edc00278955d

8230228: [TESTBUG] Several runtime/ErrorHandling tests may fail on some platforms
Reviewed-by: coleenp, stuefe, mseledtsov

! test/hotspot/jtreg/runtime/ErrorHandling/BadNativeStackInErrorHandlingTest.java
! test/hotspot/jtreg/runtime/ErrorHandling/ErrorFileRedirectTest.java
! test/hotspot/jtreg/runtime/ErrorHandling/SafeFetchInErrorHandlingTest.java
! test/hotspot/jtreg/runtime/ErrorHandling/TimeoutInErrorHandlingTest.java

Changeset: 339af8e17cb3
Author:    jwilhelm
Date:      2019-08-29 02:54 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/339af8e17cb3

Added tag jdk-14+12 for changeset 8570f22b9b6a

! .hgtags

Changeset: 3da1848cc39b
Author:    darcy
Date:      2019-08-28 22:30 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/3da1848cc39b

8230074: Improve specification for {Math, StrictMath}.negateExact
Reviewed-by: bpb

! src/java.base/share/classes/java/lang/Math.java
! src/java.base/share/classes/java/lang/StrictMath.java

Changeset: ce786c3f1f1c
Author:    psadhukhan
Date:      2019-07-22 11:08 +0530
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/ce786c3f1f1c

Merge

- src/hotspot/share/gc/z/zOopClosures.cpp
- src/hotspot/share/jfr/leakprofiler/emitEventOperation.cpp
- src/hotspot/share/jfr/leakprofiler/emitEventOperation.hpp
- src/java.base/share/classes/jdk/internal/access/JavaNetSocketAccess.java
- src/java.base/share/classes/jdk/internal/access/JavaNetURLClassLoaderAccess.java
! test/jdk/ProblemList.txt
- test/jdk/sun/misc/ClassLoaderUtil/test.jar
- test/jdk/sun/security/tools/keytool/DefaultSignatureAlgorithm.java
- test/jdk/sun/security/tools/keytool/pss/PSS.java
- test/jdk/sun/security/tools/keytool/pss/java.base/sun/security/rsa/RSAKeyPairGenerator.java

Changeset: e28ccaff2f84
Author:    psadhukhan
Date:      2019-07-24 12:21 +0530
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/e28ccaff2f84

Merge

- src/java.base/share/classes/jdk/internal/reflect/LangReflectAccess.java
- src/jdk.javadoc/share/legal/pako.md
! test/jdk/ProblemList.txt

Changeset: 70865ef2afc7
Author:    psadhukhan
Date:      2019-07-24 12:49 +0530
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/70865ef2afc7

Merge


Changeset: b0aaa82a1b03
Author:    psadhukhan
Date:      2019-07-25 12:23 +0530
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/b0aaa82a1b03

Merge

! test/jdk/ProblemList.txt

Changeset: f95327be136a
Author:    akolarkunnu
Date:      2019-08-06 00:16 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/f95327be136a

8221312: test/jdk/sanity/client/SwingSet/src/ColorChooserDemoTest.java failed
Reviewed-by: serb, psadhukhan

! src/demo/share/jfc/SwingSet2/BezierAnimationPanel.java
! test/jdk/ProblemList.txt
! test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/colorchooser/BezierAnimationPanel.java

Changeset: 13178f7e75d5
Author:    lbourges
Date:      2019-08-07 10:25 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/13178f7e75d5

8228711: Path rendered incorrectly when it goes outside the clipping region
Summary: fixed closePath() to preserve last position and its outcode in Stroker and TransformingPathConsumer2D.PathClipFilter
Reviewed-by: prr, kcr

! src/java.desktop/share/classes/sun/java2d/marlin/DDasher.java
! src/java.desktop/share/classes/sun/java2d/marlin/DHelpers.java
! src/java.desktop/share/classes/sun/java2d/marlin/DStroker.java
! src/java.desktop/share/classes/sun/java2d/marlin/DTransformingPathConsumer2D.java
! src/java.desktop/share/classes/sun/java2d/marlin/Dasher.java
! src/java.desktop/share/classes/sun/java2d/marlin/Helpers.java
! src/java.desktop/share/classes/sun/java2d/marlin/Stroker.java
! src/java.desktop/share/classes/sun/java2d/marlin/TransformingPathConsumer2D.java
! src/java.desktop/share/classes/sun/java2d/marlin/Version.java
! test/jdk/sun/java2d/marlin/ClipShapeTest.java

Changeset: 020f8fab32e2
Author:    aivanov
Date:      2019-08-18 21:36 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/020f8fab32e2

8222108: Reduce minRefreshTime for updating remote printer list on Windows
Reviewed-by: prr, serb

! src/java.desktop/windows/classes/sun/print/PrintServiceLookupProvider.java
! test/jdk/java/awt/print/RemotePrinterStatusRefresh/RemotePrinterStatusRefresh.java

Changeset: 39f133168348
Author:    psadhukhan
Date:      2019-08-19 12:13 +0530
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/39f133168348

8226513: JEditorPane is shown with incorrect size
Reviewed-by: prr, psadhukhan
Contributed-by: semyon.sadetsky at oracle.com

! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java
+ test/jdk/javax/swing/JEditorPane/8226513/JEditorPaneLayoutTest.java

Changeset: e00a2d8a1016
Author:    dmarkov
Date:      2019-08-23 14:25 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/e00a2d8a1016

8225505: ctrl-F1 does not show the tooltip of a menu item (JMenuItems)
Reviewed-by: psadhukhan, serb

! src/java.desktop/share/classes/javax/swing/ToolTipManager.java
+ test/jdk/javax/swing/ToolTipManager/JMenuItemToolTipKeyBindingsTest/JMenuItemToolTipKeyBindingsTest.java

Changeset: c16208de74da
Author:    psadhukhan
Date:      2019-08-29 15:09 +0530
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/c16208de74da

Merge

- make/jdk/src/classes/build/tools/tzdb/ZoneRules.java
- src/hotspot/cpu/aarch64/aarch64_call.cpp
- src/hotspot/cpu/aarch64/aarch64_linkage.S
- src/hotspot/cpu/aarch64/cpustate_aarch64.hpp
- src/hotspot/cpu/aarch64/decode_aarch64.hpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zBackingFile_linux_aarch64.cpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zBackingFile_linux_aarch64.hpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zBackingPath_linux_aarch64.cpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zBackingPath_linux_aarch64.hpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zPhysicalMemoryBacking_linux_aarch64.cpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zPhysicalMemoryBacking_linux_aarch64.hpp
- src/hotspot/os_cpu/linux_aarch64/linux_aarch64.S
- src/hotspot/os_cpu/linux_x86/gc/z/zBackingFile_linux_x86.cpp
- src/hotspot/os_cpu/linux_x86/gc/z/zBackingFile_linux_x86.hpp
- src/hotspot/os_cpu/linux_x86/gc/z/zBackingPath_linux_x86.cpp
- src/hotspot/os_cpu/linux_x86/gc/z/zBackingPath_linux_x86.hpp
- src/hotspot/os_cpu/linux_x86/gc/z/zPhysicalMemoryBacking_linux_x86.cpp
- src/hotspot/os_cpu/linux_x86/gc/z/zPhysicalMemoryBacking_linux_x86.hpp
- src/hotspot/share/classfile/sharedPathsMiscInfo.cpp
- src/hotspot/share/classfile/sharedPathsMiscInfo.hpp
- src/hotspot/share/gc/parallel/gcTaskManager.cpp
- src/hotspot/share/gc/parallel/gcTaskManager.hpp
- src/hotspot/share/gc/parallel/gcTaskThread.cpp
- src/hotspot/share/gc/parallel/gcTaskThread.hpp
- src/hotspot/share/gc/parallel/pcTasks.cpp
- src/hotspot/share/gc/parallel/pcTasks.hpp
- src/hotspot/share/gc/parallel/psTasks.cpp
- src/hotspot/share/gc/parallel/psTasks.hpp
- src/hotspot/share/oops/markOop.cpp
- src/hotspot/share/oops/markOop.hpp
- src/hotspot/share/oops/markOop.inline.hpp
- src/java.base/share/classes/java/security/acl/Acl.java
- src/java.base/share/classes/java/security/acl/AclEntry.java
- src/java.base/share/classes/java/security/acl/AclNotFoundException.java
- src/java.base/share/classes/java/security/acl/Group.java
- src/java.base/share/classes/java/security/acl/LastOwnerException.java
- src/java.base/share/classes/java/security/acl/NotOwnerException.java
- src/java.base/share/classes/java/security/acl/Owner.java
- src/java.base/share/classes/java/security/acl/Permission.java
- src/java.base/share/classes/java/security/acl/package-info.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/ArchiveDoesNotExist.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/BootAppendTests.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/CdsDifferentCompactStrings.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/CdsDifferentObjectAlignment.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/CdsSameObjectAlignment.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/CheckDefaultArchiveFile.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/CheckSharingWithDefaultArchive.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/DumpSharedDictionary.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/DumpSymbolAndStringTable.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/LoadClass.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/MaxMetaspaceSize.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/NonBootLoaderClasses.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/PrintSharedArchiveAndExit.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/SharedArchiveFile.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/SharedBaseAddress.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/SharedStrings.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/SharedStringsDedup.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/SharedStringsRunAuto.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/SharedStringsWb.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/SharedSymbolTableBucketSize.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/SpaceUtilizationCheck.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/TestInterpreterMethodEntries.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/javax/annotation/processing/FilerException.jasm
- test/hotspot/jtreg/runtime/SharedArchiveFile/javax/sound/sampled/MyClass.jasm
- test/hotspot/jtreg/runtime/SharedArchiveFile/nonjdk/myPackage/MyClass.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/serviceability/ReplaceCriticalClasses.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/serviceability/ReplaceCriticalClassesForSubgraphs.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/serviceability/transformRelatedClasses/Implementor.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/serviceability/transformRelatedClasses/Interface.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/serviceability/transformRelatedClasses/SubClass.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/serviceability/transformRelatedClasses/SuperClazz.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/serviceability/transformRelatedClasses/TestEntry.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/serviceability/transformRelatedClasses/TransformInterfaceAndImplementor.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/serviceability/transformRelatedClasses/TransformRelatedClasses.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/serviceability/transformRelatedClasses/TransformSuperAndSubClasses.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/serviceability/transformRelatedClasses/TransformSuperSubTwoPckgs.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/serviceability/transformRelatedClasses/TransformTestCommon.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/serviceability/transformRelatedClasses/myPkg1/SuperClazz.java
- test/hotspot/jtreg/runtime/SharedArchiveFile/serviceability/transformRelatedClasses/myPkg2/SubClass.java
- test/hotspot/jtreg/runtime/appcds/AppCDSOptions.java
- test/hotspot/jtreg/runtime/appcds/AppendClasspath.java
- test/hotspot/jtreg/runtime/appcds/BootClassPathMismatch.java
- test/hotspot/jtreg/runtime/appcds/CDSandJFR.java
- test/hotspot/jtreg/runtime/appcds/CaseSensitiveClassPath.java
- test/hotspot/jtreg/runtime/appcds/ClassLoaderTest.java
- test/hotspot/jtreg/runtime/appcds/ClassPathAttr.java
- test/hotspot/jtreg/runtime/appcds/CommandLineFlagCombo.java
- test/hotspot/jtreg/runtime/appcds/CommandLineFlagComboNegative.java
- test/hotspot/jtreg/runtime/appcds/CompilerUtils.java
- test/hotspot/jtreg/runtime/appcds/DirClasspathTest.java
- test/hotspot/jtreg/runtime/appcds/DumpClassList.java
- test/hotspot/jtreg/runtime/appcds/ExtraSymbols.invalid_1.txt
- test/hotspot/jtreg/runtime/appcds/ExtraSymbols.invalid_2.txt
- test/hotspot/jtreg/runtime/appcds/ExtraSymbols.invalid_3.txt
- test/hotspot/jtreg/runtime/appcds/ExtraSymbols.java
- test/hotspot/jtreg/runtime/appcds/ExtraSymbols.symbols.txt
- test/hotspot/jtreg/runtime/appcds/FieldAnnotationsTest.java
- test/hotspot/jtreg/runtime/appcds/FreeUnusedMetadata.java
- test/hotspot/jtreg/runtime/appcds/GraalWithLimitedMetaspace.java
- test/hotspot/jtreg/runtime/appcds/HelloExtTest.java
- test/hotspot/jtreg/runtime/appcds/HelloTest.java
- test/hotspot/jtreg/runtime/appcds/IgnoreEmptyClassPaths.java
- test/hotspot/jtreg/runtime/appcds/JarBuilder.java
- test/hotspot/jtreg/runtime/appcds/JvmtiAddPath.java
- test/hotspot/jtreg/runtime/appcds/LongClassListPath.java
- test/hotspot/jtreg/runtime/appcds/LotsOfClasses.java
- test/hotspot/jtreg/runtime/appcds/MissingSuperTest.java
- test/hotspot/jtreg/runtime/appcds/MoveJDKTest.java
- test/hotspot/jtreg/runtime/appcds/MultiProcessSharing.java
- test/hotspot/jtreg/runtime/appcds/MultiReleaseJars.java
- test/hotspot/jtreg/runtime/appcds/OldClassTest.java
- test/hotspot/jtreg/runtime/appcds/PackageSealing.java
- test/hotspot/jtreg/runtime/appcds/ParallelLoad2.java
- test/hotspot/jtreg/runtime/appcds/ParallelLoadTest.java
- test/hotspot/jtreg/runtime/appcds/PrintSharedArchiveAndExit.java
- test/hotspot/jtreg/runtime/appcds/ProhibitedPackage.java
- test/hotspot/jtreg/runtime/appcds/ProtectionDomain.java
- test/hotspot/jtreg/runtime/appcds/RelativePath.java
- test/hotspot/jtreg/runtime/appcds/RewriteBytecodesTest.java
- test/hotspot/jtreg/runtime/appcds/SharedArchiveConsistency.java
- test/hotspot/jtreg/runtime/appcds/SharedBaseAddress.java
- test/hotspot/jtreg/runtime/appcds/SharedPackages.java
- test/hotspot/jtreg/runtime/appcds/SignedJar.java
- test/hotspot/jtreg/runtime/appcds/SpecifySysLoaderProp.java
- test/hotspot/jtreg/runtime/appcds/TestCommon.java
- test/hotspot/jtreg/runtime/appcds/TestWithProfiler.java
- test/hotspot/jtreg/runtime/appcds/TraceLongClasspath.java
- test/hotspot/jtreg/runtime/appcds/UnusedCPDuringDump.java
- test/hotspot/jtreg/runtime/appcds/UseAppCDS_Test.java
- test/hotspot/jtreg/runtime/appcds/VerifierTest.java
- test/hotspot/jtreg/runtime/appcds/VerifierTest_0.java
- test/hotspot/jtreg/runtime/appcds/VerifierTest_1A.java
- test/hotspot/jtreg/runtime/appcds/VerifierTest_1B.java
- test/hotspot/jtreg/runtime/appcds/VerifierTest_2.java
- test/hotspot/jtreg/runtime/appcds/WideIloadTest.java
- test/hotspot/jtreg/runtime/appcds/WrongClasspath.java
- test/hotspot/jtreg/runtime/appcds/XShareAutoWithChangedJar.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/ArchivedIntegerCacheTest.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/ArchivedModuleComboTest.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/ArchivedModuleCompareTest.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/ArchivedModuleWithCustomImageTest.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/CheckArchivedModuleApp.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/CheckCachedMirrorApp.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/CheckCachedMirrorTest.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/CheckCachedResolvedReferences.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/CheckCachedResolvedReferencesApp.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/CheckIntegerCacheApp.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/DifferentHeapSizes.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/DumpTimeVerifyFailure.config.txt
- test/hotspot/jtreg/runtime/appcds/cacheObject/DumpTimeVerifyFailure.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/GCStress.config.txt
- test/hotspot/jtreg/runtime/appcds/cacheObject/GCStressApp.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/GCStressTest.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/InstrumentationAgent.mf
- test/hotspot/jtreg/runtime/appcds/cacheObject/MirrorWithReferenceFieldsApp.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/MirrorWithReferenceFieldsTest.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/MyException.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/MyOuter.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/OpenArchiveRegion.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/PrimitiveTypesApp.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/PrimitiveTypesTest.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/PrintSystemModulesApp.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/RedefineClassApp.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/RedefineClassTest.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/src/test/jdk/test/Test.java
- test/hotspot/jtreg/runtime/appcds/cacheObject/src/test/module-info.java
- test/hotspot/jtreg/runtime/appcds/cdsutils/DynamicDumpHelper.java
- test/hotspot/jtreg/runtime/appcds/condy/CondyHello.jasm
- test/hotspot/jtreg/runtime/appcds/condy/CondyHelloApp.java
- test/hotspot/jtreg/runtime/appcds/condy/CondyHelloTest.java
- test/hotspot/jtreg/runtime/appcds/customLoader/ClassListFormatA.java
- test/hotspot/jtreg/runtime/appcds/customLoader/ClassListFormatB.java
- test/hotspot/jtreg/runtime/appcds/customLoader/ClassListFormatBase.java
- test/hotspot/jtreg/runtime/appcds/customLoader/ClassListFormatC.java
- test/hotspot/jtreg/runtime/appcds/customLoader/ClassListFormatD.java
- test/hotspot/jtreg/runtime/appcds/customLoader/ClassListFormatE.java
- test/hotspot/jtreg/runtime/appcds/customLoader/CustomLoaderApp.java
- test/hotspot/jtreg/runtime/appcds/customLoader/HelloCustom.java
- test/hotspot/jtreg/runtime/appcds/customLoader/HelloCustom_JFR.java
- test/hotspot/jtreg/runtime/appcds/customLoader/LoaderSegregationTest.java
- test/hotspot/jtreg/runtime/appcds/customLoader/ParallelTestBase.java
- test/hotspot/jtreg/runtime/appcds/customLoader/ParallelTestMultiFP.java
- test/hotspot/jtreg/runtime/appcds/customLoader/ParallelTestSingleFP.java
- test/hotspot/jtreg/runtime/appcds/customLoader/ProhibitedPackageNamesTest.java
- test/hotspot/jtreg/runtime/appcds/customLoader/ProtectionDomain.java
- test/hotspot/jtreg/runtime/appcds/customLoader/SameNameInTwoLoadersTest.java
- test/hotspot/jtreg/runtime/appcds/customLoader/UnintendedLoadersTest.java
- test/hotspot/jtreg/runtime/appcds/customLoader/UnloadUnregisteredLoaderTest.java
- test/hotspot/jtreg/runtime/appcds/customLoader/UnsupportedPlatforms.java
- test/hotspot/jtreg/runtime/appcds/customLoader/test-classes/CustomInterface2_ia.java
- test/hotspot/jtreg/runtime/appcds/customLoader/test-classes/CustomInterface2_ib.java
- test/hotspot/jtreg/runtime/appcds/customLoader/test-classes/CustomLoadee.java
- test/hotspot/jtreg/runtime/appcds/customLoader/test-classes/CustomLoadee2.java
- test/hotspot/jtreg/runtime/appcds/customLoader/test-classes/CustomLoadee3.java
- test/hotspot/jtreg/runtime/appcds/customLoader/test-classes/CustomLoadee3Child.java
- test/hotspot/jtreg/runtime/appcds/customLoader/test-classes/Hello.java
- test/hotspot/jtreg/runtime/appcds/customLoader/test-classes/HelloUnload.java
- test/hotspot/jtreg/runtime/appcds/customLoader/test-classes/InProhibitedPkg.java
- test/hotspot/jtreg/runtime/appcds/customLoader/test-classes/LoaderAPI.mf
- test/hotspot/jtreg/runtime/appcds/customLoader/test-classes/LoaderSegregation.java
- test/hotspot/jtreg/runtime/appcds/customLoader/test-classes/OnlyBuiltin.java
- test/hotspot/jtreg/runtime/appcds/customLoader/test-classes/OnlyUnregistered.java
- test/hotspot/jtreg/runtime/appcds/customLoader/test-classes/ProtDomain.java
- test/hotspot/jtreg/runtime/appcds/customLoader/test-classes/SameNameUnrelatedLoaders.java
- test/hotspot/jtreg/runtime/appcds/customLoader/test-classes/SimpleHello.java
- test/hotspot/jtreg/runtime/appcds/customLoader/test-classes/UnintendedLoaders.java
- test/hotspot/jtreg/runtime/appcds/customLoader/test-classes/UnloadUnregisteredLoader.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/AppendClasspath.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/ArchiveConsistency.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/ArrayKlasses.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/ClassResolutionFailure.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/DynamicArchiveTestBase.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/DynamicFlag.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/DynamicLotsOfClasses.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/ExcludedClasses.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/HelloDynamic.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/HelloDynamicCustom.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/HelloDynamicCustomUnload.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/JITInteraction.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/MainModuleOnly.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/MethodSorting.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/MissingArchive.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/NoClassToArchive.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/RelativePath.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/SharedArchiveFileOption.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/UnsupportedBaseArchive.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/UnusedCPDuringDump.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/WrongTopClasspath.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/test-classes/ArrayKlassesApp.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/test-classes/ExcludedClassesApp.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/test-classes/LoadClasses.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/test-classes/MethodSortingApp.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/test-classes/MissingDependent.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/test-classes/StrConcatApp.java
- test/hotspot/jtreg/runtime/appcds/dynamicArchive/test-classes/TestJIT.java
- test/hotspot/jtreg/runtime/appcds/javaldr/AnonVmClassesDuringDump.java
- test/hotspot/jtreg/runtime/appcds/javaldr/AnonVmClassesDuringDumpTransformer.java
- test/hotspot/jtreg/runtime/appcds/javaldr/AnonVmClassesDuringDumpTransformer.mf
- test/hotspot/jtreg/runtime/appcds/javaldr/ArrayTest.java
- test/hotspot/jtreg/runtime/appcds/javaldr/ArrayTestHelper.java
- test/hotspot/jtreg/runtime/appcds/javaldr/GCDuringDump.java
- test/hotspot/jtreg/runtime/appcds/javaldr/GCDuringDumpTransformer.java
- test/hotspot/jtreg/runtime/appcds/javaldr/GCDuringDumpTransformer.mf
- test/hotspot/jtreg/runtime/appcds/javaldr/GCSharedStringsDuringDump.java
- test/hotspot/jtreg/runtime/appcds/javaldr/GCSharedStringsDuringDumpWb.java
- test/hotspot/jtreg/runtime/appcds/javaldr/HumongousDuringDump.java
- test/hotspot/jtreg/runtime/appcds/javaldr/HumongousDuringDumpTransformer.java
- test/hotspot/jtreg/runtime/appcds/javaldr/HumongousDuringDumpTransformer.mf
- test/hotspot/jtreg/runtime/appcds/jigsaw/CheckUnsupportedDumpingOptions.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/JigsawOptionsCombo.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/AppClassInCP.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/CustomPackage.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/MismatchedPatchModule.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/PatchDir.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/PatchJavaBase.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/PatchMain.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/Simple.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/SubClassOfPatchedClass.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/TwoJars.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/classpathtests/BootAppendTests.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/classpathtests/ClassPathTests.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/classpathtests/DummyClassesInBootClassPath.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/classpathtests/EmptyClassInBootClassPath.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/classpathtests/src/com/sun/tools/javac/Main.jasm
- test/hotspot/jtreg/runtime/appcds/jigsaw/classpathtests/src/com/sun/tools/javac/MyMain.jasm
- test/hotspot/jtreg/runtime/appcds/jigsaw/classpathtests/src/jdk/test/Main.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/classpathtests/src/sun/nio/cs/ext/MyClass.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/classpathtests/src/sun/nio/cs/ext1/MyClass.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/AddModules.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/AddOpens.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/AddReads.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/ExportModule.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/JvmtiAddPath.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/MainModuleOnly.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/ModulePathAndCP.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/ModulePathAndCP_JFR.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.greetings/com/greetings/Main.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.greetings/module-info.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.hello/com/hello/Main.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.hello/module-info.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.nomodule/com/nomodule/Main.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.norequires/com/norequires/Main.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.norequires/module-info.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.simple/com/simple/Main.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.simple/module-info.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/org.astro/module-info.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/org.astro/org/astro/World.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/overridetests/OverrideTests.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/overridetests/src/java.net.http/java/net/http/HttpTimeoutException.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/overridetests/src/java.net.http/module-info.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/overridetests/src/jdk.compiler/com/sun/tools/javac/Main.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/overridetests/src/jdk.compiler/module-info.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/overridetests/src/test/jdk/test/Main.java
- test/hotspot/jtreg/runtime/appcds/jigsaw/overridetests/src/test/module-info.java
- test/hotspot/jtreg/runtime/appcds/jvmti/ClassFileLoadHook.java
- test/hotspot/jtreg/runtime/appcds/jvmti/ClassFileLoadHookTest.java
- test/hotspot/jtreg/runtime/appcds/jvmti/InstrumentationAgent.mf
- test/hotspot/jtreg/runtime/appcds/jvmti/InstrumentationApp.java
- test/hotspot/jtreg/runtime/appcds/jvmti/InstrumentationClassFileTransformer.java
- test/hotspot/jtreg/runtime/appcds/jvmti/InstrumentationRegisterClassFileTransformer.java
- test/hotspot/jtreg/runtime/appcds/jvmti/InstrumentationTest.java
- test/hotspot/jtreg/runtime/appcds/jvmti/dumpingWithAgent/DumpingWithJavaAgent.java
- test/hotspot/jtreg/runtime/appcds/jvmti/dumpingWithAgent/DumpingWithJvmtiAgent.java
- test/hotspot/jtreg/runtime/appcds/jvmti/dumpingWithAgent/SimpleAgent.java
- test/hotspot/jtreg/runtime/appcds/jvmti/dumpingWithAgent/SimpleAgent.mf
- test/hotspot/jtreg/runtime/appcds/jvmti/dumpingWithAgent/libAddToSystemCLSearchOnLoad.c
- test/hotspot/jtreg/runtime/appcds/jvmti/parallelLoad/ParallelClassesTransform.java
- test/hotspot/jtreg/runtime/appcds/jvmti/parallelLoad/ParallelLoadAndTransformTest.java
- test/hotspot/jtreg/runtime/appcds/jvmti/transformRelatedClasses/TransformInterfaceImplementorAppCDS.java
- test/hotspot/jtreg/runtime/appcds/jvmti/transformRelatedClasses/TransformRelatedClassesAppCDS.java
- test/hotspot/jtreg/runtime/appcds/jvmti/transformRelatedClasses/TransformSuperSubAppCDS.java
- test/hotspot/jtreg/runtime/appcds/redefineClass/RedefineBasic.java
- test/hotspot/jtreg/runtime/appcds/redefineClass/RedefineBasicTest.java
- test/hotspot/jtreg/runtime/appcds/redefineClass/RedefineRunningMethods_Shared.java
- test/hotspot/jtreg/runtime/appcds/redefineClass/RedefineRunningMethods_SharedHelper.java
- test/hotspot/jtreg/runtime/appcds/sharedStrings/ExerciseGC.java
- test/hotspot/jtreg/runtime/appcds/sharedStrings/ExtraSharedInput.txt
- test/hotspot/jtreg/runtime/appcds/sharedStrings/FlagCombo.java
- test/hotspot/jtreg/runtime/appcds/sharedStrings/HelloString.java
- test/hotspot/jtreg/runtime/appcds/sharedStrings/HelloStringGC.java
- test/hotspot/jtreg/runtime/appcds/sharedStrings/HelloStringPlus.java
- test/hotspot/jtreg/runtime/appcds/sharedStrings/IncompatibleOptions.java
- test/hotspot/jtreg/runtime/appcds/sharedStrings/InternSharedString.java
- test/hotspot/jtreg/runtime/appcds/sharedStrings/InternStringTest.java
- test/hotspot/jtreg/runtime/appcds/sharedStrings/InvalidFileFormat.java
- test/hotspot/jtreg/runtime/appcds/sharedStrings/LargePages.java
- test/hotspot/jtreg/runtime/appcds/sharedStrings/LockSharedStrings.java
- test/hotspot/jtreg/runtime/appcds/sharedStrings/LockStringTest.java
- test/hotspot/jtreg/runtime/appcds/sharedStrings/LockStringValueTest.java
- test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasic.java
- test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasic.txt
- test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasicPlus.java
- test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsHumongous.java
- test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsStress.java
- test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsUtils.java
- test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsWb.java
- test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsWbTest.java
- test/hotspot/jtreg/runtime/appcds/sharedStrings/SysDictCrash.java
- test/hotspot/jtreg/runtime/appcds/sharedStrings/invalidFormat/CorruptDataLine.txt
- test/hotspot/jtreg/runtime/appcds/sharedStrings/invalidFormat/InvalidDataType.txt
- test/hotspot/jtreg/runtime/appcds/sharedStrings/invalidFormat/InvalidHeader.txt
- test/hotspot/jtreg/runtime/appcds/sharedStrings/invalidFormat/InvalidString.txt
- test/hotspot/jtreg/runtime/appcds/sharedStrings/invalidFormat/InvalidStringFormat.txt
- test/hotspot/jtreg/runtime/appcds/sharedStrings/invalidFormat/InvalidSymbol.txt
- test/hotspot/jtreg/runtime/appcds/sharedStrings/invalidFormat/InvalidSymbolFormat.txt
- test/hotspot/jtreg/runtime/appcds/sharedStrings/invalidFormat/InvalidVersion.txt
- test/hotspot/jtreg/runtime/appcds/sharedStrings/invalidFormat/LengthOverflow.txt
- test/hotspot/jtreg/runtime/appcds/sharedStrings/invalidFormat/OverflowPrefix.txt
- test/hotspot/jtreg/runtime/appcds/sharedStrings/invalidFormat/TruncatedString.txt
- test/hotspot/jtreg/runtime/appcds/sharedStrings/invalidFormat/UnrecognizedPrefix.txt
- test/hotspot/jtreg/runtime/appcds/test-classes/ArrayListTest.java
- test/hotspot/jtreg/runtime/appcds/test-classes/BootClassPathAppendHelper.java
- test/hotspot/jtreg/runtime/appcds/test-classes/C1.java
- test/hotspot/jtreg/runtime/appcds/test-classes/C2.java
- test/hotspot/jtreg/runtime/appcds/test-classes/Child.java
- test/hotspot/jtreg/runtime/appcds/test-classes/CpAttr1.java
- test/hotspot/jtreg/runtime/appcds/test-classes/CpAttr2.java
- test/hotspot/jtreg/runtime/appcds/test-classes/CpAttr3.java
- test/hotspot/jtreg/runtime/appcds/test-classes/CpAttr4.java
- test/hotspot/jtreg/runtime/appcds/test-classes/CpAttr5.java
- test/hotspot/jtreg/runtime/appcds/test-classes/DummyClassHelper.java
- test/hotspot/jtreg/runtime/appcds/test-classes/EmptyClassHelper.java
- test/hotspot/jtreg/runtime/appcds/test-classes/FieldAnnotationsApp.java
- test/hotspot/jtreg/runtime/appcds/test-classes/ForNameTest.java
- test/hotspot/jtreg/runtime/appcds/test-classes/GenericTestApp.java
- test/hotspot/jtreg/runtime/appcds/test-classes/GetFlightRecorder.java
- test/hotspot/jtreg/runtime/appcds/test-classes/Greet.java
- test/hotspot/jtreg/runtime/appcds/test-classes/Hello.java
- test/hotspot/jtreg/runtime/appcds/test-classes/HelloExt.java
- test/hotspot/jtreg/runtime/appcds/test-classes/HelloExtApp.java
- test/hotspot/jtreg/runtime/appcds/test-classes/HelloExtExt.java
- test/hotspot/jtreg/runtime/appcds/test-classes/HelloMore.java
- test/hotspot/jtreg/runtime/appcds/test-classes/HelloWB.java
- test/hotspot/jtreg/runtime/appcds/test-classes/Hi.java
- test/hotspot/jtreg/runtime/appcds/test-classes/Iloadw.jasm
- test/hotspot/jtreg/runtime/appcds/test-classes/IloadwMain.java
- test/hotspot/jtreg/runtime/appcds/test-classes/JimageClassPackage.java
- test/hotspot/jtreg/runtime/appcds/test-classes/JimageClassProtDomain.java
- test/hotspot/jtreg/runtime/appcds/test-classes/JvmtiApp.java
- test/hotspot/jtreg/runtime/appcds/test-classes/MethodNoReturn.jasm
- test/hotspot/jtreg/runtime/appcds/test-classes/MissingSuper.java
- test/hotspot/jtreg/runtime/appcds/test-classes/MultiProcClass.java
- test/hotspot/jtreg/runtime/appcds/test-classes/MyAnnotation.java
- test/hotspot/jtreg/runtime/appcds/test-classes/MyThread.java
- test/hotspot/jtreg/runtime/appcds/test-classes/PackageSealingTest.java
- test/hotspot/jtreg/runtime/appcds/test-classes/PackageTest.java
- test/hotspot/jtreg/runtime/appcds/test-classes/ParallelClasses.java
- test/hotspot/jtreg/runtime/appcds/test-classes/ParallelLoad.java
- test/hotspot/jtreg/runtime/appcds/test-classes/Prohibited.jasm
- test/hotspot/jtreg/runtime/appcds/test-classes/ProhibitedHelper.java
- test/hotspot/jtreg/runtime/appcds/test-classes/ProtDomain.java
- test/hotspot/jtreg/runtime/appcds/test-classes/ProtDomainB.java
- test/hotspot/jtreg/runtime/appcds/test-classes/ReportMyLoader.java
- test/hotspot/jtreg/runtime/appcds/test-classes/RewriteBytecodes.java
- test/hotspot/jtreg/runtime/appcds/test-classes/Super.java
- test/hotspot/jtreg/runtime/appcds/test-classes/TestClassLoader.java
- test/hotspot/jtreg/runtime/appcds/test-classes/TestWithProfilerHelper.java
- test/hotspot/jtreg/runtime/appcds/test-classes/TrySwitchMyLoader.java
- test/hotspot/jtreg/runtime/appcds/test-classes/Util.java
- test/hotspot/jtreg/runtime/appcds/test-classes/VerifierTest0.java
- test/hotspot/jtreg/runtime/appcds/test-classes/com/sun/tools/javac/Main.jasm
- test/hotspot/jtreg/runtime/appcds/test-classes/cpattr1.mf
- test/hotspot/jtreg/runtime/appcds/test-classes/cpattr1_long.mf
- test/hotspot/jtreg/runtime/appcds/test-classes/cpattr2.mf
- test/hotspot/jtreg/runtime/appcds/test-classes/cpattr3.mf
- test/hotspot/jtreg/runtime/appcds/test-classes/cpattr4.mf
- test/hotspot/jtreg/runtime/appcds/test-classes/cpattr5_extra_long.mf
- test/hotspot/jtreg/runtime/appcds/test-classes/java/net/HttpCookie.jasm
- test/hotspot/jtreg/runtime/appcds/test-classes/javax/transaction/InvalidTransactionException.jasm
- test/hotspot/jtreg/runtime/appcds/test-classes/package_seal.mf
- test/hotspot/jtreg/serviceability/sa/ClhsdbRegionDetailsScanOopsForG1.java
- test/hotspot/jtreg/serviceability/sa/LingeredAppWithLargeArray.java
- test/hotspot/jtreg/serviceability/sa/LingeredAppWithLargeStringArray.java
- test/hotspot/jtreg/serviceability/sa/TestHeapDumpForLargeArray.java
! test/jdk/ProblemList.txt
- test/jdk/java/net/Socket/reset/Test.java
- test/jdk/javax/xml/jaxp/testng/validation/jdk8037819/BasicTest1.java
- test/jdk/sun/util/calendar/zi/tzdata/VERSION
- test/jdk/sun/util/calendar/zi/tzdata/africa
- test/jdk/sun/util/calendar/zi/tzdata/antarctica
- test/jdk/sun/util/calendar/zi/tzdata/asia
- test/jdk/sun/util/calendar/zi/tzdata/australasia
- test/jdk/sun/util/calendar/zi/tzdata/backward
- test/jdk/sun/util/calendar/zi/tzdata/etcetera
- test/jdk/sun/util/calendar/zi/tzdata/europe
- test/jdk/sun/util/calendar/zi/tzdata/factory
- test/jdk/sun/util/calendar/zi/tzdata/gmt
- test/jdk/sun/util/calendar/zi/tzdata/iso3166.tab
- test/jdk/sun/util/calendar/zi/tzdata/jdk11_backward
- test/jdk/sun/util/calendar/zi/tzdata/leapseconds
- test/jdk/sun/util/calendar/zi/tzdata/northamerica
- test/jdk/sun/util/calendar/zi/tzdata/pacificnew
- test/jdk/sun/util/calendar/zi/tzdata/solar87
- test/jdk/sun/util/calendar/zi/tzdata/solar88
- test/jdk/sun/util/calendar/zi/tzdata/solar89
- test/jdk/sun/util/calendar/zi/tzdata/southamerica
- test/jdk/sun/util/calendar/zi/tzdata/systemv
- test/jdk/sun/util/calendar/zi/tzdata/zone.tab
- test/jdk/sun/util/calendar/zi/tzdata_jdk/gmt
- test/jdk/sun/util/calendar/zi/tzdata_jdk/jdk11_full_backward

Changeset: 8ec5ad4f5cc3
Author:    coleenp
Date:      2019-08-29 08:52 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/8ec5ad4f5cc3

8216977: ShowHiddenFrames use in java_lang_StackTraceElement::fill_in appears broken
Summary: Return NULL source file and negative line number for hidden frames.
Reviewed-by: dholmes, hseigel

! src/hotspot/share/classfile/javaClasses.cpp
! src/hotspot/share/classfile/javaClasses.inline.hpp
+ test/hotspot/jtreg/runtime/StackTrace/HiddenFrameTest.java

Changeset: e8ba7e4f4190
Author:    redestad
Date:      2019-08-29 15:59 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/e8ba7e4f4190

8230302: GenerateJLIClassesPlugin can generate invalid DirectMethodHandle methods
Reviewed-by: mchung

! src/java.base/share/classes/java/lang/invoke/GenerateJLIClassesHelper.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/GenerateJLIClassesPlugin.java
! test/jdk/tools/jlink/plugins/GenerateJLIClassesPluginTest.java

Changeset: a1a8f8fae7d9
Author:    igerasim
Date:      2019-08-29 07:39 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/a1a8f8fae7d9

8230338: Accurate error message about bad Unicode block name
Reviewed-by: rriggs

! src/java.base/share/classes/java/util/regex/Pattern.java

Changeset: e29b6ddfd9f4
Author:    mseledtsov
Date:      2019-08-29 08:35 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/e29b6ddfd9f4

8229210: [TESTBUG] Move gc stress tests from JFR directory tree to gc/stress
Summary: moved the tests
Reviewed-by: egahlin

+ test/hotspot/jtreg/gc/stress/jfr/TestStressAllocationGCEventsWithCMS.java
+ test/hotspot/jtreg/gc/stress/jfr/TestStressAllocationGCEventsWithDefNew.java
+ test/hotspot/jtreg/gc/stress/jfr/TestStressAllocationGCEventsWithG1.java
+ test/hotspot/jtreg/gc/stress/jfr/TestStressAllocationGCEventsWithParNew.java
+ test/hotspot/jtreg/gc/stress/jfr/TestStressAllocationGCEventsWithParallel.java
+ test/hotspot/jtreg/gc/stress/jfr/TestStressBigAllocationGCEventsWithCMS.java
+ test/hotspot/jtreg/gc/stress/jfr/TestStressBigAllocationGCEventsWithDefNew.java
+ test/hotspot/jtreg/gc/stress/jfr/TestStressBigAllocationGCEventsWithG1.java
+ test/hotspot/jtreg/gc/stress/jfr/TestStressBigAllocationGCEventsWithParNew.java
+ test/hotspot/jtreg/gc/stress/jfr/TestStressBigAllocationGCEventsWithParallel.java
- test/jdk/jdk/jfr/event/gc/detailed/TestStressAllocationGCEventsWithCMS.java
- test/jdk/jdk/jfr/event/gc/detailed/TestStressAllocationGCEventsWithDefNew.java
- test/jdk/jdk/jfr/event/gc/detailed/TestStressAllocationGCEventsWithG1.java
- test/jdk/jdk/jfr/event/gc/detailed/TestStressAllocationGCEventsWithParNew.java
- test/jdk/jdk/jfr/event/gc/detailed/TestStressAllocationGCEventsWithParallel.java
- test/jdk/jdk/jfr/event/gc/detailed/TestStressBigAllocationGCEventsWithCMS.java
- test/jdk/jdk/jfr/event/gc/detailed/TestStressBigAllocationGCEventsWithDefNew.java
- test/jdk/jdk/jfr/event/gc/detailed/TestStressBigAllocationGCEventsWithG1.java
- test/jdk/jdk/jfr/event/gc/detailed/TestStressBigAllocationGCEventsWithParNew.java
- test/jdk/jdk/jfr/event/gc/detailed/TestStressBigAllocationGCEventsWithParallel.java

Changeset: 72bc9a29fd7e
Author:    mbaesken
Date:      2019-08-28 14:22 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/72bc9a29fd7e

8229284: jdk/internal/platform/cgroup/TestCgroupMetrics.java fails for - memory:getMemoryUsage
Reviewed-by: mseledtsov, sgehwolf

! test/lib/jdk/test/lib/containers/cgroup/MetricsTester.java

Changeset: e09c993ac476
Author:    dtitov
Date:      2019-08-29 10:09 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/e09c993ac476

8182119: jdk.hotspot.agent's META-INF/services/com.sun.jdi.connect.Connector no longer needed
Reviewed-by: sspitsyn, amenkov, alanb

- src/jdk.hotspot.agent/share/classes/META-INF/services/com.sun.jdi.connect.Connector

Changeset: 4612a3cfb927
Author:    darcy
Date:      2019-08-29 10:52 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/4612a3cfb927

8229999: Apply java.io.Serial annotations to security types in java.base
Reviewed-by: rriggs, mullan

! src/java.base/share/classes/com/sun/crypto/provider/DESKey.java
! src/java.base/share/classes/com/sun/crypto/provider/DESedeKey.java
! src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java
! src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java
! src/java.base/share/classes/com/sun/crypto/provider/PBEKey.java
! src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java
! src/java.base/share/classes/com/sun/crypto/provider/SealedObjectForKeyProtector.java
! src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java
! src/java.base/share/classes/com/sun/crypto/provider/TlsMasterSecretGenerator.java
! src/java.base/share/classes/com/sun/security/cert/internal/x509/X509V1CertImpl.java
! src/java.base/share/classes/com/sun/security/ntlm/NTLMException.java
! src/java.base/share/classes/java/security/AccessControlException.java
! src/java.base/share/classes/java/security/AllPermission.java
! src/java.base/share/classes/java/security/AuthProvider.java
! src/java.base/share/classes/java/security/BasicPermission.java
! src/java.base/share/classes/java/security/CodeSigner.java
! src/java.base/share/classes/java/security/CodeSource.java
! src/java.base/share/classes/java/security/DigestException.java
! src/java.base/share/classes/java/security/GeneralSecurityException.java
! src/java.base/share/classes/java/security/GuardedObject.java
! src/java.base/share/classes/java/security/Identity.java
! src/java.base/share/classes/java/security/IdentityScope.java
! src/java.base/share/classes/java/security/InvalidAlgorithmParameterException.java
! src/java.base/share/classes/java/security/InvalidKeyException.java
! src/java.base/share/classes/java/security/InvalidParameterException.java
! src/java.base/share/classes/java/security/Key.java
! src/java.base/share/classes/java/security/KeyException.java
! src/java.base/share/classes/java/security/KeyManagementException.java
! src/java.base/share/classes/java/security/KeyPair.java
! src/java.base/share/classes/java/security/KeyRep.java
! src/java.base/share/classes/java/security/KeyStoreException.java
! src/java.base/share/classes/java/security/NoSuchAlgorithmException.java
! src/java.base/share/classes/java/security/NoSuchProviderException.java
! src/java.base/share/classes/java/security/Permission.java
! src/java.base/share/classes/java/security/PermissionCollection.java
! src/java.base/share/classes/java/security/Permissions.java
! src/java.base/share/classes/java/security/Policy.java
! src/java.base/share/classes/java/security/PrivateKey.java
! src/java.base/share/classes/java/security/PrivilegedActionException.java
! src/java.base/share/classes/java/security/Provider.java
! src/java.base/share/classes/java/security/ProviderException.java
! src/java.base/share/classes/java/security/PublicKey.java
! src/java.base/share/classes/java/security/SecureRandom.java
! src/java.base/share/classes/java/security/SecureRandomSpi.java
! src/java.base/share/classes/java/security/SecurityPermission.java
! src/java.base/share/classes/java/security/SignatureException.java
! src/java.base/share/classes/java/security/SignedObject.java
! src/java.base/share/classes/java/security/Signer.java
! src/java.base/share/classes/java/security/Timestamp.java
! src/java.base/share/classes/java/security/UnrecoverableEntryException.java
! src/java.base/share/classes/java/security/UnrecoverableKeyException.java
! src/java.base/share/classes/java/security/UnresolvedPermission.java
! src/java.base/share/classes/java/security/UnresolvedPermissionCollection.java
! src/java.base/share/classes/java/security/cert/CRLException.java
! src/java.base/share/classes/java/security/cert/CertPath.java
! src/java.base/share/classes/java/security/cert/CertPathBuilderException.java
! src/java.base/share/classes/java/security/cert/CertPathValidatorException.java
! src/java.base/share/classes/java/security/cert/CertStoreException.java
! src/java.base/share/classes/java/security/cert/Certificate.java
! src/java.base/share/classes/java/security/cert/CertificateEncodingException.java
! src/java.base/share/classes/java/security/cert/CertificateException.java
! src/java.base/share/classes/java/security/cert/CertificateExpiredException.java
! src/java.base/share/classes/java/security/cert/CertificateNotYetValidException.java
! src/java.base/share/classes/java/security/cert/CertificateParsingException.java
! src/java.base/share/classes/java/security/cert/CertificateRevokedException.java
! src/java.base/share/classes/java/security/cert/X509Certificate.java
! src/java.base/share/classes/java/security/interfaces/DSAPrivateKey.java
! src/java.base/share/classes/java/security/interfaces/DSAPublicKey.java
! src/java.base/share/classes/java/security/interfaces/ECPrivateKey.java
! src/java.base/share/classes/java/security/interfaces/ECPublicKey.java
! src/java.base/share/classes/java/security/interfaces/RSAMultiPrimePrivateCrtKey.java
! src/java.base/share/classes/java/security/interfaces/RSAPrivateCrtKey.java
! src/java.base/share/classes/java/security/interfaces/RSAPrivateKey.java
! src/java.base/share/classes/java/security/interfaces/RSAPublicKey.java
! src/java.base/share/classes/java/security/spec/InvalidKeySpecException.java
! src/java.base/share/classes/java/security/spec/InvalidParameterSpecException.java
! src/java.base/share/classes/javax/crypto/AEADBadTagException.java
! src/java.base/share/classes/javax/crypto/BadPaddingException.java
! src/java.base/share/classes/javax/crypto/CryptoAllPermission.java
! src/java.base/share/classes/javax/crypto/CryptoPermission.java
! src/java.base/share/classes/javax/crypto/CryptoPermissions.java
! src/java.base/share/classes/javax/crypto/CryptoPolicyParser.java
! src/java.base/share/classes/javax/crypto/ExemptionMechanismException.java
! src/java.base/share/classes/javax/crypto/IllegalBlockSizeException.java
! src/java.base/share/classes/javax/crypto/NoSuchPaddingException.java
! src/java.base/share/classes/javax/crypto/SealedObject.java
! src/java.base/share/classes/javax/crypto/ShortBufferException.java
! src/java.base/share/classes/javax/crypto/interfaces/DHPrivateKey.java
! src/java.base/share/classes/javax/crypto/interfaces/DHPublicKey.java
! src/java.base/share/classes/javax/crypto/interfaces/PBEKey.java
! src/java.base/share/classes/javax/crypto/spec/SecretKeySpec.java
! src/java.base/share/classes/javax/security/auth/AuthPermission.java
! src/java.base/share/classes/javax/security/auth/DestroyFailedException.java
! src/java.base/share/classes/javax/security/auth/PrivateCredentialPermission.java
! src/java.base/share/classes/javax/security/auth/RefreshFailedException.java
! src/java.base/share/classes/javax/security/auth/Subject.java
! src/java.base/share/classes/javax/security/auth/callback/ChoiceCallback.java
! src/java.base/share/classes/javax/security/auth/callback/ConfirmationCallback.java
! src/java.base/share/classes/javax/security/auth/callback/LanguageCallback.java
! src/java.base/share/classes/javax/security/auth/callback/NameCallback.java
! src/java.base/share/classes/javax/security/auth/callback/PasswordCallback.java
! src/java.base/share/classes/javax/security/auth/callback/TextInputCallback.java
! src/java.base/share/classes/javax/security/auth/callback/TextOutputCallback.java
! src/java.base/share/classes/javax/security/auth/callback/UnsupportedCallbackException.java
! src/java.base/share/classes/javax/security/auth/login/AccountException.java
! src/java.base/share/classes/javax/security/auth/login/AccountExpiredException.java
! src/java.base/share/classes/javax/security/auth/login/AccountLockedException.java
! src/java.base/share/classes/javax/security/auth/login/AccountNotFoundException.java
! src/java.base/share/classes/javax/security/auth/login/CredentialException.java
! src/java.base/share/classes/javax/security/auth/login/CredentialExpiredException.java
! src/java.base/share/classes/javax/security/auth/login/CredentialNotFoundException.java
! src/java.base/share/classes/javax/security/auth/login/FailedLoginException.java
! src/java.base/share/classes/javax/security/auth/login/LoginException.java
! src/java.base/share/classes/javax/security/auth/x500/X500Principal.java
! src/java.base/share/classes/javax/security/cert/CertificateEncodingException.java
! src/java.base/share/classes/javax/security/cert/CertificateException.java
! src/java.base/share/classes/javax/security/cert/CertificateExpiredException.java
! src/java.base/share/classes/javax/security/cert/CertificateNotYetValidException.java
! src/java.base/share/classes/javax/security/cert/CertificateParsingException.java
! src/java.base/share/classes/sun/security/internal/interfaces/TlsMasterSecret.java
! src/java.base/share/classes/sun/security/internal/spec/TlsKeyMaterialSpec.java
! src/java.base/share/classes/sun/security/jca/ProviderList.java
! src/java.base/share/classes/sun/security/pkcs/PKCS8Key.java
! src/java.base/share/classes/sun/security/pkcs/ParsingException.java
! src/java.base/share/classes/sun/security/provider/DRBG.java
! src/java.base/share/classes/sun/security/provider/DSAPrivateKey.java
! src/java.base/share/classes/sun/security/provider/DSAPublicKey.java
! src/java.base/share/classes/sun/security/provider/DSAPublicKeyImpl.java
! src/java.base/share/classes/sun/security/provider/MD4.java
! src/java.base/share/classes/sun/security/provider/MoreDrbgParameters.java
! src/java.base/share/classes/sun/security/provider/PolicyFile.java
! src/java.base/share/classes/sun/security/provider/PolicyParser.java
! src/java.base/share/classes/sun/security/provider/SecureRandom.java
! src/java.base/share/classes/sun/security/provider/SubjectCodeSource.java
! src/java.base/share/classes/sun/security/provider/Sun.java
! src/java.base/share/classes/sun/security/provider/VerificationProvider.java
! src/java.base/share/classes/sun/security/provider/certpath/PKIX.java
! src/java.base/share/classes/sun/security/provider/certpath/SunCertPathBuilderException.java
! src/java.base/share/classes/sun/security/provider/certpath/X509CertPath.java
! src/java.base/share/classes/sun/security/rsa/RSAPrivateCrtKeyImpl.java
! src/java.base/share/classes/sun/security/rsa/RSAPrivateKeyImpl.java
! src/java.base/share/classes/sun/security/rsa/RSAPublicKeyImpl.java
! src/java.base/share/classes/sun/security/rsa/SunRsaSign.java
! src/java.base/share/classes/sun/security/ssl/SunJSSE.java
! src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java
! src/java.base/share/classes/sun/security/timestamp/TSResponse.java
! src/java.base/share/classes/sun/security/util/LazyCodeSourcePermissionCollection.java
! src/java.base/share/classes/sun/security/util/ObjectIdentifier.java
! src/java.base/share/classes/sun/security/util/PendingException.java
! src/java.base/share/classes/sun/security/util/PropertyExpander.java
! src/java.base/share/classes/sun/security/validator/ValidatorException.java
! src/java.base/share/classes/sun/security/x509/AlgIdDSA.java
! src/java.base/share/classes/sun/security/x509/AlgorithmId.java
! src/java.base/share/classes/sun/security/x509/AttributeNameEnumeration.java
! src/java.base/share/classes/sun/security/x509/CertException.java
! src/java.base/share/classes/sun/security/x509/CertParseError.java
! src/java.base/share/classes/sun/security/x509/X509CertImpl.java
! src/java.base/share/classes/sun/security/x509/X509Key.java

Changeset: 5021d91ba9bd
Author:    jiefu
Date:      2019-08-30 00:03 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/5021d91ba9bd

8230037: Confused MetaData dumped by PrintOptoAssembly
Reviewed-by: kvn, bsrbnd

! src/hotspot/share/opto/output.cpp

Changeset: d78c910f9069
Author:    kbarrett
Date:      2019-08-29 18:35 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/d78c910f9069

8230109: G1DirtyCardQueueSet should use card counts rather than buffer counts
Summary: Consistently use card counts
Reviewed-by: sjohanss, sangheki

! src/hotspot/share/gc/g1/g1Analytics.cpp
! src/hotspot/share/gc/g1/g1Analytics.hpp
! src/hotspot/share/gc/g1/g1CollectedHeap.cpp
! src/hotspot/share/gc/g1/g1ConcurrentRefine.cpp
! src/hotspot/share/gc/g1/g1ConcurrentRefine.hpp
! src/hotspot/share/gc/g1/g1ConcurrentRefineThread.cpp
! src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp
! src/hotspot/share/gc/g1/g1DirtyCardQueue.hpp
! src/hotspot/share/gc/g1/g1Policy.cpp
! src/hotspot/share/gc/g1/g1Policy.hpp

Changeset: fd09c637dedb
Author:    mseledtsov
Date:      2019-08-29 15:50 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/fd09c637dedb

8228960: [TESTBUG] containers/docker/TestJcmdWithSideCar.java: jcmd reports main class as Unknown
Summary: waiting for child output to start main() before running jcmd
Reviewed-by: dholmes, bobv

! test/hotspot/jtreg/ProblemList.txt
! test/hotspot/jtreg/containers/docker/EventGeneratorLoop.java
! test/hotspot/jtreg/containers/docker/TestJcmdWithSideCar.java

Changeset: 18863bf3501f
Author:    kbarrett
Date:      2019-08-29 18:52 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/18863bf3501f

8230332: G1DirtyCardQueueSet _notify_when_complete is always true
Summary: Removed _notify_when_complete, assume true value where formerly used.
Reviewed-by: sjohanss, tschatzl

! src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp
! src/hotspot/share/gc/g1/g1DirtyCardQueue.hpp

Changeset: e0b8b019d2f5
Author:    darcy
Date:      2019-08-29 16:31 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/e0b8b019d2f5

8229997: Apply java.io.Serial annotations in java.base
Reviewed-by: alanb, rriggs

! src/java.base/share/classes/com/sun/java/util/jar/pack/Attribute.java
! src/java.base/share/classes/com/sun/java/util/jar/pack/ClassReader.java
! src/java.base/share/classes/com/sun/java/util/jar/pack/Instruction.java
! src/java.base/share/classes/java/io/CharConversionException.java
! src/java.base/share/classes/java/io/EOFException.java
! src/java.base/share/classes/java/io/File.java
! src/java.base/share/classes/java/io/FileNotFoundException.java
! src/java.base/share/classes/java/io/FilePermission.java
! src/java.base/share/classes/java/io/IOError.java
! src/java.base/share/classes/java/io/IOException.java
! src/java.base/share/classes/java/io/InterruptedIOException.java
! src/java.base/share/classes/java/io/InvalidClassException.java
! src/java.base/share/classes/java/io/InvalidObjectException.java
! src/java.base/share/classes/java/io/NotActiveException.java
! src/java.base/share/classes/java/io/NotSerializableException.java
! src/java.base/share/classes/java/io/ObjectStreamClass.java
! src/java.base/share/classes/java/io/ObjectStreamException.java
! src/java.base/share/classes/java/io/OptionalDataException.java
! src/java.base/share/classes/java/io/SerializablePermission.java
! src/java.base/share/classes/java/io/StreamCorruptedException.java
! src/java.base/share/classes/java/io/SyncFailedException.java
! src/java.base/share/classes/java/io/UTFDataFormatException.java
! src/java.base/share/classes/java/io/UncheckedIOException.java
! src/java.base/share/classes/java/io/UnsupportedEncodingException.java
! src/java.base/share/classes/java/io/WriteAbortedException.java
! src/java.base/share/classes/java/lang/AbstractMethodError.java
! src/java.base/share/classes/java/lang/ArithmeticException.java
! src/java.base/share/classes/java/lang/ArrayIndexOutOfBoundsException.java
! src/java.base/share/classes/java/lang/ArrayStoreException.java
! src/java.base/share/classes/java/lang/AssertionError.java
! src/java.base/share/classes/java/lang/Boolean.java
! src/java.base/share/classes/java/lang/BootstrapMethodError.java
! src/java.base/share/classes/java/lang/Byte.java
! src/java.base/share/classes/java/lang/Character.java
! src/java.base/share/classes/java/lang/Class.java
! src/java.base/share/classes/java/lang/ClassCastException.java
! src/java.base/share/classes/java/lang/ClassCircularityError.java
! src/java.base/share/classes/java/lang/ClassFormatError.java
! src/java.base/share/classes/java/lang/ClassNotFoundException.java
! src/java.base/share/classes/java/lang/CloneNotSupportedException.java
! src/java.base/share/classes/java/lang/Double.java
! src/java.base/share/classes/java/lang/Enum.java
! src/java.base/share/classes/java/lang/EnumConstantNotPresentException.java
! src/java.base/share/classes/java/lang/Error.java
! src/java.base/share/classes/java/lang/Exception.java
! src/java.base/share/classes/java/lang/ExceptionInInitializerError.java
! src/java.base/share/classes/java/lang/Float.java
! src/java.base/share/classes/java/lang/IllegalAccessError.java
! src/java.base/share/classes/java/lang/IllegalArgumentException.java
! src/java.base/share/classes/java/lang/IllegalCallerException.java
! src/java.base/share/classes/java/lang/IllegalMonitorStateException.java
! src/java.base/share/classes/java/lang/IllegalStateException.java
! src/java.base/share/classes/java/lang/IllegalThreadStateException.java
! src/java.base/share/classes/java/lang/IncompatibleClassChangeError.java
! src/java.base/share/classes/java/lang/IndexOutOfBoundsException.java
! src/java.base/share/classes/java/lang/InstantiationError.java
! src/java.base/share/classes/java/lang/InstantiationException.java
! src/java.base/share/classes/java/lang/Integer.java
! src/java.base/share/classes/java/lang/InterruptedException.java
! src/java.base/share/classes/java/lang/LayerInstantiationException.java
! src/java.base/share/classes/java/lang/LinkageError.java
! src/java.base/share/classes/java/lang/Long.java
! src/java.base/share/classes/java/lang/NegativeArraySizeException.java
! src/java.base/share/classes/java/lang/NoClassDefFoundError.java
! src/java.base/share/classes/java/lang/NoSuchFieldError.java
! src/java.base/share/classes/java/lang/NoSuchFieldException.java
! src/java.base/share/classes/java/lang/NoSuchMethodError.java
! src/java.base/share/classes/java/lang/NoSuchMethodException.java
! src/java.base/share/classes/java/lang/NullPointerException.java
! src/java.base/share/classes/java/lang/Number.java
! src/java.base/share/classes/java/lang/NumberFormatException.java
! src/java.base/share/classes/java/lang/OutOfMemoryError.java
! src/java.base/share/classes/java/lang/ReflectiveOperationException.java
! src/java.base/share/classes/java/lang/RuntimeException.java
! src/java.base/share/classes/java/lang/RuntimePermission.java
! src/java.base/share/classes/java/lang/SecurityException.java
! src/java.base/share/classes/java/lang/Short.java
! src/java.base/share/classes/java/lang/StackOverflowError.java
! src/java.base/share/classes/java/lang/StackTraceElement.java
! src/java.base/share/classes/java/lang/String.java
! src/java.base/share/classes/java/lang/StringBuffer.java
! src/java.base/share/classes/java/lang/StringBuilder.java
! src/java.base/share/classes/java/lang/StringIndexOutOfBoundsException.java
! src/java.base/share/classes/java/lang/ThreadDeath.java
! src/java.base/share/classes/java/lang/Throwable.java
! src/java.base/share/classes/java/lang/TypeNotPresentException.java
! src/java.base/share/classes/java/lang/UnknownError.java
! src/java.base/share/classes/java/lang/UnsatisfiedLinkError.java
! src/java.base/share/classes/java/lang/UnsupportedClassVersionError.java
! src/java.base/share/classes/java/lang/UnsupportedOperationException.java
! src/java.base/share/classes/java/lang/VerifyError.java
! src/java.base/share/classes/java/lang/VirtualMachineError.java
! src/java.base/share/classes/java/lang/annotation/AnnotationFormatError.java
! src/java.base/share/classes/java/lang/annotation/AnnotationTypeMismatchException.java
! src/java.base/share/classes/java/lang/annotation/IncompleteAnnotationException.java
! src/java.base/share/classes/java/lang/invoke/LambdaConversionException.java
! src/java.base/share/classes/java/lang/invoke/MethodType.java
! src/java.base/share/classes/java/lang/invoke/SerializedLambda.java
! src/java.base/share/classes/java/lang/invoke/StringConcatException.java
! src/java.base/share/classes/java/lang/invoke/WrongMethodTypeException.java
! src/java.base/share/classes/java/lang/module/FindException.java
! src/java.base/share/classes/java/lang/module/InvalidModuleDescriptorException.java
! src/java.base/share/classes/java/lang/module/ResolutionException.java
! src/java.base/share/classes/java/lang/reflect/GenericSignatureFormatError.java
! src/java.base/share/classes/java/lang/reflect/InaccessibleObjectException.java
! src/java.base/share/classes/java/lang/reflect/InvocationTargetException.java
! src/java.base/share/classes/java/lang/reflect/MalformedParameterizedTypeException.java
! src/java.base/share/classes/java/lang/reflect/MalformedParametersException.java
! src/java.base/share/classes/java/lang/reflect/Proxy.java
! src/java.base/share/classes/java/lang/reflect/ReflectPermission.java
! src/java.base/share/classes/java/lang/reflect/UndeclaredThrowableException.java
! src/java.base/share/classes/java/math/BigDecimal.java
! src/java.base/share/classes/java/math/BigInteger.java
! src/java.base/share/classes/java/math/MathContext.java
! src/java.base/share/classes/java/net/BindException.java
! src/java.base/share/classes/java/net/ConnectException.java
! src/java.base/share/classes/java/net/HttpRetryException.java
! src/java.base/share/classes/java/net/Inet4Address.java
! src/java.base/share/classes/java/net/Inet6Address.java
! src/java.base/share/classes/java/net/InetAddress.java
! src/java.base/share/classes/java/net/InetSocketAddress.java
! src/java.base/share/classes/java/net/MalformedURLException.java
! src/java.base/share/classes/java/net/NetPermission.java
! src/java.base/share/classes/java/net/NoRouteToHostException.java
! src/java.base/share/classes/java/net/PortUnreachableException.java
! src/java.base/share/classes/java/net/ProtocolException.java
! src/java.base/share/classes/java/net/SocketAddress.java
! src/java.base/share/classes/java/net/SocketException.java
! src/java.base/share/classes/java/net/SocketPermission.java
! src/java.base/share/classes/java/net/SocketTimeoutException.java
! src/java.base/share/classes/java/net/URI.java
! src/java.base/share/classes/java/net/URISyntaxException.java
! src/java.base/share/classes/java/net/URL.java
! src/java.base/share/classes/java/net/URLPermission.java
! src/java.base/share/classes/java/net/UnknownHostException.java
! src/java.base/share/classes/java/net/UnknownServiceException.java
! src/java.base/share/classes/java/nio/charset/CoderMalfunctionError.java
! src/java.base/share/classes/java/nio/charset/MalformedInputException.java
! src/java.base/share/classes/java/nio/charset/UnmappableCharacterException.java
! src/java.base/share/classes/java/nio/file/AccessDeniedException.java
! src/java.base/share/classes/java/nio/file/AtomicMoveNotSupportedException.java
! src/java.base/share/classes/java/nio/file/ClosedDirectoryStreamException.java
! src/java.base/share/classes/java/nio/file/ClosedFileSystemException.java
! src/java.base/share/classes/java/nio/file/ClosedWatchServiceException.java
! src/java.base/share/classes/java/nio/file/DirectoryIteratorException.java
! src/java.base/share/classes/java/nio/file/DirectoryNotEmptyException.java
! src/java.base/share/classes/java/nio/file/FileAlreadyExistsException.java
! src/java.base/share/classes/java/nio/file/FileSystemAlreadyExistsException.java
! src/java.base/share/classes/java/nio/file/FileSystemException.java
! src/java.base/share/classes/java/nio/file/FileSystemLoopException.java
! src/java.base/share/classes/java/nio/file/FileSystemNotFoundException.java
! src/java.base/share/classes/java/nio/file/InvalidPathException.java
! src/java.base/share/classes/java/nio/file/LinkPermission.java
! src/java.base/share/classes/java/nio/file/NoSuchFileException.java
! src/java.base/share/classes/java/nio/file/NotDirectoryException.java
! src/java.base/share/classes/java/nio/file/NotLinkException.java
! src/java.base/share/classes/java/nio/file/ProviderMismatchException.java
! src/java.base/share/classes/java/nio/file/ProviderNotFoundException.java
! src/java.base/share/classes/java/nio/file/ReadOnlyFileSystemException.java
! src/java.base/share/classes/java/nio/file/attribute/UserPrincipalNotFoundException.java
! src/java.base/share/classes/java/text/AttributedCharacterIterator.java
! src/java.base/share/classes/java/text/ChoiceFormat.java
! src/java.base/share/classes/java/text/CompactNumberFormat.java
! src/java.base/share/classes/java/text/DateFormat.java
! src/java.base/share/classes/java/text/DateFormatSymbols.java
! src/java.base/share/classes/java/text/DecimalFormat.java
! src/java.base/share/classes/java/text/DecimalFormatSymbols.java
! src/java.base/share/classes/java/text/Format.java
! src/java.base/share/classes/java/text/MessageFormat.java
! src/java.base/share/classes/java/text/NumberFormat.java
! src/java.base/share/classes/java/text/ParseException.java
! src/java.base/share/classes/java/text/SimpleDateFormat.java
! src/java.base/share/classes/java/time/Clock.java
! src/java.base/share/classes/java/time/DateTimeException.java
! src/java.base/share/classes/java/time/Duration.java
! src/java.base/share/classes/java/time/Instant.java
! src/java.base/share/classes/java/time/LocalDate.java
! src/java.base/share/classes/java/time/LocalDateTime.java
! src/java.base/share/classes/java/time/LocalTime.java
! src/java.base/share/classes/java/time/MonthDay.java
! src/java.base/share/classes/java/time/OffsetDateTime.java
! src/java.base/share/classes/java/time/OffsetTime.java
! src/java.base/share/classes/java/time/Period.java
! src/java.base/share/classes/java/time/Ser.java
! src/java.base/share/classes/java/time/Year.java
! src/java.base/share/classes/java/time/YearMonth.java
! src/java.base/share/classes/java/time/ZoneId.java
! src/java.base/share/classes/java/time/ZoneOffset.java
! src/java.base/share/classes/java/time/ZoneRegion.java
! src/java.base/share/classes/java/time/ZonedDateTime.java
! src/java.base/share/classes/java/time/chrono/AbstractChronology.java
! src/java.base/share/classes/java/time/chrono/ChronoLocalDateImpl.java
! src/java.base/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java
! src/java.base/share/classes/java/time/chrono/ChronoPeriodImpl.java
! src/java.base/share/classes/java/time/chrono/ChronoZonedDateTimeImpl.java
! src/java.base/share/classes/java/time/chrono/HijrahChronology.java
! src/java.base/share/classes/java/time/chrono/HijrahDate.java
! src/java.base/share/classes/java/time/chrono/IsoChronology.java
! src/java.base/share/classes/java/time/chrono/JapaneseChronology.java
! src/java.base/share/classes/java/time/chrono/JapaneseDate.java
! src/java.base/share/classes/java/time/chrono/JapaneseEra.java
! src/java.base/share/classes/java/time/chrono/MinguoChronology.java
! src/java.base/share/classes/java/time/chrono/MinguoDate.java
! src/java.base/share/classes/java/time/chrono/Ser.java
! src/java.base/share/classes/java/time/chrono/ThaiBuddhistChronology.java
! src/java.base/share/classes/java/time/chrono/ThaiBuddhistDate.java
! src/java.base/share/classes/java/time/format/DateTimeParseException.java
! src/java.base/share/classes/java/time/temporal/UnsupportedTemporalTypeException.java
! src/java.base/share/classes/java/time/temporal/ValueRange.java
! src/java.base/share/classes/java/time/temporal/WeekFields.java
! src/java.base/share/classes/java/util/AbstractMap.java
! src/java.base/share/classes/java/util/ArrayDeque.java
! src/java.base/share/classes/java/util/ArrayList.java
! src/java.base/share/classes/java/util/ArrayPrefixHelpers.java
! src/java.base/share/classes/java/util/Arrays.java
! src/java.base/share/classes/java/util/ArraysParallelSortHelpers.java
! src/java.base/share/classes/java/util/BitSet.java
! src/java.base/share/classes/java/util/Calendar.java
! src/java.base/share/classes/java/util/Collections.java
! src/java.base/share/classes/java/util/Comparators.java
! src/java.base/share/classes/java/util/ConcurrentModificationException.java
! src/java.base/share/classes/java/util/Currency.java
! src/java.base/share/classes/java/util/Date.java
! src/java.base/share/classes/java/util/DuplicateFormatFlagsException.java
! src/java.base/share/classes/java/util/EmptyStackException.java
! src/java.base/share/classes/java/util/EnumMap.java
! src/java.base/share/classes/java/util/EnumSet.java
! src/java.base/share/classes/java/util/EventObject.java
! src/java.base/share/classes/java/util/FormatFlagsConversionMismatchException.java
! src/java.base/share/classes/java/util/FormatterClosedException.java
! src/java.base/share/classes/java/util/GregorianCalendar.java
! src/java.base/share/classes/java/util/HashMap.java
! src/java.base/share/classes/java/util/HashSet.java
! src/java.base/share/classes/java/util/Hashtable.java
! src/java.base/share/classes/java/util/IdentityHashMap.java
! src/java.base/share/classes/java/util/IllegalFormatCodePointException.java
! src/java.base/share/classes/java/util/IllegalFormatConversionException.java
! src/java.base/share/classes/java/util/IllegalFormatException.java
! src/java.base/share/classes/java/util/IllegalFormatFlagsException.java
! src/java.base/share/classes/java/util/IllegalFormatPrecisionException.java
! src/java.base/share/classes/java/util/IllegalFormatWidthException.java
! src/java.base/share/classes/java/util/IllformedLocaleException.java
! src/java.base/share/classes/java/util/ImmutableCollections.java
! src/java.base/share/classes/java/util/InputMismatchException.java
! src/java.base/share/classes/java/util/InvalidPropertiesFormatException.java
! src/java.base/share/classes/java/util/JapaneseImperialCalendar.java
! src/java.base/share/classes/java/util/JumboEnumSet.java
! src/java.base/share/classes/java/util/LinkedHashMap.java
! src/java.base/share/classes/java/util/LinkedHashSet.java
! src/java.base/share/classes/java/util/LinkedList.java
! src/java.base/share/classes/java/util/Locale.java
! src/java.base/share/classes/java/util/MissingFormatArgumentException.java
! src/java.base/share/classes/java/util/MissingFormatWidthException.java
! src/java.base/share/classes/java/util/MissingResourceException.java
! src/java.base/share/classes/java/util/NoSuchElementException.java
! src/java.base/share/classes/java/util/PriorityQueue.java
! src/java.base/share/classes/java/util/Properties.java
! src/java.base/share/classes/java/util/PropertyPermission.java
! src/java.base/share/classes/java/util/Random.java
! src/java.base/share/classes/java/util/RegularEnumSet.java
! src/java.base/share/classes/java/util/ServiceConfigurationError.java
! src/java.base/share/classes/java/util/SimpleTimeZone.java
! src/java.base/share/classes/java/util/Stack.java
! src/java.base/share/classes/java/util/TimeZone.java
! src/java.base/share/classes/java/util/TooManyListenersException.java
! src/java.base/share/classes/java/util/TreeMap.java
! src/java.base/share/classes/java/util/TreeSet.java
! src/java.base/share/classes/java/util/UUID.java
! src/java.base/share/classes/java/util/UnknownFormatConversionException.java
! src/java.base/share/classes/java/util/UnknownFormatFlagsException.java
! src/java.base/share/classes/java/util/Vector.java
! src/java.base/share/classes/java/util/jar/JarException.java
! src/java.base/share/classes/java/util/jar/JarVerifier.java
! src/java.base/share/classes/java/util/regex/Pattern.java
! src/java.base/share/classes/java/util/regex/PatternSyntaxException.java
! src/java.base/share/classes/java/util/zip/DataFormatException.java
! src/java.base/share/classes/java/util/zip/ZipError.java
! src/java.base/share/classes/java/util/zip/ZipException.java
! src/java.base/share/classes/javax/net/ssl/HandshakeCompletedEvent.java
! src/java.base/share/classes/javax/net/ssl/SSLException.java
! src/java.base/share/classes/javax/net/ssl/SSLHandshakeException.java
! src/java.base/share/classes/javax/net/ssl/SSLKeyException.java
! src/java.base/share/classes/javax/net/ssl/SSLPeerUnverifiedException.java
! src/java.base/share/classes/javax/net/ssl/SSLPermission.java
! src/java.base/share/classes/javax/net/ssl/SSLProtocolException.java
! src/java.base/share/classes/javax/net/ssl/SSLSessionBindingEvent.java
! src/java.base/share/classes/jdk/internal/loader/AbstractClassLoaderValue.java
! src/java.base/share/classes/jdk/internal/org/xml/sax/SAXException.java
! src/java.base/share/classes/jdk/internal/org/xml/sax/SAXNotRecognizedException.java
! src/java.base/share/classes/jdk/internal/org/xml/sax/SAXNotSupportedException.java
! src/java.base/share/classes/jdk/internal/org/xml/sax/SAXParseException.java
! src/java.base/share/classes/jdk/internal/util/jar/InvalidJarIndexError.java
! src/java.base/share/classes/jdk/internal/util/xml/XMLStreamException.java
! src/java.base/share/classes/sun/net/ConnectionResetException.java
! src/java.base/share/classes/sun/net/TelnetProtocolException.java
! src/java.base/share/classes/sun/net/ftp/FtpLoginException.java
! src/java.base/share/classes/sun/net/ftp/FtpProtocolException.java
! src/java.base/share/classes/sun/net/smtp/SmtpProtocolException.java
! src/java.base/share/classes/sun/net/www/ApplicationLaunchException.java
! src/java.base/share/classes/sun/net/www/http/KeepAliveCache.java
! src/java.base/share/classes/sun/net/www/protocol/http/AuthCacheValue.java
! src/java.base/share/classes/sun/net/www/protocol/http/AuthenticationInfo.java
! src/java.base/share/classes/sun/net/www/protocol/http/BasicAuthentication.java
! src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthentication.java
! src/java.base/share/classes/sun/net/www/protocol/http/NegotiateAuthentication.java
! src/java.base/share/classes/sun/nio/ch/Reflect.java
! src/java.base/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java
! src/java.base/share/classes/sun/reflect/annotation/AnnotationTypeMismatchExceptionProxy.java
! src/java.base/share/classes/sun/reflect/annotation/EnumConstantNotPresentExceptionProxy.java
! src/java.base/share/classes/sun/reflect/annotation/ExceptionProxy.java
! src/java.base/share/classes/sun/reflect/annotation/TypeNotPresentExceptionProxy.java
! src/java.base/share/classes/sun/reflect/generics/reflectiveObjects/NotImplementedException.java
! src/java.base/share/classes/sun/util/BuddhistCalendar.java
! src/java.base/share/classes/sun/util/calendar/ZoneInfo.java
! src/java.base/share/classes/sun/util/locale/LocaleSyntaxException.java

Changeset: 4364524f8cac
Author:    pli
Date:      2019-08-30 09:38 +0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/4364524f8cac

8229797: [JVMCI] Clean up no longer used JVMCI::dependencies_invalid value
Reviewed-by: dlong, coleenp
Contributed-by: doug.simon at oracle.com, xiaohong.gong at arm.com

! src/hotspot/share/jvmci/jvmci.hpp
! src/hotspot/share/jvmci/jvmciRuntime.cpp
! src/hotspot/share/jvmci/vmStructs_jvmci.cpp
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/CompilerToVM.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotCodeCacheProvider.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotVMConfig.java

Changeset: bfb76c34e5c5
Author:    jiefu
Date:      2019-08-30 01:21 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/bfb76c34e5c5

8230376: [TESTBUG] runtime/StackTrace/HiddenFrameTest.java fails with release VM
Reviewed-by: dholmes

! test/hotspot/jtreg/runtime/StackTrace/HiddenFrameTest.java

Changeset: 6b539901e79e
Author:    stefank
Date:      2019-08-30 09:06 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/6b539901e79e

8230203: Replace markWord enums with typed constants
Reviewed-by: kbarrett, dholmes

! src/hotspot/cpu/aarch64/aarch64.ad
! src/hotspot/cpu/arm/macroAssembler_arm.cpp
! src/hotspot/cpu/ppc/macroAssembler_ppc.cpp
! src/hotspot/share/interpreter/bytecodeInterpreter.cpp
! src/hotspot/share/oops/markWord.hpp
! src/hotspot/share/opto/macro.cpp
! src/hotspot/share/runtime/thread.cpp

Changeset: 28915ebc6510
Author:    amlu
Date:      2019-08-30 16:44 +0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/28915ebc6510

8230004: jdk/internal/jimage/JImageOpenTest.java runs no test
Reviewed-by: alanb

! test/jdk/jdk/internal/jimage/JImageOpenTest.java
! test/jdk/jdk/internal/jimage/JImageReadTest.java
! test/jdk/jdk/internal/jimage/TEST.properties

Changeset: 421cc7c347cf
Author:    thartmann
Date:      2019-08-30 11:11 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/421cc7c347cf

8230388: Problemlist additional compiler/rtm tests
Summary: Putting tests on the problem list.
Reviewed-by: roland

! test/hotspot/jtreg/ProblemList.txt

Changeset: 4b436b5d1630
Author:    eosterlund
Date:      2019-08-30 10:44 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/4b436b5d1630

8230307: ZGC: Make zGlobals and zArguments OS agnostic
Reviewed-by: pliden, smonteith

+ src/hotspot/cpu/aarch64/gc/z/zArguments_aarch64.cpp
+ src/hotspot/cpu/aarch64/gc/z/zGlobals_aarch64.cpp
+ src/hotspot/cpu/aarch64/gc/z/zGlobals_aarch64.hpp
+ src/hotspot/cpu/x86/gc/z/zArguments_x86.cpp
+ src/hotspot/cpu/x86/gc/z/zGlobals_x86.cpp
+ src/hotspot/cpu/x86/gc/z/zGlobals_x86.hpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zArguments_linux_aarch64.cpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zGlobals_linux_aarch64.cpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zGlobals_linux_aarch64.hpp
- src/hotspot/os_cpu/linux_x86/gc/z/zArguments_linux_x86.cpp
- src/hotspot/os_cpu/linux_x86/gc/z/zGlobals_linux_x86.cpp
- src/hotspot/os_cpu/linux_x86/gc/z/zGlobals_linux_x86.hpp
! src/hotspot/share/gc/z/zGlobals.hpp

Changeset: ed7eb20871c5
Author:    jlahoda
Date:      2019-08-30 12:24 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/ed7eb20871c5

8230105: -XDfind=diamond crashes
Summary: Avoiding side-effects in Analyzer's speculative attribution.
Reviewed-by: mcimadamore, vromero

! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Analyzer.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ArgumentAttr.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/AttrContext.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/DeferredAttr.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java
+ test/langtools/tools/javac/analyzer/AnalyzerMandatoryWarnings.java
+ test/langtools/tools/javac/analyzer/AnalyzerMandatoryWarnings.out
+ test/langtools/tools/javac/analyzer/AnalyzerNotQuiteSpeculative.java
+ test/langtools/tools/javac/analyzer/AnalyzerNotQuiteSpeculative.out
+ test/langtools/tools/javac/analyzer/DoNoRunAnalyzersWhenException.java
+ test/langtools/tools/javac/analyzer/StuckLambdas.java
+ test/langtools/tools/javac/analyzer/StuckLambdas.out

Changeset: 6bee0a3d2a3a
Author:    jpai
Date:      2019-08-28 20:05 +0530
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/6bee0a3d2a3a

8230310: SocksSocketImpl should handle the IllegalArgumentException thrown by ProxySelector.select usage
Summary: Catch the IAE thrown by ProxySelector.select and wrap it into a IOException
Reviewed-by: dfuchs

! src/java.base/share/classes/java/net/SocksSocketImpl.java
+ test/jdk/java/net/Socks/SocksSocketImplTest.java

Changeset: ef15850629cd
Author:    dfuchs
Date:      2019-08-30 12:44 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/ef15850629cd

8193596: java/net/DatagramPacket/ReuseBuf.java failed due to timeout
Summary: The test is changed to bind to InetAddress.getLocalHost() instead of binding to the wildcard.
Reviewed-by: alanb, dfuchs, msheppar
Contributed-by: Patrick Concannon <catrick.concannon at oracle.com>

! test/jdk/java/net/DatagramPacket/ReuseBuf.java

Changeset: 481a6a3449c8
Author:    thartmann
Date:      2019-08-30 16:17 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/481a6a3449c8

8230390: Problemlist SA tests with AOT
Summary: Putting tests on the problem list.
Reviewed-by: roland

! test/hotspot/jtreg/ProblemList-aot.txt

Changeset: 6f0215981777
Author:    kbarrett
Date:      2019-08-30 14:05 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/6f0215981777

8230327: Make G1DirtyCardQueueSet free-id init unconditional
Summary: Remove conditional init and make the set an inline member.
Reviewed-by: sjohanss, lkorinth, tschatzl

! src/hotspot/share/gc/g1/g1CollectedHeap.cpp
! src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp
! src/hotspot/share/gc/g1/g1DirtyCardQueue.hpp
! src/hotspot/share/gc/g1/g1FreeIdSet.hpp

Changeset: f249fc6665d5
Author:    darcy
Date:      2019-08-30 11:26 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/f249fc6665d5

8230337: Clarify intention of Elements.{getPackageOf, getModuleOf}
Reviewed-by: jjg

! src/java.compiler/share/classes/javax/lang/model/util/Elements.java
+ test/langtools/tools/javac/processing/model/util/elements/TestGetModuleOf.java
! test/langtools/tools/javac/processing/model/util/elements/TestGetPackageOf.java

Changeset: 374f3f9dda6f
Author:    tonyp
Date:      2019-08-30 14:58 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/374f3f9dda6f

8227224: GenCollectedHeap: add subspace transitions for young gen for gc+heap=info log lines
Reviewed-by: kbarrett, tschatzl

! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp
! src/hotspot/share/gc/shared/genCollectedHeap.cpp
! src/hotspot/share/gc/shared/genCollectedHeap.hpp

Changeset: e9a0224b45a1
Author:    kbarrett
Date:      2019-08-30 15:36 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/e9a0224b45a1

8230372: Remove G1GCPhaseTimes::MergeLBProcessedBuffers
Summary: Removed no longer needed phase time.
Reviewed-by: sjohanss, tschatzl

! src/hotspot/share/gc/g1/g1CollectedHeap.cpp
! src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp
! src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp
! test/hotspot/jtreg/gc/g1/TestGCLogMessages.java

Changeset: 1262b3ddd7e4
Author:    darcy
Date:      2019-08-31 09:18 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/1262b3ddd7e4

8230373: Use java.io.Serial in generated exception types
Reviewed-by: erikj, alanb

! make/scripts/genExceptions.sh

Changeset: a333fdeb8de0
Author:    mbaesken
Date:      2019-08-30 09:37 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/a333fdeb8de0

8224214: [AIX] Remove support for legacy xlc compiler
Reviewed-by: erikj, kbarrett, mdoerr, dholmes

! make/autoconf/flags-cflags.m4
! make/autoconf/toolchain.m4
! src/hotspot/os/aix/os_aix.cpp
! src/hotspot/share/gc/shared/oopStorage.hpp
! src/hotspot/share/gc/shared/ptrQueue.hpp
! src/hotspot/share/memory/allocation.hpp
! src/hotspot/share/runtime/vm_version.cpp
! src/hotspot/share/utilities/globalDefinitions_xlc.hpp

Changeset: 47ce198d5cf1
Author:    shade
Date:      2019-09-02 11:31 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/47ce198d5cf1

8230238: Add another regression test for JDK-8134739
Reviewed-by: kvn

+ test/hotspot/jtreg/compiler/loopopts/superword/TestFuzzPreLoop.java

Changeset: 42a13b4e9553
Author:    shade
Date:      2019-09-02 12:10 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/42a13b4e9553

8230425: Shenandoah forces +UseNUMAInterleaving even after explicitly disabled
Reviewed-by: rkennke

! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp

Changeset: be5865bda5b9
Author:    mdoerr
Date:      2019-08-12 19:20 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/be5865bda5b9

8229422: Taskqueue: Outdated selection of weak memory model platforms
Reviewed-by: tschatzl, dholmes, drwhite

! src/hotspot/cpu/aarch64/globalDefinitions_aarch64.hpp
! src/hotspot/cpu/arm/globalDefinitions_arm.hpp
! src/hotspot/cpu/ppc/globalDefinitions_ppc.hpp
! src/hotspot/cpu/s390/globalDefinitions_s390.hpp
! src/hotspot/cpu/sparc/globalDefinitions_sparc.hpp
! src/hotspot/cpu/x86/globalDefinitions_x86.hpp
! src/hotspot/share/gc/shared/taskqueue.inline.hpp
! src/hotspot/share/utilities/globalDefinitions.hpp

Changeset: 94481c2b9388
Author:    mgronlun
Date:      2019-09-02 13:57 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/94481c2b9388

8229437: assert(is_aligned(ref, HeapWordSize)) failed: invariant
Reviewed-by: egahlin

! src/hotspot/share/jfr/leakprofiler/chains/bfsClosure.cpp
! src/hotspot/share/jfr/leakprofiler/chains/dfsClosure.cpp

Changeset: ca9e3b68a969
Author:    mgronlun
Date:      2019-09-02 15:04 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/ca9e3b68a969

8227411: TestTimeMultiple.java failed "assert(!lease()) failed: invariant"
Reviewed-by: egahlin

! src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointManager.cpp

Changeset: c4ec55644b4b
Author:    michaelm
Date:      2019-09-02 15:58 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/c4ec55644b4b

8229235: com.sun.net.httpserver.HttpExchange should implement AutoCloseable
Reviewed-by: dfuchs, michaelm
Contributed-by: patrick.concannon at oracle.com

! src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpExchange.java
+ test/jdk/com/sun/net/httpserver/bugs/HttpExchange/AutoCloseableHttpExchange.java
+ test/jdk/com/sun/net/httpserver/bugs/HttpExchange/jdk.httpserver/sun/net/httpserver/HttpExchangeAccess.java

Changeset: f571cc16478a
Author:    michaelm
Date:      2019-09-02 15:59 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/f571cc16478a

Merge


Changeset: 2172fd713350
Author:    thartmann
Date:      2019-09-03 10:03 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/2172fd713350

8230428: Cleanup dead CastIP node code in formssel.cpp
Summary: Removed dead code.
Reviewed-by: roland

! src/hotspot/share/adlc/formssel.cpp

Changeset: 197f36af94f3
Author:    jpai
Date:      2019-08-30 17:22 +0530
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/197f36af94f3

8223714: HTTPSetAuthenticatorTest could be made more resilient
Summary: HTTPTestServer (in the test infrastructure) will no longer stop accepting requests if a previous request processing failed
Reviewed-by: dfuchs

! test/jdk/java/net/HttpURLConnection/SetAuthenticator/HTTPTestServer.java

Changeset: d8f22418ca99
Author:    zgu
Date:      2019-09-03 13:55 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/d8f22418ca99

8230483: Shenandoah: consistently disable concurrent roots for Traversal mode
Reviewed-by: shade

! src/hotspot/share/gc/shenandoah/shenandoahConcurrentRoots.cpp

Changeset: bf3fb5465543
Author:    vlivanov
Date:      2019-09-03 17:45 +0300
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/bf3fb5465543

8227236: assert(singleton != __null && singleton != declared_interface) failed
Reviewed-by: dlong

! src/hotspot/share/c1/c1_GraphBuilder.cpp
! src/hotspot/share/ci/ciInstanceKlass.hpp
! src/hotspot/share/opto/doCall.cpp

Changeset: 849acc346a1d
Author:    dholmes
Date:      2019-09-03 23:42 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/849acc346a1d

6313903: Thread.sleep(3) might wake up immediately on windows
Reviewed-by: rehn, dcubed, rriggs

! src/hotspot/os/posix/os_posix.cpp
! src/hotspot/os/windows/os_windows.cpp
! src/hotspot/share/runtime/os.cpp

Changeset: b7afd4b040d3
Author:    jjiang
Date:      2019-09-04 12:47 +0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/b7afd4b040d3

8226221: Update PKCS11 tests to use NSS 3.46 libs
Reviewed-by: xuelei

! test/jdk/sun/security/pkcs11/PKCS11Test.java

Changeset: 62926eb5e40e
Author:    mbaesken
Date:      2019-09-03 16:52 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/62926eb5e40e

8230485: add handling of aix tar in configure
Reviewed-by: erikj

! make/autoconf/basics.m4

Changeset: 0437b0f20312
Author:    mbaesken
Date:      2019-09-03 17:52 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/0437b0f20312

8229182: runtime/containers/docker/TestMemoryAwareness.java test fails on SLES12
Reviewed-by: clanger, mseledtsov

! test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
! test/lib/jdk/test/lib/containers/docker/DockerRunOptions.java
! test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java

Changeset: 01d31583f25c
Author:    sjohanss
Date:      2019-09-04 09:47 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/01d31583f25c

8230431: Move G1 trace code from gcTrace* to G1 directory
Reviewed-by: kbarrett, lkorinth

! src/hotspot/share/gc/g1/g1CollectedHeap.cpp
! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp
! src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp
! src/hotspot/share/gc/g1/g1FullGCScope.hpp
! src/hotspot/share/gc/g1/g1IHOPControl.cpp
! src/hotspot/share/gc/g1/g1MMUTracker.cpp
! src/hotspot/share/gc/g1/g1ParScanThreadState.cpp
+ src/hotspot/share/gc/g1/g1Trace.cpp
+ src/hotspot/share/gc/g1/g1Trace.hpp
! src/hotspot/share/gc/shared/gcTrace.cpp
! src/hotspot/share/gc/shared/gcTrace.hpp
! src/hotspot/share/gc/shared/gcTraceSend.cpp

Changeset: a645b2f7bece
Author:    sjohanss
Date:      2019-09-04 09:47 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/a645b2f7bece

8209802: Garbage collectors should register JFR types themselves to avoid build errors.
Reviewed-by: kbarrett, tschatzl

! src/hotspot/share/gc/g1/g1CollectedHeap.cpp
! src/hotspot/share/gc/g1/g1HeapRegionEventSender.cpp
! src/hotspot/share/gc/g1/g1Trace.cpp
! src/hotspot/share/gc/g1/g1Trace.hpp
! src/hotspot/share/jfr/periodic/jfrPeriodic.cpp
! src/hotspot/share/jfr/recorder/checkpoint/types/jfrType.cpp
! src/hotspot/share/jfr/recorder/checkpoint/types/jfrType.hpp
! src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeManager.cpp

Changeset: dee322336e17
Author:    mdoerr
Date:      2019-09-04 14:21 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/dee322336e17

8230434: [C1, C2] Release barrier for volatile field stores in constructors implemented inconsistently
Reviewed-by: shade, lucy

! src/hotspot/share/c1/c1_GraphBuilder.cpp
! src/hotspot/share/opto/parse1.cpp

Changeset: 9ee010450e84
Author:    eosterlund
Date:      2019-09-04 15:05 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/9ee010450e84

8230401: ClassLoaderData::_keep_alive is read with wrong type in c2i entry barrier
Reviewed-by: zgu, tschatzl, iklam

! src/hotspot/share/classfile/classLoaderData.hpp

Changeset: cf8164854fda
Author:    xliu
Date:      2019-09-04 16:39 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/cf8164854fda

8229450: C2 compilation fails with assert(found_sfpt) failed
Reviewed-by: roland, thartmann

! src/hotspot/share/opto/loopopts.cpp
+ test/hotspot/jtreg/compiler/loopstripmining/LoadDependsOnIfIdenticalToLoopExit.java

Changeset: fbbe6672ae15
Author:    dfuchs
Date:      2019-09-04 16:42 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/fbbe6672ae15

8230159: Add test to verify that com.sun.net.httpserver.BasicAuthenticator constructors throw expected exceptions
Summary: new BasicAuthenticatorExceptionCheck.java test added
Reviewed-by: chegar, dfuchs, vtewari
Contributed-by: Patrick Concannon <patrick.concannon at oracle.com>

+ test/jdk/com/sun/net/httpserver/bugs/BasicAuthenticatorExceptionCheck.java

Changeset: 9ae63aa9fc22
Author:    dfuchs
Date:      2019-09-04 17:36 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/9ae63aa9fc22

8171405: java/net/URLConnection/ResendPostBody.java failed with "Error while cleaning up threads after test"
Summary: test cleaned up to improve safe termination
Reviewed-by: michaelm, vtewari, dfuchs
Contributed-by: Julia Boes <julia.boes at oracle.com>

! test/jdk/java/net/URLConnection/ResendPostBody.java

Changeset: 0daf32316b47
Author:    dfuchs
Date:      2019-09-04 18:10 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/0daf32316b47

8230435: Replace wildcard address with loopback or local host in tests - part 22
Summary: fixes tests to use the loopback address whenever possible. It also fixes some safe publishing issues, or add diagnostics in some of the tests.
Reviewed-by: michaelm

! test/jdk/com/sun/net/httpserver/bugs/8199849/BasicAuthenticatorCharset.java
! test/jdk/java/net/Authenticator/B4678055.java
! test/jdk/java/net/DatagramSocket/PortUnreachable.java
! test/jdk/java/net/URLConnection/RedirectLimit.java
! test/jdk/java/net/URLConnection/Responses.java
! test/jdk/javax/net/ssl/templates/SSLSocketTemplate.java
! test/jdk/sun/net/InetAddress/nameservice/simple/DefaultCaching.java
! test/jdk/sun/net/www/AuthHeaderTest.java
! test/jdk/sun/net/www/http/HttpClient/RetryPost.java
! test/jdk/sun/net/www/protocol/https/HttpsClient/ProxyAuthTest.java
! test/jdk/sun/net/www/protocol/https/HttpsClient/ProxyTunnelServer.java
! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/B6216082.java
! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/B6226610.java
! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/HttpsProxyStackOverflow.java
! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/TunnelProxy.java

Changeset: ef055f777569
Author:    mseledtsov
Date:      2019-09-04 13:57 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/ef055f777569

8230624: [TESTBUG] Problemlist JFR compiler/TestCodeSweeper.java
Summary: Added the test to the problem list
Reviewed-by: egahlin

! test/jdk/ProblemList.txt

Changeset: f016cc0874f0
Author:    darcy
Date:      2019-09-04 15:49 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/f016cc0874f0

8230626: Make UnknownFooException strings more informative
Reviewed-by: jjg, mr

! src/java.compiler/share/classes/javax/lang/model/element/UnknownAnnotationValueException.java
! src/java.compiler/share/classes/javax/lang/model/element/UnknownElementException.java
! src/java.compiler/share/classes/javax/lang/model/type/UnknownTypeException.java

Changeset: 70cb43a67409
Author:    jwilhelm
Date:      2019-09-05 02:13 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/70cb43a67409

Added tag jdk-14+13 for changeset fbbe6672ae15

! .hgtags

Changeset: d80e4bce4588
Author:    jjiang
Date:      2019-09-05 14:55 +0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/d80e4bce4588

8228967: Trust/Key store and SSL context utilities for tests
Reviewed-by: xuelei

! test/jdk/java/security/cert/CertPathBuilder/targetConstraints/BuildEEBasicConstraints.java
! test/jdk/java/security/cert/X509CRL/VerifyDefault.java
! test/jdk/java/security/cert/X509Certificate/VerifyDefault.java
- test/jdk/java/security/testlibrary/CertUtils.java
! test/jdk/javax/net/ssl/DTLS/CipherSuite.java
! test/jdk/javax/net/ssl/DTLS/ClientAuth.java
! test/jdk/javax/net/ssl/DTLS/DTLSOverDatagram.java
! test/jdk/javax/net/ssl/DTLS/InvalidCookie.java
! test/jdk/javax/net/ssl/DTLS/InvalidRecords.java
! test/jdk/javax/net/ssl/DTLS/NoMacInitialClientHello.java
! test/jdk/javax/net/ssl/DTLS/PacketLossRetransmission.java
! test/jdk/javax/net/ssl/DTLS/Reordered.java
! test/jdk/javax/net/ssl/DTLS/RespondToRetransmit.java
! test/jdk/javax/net/ssl/DTLS/Retransmission.java
! test/jdk/javax/net/ssl/DTLS/WeakCipherSuite.java
! test/jdk/sun/security/mscapi/KeytoolChangeAlias.java
! test/jdk/sun/security/util/HostnameMatcher/NullHostnameCheck.java
! test/jdk/sun/security/util/HostnameMatcher/TestHostnameChecker.java
+ test/lib/jdk/test/lib/security/CertUtils.java
+ test/lib/jdk/test/lib/security/KeyEntry.java
+ test/lib/jdk/test/lib/security/KeyStoreUtils.java
+ test/lib/jdk/test/lib/security/SSLContextBuilder.java

Changeset: aba258cd7df8
Author:    eosterlund
Date:      2019-09-05 08:26 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/aba258cd7df8

8229189: Improve JFR leak profiler tracing to deal with discontiguous heaps
Reviewed-by: mgronlun, egahlin

! src/hotspot/share/jfr/leakprofiler/chains/bfsClosure.cpp
! src/hotspot/share/jfr/leakprofiler/chains/bitset.cpp
! src/hotspot/share/jfr/leakprofiler/chains/bitset.hpp
+ src/hotspot/share/jfr/leakprofiler/chains/bitset.inline.hpp
! src/hotspot/share/jfr/leakprofiler/chains/dfsClosure.cpp
! src/hotspot/share/jfr/leakprofiler/chains/pathToGcRootsOperation.cpp
! src/hotspot/share/utilities/hashtable.cpp

Changeset: dd84de796f2c
Author:    eosterlund
Date:      2019-09-05 08:26 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/dd84de796f2c

8224815: Remove non-GC uses of CollectedHeap::is_in_reserved()
Reviewed-by: stefank, coleenp

! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp
! src/hotspot/cpu/sparc/c1_LIRAssembler_sparc.cpp
! src/hotspot/cpu/sparc/macroAssembler_sparc.cpp
! src/hotspot/cpu/x86/relocInfo_x86.cpp
! src/hotspot/cpu/x86/x86_64.ad
! src/hotspot/share/ci/ciObjectFactory.cpp
! src/hotspot/share/code/debugInfo.cpp
! src/hotspot/share/gc/cms/cmsHeap.hpp
! src/hotspot/share/gc/cms/jvmFlagConstraintsCMS.cpp
! src/hotspot/share/gc/epsilon/epsilonHeap.cpp
! src/hotspot/share/gc/epsilon/epsilonHeap.hpp
! src/hotspot/share/gc/g1/g1Allocator.inline.hpp
! src/hotspot/share/gc/g1/g1CollectedHeap.cpp
! src/hotspot/share/gc/g1/g1CollectedHeap.hpp
! src/hotspot/share/gc/g1/g1FullGCOopClosures.inline.hpp
! src/hotspot/share/gc/g1/g1OopClosures.inline.hpp
! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp
! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp
! src/hotspot/share/gc/serial/markSweep.cpp
! src/hotspot/share/gc/serial/markSweep.inline.hpp
! src/hotspot/share/gc/shared/blockOffsetTable.cpp
! src/hotspot/share/gc/shared/collectedHeap.cpp
! src/hotspot/share/gc/shared/collectedHeap.hpp
! src/hotspot/share/gc/shared/gcVMOperations.cpp
! src/hotspot/share/gc/shared/genCollectedHeap.cpp
! src/hotspot/share/gc/shared/genCollectedHeap.hpp
! src/hotspot/share/gc/shared/markBitMap.cpp
! src/hotspot/share/gc/shared/referenceProcessor.cpp
! src/hotspot/share/gc/shared/stringdedup/stringDedupTable.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp
! src/hotspot/share/gc/z/zCollectedHeap.cpp
! src/hotspot/share/gc/z/zCollectedHeap.hpp
! src/hotspot/share/interpreter/interpreterRuntime.cpp
! src/hotspot/share/jvmci/jvmciRuntime.cpp
! src/hotspot/share/memory/filemap.cpp
! src/hotspot/share/memory/filemap.hpp
! src/hotspot/share/memory/metaspace.cpp
! src/hotspot/share/memory/universe.cpp
! src/hotspot/share/memory/universe.hpp
! src/hotspot/share/memory/virtualspace.cpp
! src/hotspot/share/memory/virtualspace.hpp
! src/hotspot/share/oops/compressedOops.cpp
! src/hotspot/share/oops/compressedOops.hpp
! src/hotspot/share/oops/compressedOops.inline.hpp
! src/hotspot/share/oops/oop.cpp
! src/hotspot/share/oops/oop.hpp
! src/hotspot/share/oops/oop.inline.hpp
! src/hotspot/share/oops/oopsHierarchy.hpp
! src/hotspot/share/oops/symbol.cpp
! src/hotspot/share/opto/machnode.cpp
! src/hotspot/share/prims/jvmtiTagMap.cpp
! src/hotspot/share/runtime/jniHandles.cpp
! test/hotspot/gtest/gc/shared/test_collectedHeap.cpp
! test/hotspot/jtreg/gc/g1/TestLargePageUseForHeap.java

Changeset: c8bc506106e3
Author:    stuefe
Date:      2019-09-05 11:09 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/c8bc506106e3

8230642: 8224815 broke Shenandoah build
Reviewed-by: shade

! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp

Changeset: 9726449d2644
Author:    mbaesken
Date:      2019-09-05 09:59 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/9726449d2644

8230466: check malloc/calloc results in jdk.hotspot.agent
Reviewed-by: cjplummer, ysuenaga, sspitsyn

! src/jdk.hotspot.agent/linux/native/libsaproc/symtab.c
! src/jdk.hotspot.agent/macosx/native/libsaproc/MacosxDebuggerLocal.m
! src/jdk.hotspot.agent/macosx/native/libsaproc/symtab.c

Changeset: a3c63a9dfb2c
Author:    jlahoda
Date:      2019-09-05 12:39 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/a3c63a9dfb2c

8177068: incomplete classpath causes NPE in Flow
Summary: Undo completions that failed during speculative attribution, so that the appropriate CompletionFailures are thrown again and properly reported.
Reviewed-by: vromero

! src/jdk.compiler/share/classes/com/sun/tools/javac/code/DeferredCompletionFailureHandler.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/DeferredAttr.java
+ test/langtools/tools/javac/T8177068/NoCompletionFailureSkipOnSpeculativeAttribution.java

Changeset: 86b95fc6ca32
Author:    thartmann
Date:      2019-09-05 13:56 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/86b95fc6ca32

8229496: SIGFPE (division by zero) in C2 OSR compiled method
Summary: Adding a CastNode to keep the dependency between the div/mod operation and the zero check.
Reviewed-by: roland, mdoerr

! src/hotspot/cpu/aarch64/aarch64.ad
! src/hotspot/cpu/arm/arm.ad
! src/hotspot/cpu/ppc/ppc.ad
! src/hotspot/cpu/s390/s390.ad
! src/hotspot/cpu/sparc/sparc.ad
! src/hotspot/cpu/x86/x86_32.ad
! src/hotspot/cpu/x86/x86_64.ad
! src/hotspot/share/opto/castnode.cpp
! src/hotspot/share/opto/castnode.hpp
! src/hotspot/share/opto/cfgnode.cpp
! src/hotspot/share/opto/classes.hpp
! src/hotspot/share/opto/graphKit.cpp
! src/hotspot/share/opto/node.hpp
! src/hotspot/share/runtime/vmStructs.cpp
+ test/hotspot/jtreg/compiler/loopopts/TestDivZeroCheckControl.java

Changeset: 5f5ca2e02f6e
Author:    shade
Date:      2019-09-05 19:24 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/5f5ca2e02f6e

8230646: Epsilon does not extend TLABs to max size
Reviewed-by: tschatzl, zgu

! src/hotspot/share/gc/epsilon/epsilonHeap.cpp

Changeset: 12885822f0c5
Author:    joehw
Date:      2019-09-05 17:26 +0000
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/12885822f0c5

8228854: Default ErrorListener reports warnings and errors to the console
Reviewed-by: lancea

! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/AbstractTranslet.java
! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/MessageHandler.java
! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/output/TransletOutputHandlerFactory.java
! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerFactoryImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/SerializerBase.java
! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/ToHTMLStream.java
! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/ToStream.java
! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/ToTextStream.java
! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/ToUnknownStream.java
! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/ToXMLStream.java
! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/dom3/LSSerializerImpl.java
! src/java.xml/share/classes/javax/xml/transform/ErrorListener.java
! src/java.xml/share/classes/javax/xml/transform/package-info.java
+ src/java.xml/share/classes/jdk/xml/internal/TransformErrorListener.java
! test/jaxp/javax/xml/jaxp/unittest/transform/ErrorListenerTest.java

Changeset: 06f3d5092832
Author:    ccheung
Date:      2019-09-05 11:12 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/06f3d5092832

8230632: [TESTBUG] appcds/NonExistClasspath.java and ClassPathAttr.java failed when running in hotspot_appcds_dynamic test group
Summary: Exclude NonExistClasspath.java from the test group; increase timeout for ClassPathAttr.java.
Reviewed-by: dcubed, iklam

! test/hotspot/jtreg/TEST.groups
! test/hotspot/jtreg/runtime/cds/appcds/ClassPathAttr.java

Changeset: 6eb44470aa98
Author:    bpb
Date:      2019-09-05 14:12 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/6eb44470aa98

8229280: Test failures on several linux hosts after JDK-8181493
Reviewed-by: alanb, clanger, dfuchs

! test/jdk/java/nio/file/attribute/BasicFileAttributeView/SetTimesNanos.java

Changeset: cfd0f43fdf5f
Author:    dholmes
Date:      2019-09-05 18:39 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/cfd0f43fdf5f

8227563: jvmti/scenarios/contention/TC05/tc05t001 fails due to "ERROR: tc05t001.cpp, 278: (waitedThreadCpuTime - waitThreadCpuTime) < (EXPECTED_ACCURACY * 1000000)"
Reviewed-by: amenkov, cjplummer, sspitsyn

! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/contention/TC05/tc05t001/TestDescription.java
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/contention/TC05/tc05t001/tc05t001.cpp

Changeset: 1e3f58d409f7
Author:    darcy
Date:      2019-09-05 15:55 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/1e3f58d409f7

8230681: Add @since tag to java.io.Serial
Reviewed-by: lancea, bpb

! src/java.base/share/classes/java/io/Serial.java

Changeset: 930551e8ac62
Author:    bpb
Date:      2019-09-05 16:26 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/930551e8ac62

8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause
Reviewed-by: alanb, rriggs, lancea, darcy

! src/java.base/share/classes/java/io/PrintStream.java
+ test/jdk/java/io/PrintStream/WriteBytes.java

Changeset: 7ac4273bb49b
Author:    naoto
Date:      2019-09-05 17:38 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/7ac4273bb49b

8229831: Upgrade Character.isUnicodeIdentifierStart/Part() methods to the latest standard
Reviewed-by: rriggs

! make/data/characterdata/CharacterData00.java.template
! make/data/characterdata/CharacterData01.java.template
! make/data/characterdata/CharacterData02.java.template
! make/data/characterdata/CharacterData0E.java.template
! make/data/characterdata/CharacterDataLatin1.java.template
+ make/data/unicodedata/DerivedCoreProperties.txt
! make/gensrc/GensrcCharacterData.gmk
! make/jdk/src/classes/build/tools/generatecharacter/GenerateCharacter.java
! make/jdk/src/classes/build/tools/generatecharacter/PropList.java
! src/java.base/share/classes/java/lang/Character.java
! test/jdk/java/lang/Character/CharPropTest.java
! test/jdk/java/lang/Character/CheckProp.java
! test/jdk/lib/testlibrary/java/lang/UCDFiles.java

Changeset: 66c880e5d21d
Author:    shade
Date:      2019-09-06 09:26 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/66c880e5d21d

8230671: x86_32 build failures after JDK-8229496
Reviewed-by: thartmann

! src/hotspot/cpu/x86/x86_32.ad

Changeset: d6e2dbf20eaa
Author:    rrich
Date:      2019-08-30 09:24 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/d6e2dbf20eaa

8230363: C2: Let ConnectionGraph::not_global_escape(Node* n) return false if n is not in the CG
Reviewed-by: thartmann, mdoerr

! src/hotspot/share/opto/escape.cpp

Changeset: 5aaf53d4fe63
Author:    dfuchs
Date:      2019-09-06 14:04 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/5aaf53d4fe63

8230694: http.keepAlive system property is inconsistently/incorrectly documented
Summary: trivially fixed the net-properties.html file
Reviewed-by: alanb

! src/java.base/share/classes/java/net/doc-files/net-properties.html

Changeset: 1ebc2f316e45
Author:    clanger
Date:      2019-09-06 15:13 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/1ebc2f316e45

8230666: Exclude serviceability/sa/TestInstanceKlassSize.java on linuxppc64 and linuxppc64le
Reviewed-by: dcubed

! test/hotspot/jtreg/ProblemList.txt

Changeset: 9162feb63c42
Author:    kbarrett
Date:      2019-09-06 13:38 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/9162feb63c42

8230404: Refactor logged card refinement support in G1DirtyCardQueueSet
Summary: Separate concurrent refinement from STW refinement.
Reviewed-by: sjohanss, tschatzl

! src/hotspot/share/gc/g1/g1CardTableEntryClosure.hpp
! src/hotspot/share/gc/g1/g1CollectedHeap.cpp
! src/hotspot/share/gc/g1/g1CollectedHeap.hpp
! src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp
! src/hotspot/share/gc/g1/g1DirtyCardQueue.hpp
! src/hotspot/share/gc/g1/g1HotCardCache.cpp
! src/hotspot/share/gc/g1/g1RemSet.cpp

Changeset: 318cd16cc202
Author:    dlong
Date:      2019-09-06 14:54 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/318cd16cc202

8230680: latest Graal unittests depend on jdk.internal.module
Reviewed-by: iignatyev

! make/test/JtregGraalUnit.gmk

Changeset: 378007c18687
Author:    erikj
Date:      2019-09-06 12:41 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/378007c18687

8230715: Baseline compare build on Windows fails intermittently in file type for jvm.pdb
Reviewed-by: mikael

! make/scripts/compare.sh

Changeset: aa3715655834
Author:    redestad
Date:      2019-09-07 15:44 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/aa3715655834

8230662: Remove dead code from MethodTypeForm
Reviewed-by: vlivanov, mchung

! src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java
! src/java.base/share/classes/java/lang/invoke/MethodType.java
! src/java.base/share/classes/java/lang/invoke/MethodTypeForm.java

Changeset: c7374ff3f3a3
Author:    zgu
Date:      2019-09-07 10:04 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/c7374ff3f3a3

8230730: UseCompressedOops test crash with assertion failure
Reviewed-by: stefank, eosterlund

! src/hotspot/share/oops/compressedOops.cpp

Changeset: d99af76d7689
Author:    iveresov
Date:      2019-09-07 10:05 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/d99af76d7689

8226953: AOT: assert(oopDesc::is_oop(obj)) failed: not an oop
Reviewed-by: dlong

! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotForeignCallsProvider.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotForeignCallsProvider.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.sparc/src/org/graalvm/compiler/hotspot/sparc/SPARCHotSpotForeignCallsProvider.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/HotSpotMethodSubstitutionTest.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotForeignCallLinkage.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotForeignCallLinkageImpl.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotHostForeignCallsProvider.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/ThreadSubstitutions.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/ForeignCallStub.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/MethodSubstitutionTest.java

Changeset: d8902e9c307c
Author:    dholmes
Date:      2019-09-07 18:48 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/d8902e9c307c

8230422: Convert uninterruptible os::sleep calls to os::naked_short_sleep
Reviewed-by: kbarrett, dcubed, shade

! src/hotspot/cpu/x86/rdtsc_x86.cpp
! src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp
! src/hotspot/share/gc/cms/parNewGeneration.cpp
! src/hotspot/share/gc/parallel/psCardTable.cpp
! src/hotspot/share/gc/parallel/psOldGen.cpp
! src/hotspot/share/gc/parallel/psPromotionManager.inline.hpp
! src/hotspot/share/gc/serial/tenuredGeneration.cpp
! src/hotspot/share/gc/shared/taskqueue.cpp
! src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp
! src/hotspot/share/jvmci/jvmciCompiler.cpp
! src/hotspot/share/jvmci/jvmciRuntime.cpp
! src/hotspot/share/prims/jvm.cpp
! src/hotspot/share/runtime/os.cpp
! src/hotspot/share/runtime/os.hpp
! src/hotspot/share/runtime/safepoint.cpp
! test/hotspot/gtest/gc/g1/test_g1FreeIdSet.cpp
! test/hotspot/gtest/gc/shared/test_ptrQueueBufferAllocator.cpp
! test/hotspot/gtest/utilities/test_singleWriterSynchronizer.cpp

Changeset: 95c206a3e53c
Author:    xgong
Date:      2019-09-09 11:19 +0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/95c206a3e53c

8230129: Add jtreg "serviceability/sa/ClhsdbInspect.java" to graal problem list.
Reviewed-by: dlong, thartmann

! test/hotspot/jtreg/ProblemList-graal.txt

Changeset: 647d623650d3
Author:    rehn
Date:      2019-09-09 09:05 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/647d623650d3

8228758: assert(_no_handle_mark_nesting == 0) failed: allocating handle inside NoHandleMark
Reviewed-by: coleenp, dcubed, dholmes

! src/hotspot/share/prims/jni.cpp
! src/hotspot/share/prims/jvm.cpp
! src/hotspot/share/runtime/interfaceSupport.inline.hpp

Changeset: 3277a7454dc5
Author:    stefank
Date:      2019-09-04 11:05 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/3277a7454dc5

8224599: Remove globals_ext.hpp
Reviewed-by: coleenp, kvn, gziemski, ehelin

! src/hotspot/share/gc/cms/jvmFlagConstraintsCMS.hpp
! src/hotspot/share/gc/g1/jvmFlagConstraintsG1.hpp
! src/hotspot/share/gc/parallel/jvmFlagConstraintsParallel.hpp
! src/hotspot/share/gc/shared/jvmFlagConstraintsGC.hpp
! src/hotspot/share/runtime/flags/jvmFlag.cpp
! src/hotspot/share/runtime/flags/jvmFlag.hpp
! src/hotspot/share/runtime/flags/jvmFlagConstraintList.cpp
! src/hotspot/share/runtime/flags/jvmFlagRangeList.cpp
! src/hotspot/share/runtime/flags/jvmFlagWriteableList.cpp
! src/hotspot/share/runtime/globals.cpp
! src/hotspot/share/runtime/globals.hpp
- src/hotspot/share/runtime/globals_ext.hpp
! src/hotspot/share/runtime/globals_extension.hpp
! src/hotspot/share/runtime/os_ext.hpp
! test/hotspot/gtest/runtime/test_globals.cpp

Changeset: a0a67b6b8183
Author:    stefank
Date:      2019-09-04 11:38 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/a0a67b6b8183

8230561: Remove logTag_ext.hpp
Reviewed-by: dholmes, coleenp

! src/hotspot/share/logging/logTag.hpp
- src/hotspot/share/logging/logTag_ext.hpp

Changeset: 7efe5923cfdc
Author:    stefank
Date:      2019-09-04 13:06 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/7efe5923cfdc

8230562: Remove g1HeapSizingPolicy_ext.cpp
Reviewed-by: dholmes, sjohanss

! src/hotspot/share/gc/g1/g1HeapSizingPolicy.cpp
- src/hotspot/share/gc/g1/g1HeapSizingPolicy_ext.cpp

Changeset: 01905d6a828b
Author:    stefank
Date:      2019-09-04 13:06 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/01905d6a828b

8230563: Remove arguments_ext.cpp
Reviewed-by: dholmes, coleenp

! src/hotspot/share/runtime/arguments.cpp
- src/hotspot/share/runtime/arguments_ext.cpp

Changeset: 8009a9c36251
Author:    stefank
Date:      2019-09-04 13:07 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/8009a9c36251

8230564: Remove os_ext.hpp
Reviewed-by: coleenp, dholmes

! src/hotspot/share/runtime/init.cpp
! src/hotspot/share/runtime/os.cpp
! src/hotspot/share/runtime/os.hpp
- src/hotspot/share/runtime/os_ext.hpp

Changeset: 9fba708740d6
Author:    glaubitz
Date:      2019-09-09 15:14 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/9fba708740d6

8230708: Hotspot fails to build on linux-sparc with gcc-9
Reviewed-by: dholmes, phh

! src/hotspot/cpu/sparc/nativeInst_sparc.hpp

Changeset: 505e28fe1769
Author:    mdoerr
Date:      2019-09-09 15:42 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/505e28fe1769

8230669: [s390] C1: assert(is_bound() || is_unused()) failed: Label was never bound to a location, but it was used as a jmp target
Reviewed-by: phh, xliu

! src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp
! src/hotspot/share/c1/c1_Compilation.hpp

Changeset: bc4e7a84e89d
Author:    dfuchs
Date:      2019-09-09 16:13 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/bc4e7a84e89d

8230132: java/net/NetworkInterface/NetworkInterfaceRetrievalTests.java to skip Teredo Tunneling Pseudo-Interface
Summary: The test is updated to skip Teredo pseudo interfaces on windows.
Reviewed-by: michaelm, vtewari, aefimov
Contributed-by: patrick.concannon at oracle.com

! test/jdk/java/net/NetworkInterface/NetworkInterfaceRetrievalTests.java

Changeset: 1a296c9064dc
Author:    jpai
Date:      2019-08-24 09:31 +0530
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/1a296c9064dc

8177389: Hyphen "-" should be removed in URL class documentation
Summary: javadoc of java.net.URL constructor updated to remove an unnecessary hyphen
Reviewed-by: dfuchs

! src/java.base/share/classes/java/net/URL.java

Changeset: ee230ad8cfef
Author:    darcy
Date:      2019-09-09 10:13 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/ee230ad8cfef

8230723: Remove default constructors from java.lang and java.io
Reviewed-by: bpb, rriggs

! src/java.base/share/classes/java/io/InputStream.java
! src/java.base/share/classes/java/io/ObjectInputStream.java
! src/java.base/share/classes/java/io/ObjectOutputStream.java
! src/java.base/share/classes/java/io/OutputStream.java
! src/java.base/share/classes/java/lang/InheritableThreadLocal.java
! src/java.base/share/classes/java/lang/LiveStackFrame.java
! src/java.base/share/classes/java/lang/ThreadDeath.java
! src/java.base/share/classes/java/lang/invoke/ClassSpecializer.java
! src/java.base/share/classes/java/lang/invoke/ConstantBootstraps.java
! src/java.base/share/classes/java/lang/reflect/Modifier.java

Changeset: 734f7711f87c
Author:    dfuchs
Date:      2019-09-09 18:23 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/734f7711f87c

8230526: jdk.internal.net.http.PlainProxyConnection is never reused by HttpClient
Summary: fixed the PlainProxyConnection lookup key.
Reviewed-by: chegar

! src/java.net.http/share/classes/jdk/internal/net/http/ConnectionPool.java
+ test/jdk/java/net/httpclient/PlainProxyConnectionTest.java

Changeset: db92a157dd70
Author:    bchristi
Date:      2019-09-09 11:04 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/db92a157dd70

8212117: Class.forName may return a reference to a loaded but not linked Class
Reviewed-by: dholmes, mchung

! make/hotspot/symbols/symbols-unix
! src/hotspot/share/include/jvm.h
! src/hotspot/share/prims/jni.cpp
! src/hotspot/share/prims/jvm.cpp
! src/hotspot/share/prims/jvm_misc.hpp
! src/hotspot/share/runtime/globals.hpp
! src/java.base/share/classes/java/lang/Class.java
! src/java.base/share/classes/java/lang/invoke/MethodHandles.java
! src/java.base/share/classes/sun/launcher/LauncherHelper.java
! src/java.base/share/native/libjava/Class.c
! test/hotspot/jtreg/gc/logging/TestMetaSpaceLog.java
+ test/hotspot/jtreg/serviceability/jvmti/ClassStatus/ClassStatus.java
+ test/hotspot/jtreg/serviceability/jvmti/ClassStatus/libClassStatus.c

Changeset: f894baf8d871
Author:    amenkov
Date:      2019-09-09 12:00 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/f894baf8d871

8230516: invalid html in jdwp-protocol.html
Reviewed-by: dtitov, sspitsyn

! make/jdk/src/classes/build/tools/jdwpgen/ConstantNode.java
! make/jdk/src/classes/build/tools/jdwpgen/ConstantSetNode.java

Changeset: b553ad95acf0
Author:    naoto
Date:      2019-09-09 12:42 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/b553ad95acf0

8230284: Accounting currency format support does not cope with explicit number system
Reviewed-by: rriggs

! make/jdk/src/classes/build/tools/cldrconverter/Bundle.java
! make/jdk/src/classes/build/tools/cldrconverter/CLDRConverter.java
! make/jdk/src/classes/build/tools/cldrconverter/LDMLParseHandler.java
! src/java.base/share/classes/sun/util/locale/provider/LocaleResources.java
! test/jdk/java/text/Format/NumberFormat/DFSMinusPerCentMill.java
! test/jdk/java/util/Locale/bcp47u/CurrencyFormatTests.java
! test/jdk/sun/text/resources/LocaleData.cldr
! test/jdk/sun/text/resources/LocaleDataTest.java

Changeset: baa4dd528de0
Author:    kbarrett
Date:      2019-09-09 16:54 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/baa4dd528de0

8221361: Eliminate two-phase initialization for PtrQueueSet classes
Summary: Move allocator and CBL monitor init to constructor.
Reviewed-by: tschatzl, shade

! src/hotspot/share/gc/g1/g1BarrierSet.cpp
! src/hotspot/share/gc/g1/g1BarrierSet.hpp
! src/hotspot/share/gc/g1/g1CollectedHeap.cpp
! src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp
! src/hotspot/share/gc/g1/g1DirtyCardQueue.hpp
! src/hotspot/share/gc/g1/g1RedirtyCardsQueue.cpp
! src/hotspot/share/gc/g1/g1SATBMarkQueueSet.cpp
! src/hotspot/share/gc/g1/g1SATBMarkQueueSet.hpp
! src/hotspot/share/gc/shared/ptrQueue.cpp
! src/hotspot/share/gc/shared/ptrQueue.hpp
! src/hotspot/share/gc/shared/satbMarkQueue.cpp
! src/hotspot/share/gc/shared/satbMarkQueue.hpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.cpp
! src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.hpp

Changeset: 44f3609f46af
Author:    godin
Date:      2019-09-10 07:42 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/44f3609f46af

8207800: always_do_update_barrier is unused
Reviewed-by: shade, tschatzl
Contributed-by: Evgeny Mandrikov <mandrikov at gmail.com>

! src/hotspot/share/gc/cms/cmsHeap.cpp
! src/hotspot/share/gc/g1/g1CollectedHeap.cpp
! src/hotspot/share/gc/shared/genArguments.cpp
! src/hotspot/share/oops/oop.cpp
! src/hotspot/share/oops/oop.hpp

Changeset: fafba5cf3546
Author:    chagedorn
Date:      2019-09-10 08:43 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/fafba5cf3546

8225653: Provide more information when hitting SIGILL from HaltNode
Summary: Add information string for each HaltNode which is printed if hit at runtime.
Reviewed-by: vlivanov, thartmann

! src/hotspot/cpu/x86/x86.ad
! src/hotspot/share/adlc/main.cpp
! src/hotspot/share/adlc/output_c.cpp
! src/hotspot/share/opto/callnode.cpp
! src/hotspot/share/opto/graphKit.cpp
! src/hotspot/share/opto/loopTransform.cpp
! src/hotspot/share/opto/loopnode.cpp
! src/hotspot/share/opto/machnode.hpp
! src/hotspot/share/opto/memnode.cpp
! src/hotspot/share/opto/node.hpp
! src/hotspot/share/opto/rootnode.cpp
! src/hotspot/share/opto/rootnode.hpp

Changeset: 65cad575ace3
Author:    xgong
Date:      2019-09-10 14:52 +0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/65cad575ace3

8230454: [Graal] Add "com/sun/crypto/provider/KeyFactory/TestProviderLeak.java" to Graal problem list.
Reviewed-by: dlong

! test/jdk/ProblemList-graal.txt

Changeset: d8f60e5bb4a6
Author:    mbaesken
Date:      2019-09-06 16:15 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/d8f60e5bb4a6

8230711: ConnectionGraph::unique_java_object(Node* N) return NULL if n is not in the CG
Reviewed-by: mdoerr

! src/hotspot/share/opto/escape.cpp

Changeset: 3fee0e6b54f5
Author:    mbaesken
Date:      2019-09-09 16:34 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/3fee0e6b54f5

8230769: BufImg_SetupICM add ReleasePrimitiveArrayCritical call in early return
Reviewed-by: prr, stuefe

! src/java.desktop/share/native/libawt/awt/image/BufImgSurfaceData.c

Changeset: 8407928b9fe5
Author:    pliden
Date:      2019-09-10 11:11 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/8407928b9fe5

8230566: ZGC: Don't substitute klass pointer during array clearing
Reviewed-by: stefank, eosterlund

! src/hotspot/share/gc/z/zBarrier.cpp
! src/hotspot/share/gc/z/zBarrier.hpp
! src/hotspot/share/gc/z/zBarrier.inline.hpp
! src/hotspot/share/gc/z/zHeap.hpp
! src/hotspot/share/gc/z/zHeap.inline.hpp
! src/hotspot/share/gc/z/zHeapIterator.cpp
! src/hotspot/share/gc/z/zMark.cpp
! src/hotspot/share/gc/z/zMark.hpp
! src/hotspot/share/gc/z/zMark.inline.hpp
! src/hotspot/share/gc/z/zMarkStackEntry.hpp
! src/hotspot/share/gc/z/zObjArrayAllocator.cpp
! src/hotspot/share/gc/z/zObjArrayAllocator.hpp
! src/hotspot/share/gc/z/zRelocate.cpp
! src/hotspot/share/gc/z/zRootsIterator.cpp
! src/hotspot/share/gc/z/zRootsIterator.hpp
! src/hotspot/share/gc/z/zThreadLocalData.hpp

Changeset: 8a066d872553
Author:    hannesw
Date:      2019-09-10 15:30 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/8a066d872553

8230766: Changed message in IllegalMonitorStateException
Reviewed-by: attila, jlaskey

! test/nashorn/script/basic/javaexceptions.js.EXPECTED

Changeset: 336687518f92
Author:    hannesw
Date:      2019-09-10 15:35 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/336687518f92

8230709: Array index out of bounds in ES6 mode
Reviewed-by: attila

! src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/ir/LexicalContext.java
+ test/nashorn/script/basic/es6/JDK-8230709.js

Changeset: 6eca527d3689
Author:    igerasim
Date:      2019-09-10 09:08 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/6eca527d3689

8230303: JDB hangs when running monitor command
Reviewed-by: sspitsyn

! src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTY.java
+ test/hotspot/jtreg/vmTestbase/nsk/jdb/monitor/monitor002/monitor002.java
+ test/hotspot/jtreg/vmTestbase/nsk/jdb/monitor/monitor002/monitor002a.java

Changeset: 6488adc963b8
Author:    lmesnik
Date:      2019-09-10 09:12 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/6488adc963b8

8230781: Add JTREG_FAILURE_HANDLER_TIMEOUT to control timeout handler timeout
Reviewed-by: erikj

! make/RunTests.gmk

Changeset: 874edfe72c3e
Author:    darcy
Date:      2019-09-10 10:24 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/874edfe72c3e

8225761: Update --release 13 symbol information after JDK 13 GA
Reviewed-by: jlahoda

! make/data/symbols/java.base-D.sym.txt
+ make/data/symbols/java.security.jgss-D.sym.txt
! make/data/symbols/jdk.compiler-D.sym.txt
+ make/data/symbols/jdk.jartool-D.sym.txt
! make/data/symbols/symbols

Changeset: 41f119856e7c
Author:    mchung
Date:      2019-09-10 10:35 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/41f119856e7c

8229785: MethodType::fromMethodDescriptorString should require security permission if loader is null
Reviewed-by: vromero

! src/java.base/share/classes/java/lang/constant/MethodTypeDescImpl.java
! src/java.base/share/classes/java/lang/invoke/MethodType.java
! src/java.base/share/classes/sun/invoke/util/BytecodeDescriptor.java
+ test/jdk/java/lang/constant/methodTypeDesc/ResolveConstantDesc.java
+ test/jdk/java/lang/constant/methodTypeDesc/jdk.unsupported/sun/misc/Test.java
+ test/jdk/java/lang/constant/methodTypeDesc/test.policy
! test/jdk/java/lang/invoke/FindClassSecurityManager.java
+ test/jdk/java/lang/invoke/MethodTypeSecurityManager.java
- test/jdk/java/lang/invoke/findclass.security.policy
+ test/jdk/java/lang/invoke/getclassloader.policy

Changeset: 8db87a43a1ce
Author:    shade
Date:      2019-09-10 19:58 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/8db87a43a1ce

8230813: Add JDK-8010500 to compiler/loopopts/superword/TestFuzzPreLoop.java bug list
Reviewed-by: zgu

! test/hotspot/jtreg/compiler/loopopts/superword/TestFuzzPreLoop.java

Changeset: 931799bfbc10
Author:    naoto
Date:      2019-09-10 12:51 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/931799bfbc10

8229960: Remove sun.nio.cs.map system property
Reviewed-by: alanb

! make/data/charsetmapping/charsets
! make/data/charsetmapping/stdcs-linux
! make/data/charsetmapping/stdcs-windows
! src/java.base/share/classes/sun/nio/cs/StandardCharsets.java.template
! src/java.base/share/lib/security/default.policy
! src/jdk.charsets/share/classes/sun/nio/cs/ext/ExtendedCharsets.java.template
! test/jdk/java/nio/charset/coders/Check.java
- test/jdk/java/nio/charset/coders/SJISMappingPropTest.java
- test/jdk/java/nio/charset/coders/SJISPropTest.java
- test/jdk/java/nio/charset/coders/ref.windows-31j
! test/jdk/java/nio/charset/spi/default-pol
! test/jdk/sun/nio/cs/TestMS5022X.java

Changeset: 8b08eaf9a0eb
Author:    tschatzl
Date:      2019-09-11 10:19 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/8b08eaf9a0eb

8230794: Improve assert to get more information about the JDK-8227695 failure
Reviewed-by: kbarrett, sjohanss

! src/hotspot/share/gc/g1/g1CollectedHeap.cpp

Changeset: 9046db64ca39
Author:    lkorinth
Date:      2019-09-11 14:16 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/9046db64ca39

8227168: Cleanup usage of NEW_C_HEAP_ARRAY
Reviewed-by: coleenp, dholmes, kbarrett, tschatzl

! src/hotspot/os/aix/os_aix.cpp
! src/hotspot/os/aix/os_perf_aix.cpp
! src/hotspot/os/bsd/os_bsd.cpp
! src/hotspot/os/linux/os_linux.cpp
! src/hotspot/os/linux/os_perf_linux.cpp
! src/hotspot/os/solaris/os_perf_solaris.cpp
! src/hotspot/os/solaris/os_solaris.cpp
! src/hotspot/os/windows/os_perf_windows.cpp
! src/hotspot/os/windows/perfMemory_windows.cpp
! src/hotspot/share/classfile/moduleEntry.cpp
! src/hotspot/share/compiler/oopMap.cpp
! src/hotspot/share/gc/cms/parNewGeneration.cpp
! src/hotspot/share/gc/parallel/psCompactionManager.cpp
! src/hotspot/share/gc/shared/cardTableRS.cpp
! src/hotspot/share/gc/shared/referenceProcessor.cpp
! src/hotspot/share/gc/shared/workgroup.cpp
! src/hotspot/share/interpreter/oopMapCache.cpp
! src/hotspot/share/memory/allocation.hpp
! src/hotspot/share/runtime/os.cpp
! src/hotspot/share/runtime/perfData.cpp
! src/hotspot/share/runtime/synchronizer.cpp
! src/hotspot/share/runtime/thread.cpp
! src/hotspot/share/services/memoryManager.cpp

Changeset: cddef3bde924
Author:    lkorinth
Date:      2019-09-11 14:16 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/cddef3bde924

8230398: Remove NULL checks before FREE_C_HEAP_ARRAY
Reviewed-by: dholmes, kbarrett, tschatzl

! src/hotspot/os/aix/perfMemory_aix.cpp
! src/hotspot/os/bsd/perfMemory_bsd.cpp
! src/hotspot/os/linux/perfMemory_linux.cpp
! src/hotspot/os/solaris/os_perf_solaris.cpp
! src/hotspot/os/solaris/os_solaris.cpp
! src/hotspot/os/solaris/perfMemory_solaris.cpp
! src/hotspot/os/windows/os_perf_windows.cpp
! src/hotspot/os/windows/os_windows.cpp
! src/hotspot/os/windows/perfMemory_windows.cpp
! src/hotspot/share/aot/aotCodeHeap.cpp
! src/hotspot/share/classfile/classLoader.cpp
! src/hotspot/share/classfile/systemDictionaryShared.cpp
! src/hotspot/share/code/codeBlob.cpp
! src/hotspot/share/gc/cms/gSpaceCounters.cpp
! src/hotspot/share/gc/epsilon/epsilonMonitoringSupport.cpp
! src/hotspot/share/gc/g1/g1CollectionSet.cpp
! src/hotspot/share/gc/g1/g1RemSetSummary.cpp
! src/hotspot/share/gc/g1/heapRegionManager.cpp
! src/hotspot/share/gc/g1/sparsePRT.cpp
! src/hotspot/share/gc/parallel/spaceCounters.cpp
! src/hotspot/share/gc/serial/cSpaceCounters.cpp
! src/hotspot/share/gc/shared/cardTableRS.cpp
! src/hotspot/share/gc/shared/collectorCounters.cpp
! src/hotspot/share/gc/shared/generationCounters.cpp
! src/hotspot/share/gc/shared/hSpaceCounters.cpp
! src/hotspot/share/gc/shared/workgroup.cpp
! src/hotspot/share/gc/z/zArray.inline.hpp
! src/hotspot/share/jfr/recorder/stacktrace/jfrStackTraceRepository.cpp
! src/hotspot/share/jfr/support/jfrThreadLocal.cpp
! src/hotspot/share/jfr/utilities/jfrHashtable.hpp
! src/hotspot/share/jvmci/jvmciCodeInstaller.cpp
! src/hotspot/share/memory/allocation.cpp
! src/hotspot/share/memory/allocation.hpp
! src/hotspot/share/oops/instanceKlass.cpp
! src/hotspot/share/prims/unsafe.cpp
! src/hotspot/share/runtime/arguments.cpp
! src/hotspot/share/runtime/os.cpp
! src/hotspot/share/runtime/os.hpp
! src/hotspot/share/runtime/os_perf.hpp
! src/hotspot/share/runtime/perfData.cpp
! src/hotspot/share/runtime/sharedRuntime.cpp
! src/hotspot/share/runtime/thread.cpp
! src/hotspot/share/services/diagnosticArgument.cpp
! src/hotspot/share/utilities/hashtable.cpp

Changeset: d52f77f0acb5
Author:    naoto
Date:      2019-09-11 08:50 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/d52f77f0acb5

8230136: DateTimeFormatterBuilder.FractionPrinterParser#parse fails to verify minWidth
Reviewed-by: joehw, scolebourne, rriggs

! src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java
! test/jdk/java/time/test/java/time/format/TestFractionPrinterParser.java

Changeset: 03964761a23c
Author:    bobv
Date:      2019-09-11 17:30 +0000
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/03964761a23c

8229202: Docker reporting causes secondary crashes in error handling
Reviewed-by: coleenp, hseigel, mseledtsov

! src/hotspot/os/linux/osContainer_linux.hpp

Changeset: e2de6e166880
Author:    amenkov
Date:      2019-09-11 11:55 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/e2de6e166880

8192057: com/sun/jdi/BadHandshakeTest.java fails with java.net.ConnectException
Reviewed-by: sspitsyn, rrich

! test/jdk/com/sun/jdi/BadHandshakeTest.java

Changeset: e64fec9f1773
Author:    bpb
Date:      2019-09-11 12:32 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/e64fec9f1773

8230342: LineNumberReader.getLineNumber() returns inconsistent results after EOF
Reviewed-by: rriggs, dfuchs

! src/java.base/share/classes/java/io/BufferedReader.java
! src/java.base/share/classes/java/io/LineNumberReader.java
! test/jdk/java/io/LineNumberReader/Read.java

Changeset: 91bc4d6c4054
Author:    iklam
Date:      2019-09-11 13:28 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/91bc4d6c4054

8230674: Heap dumps should exclude dormant CDS archived objects of unloaded classes
Reviewed-by: dholmes, jiangli

! src/hotspot/share/services/heapDumper.cpp

Changeset: c0cc906cb29c
Author:    darcy
Date:      2019-09-11 16:06 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/c0cc906cb29c

8230734: Remove default constructors from java.compiler
Reviewed-by: jjg

! src/java.compiler/share/classes/javax/tools/DiagnosticCollector.java
! src/java.compiler/share/classes/javax/tools/ToolProvider.java

Changeset: b00b4706ec0f
Author:    afarley
Date:      2019-09-11 23:10 +0000
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/b00b4706ec0f

8229378: jdwp library loader in linker_md.c quietly truncates on buffer overflow
Summary: Check buffer overflow when the jdwp agent full dll name is built
Reviewed-by: cjplummer, sspitsyn

! src/jdk.jdwp.agent/unix/native/libjdwp/linker_md.c
! src/jdk.jdwp.agent/windows/native/libjdwp/linker_md.c

Changeset: 50e1d346a126
Author:    lmesnik
Date:      2019-09-11 16:25 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/50e1d346a126

8230830: No required ResourceMark in src/hotspot/share/prims/jvmtiImpl.cpp:JvmtiSuspendControl::print()
Reviewed-by: dholmes, cjplummer, sspitsyn

! src/hotspot/share/prims/jvmtiImpl.cpp

Changeset: 0f6c749acd15
Author:    jwilhelm
Date:      2019-09-12 03:21 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/0f6c749acd15

Added tag jdk-14+14 for changeset cddef3bde924

! .hgtags

Changeset: adc72cd1d1f2
Author:    dholmes
Date:      2019-09-11 22:09 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/adc72cd1d1f2

8230423: Move os::sleep to JavaThread::sleep
Reviewed-by: rehn, dcubed

! src/hotspot/cpu/x86/rdtsc_x86.cpp
! src/hotspot/os/posix/os_posix.cpp
! src/hotspot/os/windows/os_windows.cpp
! src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp
! src/hotspot/share/jvmci/jvmciCompiler.cpp
! src/hotspot/share/jvmci/jvmciRuntime.cpp
! src/hotspot/share/prims/jvm.cpp
! src/hotspot/share/runtime/os.cpp
! src/hotspot/share/runtime/os.hpp
! src/hotspot/share/runtime/thread.cpp
! src/hotspot/share/runtime/thread.hpp
! test/hotspot/gtest/gc/g1/test_g1FreeIdSet.cpp
! test/hotspot/gtest/gc/shared/test_ptrQueueBufferAllocator.cpp
! test/hotspot/gtest/utilities/test_singleWriterSynchronizer.cpp

Changeset: 0d97bf7cf8a4
Author:    iklam
Date:      2019-09-11 18:31 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/0d97bf7cf8a4

8230586: Encapsulate fields in filemap.hpp
Reviewed-by: ccheung

! src/hotspot/share/classfile/classLoaderExt.cpp
! src/hotspot/share/classfile/systemDictionaryShared.cpp
! src/hotspot/share/include/cds.h
! src/hotspot/share/interpreter/abstractInterpreter.cpp
! src/hotspot/share/memory/dynamicArchive.cpp
! src/hotspot/share/memory/dynamicArchive.hpp
! src/hotspot/share/memory/filemap.cpp
! src/hotspot/share/memory/filemap.hpp
! src/hotspot/share/memory/metaspaceShared.cpp
! src/hotspot/share/memory/metaspaceShared.hpp
! src/hotspot/share/prims/cdsoffsets.cpp
! test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/ArchiveConsistency.java

Changeset: fa0514bdc09b
Author:    mbaesken
Date:      2019-09-11 16:54 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/fa0514bdc09b

8230861: missing ReleaseStringUTFChars in Java_sun_security_pkcs11_wrapper_PKCS11_connect
Reviewed-by: alanb, stuefe

! src/jdk.crypto.cryptoki/unix/native/libj2pkcs11/p11_md.c

Changeset: ea93d6a9f720
Author:    mbaesken
Date:      2019-09-11 16:13 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/ea93d6a9f720

8230856: Java_java_net_NetworkInterface_getByName0 on unix misses ReleaseStringUTFChars in early return
Reviewed-by: dfuchs, stuefe, vtewari

! src/java.base/unix/native/libnet/NetworkInterface.c

Changeset: b2a4b22f8cf2
Author:    roland
Date:      2019-08-23 14:22 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/b2a4b22f8cf2

8229701: aarch64: C2 OSR compilation fails with "shouldn't process one node several times" in final graph reshaping
Reviewed-by: thartmann, kvn

! src/hotspot/share/opto/compile.cpp
+ test/hotspot/jtreg/compiler/c2/aarch64/ConvI2LWideningAssertTooStrong.java

Changeset: 689a80d20550
Author:    chagedorn
Date:      2019-09-12 12:12 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/689a80d20550

8230762: Change MacroAssembler::debug32/64 to use fatal instead of assert
Summary: Always call fatal from debug32/64 to also crash in product build as a follow-up to JDK-8225653.
Reviewed-by: roland, thartmann

! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp
! src/hotspot/cpu/x86/macroAssembler_x86.cpp
! src/hotspot/cpu/x86/stubGenerator_x86_32.cpp
! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp

Changeset: 46e11f978852
Author:    chagedorn
Date:      2019-09-12 12:23 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/46e11f978852

8220416: Comparison of klass pointers is not optimized any more
Summary: Enables dead klass pointer optimization (since JDK-6964458) again.
Reviewed-by: roland, thartmann

! src/hotspot/share/opto/subnode.cpp

Changeset: efcda145fb2c
Author:    stuefe
Date:      2019-09-12 12:51 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/efcda145fb2c

8230888: jfrVirtualMemory.cpp should include globals.hpp
Reviewed-by: dholmes, mgronlun

! src/hotspot/share/jfr/recorder/storage/jfrVirtualMemory.cpp

Changeset: 79186d82463e
Author:    roland
Date:      2019-09-03 09:28 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/79186d82463e

8230470: Shenandoah doesn't need change from JDK-8212610 anymore
Reviewed-by: thartmann

! src/hotspot/share/opto/loopPredicate.cpp
! src/hotspot/share/opto/loopnode.hpp

Changeset: 5302477c8285
Author:    dfuchs
Date:      2019-09-12 15:46 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/5302477c8285

8230858: Replace wildcard address with loopback or local host in tests - part 23
Summary: Add new traces for better diagnosis, refrain binding to the wildcard address when possible.
Reviewed-by: chegar, xuelei

! test/jdk/java/net/CookieHandler/CookieManagerTest.java
! test/jdk/java/net/Socket/HttpProxy.java
! test/jdk/java/net/Socket/NullHost.java
! test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java
! test/jdk/sun/net/www/protocol/https/HttpsClient/ServerIdentityTest.java
! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/DNSIdentities.java
! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/IPAddressDNSIdentities.java
! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/IPAddressIPIdentities.java
! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/IPIdentities.java
! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/Identities.java
! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/ImpactOnSNI.java
! test/jdk/sun/net/www/protocol/https/NewImpl/JavaxHostnameVerifier.java
! test/jdk/sun/net/www/protocol/jar/B4957695.java

Changeset: 85e1de070bef
Author:    ccheung
Date:      2019-09-12 09:59 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/85e1de070bef

8186988: use log_warning() and log_error() instead of tty->print_cr for CDS warning and error messages
Reviewed-by: stuefe, iklam, dholmes

! src/hotspot/share/classfile/classLoader.cpp
! src/hotspot/share/classfile/classLoaderExt.cpp
! src/hotspot/share/memory/filemap.cpp
! src/hotspot/share/memory/metaspaceShared.cpp

Changeset: f63f50a4bf43
Author:    igerasim
Date:      2019-09-12 11:07 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/f63f50a4bf43

8230829: Matcher matches a surrogate pair that crosses border of the region
Reviewed-by: naoto

! src/java.base/share/classes/java/util/regex/Pattern.java
! test/jdk/java/util/regex/RegExTest.java

Changeset: 48d51def09f9
Author:    pliden
Date:      2019-09-13 08:40 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/48d51def09f9

8230845: ZGC: Implement ZLock using os::PlatformMutex
Reviewed-by: stefank

! src/hotspot/share/gc/z/zLock.hpp
! src/hotspot/share/gc/z/zLock.inline.hpp

Changeset: 70aebd567a5c
Author:    pliden
Date:      2019-09-13 08:40 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/70aebd567a5c

8230846: ZGC: Make ZUtils::alloc_aligned() posix-specific
Reviewed-by: stefank

+ src/hotspot/os/posix/gc/z/zUtils_posix.cpp
- src/hotspot/share/gc/z/zUtils.cpp

Changeset: dc792fa77da0
Author:    pliden
Date:      2019-09-13 08:40 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/dc792fa77da0

8230877: Rename THREAD_LOCAL_DECL to THREAD_LOCAL
Reviewed-by: kbarrett, dholmes

! src/hotspot/share/runtime/thread.cpp
! src/hotspot/share/runtime/thread.hpp
! src/hotspot/share/utilities/globalDefinitions_gcc.hpp
! src/hotspot/share/utilities/globalDefinitions_solstudio.hpp
! src/hotspot/share/utilities/globalDefinitions_visCPP.hpp
! src/hotspot/share/utilities/globalDefinitions_xlc.hpp

Changeset: 9b4717ca9bd1
Author:    pliden
Date:      2019-09-13 08:40 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/9b4717ca9bd1

8230878: ZGC: Use THREAD_LOCAL instead of __thread
Reviewed-by: kbarrett

! src/hotspot/share/gc/z/zCPU.cpp
! src/hotspot/share/gc/z/zCPU.hpp
! src/hotspot/share/gc/z/zStat.cpp
! src/hotspot/share/gc/z/zStat.hpp
! src/hotspot/share/gc/z/zThread.cpp
! src/hotspot/share/gc/z/zThread.hpp

Changeset: 1def54255e93
Author:    prappo
Date:      2019-09-13 11:00 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/1def54255e93

8151678: com/sun/jndi/ldap/LdapTimeoutTest.java failed due to timeout on DeadServerNoTimeoutTest is incorrect
Reviewed-by: dfuchs, martin, robm

! src/java.naming/share/classes/com/sun/jndi/ldap/DefaultLdapDnsProvider.java
! src/java.naming/share/classes/com/sun/jndi/ldap/LdapDnsProviderService.java
! test/jdk/ProblemList.txt
! test/jdk/com/sun/jndi/ldap/LdapTimeoutTest.java
! test/jdk/com/sun/jndi/ldap/lib/BaseLdapServer.java

Changeset: 41082cd965cc
Author:    lmesnik
Date:      2019-09-13 09:34 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/41082cd965cc

8230881: serviceability/sa/TestJmapCore tests fail with java.lang.RuntimeException: Could not find dump file
Reviewed-by: dholmes, cjplummer

! test/hotspot/jtreg/serviceability/sa/TestJmapCore.java

Changeset: 88bbe06ab8d6
Author:    bchristi
Date:      2019-09-13 09:33 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/88bbe06ab8d6

8230937: Update bugid in ProblemList for vmTestbase/nsk/jdb/eval/eval001/eval001.java
Reviewed-by: dholmes, mchung

! test/hotspot/jtreg/ProblemList.txt

Changeset: ff0eae1719d0
Author:    dcubed
Date:      2019-09-13 18:54 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/ff0eae1719d0

8230938: Deprecate MonitorBound
Reviewed-by: dholmes

! src/hotspot/share/runtime/arguments.cpp
! src/hotspot/share/runtime/globals.hpp

Changeset: 3054503bad7d
Author:    bpb
Date:      2019-09-13 16:03 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/3054503bad7d

8230085: (fs) FileStore::isReadOnly is always true on macOS Catalina
Reviewed-by: alanb

! src/java.base/macosx/classes/sun/nio/fs/BsdFileStore.java
! src/java.base/macosx/classes/sun/nio/fs/BsdNativeDispatcher.java
! src/java.base/macosx/native/libnio/fs/BsdNativeDispatcher.c
! src/java.base/unix/classes/sun/nio/fs/UnixNativeDispatcher.java

Changeset: caa25ab47aca
Author:    mgronlun
Date:      2019-09-14 14:40 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/caa25ab47aca

8225797: OldObjectSample event creates unexpected amount of checkpoint data
Reviewed-by: egahlin

! src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp
! src/hotspot/share/jfr/jfr.cpp
! src/hotspot/share/jfr/leakprofiler/chains/edgeStore.cpp
! src/hotspot/share/jfr/leakprofiler/chains/edgeStore.hpp
! src/hotspot/share/jfr/leakprofiler/chains/pathToGcRootsOperation.cpp
! src/hotspot/share/jfr/leakprofiler/checkpoint/objectSampleCheckpoint.cpp
! src/hotspot/share/jfr/leakprofiler/checkpoint/objectSampleCheckpoint.hpp
! src/hotspot/share/jfr/leakprofiler/checkpoint/objectSampleWriter.cpp
! src/hotspot/share/jfr/leakprofiler/checkpoint/rootResolver.cpp
! src/hotspot/share/jfr/leakprofiler/sampling/objectSample.hpp
! src/hotspot/share/jfr/leakprofiler/sampling/objectSampler.cpp
! src/hotspot/share/jfr/leakprofiler/sampling/objectSampler.hpp
! src/hotspot/share/jfr/leakprofiler/sampling/sampleList.hpp
- src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointBlob.cpp
- src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointBlob.hpp
! src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointManager.cpp
! src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointManager.hpp
! src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointWriter.cpp
! src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointWriter.hpp
! src/hotspot/share/jfr/recorder/checkpoint/types/jfrType.cpp
! src/hotspot/share/jfr/recorder/checkpoint/types/jfrType.hpp
! src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeManager.cpp
! src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeManager.hpp
! src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeSet.cpp
! src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeSet.hpp
! src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeSetUtils.cpp
! src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeSetUtils.hpp
- src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeSetWriter.hpp
! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.cpp
! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.hpp
! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.inline.hpp
! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdBits.inline.hpp
! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdEpoch.hpp
! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdMacros.hpp
! src/hotspot/share/jfr/recorder/repository/jfrChunkState.cpp
! src/hotspot/share/jfr/recorder/repository/jfrChunkState.hpp
! src/hotspot/share/jfr/recorder/repository/jfrChunkWriter.cpp
! src/hotspot/share/jfr/recorder/repository/jfrChunkWriter.hpp
! src/hotspot/share/jfr/recorder/service/jfrRecorderService.cpp
+ src/hotspot/share/jfr/recorder/stacktrace/jfrStackTrace.cpp
+ src/hotspot/share/jfr/recorder/stacktrace/jfrStackTrace.hpp
! src/hotspot/share/jfr/recorder/stacktrace/jfrStackTraceRepository.cpp
! src/hotspot/share/jfr/recorder/stacktrace/jfrStackTraceRepository.hpp
! src/hotspot/share/jfr/recorder/storage/jfrMemorySpace.hpp
! src/hotspot/share/jfr/recorder/storage/jfrMemorySpace.inline.hpp
! src/hotspot/share/jfr/support/jfrKlassExtension.hpp
! src/hotspot/share/jfr/support/jfrThreadLocal.cpp
! src/hotspot/share/jfr/support/jfrThreadLocal.hpp
! src/hotspot/share/jfr/support/jfrTraceIdExtension.hpp
+ src/hotspot/share/jfr/utilities/jfrBlob.cpp
+ src/hotspot/share/jfr/utilities/jfrBlob.hpp
! src/hotspot/share/jfr/utilities/jfrHashtable.hpp
! src/hotspot/share/jfr/utilities/jfrTypes.hpp
+ src/hotspot/share/jfr/writers/jfrTypeWriterHost.hpp
! src/hotspot/share/jfr/writers/jfrWriterHost.inline.hpp

Changeset: 515fc9f6b2d6
Author:    mgronlun
Date:      2019-09-14 18:45 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/515fc9f6b2d6

8231025: Incorrect method tag offset for big endian platform
Reviewed-by: egahlin

! src/hotspot/share/jfr/support/jfrTraceIdExtension.hpp

Changeset: 51cd29502ea9
Author:    dl
Date:      2019-09-14 11:16 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/51cd29502ea9

8229442: AQS and lock classes refresh
Reviewed-by: martin

! src/java.base/share/classes/java/util/concurrent/locks/AbstractQueuedLongSynchronizer.java
! src/java.base/share/classes/java/util/concurrent/locks/AbstractQueuedSynchronizer.java
! src/java.base/share/classes/java/util/concurrent/locks/Lock.java
! src/java.base/share/classes/java/util/concurrent/locks/LockSupport.java
! src/java.base/share/classes/java/util/concurrent/locks/ReentrantLock.java
! src/java.base/share/classes/java/util/concurrent/locks/StampedLock.java
! test/jdk/java/util/concurrent/locks/Lock/CheckedLockLoops.java
! test/jdk/java/util/concurrent/locks/Lock/FlakyMutex.java
! test/jdk/java/util/concurrent/locks/Lock/TimedAcquireLeak.java
! test/jdk/java/util/concurrent/locks/ReentrantLock/CancelledLockLoops.java
! test/jdk/java/util/concurrent/locks/ReentrantLock/LockOncePerThreadLoops.java
! test/jdk/java/util/concurrent/locks/ReentrantLock/SimpleReentrantLockLoops.java
! test/jdk/java/util/concurrent/locks/ReentrantLock/TimeoutLockLoops.java
! test/jdk/java/util/concurrent/locks/ReentrantReadWriteLock/MapLoops.java

Changeset: 2081ff900d65
Author:    dl
Date:      2019-09-14 11:20 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/2081ff900d65

8227235: rare failures in testForkHelpQuiesce tck tests
Reviewed-by: martin, alanb

! test/jdk/java/util/concurrent/tck/ForkJoinTask8Test.java
! test/jdk/java/util/concurrent/tck/ForkJoinTaskTest.java

Changeset: f689a48dba4b
Author:    dl
Date:      2019-09-14 11:24 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/f689a48dba4b

8221168: java/util/concurrent/CountDownLatch/Basic.java fails
Reviewed-by: martin, alanb

! test/jdk/java/util/concurrent/CountDownLatch/Basic.java

Changeset: 6a556bcd94fc
Author:    dl
Date:      2019-09-14 11:26 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/6a556bcd94fc

8145138: CyclicBarrier/Basic.java failed with "3 not equal to 4"
Reviewed-by: martin, alanb

! test/jdk/java/util/concurrent/CyclicBarrier/Basic.java

Changeset: 1e4270f875ee
Author:    dl
Date:      2019-09-14 11:26 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/1e4270f875ee

8225490: Miscellaneous changes imported from jsr166 CVS 2019-09
Reviewed-by: martin, alanb

! src/java.base/share/classes/java/util/concurrent/ConcurrentHashMap.java
! src/java.base/share/classes/java/util/concurrent/Phaser.java
! src/java.base/share/classes/java/util/concurrent/ThreadLocalRandom.java
! src/java.base/share/classes/java/util/concurrent/atomic/AtomicInteger.java
! src/java.base/share/classes/java/util/concurrent/atomic/AtomicLong.java
! src/java.base/share/classes/java/util/concurrent/package-info.java
! test/jdk/java/util/Map/Get.java
! test/jdk/java/util/concurrent/BlockingQueue/OfferDrainToLoops.java
! test/jdk/java/util/concurrent/ConcurrentHashMap/MapCheck.java
! test/jdk/java/util/concurrent/ConcurrentHashMap/MapLoops.java
! test/jdk/java/util/concurrent/ConcurrentHashMap/ToArray.java
! test/jdk/java/util/concurrent/ConcurrentQueues/OfferRemoveLoops.java
! test/jdk/java/util/concurrent/FutureTask/BlockingTaskExecutor.java
! test/jdk/java/util/concurrent/FutureTask/CancelledFutureLoops.java
! test/jdk/java/util/concurrent/FutureTask/DoneTimedGetLoops.java
! test/jdk/java/util/concurrent/Phaser/FickleRegister.java
! test/jdk/java/util/concurrent/Phaser/TieredArriveLoops.java
! test/jdk/java/util/concurrent/ScheduledThreadPoolExecutor/GCRetention.java
! test/jdk/java/util/concurrent/TimeUnit/Basic.java
! test/jdk/java/util/concurrent/atomic/DoubleAdderDemo.java
! test/jdk/java/util/concurrent/tck/AbstractQueuedLongSynchronizerTest.java
! test/jdk/java/util/concurrent/tck/AbstractQueuedSynchronizerTest.java
! test/jdk/java/util/concurrent/tck/ArrayBlockingQueueTest.java
! test/jdk/java/util/concurrent/tck/BlockingQueueTest.java
! test/jdk/java/util/concurrent/tck/ConcurrentLinkedDequeTest.java
! test/jdk/java/util/concurrent/tck/CountDownLatchTest.java
! test/jdk/java/util/concurrent/tck/CyclicBarrierTest.java
! test/jdk/java/util/concurrent/tck/DelayQueueTest.java
! test/jdk/java/util/concurrent/tck/DoubleAccumulatorTest.java
! test/jdk/java/util/concurrent/tck/ForkJoinPool9Test.java
! test/jdk/java/util/concurrent/tck/FutureTaskTest.java
! test/jdk/java/util/concurrent/tck/JSR166TestCase.java
! test/jdk/java/util/concurrent/tck/LinkedBlockingDequeTest.java
! test/jdk/java/util/concurrent/tck/LinkedBlockingQueueTest.java
! test/jdk/java/util/concurrent/tck/LinkedTransferQueueTest.java
! test/jdk/java/util/concurrent/tck/LongAccumulatorTest.java
! test/jdk/java/util/concurrent/tck/MapTest.java
! test/jdk/java/util/concurrent/tck/PhaserTest.java
! test/jdk/java/util/concurrent/tck/PriorityBlockingQueueTest.java
! test/jdk/java/util/concurrent/tck/ScheduledExecutorSubclassTest.java
! test/jdk/java/util/concurrent/tck/ScheduledExecutorTest.java
! test/jdk/java/util/concurrent/tck/SemaphoreTest.java
! test/jdk/java/util/concurrent/tck/SynchronousQueueTest.java
! test/jdk/java/util/concurrent/tck/ThreadPoolExecutorSubclassTest.java
! test/jdk/java/util/concurrent/tck/ThreadPoolExecutorTest.java
! test/jdk/java/util/concurrent/tck/TimeUnitTest.java

Changeset: 593005ac5a0a
Author:    stooke
Date:      2019-09-15 07:47 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/593005ac5a0a

8216354: Syntax error in toolchain_windows.m4
Reviewed-by: erikj, dholmes, clanger

! make/autoconf/toolchain_windows.m4

Changeset: a6f653312b19
Author:    stuefe
Date:      2019-09-15 08:41 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/a6f653312b19

8230910: libsspi_bridge does not build on Windows 32bit
Reviewed-by: alanb, weijun

! src/java.security.jgss/windows/native/libsspi_bridge/sspi.cpp

Changeset: a6c85c21aa39
Author:    darcy
Date:      2019-09-15 13:23 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/a6c85c21aa39

8230882: Use @index in javax.lang.model javadoc
Reviewed-by: jjg

! src/java.compiler/share/classes/javax/lang/model/package-info.java

Changeset: 24df796eef3d
Author:    dholmes
Date:      2019-09-15 21:00 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/24df796eef3d

8231033: Problemlist ReservedStackTest
8231034: ProblemList failing ThreadMXBean tests
Reviewed-by: darcy

! test/hotspot/jtreg/ProblemList.txt
! test/jdk/ProblemList.txt

Changeset: b35771556cd0
Author:    clanger
Date:      2019-09-16 09:21 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/b35771556cd0

8230850: Test sun/tools/jcmd/TestProcessHelper.java fails intermittently
Reviewed-by: stuefe, cjplummer, sgehwolf

! test/jdk/sun/tools/jcmd/TestProcessHelper.java

Changeset: d003b3ef8b60
Author:    clanger
Date:      2019-09-16 09:28 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/d003b3ef8b60

8230854: Cleanup SuppressWarnings in test lib and remove noisy traces in StreamPumper
Reviewed-by: stuefe, dholmes

! test/lib/jdk/test/lib/Platform.java
! test/lib/jdk/test/lib/Utils.java
! test/lib/jdk/test/lib/process/ProcessTools.java
! test/lib/jdk/test/lib/process/StreamPumper.java

Changeset: 00aebe177a71
Author:    thartmann
Date:      2019-09-16 13:53 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/00aebe177a71

8230742: Make AggressiveUnboxing a diagnostic flag
Summary: AggressiveUnboxing is enabled by default. It should therefore be a diagnostic flag.
Reviewed-by: roland, shade

! src/hotspot/share/opto/c2_globals.hpp

Changeset: 6a30ad1cfeec
Author:    mbaesken
Date:      2019-09-13 11:04 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/6a30ad1cfeec

8230901: missing ReleaseStringUTFChars in serviceability native code
Reviewed-by: stuefe, sspitsyn

! src/java.instrument/share/native/libinstrument/JPLISAgent.c
! src/jdk.hotspot.agent/solaris/native/libsaproc/saproc.cpp

Changeset: d349347d6b5f
Author:    mbaesken
Date:      2019-09-13 07:43 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/d349347d6b5f

8230900: missing ReleaseStringUTFChars in java.desktop native code
Reviewed-by: clanger, prr

! src/java.desktop/unix/native/common/awt/fontpath.c
! src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp

Changeset: 272910ccd7bb
Author:    pliden
Date:      2019-09-17 09:51 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/272910ccd7bb

8230796: Remove BarrierSet::oop_equals_operator_allowed()
Reviewed-by: tschatzl, shade

! src/hotspot/share/gc/shared/barrierSet.hpp
! src/hotspot/share/oops/oopsHierarchy.cpp
! src/hotspot/share/oops/oopsHierarchy.hpp

Changeset: 470af058bd5f
Author:    pliden
Date:      2019-09-17 09:51 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/470af058bd5f

8230808: Remove Access::equals()
Reviewed-by: tschatzl, shade

! src/hotspot/share/gc/shared/barrierSet.hpp
- src/hotspot/share/oops/access.cpp
! src/hotspot/share/oops/access.hpp
! src/hotspot/share/oops/access.inline.hpp
! src/hotspot/share/oops/accessBackend.hpp
! src/hotspot/share/oops/oop.hpp

Changeset: 4932dce35882
Author:    pliden
Date:      2019-09-17 09:51 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/4932dce35882

8230841: Remove oopDesc::equals()
Reviewed-by: rkennke, tschatzl

! src/hotspot/share/ci/ciEnv.cpp
! src/hotspot/share/ci/ciObjectFactory.cpp
! src/hotspot/share/ci/ciObjectFactory.hpp
! src/hotspot/share/classfile/classLoaderData.cpp
! src/hotspot/share/classfile/classLoaderStats.hpp
! src/hotspot/share/classfile/dictionary.cpp
! src/hotspot/share/classfile/javaClasses.cpp
! src/hotspot/share/classfile/javaClasses.inline.hpp
! src/hotspot/share/classfile/modules.cpp
! src/hotspot/share/classfile/protectionDomainCache.cpp
! src/hotspot/share/classfile/systemDictionary.cpp
! src/hotspot/share/code/dependencies.cpp
! src/hotspot/share/compiler/compileBroker.cpp
! src/hotspot/share/gc/shared/referenceProcessor.cpp
! src/hotspot/share/gc/shared/referenceProcessor.hpp
! src/hotspot/share/gc/shared/stringdedup/stringDedupTable.cpp
! src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahClosures.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahTaskqueue.hpp
! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp
! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp
! src/hotspot/share/interpreter/bytecodeInterpreter.cpp
! src/hotspot/share/interpreter/interpreterRuntime.cpp
! src/hotspot/share/jvmci/jvmciCompiler.cpp
! src/hotspot/share/memory/heapShared.hpp
! src/hotspot/share/memory/universe.cpp
! src/hotspot/share/oops/compressedOops.inline.hpp
! src/hotspot/share/oops/constantPool.cpp
! src/hotspot/share/oops/instanceKlass.cpp
! src/hotspot/share/oops/klassVtable.cpp
! src/hotspot/share/oops/objArrayKlass.cpp
! src/hotspot/share/oops/oop.hpp
! src/hotspot/share/prims/jni.cpp
! src/hotspot/share/prims/jvm.cpp
! src/hotspot/share/prims/jvmtiTagMap.cpp
! src/hotspot/share/prims/methodHandles.cpp
! src/hotspot/share/prims/stackwalk.cpp
! src/hotspot/share/prims/unsafe.cpp
! src/hotspot/share/runtime/biasedLocking.cpp
! src/hotspot/share/runtime/handles.hpp
! src/hotspot/share/runtime/jniHandles.inline.hpp
! src/hotspot/share/runtime/synchronizer.cpp
! src/hotspot/share/runtime/vframe.cpp
! src/hotspot/share/services/memoryManager.hpp
! src/hotspot/share/services/memoryPool.hpp
! src/hotspot/share/services/threadService.cpp
! src/hotspot/share/utilities/exceptions.cpp
! src/hotspot/share/utilities/growableArray.hpp

Changeset: bb1aaed00341
Author:    pliden
Date:      2019-09-17 09:51 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/bb1aaed00341

8231051: Remove check_obj_alignment() and replace with is_object_aligned()
Reviewed-by: tschatzl, shade

! src/hotspot/share/gc/shared/collectedHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp
! src/hotspot/share/gc/z/zCollectedHeap.cpp
! src/hotspot/share/memory/heapShared.inline.hpp
! src/hotspot/share/oops/compressedOops.inline.hpp
! src/hotspot/share/oops/oopsHierarchy.hpp

Changeset: 8ee083465318
Author:    coffeys
Date:      2019-09-17 11:07 +0000
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/8ee083465318

8223490: Optimize search algorithm for determining default time zone
Reviewed-by: naoto, rriggs

! src/java.base/unix/native/libjava/TimeZone_md.c

Changeset: 2f301425af62
Author:    jiefu
Date:      2019-09-17 20:38 +0800
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/2f301425af62

8230943: False deadlock detection with -XX:+CIPrintCompileQueue after JDK-8163511
Reviewed-by: dholmes, thartmann

! src/hotspot/share/compiler/compileBroker.cpp
+ test/hotspot/jtreg/compiler/print/PrintCompileQueue.java

Changeset: 9adf95692a3d
Author:    zgu
Date:      2019-09-17 08:22 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/9adf95692a3d

8230350: Shenandoah: Assertion failed when GC is cancelled by a worker thread
Reviewed-by: rkennke

! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

Changeset: 8a8e87e8a4fd
Author:    coffeys
Date:      2019-09-17 16:39 +0000
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/8a8e87e8a4fd

8231124: Missing closedir call with JDK-8223490
Reviewed-by: naoto

! src/java.base/unix/native/libjava/TimeZone_md.c

Changeset: 6a05019acb67
Author:    lancea
Date:      2019-09-17 14:00 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/6a05019acb67

8230870: (zipfs) Add a ZIP FS test that is similar to test/jdk/java/util/zip/EntryCount64k.java
Reviewed-by: clanger, martin

+ test/jdk/jdk/nio/zipfs/LargeEntriesTest.java

Changeset: a82fe7a88ce4
Author:    jiefu
Date:      2019-09-17 09:20 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/a82fe7a88ce4

8231024: Improve the debug info when the output is truncated
Reviewed-by: iklam, dholmes

! src/hotspot/share/utilities/ostream.cpp

Changeset: cea6839598e8
Author:    dholmes
Date:      2019-09-17 19:09 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/cea6839598e8

8230424: Use platform independent code for Thread.interrupt support
8231094: os::sleep in assert message should be changed to JavaThread::sleep
Reviewed-by: rehn, dcubed

! src/hotspot/os/posix/os_posix.cpp
! src/hotspot/os/solaris/os_solaris.cpp
! src/hotspot/os/windows/osThread_windows.cpp
! src/hotspot/os/windows/osThread_windows.hpp
! src/hotspot/os/windows/os_windows.cpp
! src/hotspot/share/jvmci/jvmciRuntime.cpp
! src/hotspot/share/prims/jvm.cpp
! src/hotspot/share/prims/jvmtiEnv.cpp
! src/hotspot/share/prims/jvmtiRawMonitor.cpp
! src/hotspot/share/runtime/objectMonitor.cpp
! src/hotspot/share/runtime/os.hpp
! src/hotspot/share/runtime/osThread.cpp
! src/hotspot/share/runtime/osThread.hpp
! src/hotspot/share/runtime/thread.cpp
! src/hotspot/share/runtime/thread.hpp

Changeset: c46407f651a9
Author:    serb
Date:      2019-09-17 19:52 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/c46407f651a9

8231027: Correct typos
Reviewed-by: lancea, dholmes, erikj

! make/autoconf/buildjdk-spec.gmk.in
! make/autoconf/spec.gmk.in
! src/hotspot/share/opto/block.hpp
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java
! src/java.xml/share/classes/com/sun/xml/internal/stream/StaxXMLInputSource.java
! src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/doubleconv/BignumDtoa.java
! test/jdk/java/awt/GradientPaint/LinearColorSpaceGradientTest.java
! test/jdk/java/awt/Graphics2D/DrawString/XRenderElt254TextTest.java
! test/jdk/java/nio/channels/Selector/WakeupSpeed.java
! test/jdk/java/text/Format/DecimalFormat/FormatMicroBenchmark.java

Changeset: a45cce906207
Author:    mbaesken
Date:      2019-07-23 16:52 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/a45cce906207

8228482: fix xlc16/xlclang comparison of distinct pointer types and string literal conversion warnings
Reviewed-by: clanger, mdoerr

! src/hotspot/os/aix/libodm_aix.cpp
! src/hotspot/os/aix/libodm_aix.hpp
! src/hotspot/os/aix/os_aix.cpp
! src/java.base/aix/native/libjli/java_md_aix.c
! src/java.base/unix/native/libnet/NetworkInterface.c
! src/java.desktop/aix/native/libawt/porting_aix.c

Changeset: dfd434203aa0
Author:    jlahoda
Date:      2019-09-18 10:41 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/dfd434203aa0

8228460: bootstrap class path not set in conjunction with -source 11
Summary: Ensuring implicit system module path is checked for the no-bootclasspath warning for -source >= 9.
Reviewed-by: vromero

! src/jdk.compiler/share/classes/com/sun/tools/javac/file/BaseFileManager.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/file/Locations.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties
+ test/langtools/tools/javac/diags/examples/SourceNoSystemModulesPath.java
+ test/langtools/tools/javac/options/BCPOrSystemNotSpecified.java
! test/langtools/tools/javac/var_implicit_lambda/VarInImplicitLambdaNegTest01_source10.out

Changeset: 0f3c23c374a4
Author:    phh
Date:      2019-09-18 05:41 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/0f3c23c374a4

8207266: ThreadMXBean::getThreadAllocatedBytes() can be quicker for self thread
Summary: Add com.sun.management.getCurrentThreadAllocatedBytes, implement getThreadAllocatedBytes(long) independent of getThreadAllocatedBytes(long[])
Reviewed-by: mchung, dholmes, sspitsyn

! src/hotspot/share/include/jmm.h
! src/hotspot/share/services/management.cpp
! src/java.management/share/classes/java/lang/management/ThreadMXBean.java
! src/java.management/share/classes/sun/management/ThreadImpl.java
! src/java.management/share/native/libmanagement/ThreadImpl.c
! src/jdk.management/share/classes/com/sun/management/ThreadMXBean.java
! src/jdk.management/share/classes/com/sun/management/internal/HotSpotThreadImpl.java
! test/jdk/com/sun/management/ThreadMXBean/ThreadAllocatedMemory.java

Changeset: 377f47ccc20b
Author:    jlahoda
Date:      2019-09-18 15:13 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/377f47ccc20b

8231176: Test tools/javac/options/BCPOrSystemNotSpecified.java broken on Windows
Summary: Temporarily disabling BCPOrSystemNotSpecified.java test on Windows.
Reviewed-by: vromero

! test/langtools/ProblemList.txt

Changeset: 8c44ac2a908e
Author:    epavlova
Date:      2019-09-18 10:58 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/8c44ac2a908e

8231145: [Graal] org.graalvm.compiler.debug.test.DebugContextTest fails because DebugContextTest.testLogging.input is not available
Reviewed-by: erikj, iveresov, ihse

! make/test/JtregGraalUnit.gmk
! test/hotspot/jtreg/ProblemList-graal.txt

Changeset: 0368f3a073a9
Author:    jwilhelm
Date:      2019-09-06 17:50 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/0368f3a073a9

Added tag jdk-13-ga for changeset 9c250a7600e1

! .hgtags

Changeset: f43c809a27bd
Author:    jwilhelm
Date:      2019-09-18 11:48 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/f43c809a27bd

Merge

! .hgtags

Changeset: b1a394e15ae9
Author:    rkennke
Date:      2019-09-18 20:56 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/b1a394e15ae9

8231085: C2/GC: Better GC-interface for expanding clone
Reviewed-by: eosterlund

! src/hotspot/share/gc/shared/c2/barrierSetC2.cpp
! src/hotspot/share/gc/shared/c2/barrierSetC2.hpp
! src/hotspot/share/opto/macro.hpp
! src/hotspot/share/opto/macroArrayCopy.cpp

Changeset: 0d7877278adf
Author:    rkennke
Date:      2019-09-18 20:56 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/0d7877278adf

8231086: Shenandoah: Stronger invariant for object-arraycopy
Reviewed-by: shade

! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.hpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahRuntime.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRuntime.hpp

Changeset: bc0648405d67
Author:    rkennke
Date:      2019-09-18 20:56 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/bc0648405d67

8231087: Shenandoah: Self-fixing load reference barriers for C1/C2
Reviewed-by: shade

! src/hotspot/cpu/aarch64/gc/shenandoah/c1/shenandoahBarrierSetC1_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp
! src/hotspot/cpu/x86/gc/shenandoah/c1/shenandoahBarrierSetC1_x86.cpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp
! src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.cpp
! src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.hpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp
! src/hotspot/share/gc/shenandoah/shenandoahRuntime.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRuntime.hpp
! src/hotspot/share/gc/shenandoah/shenandoah_globals.hpp

Changeset: 2c4185d7276a
Author:    amenkov
Date:      2019-09-18 12:13 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/2c4185d7276a

8186825: some memory leak issues in the transport_startTransport
Reviewed-by: sspitsyn, phh

! src/jdk.jdwp.agent/share/native/libjdwp/transport.c

Changeset: b73753eff8b7
Author:    godin
Date:      2019-09-18 21:20 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/b73753eff8b7

8066774: Rename the annotations arrays names in ClassFileParser
Reviewed-by: shade, coleenp, dholmes
Contributed-by: Evgeny Mandrikov <mandrikov at gmail.com>

! src/hotspot/share/classfile/classFileParser.cpp
! src/hotspot/share/classfile/classFileParser.hpp

Changeset: ee37c9b2eb61
Author:    dholmes
Date:      2019-09-18 17:31 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/ee37c9b2eb61

8231162: JVMTI RawMonitorWait triggers assertion failure: Only JavaThreads can be interruptible
Reviewed-by: dcubed

! src/hotspot/share/prims/jvmtiEnv.cpp

Changeset: 778fc2dcbdaa
Author:    dcubed
Date:      2019-09-18 20:49 -0400
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/778fc2dcbdaa

8231210: [BACKOUT] JDK-8207266 ThreadMXBean::getThreadAllocatedBytes() can be quicker for self thread
Reviewed-by: phh, dholmes

! src/hotspot/share/include/jmm.h
! src/hotspot/share/services/management.cpp
! src/java.management/share/classes/java/lang/management/ThreadMXBean.java
! src/java.management/share/classes/sun/management/ThreadImpl.java
! src/java.management/share/native/libmanagement/ThreadImpl.c
! src/jdk.management/share/classes/com/sun/management/ThreadMXBean.java
! src/jdk.management/share/classes/com/sun/management/internal/HotSpotThreadImpl.java
! test/jdk/com/sun/management/ThreadMXBean/ThreadAllocatedMemory.java

Changeset: 0c797d51d479
Author:    rkennke
Date:      2019-09-19 14:27 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk/rev/0c797d51d479

Merge

! .hgtags
! src/hotspot/cpu/aarch64/aarch64.ad
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp
! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp
! src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp
! src/hotspot/cpu/sparc/c1_LIRAssembler_sparc.cpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp
! src/hotspot/cpu/x86/macroAssembler_x86.cpp
! src/hotspot/cpu/x86/x86_64.ad
! src/hotspot/os/linux/gc/z/zNUMA_linux.cpp
! src/hotspot/os/linux/os_linux.cpp
! src/hotspot/os/windows/os_windows.cpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zArguments_linux_aarch64.cpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zBackingFile_linux_aarch64.cpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zBackingFile_linux_aarch64.hpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zBackingPath_linux_aarch64.cpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zBackingPath_linux_aarch64.hpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zGlobals_linux_aarch64.cpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zGlobals_linux_aarch64.hpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zPhysicalMemoryBacking_linux_aarch64.cpp
- src/hotspot/os_cpu/linux_aarch64/gc/z/zPhysicalMemoryBacking_linux_aarch64.hpp
- src/hotspot/os_cpu/linux_x86/gc/z/zArguments_linux_x86.cpp
- src/hotspot/os_cpu/linux_x86/gc/z/zBackingFile_linux_x86.cpp
- src/hotspot/os_cpu/linux_x86/gc/z/zBackingFile_linux_x86.hpp
- src/hotspot/os_cpu/linux_x86/gc/z/zBackingPath_linux_x86.cpp
- src/hotspot/os_cpu/linux_x86/gc/z/zBackingPath_linux_x86.hpp
- src/hotspot/os_cpu/linux_x86/gc/z/zGlobals_linux_x86.cpp
- src/hotspot/os_cpu/linux_x86/gc/z/zGlobals_linux_x86.hpp
- src/hotspot/os_cpu/linux_x86/gc/z/zPhysicalMemoryBacking_linux_x86.cpp
- src/hotspot/os_cpu/linux_x86/gc/z/zPhysicalMemoryBacking_linux_x86.hpp
! src/hotspot/share/adlc/formssel.cpp
! src/hotspot/share/adlc/output_c.cpp
! src/hotspot/share/ci/ciInstanceKlass.hpp
! src/hotspot/share/ci/ciObjectFactory.hpp
! src/hotspot/share/classfile/classLoaderData.cpp
! src/hotspot/share/classfile/javaClasses.cpp
! src/hotspot/share/classfile/modules.cpp
- src/hotspot/share/classfile/sharedPathsMiscInfo.cpp
- src/hotspot/share/classfile/sharedPathsMiscInfo.hpp
! src/hotspot/share/compiler/compileBroker.cpp
! src/hotspot/share/compiler/oopMap.cpp
! src/hotspot/share/gc/g1/g1BarrierSet.cpp
! src/hotspot/share/gc/g1/g1BarrierSet.hpp
! src/hotspot/share/gc/g1/g1CollectedHeap.hpp
- src/hotspot/share/gc/g1/g1HeapSizingPolicy_ext.cpp
! src/hotspot/share/gc/shared/barrierSet.hpp
! src/hotspot/share/gc/shared/c2/barrierSetC2.cpp
! src/hotspot/share/gc/shared/c2/barrierSetC2.hpp
! src/hotspot/share/gc/shared/collectedHeap.cpp
! src/hotspot/share/gc/shared/collectedHeap.hpp
! src/hotspot/share/gc/shared/gcTrace.hpp
! src/hotspot/share/gc/shared/markBitMap.cpp
! src/hotspot/share/gc/shared/memAllocator.cpp
! src/hotspot/share/gc/shared/memAllocator.hpp
! src/hotspot/share/gc/shared/ptrQueue.cpp
! src/hotspot/share/gc/shared/ptrQueue.hpp
! src/hotspot/share/gc/shared/referenceProcessor.cpp
! src/hotspot/share/gc/shared/referenceProcessor.hpp
! src/hotspot/share/gc/shared/satbMarkQueue.cpp
! src/hotspot/share/gc/shared/satbMarkQueue.hpp
! src/hotspot/share/gc/shared/stringdedup/stringDedupTable.cpp
! src/hotspot/share/gc/shared/taskqueue.cpp
! src/hotspot/share/gc/shared/taskqueue.inline.hpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.hpp
! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
! src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp
! src/hotspot/share/gc/shenandoah/shenandoahAsserts.hpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahClosures.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahRuntime.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRuntime.hpp
! src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.cpp
! src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.hpp
! src/hotspot/share/gc/shenandoah/shenandoahTaskqueue.hpp
! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp
! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahUtils.cpp
! src/hotspot/share/gc/shenandoah/shenandoahUtils.hpp
! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp
! src/hotspot/share/gc/shenandoah/shenandoah_globals.hpp
! src/hotspot/share/gc/z/c2/zBarrierSetC2.cpp
! src/hotspot/share/gc/z/c2/zBarrierSetC2.hpp
- src/hotspot/share/gc/z/zUtils.cpp
- src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointBlob.cpp
- src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointBlob.hpp
- src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeSetWriter.hpp
- src/hotspot/share/logging/logTag_ext.hpp
! src/hotspot/share/memory/metaspace.hpp
- src/hotspot/share/oops/access.cpp
! src/hotspot/share/oops/compressedOops.inline.hpp
! src/hotspot/share/oops/objArrayKlass.cpp
! src/hotspot/share/oops/oop.cpp
! src/hotspot/share/oops/oop.hpp
! src/hotspot/share/oops/oop.inline.hpp
! src/hotspot/share/oops/oopsHierarchy.hpp
! src/hotspot/share/opto/block.hpp
! src/hotspot/share/opto/callnode.cpp
! src/hotspot/share/opto/cfgnode.cpp
! src/hotspot/share/opto/classes.hpp
! src/hotspot/share/opto/compile.cpp
! src/hotspot/share/opto/escape.cpp
! src/hotspot/share/opto/graphKit.cpp
! src/hotspot/share/opto/loopPredicate.cpp
! src/hotspot/share/opto/loopTransform.cpp
! src/hotspot/share/opto/loopnode.cpp
! src/hotspot/share/opto/loopnode.hpp
! src/hotspot/share/opto/loopopts.cpp
! src/hotspot/share/opto/machnode.cpp
! src/hotspot/share/opto/machnode.hpp
! src/hotspot/share/opto/macro.cpp
! src/hotspot/share/opto/macro.hpp
! src/hotspot/share/opto/macroArrayCopy.cpp
! src/hotspot/share/opto/memnode.cpp
! src/hotspot/share/opto/node.hpp
! src/hotspot/share/opto/subnode.cpp
! src/hotspot/share/prims/jvmtiEnv.cpp
! src/hotspot/share/prims/whitebox.cpp
- src/hotspot/share/runtime/arguments_ext.cpp
- src/hotspot/share/runtime/globals_ext.hpp
! src/hotspot/share/runtime/mutexLocker.cpp
! src/hotspot/share/runtime/os.cpp
! src/hotspot/share/runtime/os.hpp
- src/hotspot/share/runtime/os_ext.hpp
! src/hotspot/share/runtime/safepoint.cpp
! src/hotspot/share/runtime/sharedRuntime.cpp
! src/hotspot/share/runtime/synchronizer.cpp
! src/hotspot/share/runtime/synchronizer.hpp
! src/hotspot/share/runtime/thread.cpp
! src/hotspot/share/runtime/thread.hpp
! src/hotspot/share/runtime/vmStructs.cpp
! src/hotspot/share/utilities/globalDefinitions.hpp
- src/jdk.hotspot.agent/share/classes/META-INF/services/com.sun.jdi.connect.Connector
! test/hotspot/jtreg/ProblemList.txt
! test/hotspot/jtreg/TEST.groups
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/contention/TC05/tc05t001/tc05t001.cpp
- test/jdk/java/lang/invoke/findclass.security.policy
- test/jdk/java/nio/charset/coders/SJISMappingPropTest.java
- test/jdk/java/nio/charset/coders/SJISPropTest.java
- test/jdk/java/nio/charset/coders/ref.windows-31j
- test/jdk/java/security/testlibrary/CertUtils.java
- test/jdk/javax/xml/jaxp/testng/validation/jdk8037819/BasicTest1.java
- test/jdk/jdk/jfr/event/gc/detailed/TestStressAllocationGCEventsWithCMS.java
- test/jdk/jdk/jfr/event/gc/detailed/TestStressAllocationGCEventsWithDefNew.java
- test/jdk/jdk/jfr/event/gc/detailed/TestStressAllocationGCEventsWithG1.java
- test/jdk/jdk/jfr/event/gc/detailed/TestStressAllocationGCEventsWithParNew.java
- test/jdk/jdk/jfr/event/gc/detailed/TestStressAllocationGCEventsWithParallel.java
- test/jdk/jdk/jfr/event/gc/detailed/TestStressBigAllocationGCEventsWithCMS.java
- test/jdk/jdk/jfr/event/gc/detailed/TestStressBigAllocationGCEventsWithDefNew.java
- test/jdk/jdk/jfr/event/gc/detailed/TestStressBigAllocationGCEventsWithG1.java
- test/jdk/jdk/jfr/event/gc/detailed/TestStressBigAllocationGCEventsWithParNew.java
- test/jdk/jdk/jfr/event/gc/detailed/TestStressBigAllocationGCEventsWithParallel.java


From zgu at redhat.com  Fri Sep 20 11:29:00 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Fri, 20 Sep 2019 07:29:00 -0400
Subject: RFR 8231250: Shenandoah: Shenandoah assert_correct failed; Object
 klass pointer
Message-ID: <e3991c8c-b645-3ce4-48b6-8b666dbf2011@redhat.com>

Many thanks to Christroph Langer (SAP) for reporting and helping to 
verify the problem.

The initial report was recorded in JDK-8230483, unfortunately, it did 
not fix the problem.

The root cause is that JDK-8227635 work changed behavior of traversal 
GC, which is required to always enqueue new value.

Bug: https://bugs.openjdk.java.net/browse/JDK-8231250
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8231250/webrev.00/

Test:
   hotspot_gc_shenandoah (fastdebug and release) on Linux x86_64
   SAP internal tests


Thanks,

-Zhengyu


From zgu at redhat.com  Sat Sep 21 17:27:50 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Sat, 21 Sep 2019 13:27:50 -0400
Subject: RFR 8231293: Shenandoah: Traversal fails JVMTI tests
Message-ID: <638b42c4-96dc-e2e8-f12d-2958ce36878c@redhat.com>

The problem is caused by LRB trying to evacuate dead oops.
At this point, traversal is completed, therefore, no more evacuation 
should happen. We should complete the marking bitmap and arm native 
barrier to prevent from-space oops from leaking to system.

There are duplicated works among fixup roots and parallel cleaning, 
let's address them in DKJDK-8231324.

Bug: https://bugs.openjdk.java.net/browse/JDK-8231293
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8231293/webrev.00/index.html

Test:
   hotspot_gc_shenandoah (fastdebug and release)
   vmTestbase/nsk/jvmti (fastdebug and release) normal and traversal
   modes.

Thanks,

-Zhengyu


From shade at redhat.com  Mon Sep 23 07:49:14 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 23 Sep 2019 09:49:14 +0200
Subject: RFR 8231293: Shenandoah: Traversal fails JVMTI tests
In-Reply-To: <638b42c4-96dc-e2e8-f12d-2958ce36878c@redhat.com>
References: <638b42c4-96dc-e2e8-f12d-2958ce36878c@redhat.com>
Message-ID: <1b6cc097-54f9-fd1c-a946-7b5a94cb0e19@redhat.com>

On 9/21/19 7:27 PM, Zhengyu Gu wrote:
> The problem is caused by LRB trying to evacuate dead oops.
> At this point, traversal is completed, therefore, no more evacuation should happen. We should
> complete the marking bitmap and arm native barrier to prevent from-space oops from leaking to system.
> 
> There are duplicated works among fixup roots and parallel cleaning, let's address them in
> DKJDK-8231324.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8231293
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8231293/webrev.00/index.html

Please change the synopsis to something that reflects the change being done, not the symptoms. For
example: "Shenandoah: Traversal should not revive dead weak roots"

Otherwise looks fine.

-- 
Thanks,
-Aleksey


From shade at redhat.com  Mon Sep 23 12:14:56 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 23 Sep 2019 14:14:56 +0200
Subject: RFR (S) 8231249: Shenandoah: GC retries are too aggressive for tests
 that expect OOME
Message-ID: <c035bbb0-2b97-2af8-ba47-9987aa91ae49@redhat.com>

Bug:
  https://bugs.openjdk.java.net/browse/JDK-8231249

This readily reproduces with vmTestbase_nsk_jvmti. Some tests (notably
vmTestbase/nsk/jvmti/GarbageCollectionStart/gcstart001) are filling up the memory until OOME
happens, and even count the OOMEs happened. Unfortunately, that clashes with Shenandoah's quite
aggressive retry policy. At some point, test is able to sneak past allocation failure and make
progress, and less aggressive policy helps that.

Fix:
  http://cr.openjdk.java.net/~shade/8231249/webrev.01/

Since Degenerated GC would dive into Full GC on low progress, we can just trust the flag for
retries. We also need to poll the flag after at least one attempt at handling the alloc failure
(thus entering degen-full sequence). This makes retry logic less aggressive, which saves us from
test timeouts.

Testing: vmTestbase_nsk_jvmti; hotspot_gc_shenandoah

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Mon Sep 23 14:00:10 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 23 Sep 2019 16:00:10 +0200
Subject: RFR 8231293: Shenandoah: Traversal fails JVMTI tests
In-Reply-To: <638b42c4-96dc-e2e8-f12d-2958ce36878c@redhat.com>
References: <638b42c4-96dc-e2e8-f12d-2958ce36878c@redhat.com>
Message-ID: <15c5abd9-d839-a294-fdaf-de0f428059b8@redhat.com>

Why is that a problem?

As far as I know, we don't concurrently clean native roots with 
traversal GC. Or do we?

Roman

> The problem is caused by LRB trying to evacuate dead oops.
> At this point, traversal is completed, therefore, no more evacuation 
> should happen. We should complete the marking bitmap and arm native 
> barrier to prevent from-space oops from leaking to system.
> 
> There are duplicated works among fixup roots and parallel cleaning, 
> let's address them in DKJDK-8231324.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8231293
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8231293/webrev.00/index.html
> 
> Test:
>  ? hotspot_gc_shenandoah (fastdebug and release)
>  ? vmTestbase/nsk/jvmti (fastdebug and release) normal and traversal
>  ? modes.
> 
> Thanks,
> 
> -Zhengyu
> 

From rkennke at redhat.com  Mon Sep 23 14:01:01 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 23 Sep 2019 16:01:01 +0200
Subject: RFR (S) 8231249: Shenandoah: GC retries are too aggressive for
 tests that expect OOME
In-Reply-To: <c035bbb0-2b97-2af8-ba47-9987aa91ae49@redhat.com>
References: <c035bbb0-2b97-2af8-ba47-9987aa91ae49@redhat.com>
Message-ID: <2408462d-1911-adf2-4626-c83f971f3471@redhat.com>

Ok. Thanks!

Roman


> Bug:
>    https://bugs.openjdk.java.net/browse/JDK-8231249
> 
> This readily reproduces with vmTestbase_nsk_jvmti. Some tests (notably
> vmTestbase/nsk/jvmti/GarbageCollectionStart/gcstart001) are filling up the memory until OOME
> happens, and even count the OOMEs happened. Unfortunately, that clashes with Shenandoah's quite
> aggressive retry policy. At some point, test is able to sneak past allocation failure and make
> progress, and less aggressive policy helps that.
> 
> Fix:
>    http://cr.openjdk.java.net/~shade/8231249/webrev.01/
> 
> Since Degenerated GC would dive into Full GC on low progress, we can just trust the flag for
> retries. We also need to poll the flag after at least one attempt at handling the alloc failure
> (thus entering degen-full sequence). This makes retry logic less aggressive, which saves us from
> test timeouts.
> 
> Testing: vmTestbase_nsk_jvmti; hotspot_gc_shenandoah
> 

From zgu at redhat.com  Mon Sep 23 14:21:53 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Mon, 23 Sep 2019 10:21:53 -0400
Subject: RFR 8231293: Shenandoah: Traversal fails JVMTI tests
In-Reply-To: <15c5abd9-d839-a294-fdaf-de0f428059b8@redhat.com>
References: <638b42c4-96dc-e2e8-f12d-2958ce36878c@redhat.com>
 <15c5abd9-d839-a294-fdaf-de0f428059b8@redhat.com>
Message-ID: <9547881f-5663-a6ba-c42e-f1a05fe4b6ad@redhat.com>



On 9/23/19 10:00 AM, Roman Kennke wrote:
> Why is that a problem?
> 
> As far as I know, we don't concurrently clean native roots with 
> traversal GC. Or do we?

No. But when walking jvmti weak roots (in fixup roots or parallel 
cleaning), it triggers load barrier.

-Zhengyu

> 
> Roman
> 
>> The problem is caused by LRB trying to evacuate dead oops.
>> At this point, traversal is completed, therefore, no more evacuation 
>> should happen. We should complete the marking bitmap and arm native 
>> barrier to prevent from-space oops from leaking to system.
>>
>> There are duplicated works among fixup roots and parallel cleaning, 
>> let's address them in DKJDK-8231324.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8231293
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8231293/webrev.00/index.html
>>
>> Test:
>> ?? hotspot_gc_shenandoah (fastdebug and release)
>> ?? vmTestbase/nsk/jvmti (fastdebug and release) normal and traversal
>> ?? modes.
>>
>> Thanks,
>>
>> -Zhengyu
>>

From zgu at redhat.com  Mon Sep 23 14:27:55 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Mon, 23 Sep 2019 10:27:55 -0400
Subject: RFR 8231293: Shenandoah: Traversal fails JVMTI tests
In-Reply-To: <15c5abd9-d839-a294-fdaf-de0f428059b8@redhat.com>
References: <638b42c4-96dc-e2e8-f12d-2958ce36878c@redhat.com>
 <15c5abd9-d839-a294-fdaf-de0f428059b8@redhat.com>
Message-ID: <492a9c61-761a-de2e-bfbd-29ff0866d512@redhat.com>

Hi Roman,

You may have a point, I wonder if it is an upstream bug.

JvmtiTagMap::do_weak_oops() -> entry->object_peek() triggers native load 
barrier, while here should probably be a RawAccess.

-Zhengyu

On 9/23/19 10:00 AM, Roman Kennke wrote:
> Why is that a problem?
> 
> As far as I know, we don't concurrently clean native roots with 
> traversal GC. Or do we?
> 
> Roman
> 
>> The problem is caused by LRB trying to evacuate dead oops.
>> At this point, traversal is completed, therefore, no more evacuation 
>> should happen. We should complete the marking bitmap and arm native 
>> barrier to prevent from-space oops from leaking to system.
>>
>> There are duplicated works among fixup roots and parallel cleaning, 
>> let's address them in DKJDK-8231324.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8231293
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8231293/webrev.00/index.html
>>
>> Test:
>> ?? hotspot_gc_shenandoah (fastdebug and release)
>> ?? vmTestbase/nsk/jvmti (fastdebug and release) normal and traversal
>> ?? modes.
>>
>> Thanks,
>>
>> -Zhengyu
>>

From zgu at redhat.com  Mon Sep 23 15:00:54 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Mon, 23 Sep 2019 11:00:54 -0400
Subject: [Shenandoh 8u] Shenandoah string dedup thread is not properly
 initialized
Message-ID: <d14c19c9-5d70-68e3-e849-5cf7a743cc24@redhat.com>

This bug seems to exist since day one of 8u backport. The 
ConcurrentGCThread API is different in 8u and we leaves 
ShenandoahDedupThread not properly initialized before it enters work loop.

In Shenandoah String Deduplication tests, the bug results assertion 
failure that shows Thread::current() == NULL.

The bug only manifests on Windows, is due to discrepancy of java_start() 
implementation on different OSs. e.g. it sets *thread* on Linux.


Webrev: 
http://cr.openjdk.java.net/~zgu/shenandoah/8u_init_dedup_thread/webrev.00/

Test:
   hotspot_gc_shenandoah on Windows and Linux.

Thanks,

-Zhengyu


From zgu at redhat.com  Mon Sep 23 15:16:46 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Mon, 23 Sep 2019 11:16:46 -0400
Subject: RFR 8231250: Shenandoah: Traversal GC should keep alive weak load
 from heap
Message-ID: <f6287b1f-e8c3-4c82-686b-75fcddd2a0f3@redhat.com>

Resubmit:
Was:  8231250: Shenandoah: Shenandoah assert_correct failed; Object 
klass pointer

SAP reported that this patch did not fix the assert failure in original 
bug report. But the fix is legit, as JDK-8227635 did change the behavior 
of traversal GC, resulting it may drop keepalive for heap loads.


Bug: https://bugs.openjdk.java.net/browse/JDK-8231250
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8231250/webrev.00/

Test:
   hotspot_gc_shenandoah (fastdebug and release) on Linux x86_64

Thanks,

-Zhengyu


From shade at redhat.com  Mon Sep 23 15:22:35 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 23 Sep 2019 17:22:35 +0200
Subject: [Shenandoh 8u] Shenandoah string dedup thread is not properly
 initialized
In-Reply-To: <d14c19c9-5d70-68e3-e849-5cf7a743cc24@redhat.com>
References: <d14c19c9-5d70-68e3-e849-5cf7a743cc24@redhat.com>
Message-ID: <73d8c34f-2f63-125a-1a50-c10a380e6bea@redhat.com>

On 9/23/19 5:00 PM, Zhengyu Gu wrote:
> Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/8u_init_dedup_thread/webrev.00/

Awwww. Looks good.

This looks like simple patch that fixes critical issue. So, please RFR it directly to aarch64-port@,
with proper bug ID and affects-versions: 8u-aarch64. We would pick it up from there.

-- 
Thanks,
-Aleksey


From gnu.andrew at redhat.com  Mon Sep 23 16:23:10 2019
From: gnu.andrew at redhat.com (Andrew John Hughes)
Date: Mon, 23 Sep 2019 17:23:10 +0100
Subject: [RFR] [8u] 8u232-b06 Upstream Sync
Message-ID: <156017c7-ce6d-dd46-32b6-4b35d89f4443@redhat.com>

Webrevs: https://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/

Merge changesets:

http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/corba/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/jaxp/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/jaxws/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/jdk/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/hotspot/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/langtools/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/nashorn/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/root/merge.changeset

Changes in aarch64-shenandoah-jdk8u232-b06:
  - S8178870: instrumentation.retransformClasses cause coredump
  - S8216965: crash in freetypeScaler.c CopyBW2Grey8
  - S8217676: Upgrade libpng to 1.6.37
  - S8222108: Reduce minRefreshTime for updating remote printer list on
Windows

Main issues of note:
make/lib/Awt2dLibraries.gmk already contained -DPNG_ARM_NEON_OPT=0 so a
manual merge was necessary.

diffstat for root
 b/.hgtags            |    1
 b/THIRD_PARTY_README |  171
+++++++++++++++++++++++++++++----------------------
 2 files changed, 101 insertions(+), 71 deletions(-)

diffstat for corba
 b/.hgtags            |    1
 b/THIRD_PARTY_README |  171
+++++++++++++++++++++++++++++----------------------
 2 files changed, 101 insertions(+), 71 deletions(-)

diffstat for jaxp
 b/.hgtags            |    1
 b/THIRD_PARTY_README |  171
+++++++++++++++++++++++++++++----------------------
 2 files changed, 101 insertions(+), 71 deletions(-)

diffstat for jaxws
 b/.hgtags            |    1
 b/THIRD_PARTY_README |  171
+++++++++++++++++++++++++++++----------------------
 2 files changed, 101 insertions(+), 71 deletions(-)

diffstat for langtools
 b/.hgtags            |    1
 b/THIRD_PARTY_README |  171
+++++++++++++++++++++++++++++----------------------
 2 files changed, 101 insertions(+), 71 deletions(-)

diffstat for nashorn
 b/.hgtags            |    1
 b/THIRD_PARTY_README |  171
+++++++++++++++++++++++++++++----------------------
 2 files changed, 101 insertions(+), 71 deletions(-)

diffstat for hotspot
 b/.hgtags                                              |    1
 b/THIRD_PARTY_README                                   |  171
+++++++++--------
 b/src/share/vm/prims/jvmtiRedefineClasses.cpp          |   11 -
 b/test/runtime/RedefineTests/RedefineDoubleDelete.java |   81 ++++++++
 b/test/runtime/RedefineTests/libRedefineDoubleDelete.c |  164
++++++++++++++++
 b/test/runtime/RedefineTests/test8178870.sh            |   87 ++++++++
 6 files changed, 441 insertions(+), 74 deletions(-)

diffstat for jdk
 b/.hgtags
              |    1
 b/THIRD_PARTY_README
              |  171 +++--
 b/make/lib/Awt2dLibraries.gmk
              |    3
 b/src/share/native/sun/awt/libpng/CHANGES
              |   48 +
 b/src/share/native/sun/awt/libpng/LICENSE
              |  175 ++---
 b/src/share/native/sun/awt/libpng/README
              |  109 +--
 b/src/share/native/sun/awt/libpng/png.c
              |   50 -
 b/src/share/native/sun/awt/libpng/png.h
              |  313 ++++------
 b/src/share/native/sun/awt/libpng/pngconf.h
              |   18
 b/src/share/native/sun/awt/libpng/pngdebug.h
              |    6
 b/src/share/native/sun/awt/libpng/pngerror.c
              |   12
 b/src/share/native/sun/awt/libpng/pngget.c
              |    6
 b/src/share/native/sun/awt/libpng/pnginfo.h
              |    6
 b/src/share/native/sun/awt/libpng/pnglibconf.h
              |   15
 b/src/share/native/sun/awt/libpng/pngmem.c
              |    6
 b/src/share/native/sun/awt/libpng/pngpread.c
              |   16
 b/src/share/native/sun/awt/libpng/pngpriv.h
              |   39 +
 b/src/share/native/sun/awt/libpng/pngread.c
              |   40 -
 b/src/share/native/sun/awt/libpng/pngrio.c
              |    6
 b/src/share/native/sun/awt/libpng/pngrtran.c
              |  118 ++-
 b/src/share/native/sun/awt/libpng/pngrutil.c
              |   39 -
 b/src/share/native/sun/awt/libpng/pngset.c
              |   12
 b/src/share/native/sun/awt/libpng/pngstruct.h
              |   12
 b/src/share/native/sun/awt/libpng/pngtrans.c
              |   12
 b/src/share/native/sun/font/freetypeScaler.c
              |    5
 b/src/windows/classes/sun/print/PrintServiceLookupProvider.java
              |   96 +--
 b/test/java/awt/FontClass/FontSize1Test.java
              |   56 +
 b/test/jdk/java/awt/print/RemotePrinterStatusRefresh/RemotePrinterStatusRefresh.java |   18
 28 files changed, 762 insertions(+), 646 deletions(-)

Successfully built on x86, x86_64, s390, s390x, ppc, ppc64, ppc64le &
aarch64.

Ok to push?
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew


From zgu at redhat.com  Mon Sep 23 16:24:26 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Mon, 23 Sep 2019 12:24:26 -0400
Subject: [8u] 8231366: Shenandoah: Shenandoah String Dedup thread is not
 properly initialized
Message-ID: <d45f273f-b9bf-f8dc-375b-f996807f69a6@redhat.com>

This bug seems to exist since day one of 8u backport. The 
ConcurrentGCThread API is different in 8u and we leave 
ShenandoahDedupThread not properly initialized before it enters work loop.

In Shenandoah String Deduplication tests, the bug results assertion 
failure that shows Thread::current() == NULL.

The bug only manifests on Windows, is due to discrepancy of java_start() 
implementation on different OSs. e.g. it sets *thread* on Linux.

Bug: https://bugs.openjdk.java.net/browse/JDK-8231366
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8231366/webrev.00/

Test:
   hotspot_gc_shenandoah on Windows and Linux.

Thanks,

-Zhengyu


From shade at redhat.com  Mon Sep 23 16:29:40 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 23 Sep 2019 18:29:40 +0200
Subject: [aarch64-port-dev ] [RFR] [8u] 8u232-b06 Upstream Sync
In-Reply-To: <156017c7-ce6d-dd46-32b6-4b35d89f4443@redhat.com>
References: <156017c7-ce6d-dd46-32b6-4b35d89f4443@redhat.com>
Message-ID: <cf07659f-18ce-a319-c471-ef112c357d2d@redhat.com>

On 9/23/19 6:23 PM, Andrew John Hughes wrote:
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/corba/merge.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/jaxp/merge.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/jaxws/merge.changeset

Looks good.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/jdk/merge.changeset

PNG sync is largeish, but looks good.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/hotspot/merge.changeset

Looks good.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/langtools/merge.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/nashorn/merge.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/root/merge.changeset
Looks good.

Thumbs up! Good to go.

-- 
Thanks,
-Aleksey


From zgu at redhat.com  Mon Sep 23 16:34:36 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Mon, 23 Sep 2019 12:34:36 -0400
Subject: [8u] 8231366: Shenandoah: Shenandoah String Dedup thread is not
 properly initialized
In-Reply-To: <3be75ce1-1a05-685d-794e-bdf37c73e8d6@redhat.com>
References: <d45f273f-b9bf-f8dc-375b-f996807f69a6@redhat.com>
 <3be75ce1-1a05-685d-794e-bdf37c73e8d6@redhat.com>
Message-ID: <7590f574-a724-85f7-6d71-8ef068d335a7@redhat.com>

Thanks, Aleksey.

-Zhengyu

On 9/23/19 12:33 PM, Aleksey Shipilev wrote:
> On 9/23/19 6:24 PM, Zhengyu Gu wrote:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8231366
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8231366/webrev.00/
> 
> Looks good to me, thank you.
> 
> I added the comment that other versions (9+) are handled correctly by shared code change in JDK-8140257.
> 

From shade at redhat.com  Mon Sep 23 16:33:56 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 23 Sep 2019 18:33:56 +0200
Subject: [8u] 8231366: Shenandoah: Shenandoah String Dedup thread is not
 properly initialized
In-Reply-To: <d45f273f-b9bf-f8dc-375b-f996807f69a6@redhat.com>
References: <d45f273f-b9bf-f8dc-375b-f996807f69a6@redhat.com>
Message-ID: <3be75ce1-1a05-685d-794e-bdf37c73e8d6@redhat.com>

On 9/23/19 6:24 PM, Zhengyu Gu wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8231366
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8231366/webrev.00/

Looks good to me, thank you.

I added the comment that other versions (9+) are handled correctly by shared code change in JDK-8140257.

-- 
Thanks,
-Aleksey


From gnu.andrew at redhat.com  Mon Sep 23 16:35:00 2019
From: gnu.andrew at redhat.com (Andrew John Hughes)
Date: Mon, 23 Sep 2019 17:35:00 +0100
Subject: [aarch64-port-dev ] [RFR] [8u] 8u232-b06 Upstream Sync
In-Reply-To: <cf07659f-18ce-a319-c471-ef112c357d2d@redhat.com>
References: <156017c7-ce6d-dd46-32b6-4b35d89f4443@redhat.com>
 <cf07659f-18ce-a319-c471-ef112c357d2d@redhat.com>
Message-ID: <d4985253-8e3e-663e-7a50-e92edffa6c4f@redhat.com>



On 23/09/2019 17:29, Aleksey Shipilev wrote:
> On 9/23/19 6:23 PM, Andrew John Hughes wrote:
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/corba/merge.changeset
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/jaxp/merge.changeset
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/jaxws/merge.changeset
> 
> Looks good.
> 
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/jdk/merge.changeset
> 
> PNG sync is largeish, but looks good.
> 
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/hotspot/merge.changeset
> 
> Looks good.
> 
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/langtools/merge.changeset
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/nashorn/merge.changeset
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b06/root/merge.changeset
> Looks good.
> 
> Thumbs up! Good to go.
> 

Pushed.

The libpng changes are an upstream merge in their own right. All I can
really say about them is they match the original jdk11 version when I
reviewed the backport itself.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew


From rkennke at redhat.com  Mon Sep 23 16:37:01 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 23 Sep 2019 18:37:01 +0200
Subject: RFR 8231250: Shenandoah: Traversal GC should keep alive weak load
 from heap
In-Reply-To: <f6287b1f-e8c3-4c82-686b-75fcddd2a0f3@redhat.com>
References: <f6287b1f-e8c3-4c82-686b-75fcddd2a0f3@redhat.com>
Message-ID: <eb852058-2903-7bdd-f0d6-2ad8f6fabe30@redhat.com>

OK.

We need to have a close look at the interaction between traversal and 
native barriers/conc roots soon.

Roman


> Resubmit:
> Was:? 8231250: Shenandoah: Shenandoah assert_correct failed; Object 
> klass pointer
> 
> SAP reported that this patch did not fix the assert failure in original 
> bug report. But the fix is legit, as JDK-8227635 did change the behavior 
> of traversal GC, resulting it may drop keepalive for heap loads.
> 
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8231250
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8231250/webrev.00/
> 
> Test:
>  ? hotspot_gc_shenandoah (fastdebug and release) on Linux x86_64
> 
> Thanks,
> 
> -Zhengyu
> 

From gnu.andrew at redhat.com  Mon Sep 23 16:43:35 2019
From: gnu.andrew at redhat.com (Andrew John Hughes)
Date: Mon, 23 Sep 2019 17:43:35 +0100
Subject: [8u] 8231366: Shenandoah: Shenandoah String Dedup thread is not
 properly initialized
In-Reply-To: <d45f273f-b9bf-f8dc-375b-f996807f69a6@redhat.com>
References: <d45f273f-b9bf-f8dc-375b-f996807f69a6@redhat.com>
Message-ID: <6381fb96-2bd2-a2a3-0d60-f4b971f9bc43@redhat.com>



On 23/09/2019 17:24, Zhengyu Gu wrote:
> This bug seems to exist since day one of 8u backport. The
> ConcurrentGCThread API is different in 8u and we leave
> ShenandoahDedupThread not properly initialized before it enters work loop.
> 
> In Shenandoah String Deduplication tests, the bug results assertion
> failure that shows Thread::current() == NULL.
> 
> The bug only manifests on Windows, is due to discrepancy of java_start()
> implementation on different OSs. e.g. it sets *thread* on Linux.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8231366
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8231366/webrev.00/
> 
> Test:
> ? hotspot_gc_shenandoah on Windows and Linux.
> 
> Thanks,
> 
> -Zhengyu
> 

Looks fine to me and matches what is done in other subclasses of
ConcurrentGCThread like shenandoah/shenandoahControlThread.cpp and
g1/g1StringDedupThread.cpp.

It does make me wonder if there isn't some way that ConcurrentGCThread
could catch this lack of initialisation, or do the initialisation
itself, then defer to the run() implementation of a subclass.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew


From shade at redhat.com  Mon Sep 23 16:47:40 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 23 Sep 2019 18:47:40 +0200
Subject: [aarch64-port-dev ] [8u] 8231366: Shenandoah: Shenandoah String
 Dedup thread is not properly initialized
In-Reply-To: <6381fb96-2bd2-a2a3-0d60-f4b971f9bc43@redhat.com>
References: <d45f273f-b9bf-f8dc-375b-f996807f69a6@redhat.com>
 <6381fb96-2bd2-a2a3-0d60-f4b971f9bc43@redhat.com>
Message-ID: <5eb739de-3ee1-5b93-d34c-cb6139a15f54@redhat.com>

On 9/23/19 6:43 PM, Andrew John Hughes wrote:
> It does make me wonder if there isn't some way that ConcurrentGCThread
> could catch this lack of initialisation, or do the initialisation
> itself, then defer to the run() implementation of a subclass.

This is what later issue in 9+ did (among other things):
  https://bugs.openjdk.java.net/browse/JDK-8140257

...so this bug is 8-specific.

-- 
Thanks,
-Aleksey


From shade at redhat.com  Mon Sep 23 16:48:28 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 23 Sep 2019 18:48:28 +0200
Subject: RFR: 2019-09-24, bulk backports to sh/jdk11
Message-ID: <1a85a182-a915-5b0e-6e00-da169703fc12@redhat.com>

Let me backport these JVMTI fixes to sh/jdk11:
  [backport] 8231197: Shenandoah: JVMTI heap walking cleanup crashes with NULL forwardee
  [backport] 8231198: Shenandoah: heap walking should visit all roots most of the time
  [backport] 8231244: Shenandoah: all-roots heap walking misses some weak roots
  [backport] 8231249: Shenandoah: GC retries are too aggressive for tests that expect OOME

Webrev:
  https://cr.openjdk.java.net/~shade/shenandoah/backports/jdk11-20190924/webrev.01/

Except the last patch in the queue, other patches have been tested in jdk/jdk over the weekend with
no detected trouble. I would wait for next nightlies to verify the last patch too, and I don't
foresee problems.

Testing: hotspot_gc_shenandoah; vmTestbase_nsk_jvmti

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Mon Sep 23 17:00:52 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 23 Sep 2019 19:00:52 +0200
Subject: RFR: 2019-09-24, bulk backports to sh/jdk11
In-Reply-To: <1a85a182-a915-5b0e-6e00-da169703fc12@redhat.com>
References: <1a85a182-a915-5b0e-6e00-da169703fc12@redhat.com>
Message-ID: <4f75cbe7-be09-e4fe-efb1-7cca46548463@redhat.com>

Looks good! Thanks!

Roman


> Let me backport these JVMTI fixes to sh/jdk11:
>    [backport] 8231197: Shenandoah: JVMTI heap walking cleanup crashes with NULL forwardee
>    [backport] 8231198: Shenandoah: heap walking should visit all roots most of the time
>    [backport] 8231244: Shenandoah: all-roots heap walking misses some weak roots
>    [backport] 8231249: Shenandoah: GC retries are too aggressive for tests that expect OOME
> 
> Webrev:
>    https://cr.openjdk.java.net/~shade/shenandoah/backports/jdk11-20190924/webrev.01/
> 
> Except the last patch in the queue, other patches have been tested in jdk/jdk over the weekend with
> no detected trouble. I would wait for next nightlies to verify the last patch too, and I don't
> foresee problems.
> 
> Testing: hotspot_gc_shenandoah; vmTestbase_nsk_jvmti
> 

From gnu.andrew at redhat.com  Mon Sep 23 17:09:49 2019
From: gnu.andrew at redhat.com (Andrew John Hughes)
Date: Mon, 23 Sep 2019 18:09:49 +0100
Subject: [aarch64-port-dev ] [8u] 8231366: Shenandoah: Shenandoah String
 Dedup thread is not properly initialized
In-Reply-To: <5eb739de-3ee1-5b93-d34c-cb6139a15f54@redhat.com>
References: <d45f273f-b9bf-f8dc-375b-f996807f69a6@redhat.com>
 <6381fb96-2bd2-a2a3-0d60-f4b971f9bc43@redhat.com>
 <5eb739de-3ee1-5b93-d34c-cb6139a15f54@redhat.com>
Message-ID: <8a0669a3-4c10-7afd-04d8-4dd3d89a80c9@redhat.com>



On 23/09/2019 17:47, Aleksey Shipilev wrote:
> On 9/23/19 6:43 PM, Andrew John Hughes wrote:
>> It does make me wonder if there isn't some way that ConcurrentGCThread
>> could catch this lack of initialisation, or do the initialisation
>> itself, then defer to the run() implementation of a subclass.
> 
> This is what later issue in 9+ did (among other things):
>   https://bugs.openjdk.java.net/browse/JDK-8140257
> 
> ...so this bug is 8-specific.
> 

Ah yes, I just found the changeset as I read your e-mail. I had a
feeling someone must have cleaned this up by now :)
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew


From zgu at redhat.com  Mon Sep 23 18:28:43 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Mon, 23 Sep 2019 14:28:43 -0400
Subject: RFR 8231250: Shenandoah: Traversal GC should keep alive weak load
 from heap
In-Reply-To: <eb852058-2903-7bdd-f0d6-2ad8f6fabe30@redhat.com>
References: <f6287b1f-e8c3-4c82-686b-75fcddd2a0f3@redhat.com>
 <eb852058-2903-7bdd-f0d6-2ad8f6fabe30@redhat.com>
Message-ID: <bcac97f0-37a1-9a26-8494-e0af4e5de648@redhat.com>



On 9/23/19 12:37 PM, Roman Kennke wrote:
> OK.

Thanks for reviewing.

> 
> We need to have a close look at the interaction between traversal and 
> native barriers/conc roots soon.

Concurrent roots is not enabled for traversal. I think we have problem 
of hitting barriers on GC paths, which trigger side-effects of LRB.

Thanks,

-Zhengyu


> 
> Roman
> 
> 
>> Resubmit:
>> Was:? 8231250: Shenandoah: Shenandoah assert_correct failed; Object 
>> klass pointer
>>
>> SAP reported that this patch did not fix the assert failure in 
>> original bug report. But the fix is legit, as JDK-8227635 did change 
>> the behavior of traversal GC, resulting it may drop keepalive for heap 
>> loads.
>>
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8231250
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8231250/webrev.00/
>>
>> Test:
>> ?? hotspot_gc_shenandoah (fastdebug and release) on Linux x86_64
>>
>> Thanks,
>>
>> -Zhengyu
>>

From shade at redhat.com  Tue Sep 24 07:16:13 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 24 Sep 2019 09:16:13 +0200
Subject: RFR: 2019-09-24, bulk backports to sh/jdk11
In-Reply-To: <1a85a182-a915-5b0e-6e00-da169703fc12@redhat.com>
References: <1a85a182-a915-5b0e-6e00-da169703fc12@redhat.com>
Message-ID: <90d91b5c-19ef-b1fd-77e2-09a32f6183b3@redhat.com>

On 9/23/19 6:48 PM, Aleksey Shipilev wrote:
> Let me backport these JVMTI fixes to sh/jdk11:
>   [backport] 8231197: Shenandoah: JVMTI heap walking cleanup crashes with NULL forwardee
>   [backport] 8231198: Shenandoah: heap walking should visit all roots most of the time
>   [backport] 8231244: Shenandoah: all-roots heap walking misses some weak roots
>   [backport] 8231249: Shenandoah: GC retries are too aggressive for tests that expect OOME
> 
> Webrev:
>   https://cr.openjdk.java.net/~shade/shenandoah/backports/jdk11-20190924/webrev.01/
> 
> Except the last patch in the queue, other patches have been tested in jdk/jdk over the weekend with
> no detected trouble. I would wait for next nightlies to verify the last patch too, and I don't
> foresee problems.

The last patch seems to cause some troubles in humongous allocation tests, so I would take that off
this backporting batch, and push the other three. It fixes a test timeouts, so the absence of it
should not affect product reliability. Meanwhile, I'll follow up on those failures.

-- 
Thanks,
-Aleksey


From shade at redhat.com  Tue Sep 24 07:16:57 2019
From: shade at redhat.com (shade at redhat.com)
Date: Tue, 24 Sep 2019 07:16:57 +0000
Subject: hg: shenandoah/jdk11: 3 new changesets
Message-ID: <201909240716.x8O7GwDi009077@aojmv0008.oracle.com>

Changeset: 2563158f6105
Author:    shade
Date:      2019-09-19 20:26 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/2563158f6105

[backport] 8231197: Shenandoah: JVMTI heap walking cleanup crashes with NULL forwardee
Reviewed-by: zgu, rkennke

! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

Changeset: 11fc0d1a04b6
Author:    shade
Date:      2019-09-19 20:26 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/11fc0d1a04b6

[backport] 8231198: Shenandoah: heap walking should visit all roots most of the time
Reviewed-by: zgu, rkennke

! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

Changeset: 44db3832cddc
Author:    shade
Date:      2019-09-19 20:26 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/44db3832cddc

[backport] 8231244: Shenandoah: all-roots heap walking misses some weak roots
Reviewed-by: zgu, rkennke

! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp


From shade at redhat.com  Tue Sep 24 07:43:46 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 24 Sep 2019 09:43:46 +0200
Subject: RFR (T) 8231395: Backout JDK-8231249
Message-ID: <1727364f-036a-ef37-bfa5-467c1d65b842@redhat.com>

Bug:
 https://bugs.openjdk.java.net/browse/JDK-8231395

JDK-8231249 caused some testing failures, notably in:
  gc/shenandoah/oom/TestClassLoaderLeak.java failed (JDK-8231389)
  gc/shenandoah/TestAllocHumongousFragment.java

The reason is that those tests expect us to eventually come to Full GC, and JDK-8231249 prevents
that. It requires more comprehensive fix. Let's backout the bad fix meanwhile.

Fix, produced by "hg backout"

diff -r ef8c8cf9256a src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
--- a/src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp        Fri Sep 20 10:28:48 2019 +0200
+++ b/src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp        Tue Sep 24 09:42:57 2019 +0200
@@ -810,10 +810,20 @@
     // other threads have already depleted the free storage. In this case, a better
     // strategy is to try again, as long as GC makes progress.
-
-    if (result == NULL) {
-      do {
-        control_thread()->handle_alloc_failure(req.size());
-        result = allocate_memory_under_lock(req, in_new_region);
-      } while (result == NULL && _progress_last_gc.is_set());
+    //
+    // Then, we need to make sure the allocation was retried after at least one
+    // Full GC, which means we want to try more than ShenandoahFullGCThreshold times.
+
+    size_t tries = 0;
+
+    while (result == NULL && _progress_last_gc.is_set()) {
+      tries++;
+      control_thread()->handle_alloc_failure(req.size());
+      result = allocate_memory_under_lock(req, in_new_region);
+    }
+
+    while (result == NULL && tries <= ShenandoahFullGCThreshold) {
+      tries++;
+      control_thread()->handle_alloc_failure(req.size());
+      result = allocate_memory_under_lock(req, in_new_region);
     }


Testing: hotspot_gc_shenandoah

-- 
Thanks,
-Aleksey


From mark.reinhold at oracle.com  Tue Sep 24 23:34:59 2019
From: mark.reinhold at oracle.com (mark.reinhold at oracle.com)
Date: Tue, 24 Sep 2019 16:34:59 -0700
Subject: RFR: JDK-8231086: Shenandoah: Stronger invariant for
 object-arraycopy
In-Reply-To: <5891bb2e-52ba-b3af-c89a-dfb60ac4e4ac@redhat.com>
References: <5891bb2e-52ba-b3af-c89a-dfb60ac4e4ac@redhat.com>
Message-ID: <20190924163459.120313957@eggemoggin.niobe.net>

Perhaps you?re aware of this already, but after this change and its
predecessor (8231085) it takes significantly longer to compile HotSpot,
I?m guessing due to C++ template expansion.  I saw build times on a
four-core, eight-thread, 64GB Xeon box go from about 10m up to 15m.

(Yes, I?m aware that one could avoid this slowdown by not building
 Shenandoah, but who would want to do that?)

Bisecting the repo to identify this slowdown was tricky since the
changeset for 8231085 (b1a394e15ae9) leaves the repo in a state that
doesn?t build.  Please avoid that going forward -- every changeset
should leave the repo in a buildable state.

- Mark

From rkennke at redhat.com  Wed Sep 25 07:13:59 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 25 Sep 2019 09:13:59 +0200
Subject: RFR: JDK-8231086: Shenandoah: Stronger invariant for
 object-arraycopy
In-Reply-To: <20190924163459.120313957@eggemoggin.niobe.net>
References: <5891bb2e-52ba-b3af-c89a-dfb60ac4e4ac@redhat.com>
 <20190924163459.120313957@eggemoggin.niobe.net>
Message-ID: <c5262ebc-cfd4-cc17-fa59-b6e6ac3f64eb@redhat.com>

Hi Mark,

> Perhaps you?re aware of this already, but after this change and its
> predecessor (8231085) it takes significantly longer to compile HotSpot,
> I?m guessing due to C++ template expansion.  I saw build times on a
> four-core, eight-thread, 64GB Xeon box go from about 10m up to 15m.

Ugh.
I just tried on my TR1950X box with 64G mem, before it was 3:30m, now it 
takes 5:06. So yeah, that's bad.

It is also a bit surprising, because the change *removed* a whole lot of 
template crap. It also added some (smaller) templated loop.

I'll investigate what causes the slowdown and if we can reasonably fix this.

> (Yes, I?m aware that one could avoid this slowdown by not building
>   Shenandoah, but who would want to do that?)

:-)

> Bisecting the repo to identify this slowdown was tricky since the
> changeset for 8231085 (b1a394e15ae9) leaves the repo in a state that
> doesn?t build.  Please avoid that going forward -- every changeset
> should leave the repo in a buildable state.

I'm sorry for that. I should probably have folded the two changes 
together into one. I'll avoid it in the future.

Roman


From shade at redhat.com  Wed Sep 25 09:01:15 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 25 Sep 2019 11:01:15 +0200
Subject: RFC: Pick up jdk-11.0.5+9 to sh/jdk11
Message-ID: <495ad12a-1ccf-53bf-22f6-b26769088fba@redhat.com>

Upstream had published jdk-11.0.5+9, let's pick it up to sh/jdk11.

Merge is trivial. I would tag the result immediately as shenandoah-jdk-11.0.5+9.

Changeset list:
  https://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.5%2b9/changesets.txt

Testing: hotspot_gc_shenandoah {fastdebug,release}

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Wed Sep 25 10:08:32 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 25 Sep 2019 12:08:32 +0200
Subject: RFC: Pick up jdk-11.0.5+9 to sh/jdk11
In-Reply-To: <495ad12a-1ccf-53bf-22f6-b26769088fba@redhat.com>
References: <495ad12a-1ccf-53bf-22f6-b26769088fba@redhat.com>
Message-ID: <4d3267d6-9540-268b-94f3-b838e5af43fa@redhat.com>

Good!
Thanks,
Roman


> Upstream had published jdk-11.0.5+9, let's pick it up to sh/jdk11.
> 
> Merge is trivial. I would tag the result immediately as shenandoah-jdk-11.0.5+9.
> 
> Changeset list:
>    https://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.5%2b9/changesets.txt
> 
> Testing: hotspot_gc_shenandoah {fastdebug,release}
> 

From rkennke at redhat.com  Wed Sep 25 10:11:13 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 25 Sep 2019 12:11:13 +0200
Subject: RFR: JDK-8231447: Shenandoah: Compilation-time regression after
 JDK-8231086
Message-ID: <2c2c9adc-cb89-5ac6-a787-24e118e857bf@redhat.com>

With JDK-8231086, compilation time of fastdebug build regressed from 
~3:30m to ~5:00m here. See also:

https://mail.openjdk.java.net/pipermail/shenandoah-dev/2019-September/010622.html

The problem appears to be the presence of clone-barrier code in 
shenandoahBarrierSet.inline.hpp which is then subsequently processed by 
anything that includes that file (incl.  and in particular the Access API).

I propose to fix it by breaking out the clone_barrier() code into its 
own file, and only include that where we need it shenandoahRuntime.cpp, 
and let the access-API clone() call a non-inlined entry point that 
resides in shenandoahBarrierSet.cpp. This brings compile-time back to 
what it was before.

http://cr.openjdk.java.net/~rkennke/JDK-8231447/webrev.00/

Testing: hotspot_gc_shenandoah

Ok?

Roman


From shade at redhat.com  Wed Sep 25 10:17:00 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 25 Sep 2019 12:17:00 +0200
Subject: RFR: JDK-8231447: Shenandoah: Compilation-time regression after
 JDK-8231086
In-Reply-To: <2c2c9adc-cb89-5ac6-a787-24e118e857bf@redhat.com>
References: <2c2c9adc-cb89-5ac6-a787-24e118e857bf@redhat.com>
Message-ID: <bd21f446-ab3d-0973-f4f4-9309385c399d@redhat.com>

On 9/25/19 12:11 PM, Roman Kennke wrote:
> http://cr.openjdk.java.net/~rkennke/JDK-8231447/webrev.00/

Looks okay.

*) The include guard is not correct in shenandoahBarrierSetClone.inline.hpp:

  24 #ifndef SHARE_GC_SHENANDOAH_SHENANDOAHBARRIERSETCLONE_HPP
  25 #define SHARE_GC_SHENANDOAH_SHENANDOAHBARRIERSETCLONE_HPP
  ...
  98 #endif // SHARE_GC_SHENANDOAH_SHENANDOAHBARRIERSETCLONE_HPP

Should be SHARE_GC_SHENANDOAH_SHENANDOAHBARRIERSETCLONE_INLINE_HPP?

*) Does this compile with --disable-precompiled-headers?

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Wed Sep 25 10:29:00 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 25 Sep 2019 12:29:00 +0200
Subject: RFR: JDK-8231447: Shenandoah: Compilation-time regression after
 JDK-8231086
In-Reply-To: <bd21f446-ab3d-0973-f4f4-9309385c399d@redhat.com>
References: <2c2c9adc-cb89-5ac6-a787-24e118e857bf@redhat.com>
 <bd21f446-ab3d-0973-f4f4-9309385c399d@redhat.com>
Message-ID: <7f86798b-a659-2e8c-bcd7-7024d87e5dd6@redhat.com>

> On 9/25/19 12:11 PM, Roman Kennke wrote:
>> http://cr.openjdk.java.net/~rkennke/JDK-8231447/webrev.00/
> 
> Looks okay.
> 
> *) The include guard is not correct in shenandoahBarrierSetClone.inline.hpp:
> 
>    24 #ifndef SHARE_GC_SHENANDOAH_SHENANDOAHBARRIERSETCLONE_HPP
>    25 #define SHARE_GC_SHENANDOAH_SHENANDOAHBARRIERSETCLONE_HPP
>    ...
>    98 #endif // SHARE_GC_SHENANDOAH_SHENANDOAHBARRIERSETCLONE_HPP
> 
> Should be SHARE_GC_SHENANDOAH_SHENANDOAHBARRIERSETCLONE_INLINE_HPP?

Right:
http://cr.openjdk.java.net/~rkennke/JDK-8231447/webrev.01/

> *) Does this compile with --disable-precompiled-headers?

yes.

Good?

Roman

From shade at redhat.com  Wed Sep 25 10:29:45 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 25 Sep 2019 12:29:45 +0200
Subject: RFR: JDK-8231447: Shenandoah: Compilation-time regression after
 JDK-8231086
In-Reply-To: <7f86798b-a659-2e8c-bcd7-7024d87e5dd6@redhat.com>
References: <2c2c9adc-cb89-5ac6-a787-24e118e857bf@redhat.com>
 <bd21f446-ab3d-0973-f4f4-9309385c399d@redhat.com>
 <7f86798b-a659-2e8c-bcd7-7024d87e5dd6@redhat.com>
Message-ID: <d2a9ae84-5734-6219-1775-6fb1b6bfafbf@redhat.com>

On 9/25/19 12:29 PM, Roman Kennke wrote:
> Right:
> http://cr.openjdk.java.net/~rkennke/JDK-8231447/webrev.01/
> 
>> *) Does this compile with --disable-precompiled-headers?
> 
> yes.
> 
> Good?

Good.

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Wed Sep 25 10:36:55 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 25 Sep 2019 12:36:55 +0200
Subject: RFR: JDK-8231086: Shenandoah: Stronger invariant for
 object-arraycopy
In-Reply-To: <c5262ebc-cfd4-cc17-fa59-b6e6ac3f64eb@redhat.com>
References: <5891bb2e-52ba-b3af-c89a-dfb60ac4e4ac@redhat.com>
 <20190924163459.120313957@eggemoggin.niobe.net>
 <c5262ebc-cfd4-cc17-fa59-b6e6ac3f64eb@redhat.com>
Message-ID: <a2e053ac-c0a5-e44e-291b-e484e12fe000@redhat.com>

Hi Mark,

We identified and fixed the problem. See:

https://mail.openjdk.java.net/pipermail/shenandoah-dev/2019-September/010626.html

and:
https://bugs.openjdk.java.net/browse/JDK-8231447

Thanks for raising attention to this issue!

Roman

> Hi Mark,
> 
>> Perhaps you?re aware of this already, but after this change and its
>> predecessor (8231085) it takes significantly longer to compile HotSpot,
>> I?m guessing due to C++ template expansion.? I saw build times on a
>> four-core, eight-thread, 64GB Xeon box go from about 10m up to 15m.
> 
> Ugh.
> I just tried on my TR1950X box with 64G mem, before it was 3:30m, now it 
> takes 5:06. So yeah, that's bad.
> 
> It is also a bit surprising, because the change *removed* a whole lot of 
> template crap. It also added some (smaller) templated loop.
> 
> I'll investigate what causes the slowdown and if we can reasonably fix 
> this.
> 
>> (Yes, I?m aware that one could avoid this slowdown by not building
>> ? Shenandoah, but who would want to do that?)
> 
> :-)
> 
>> Bisecting the repo to identify this slowdown was tricky since the
>> changeset for 8231085 (b1a394e15ae9) leaves the repo in a state that
>> doesn?t build.? Please avoid that going forward -- every changeset
>> should leave the repo in a buildable state.
> 
> I'm sorry for that. I should probably have folded the two changes 
> together into one. I'll avoid it in the future.
> 
> Roman
> 


From shade at redhat.com  Wed Sep 25 11:09:30 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 25 Sep 2019 13:09:30 +0200
Subject: RFR (S) 8231410: Shenandoah: clone barrier should use base pointer
Message-ID: <fe24bfd6-7a13-168c-444b-6ba4265068ce@redhat.com>

Bug:
  https://bugs.openjdk.java.net/browse/JDK-8231410

This is reproducible with x86_32, but the bug is generic, introduced by JDK-8231086.
ShenandoahRuntime::shenandoah_clone_barrier expects src to be the base pointer for the clone barrier
to act. C2, however, passes in the interior ptrs to the object contents. This leads to crashes, but
surprisingly only on x86_32.

Fix:
  https://cr.openjdk.java.net/~shade/8231410/webrev.02/

Testing: {x86_32, x86_64, aarch64} hotspot_gc_shenandoah; new regression test

-- 
Thanks,
-Aleksey


From shade at redhat.com  Wed Sep 25 11:10:25 2019
From: shade at redhat.com (shade at redhat.com)
Date: Wed, 25 Sep 2019 11:10:25 +0000
Subject: hg: shenandoah/jdk11: 8 new changesets
Message-ID: <201909251110.x8PBAQTH026790@aojmv0008.oracle.com>

Changeset: 50b627d6587f
Author:    naoto
Date:      2019-07-26 08:56 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/50b627d6587f

8212970: TZ database in "vanguard" format support
Reviewed-by: rriggs, joehw, erikj, scolebourne

! make/CompileToolsJdk.gmk
+ make/CopyInterimTZDB.gmk
! make/Main.gmk
! make/data/tzdata/africa
! make/data/tzdata/asia
! make/data/tzdata/europe
! make/jdk/src/classes/build/tools/tzdb/TzdbZoneRulesCompiler.java
! make/jdk/src/classes/build/tools/tzdb/TzdbZoneRulesProvider.java
- make/jdk/src/classes/build/tools/tzdb/ZoneRules.java
! src/java.base/share/classes/java/time/zone/Ser.java
! src/java.base/share/classes/java/time/zone/ZoneOffsetTransitionRule.java
! src/java.base/share/classes/sun/util/calendar/ZoneInfo.java
+ test/jdk/java/time/test/java/time/zone/TestZoneRules.java
+ test/jdk/java/util/TimeZone/NegativeDSTTest.java
! test/jdk/sun/util/calendar/zi/TestZoneInfo310.java
- test/jdk/sun/util/calendar/zi/tzdata/VERSION
- test/jdk/sun/util/calendar/zi/tzdata/africa
- test/jdk/sun/util/calendar/zi/tzdata/antarctica
- test/jdk/sun/util/calendar/zi/tzdata/asia
- test/jdk/sun/util/calendar/zi/tzdata/australasia
- test/jdk/sun/util/calendar/zi/tzdata/backward
- test/jdk/sun/util/calendar/zi/tzdata/etcetera
- test/jdk/sun/util/calendar/zi/tzdata/europe
- test/jdk/sun/util/calendar/zi/tzdata/factory
- test/jdk/sun/util/calendar/zi/tzdata/gmt
- test/jdk/sun/util/calendar/zi/tzdata/iso3166.tab
- test/jdk/sun/util/calendar/zi/tzdata/jdk11_backward
- test/jdk/sun/util/calendar/zi/tzdata/leapseconds
- test/jdk/sun/util/calendar/zi/tzdata/northamerica
- test/jdk/sun/util/calendar/zi/tzdata/pacificnew
- test/jdk/sun/util/calendar/zi/tzdata/solar87
- test/jdk/sun/util/calendar/zi/tzdata/solar88
- test/jdk/sun/util/calendar/zi/tzdata/solar89
- test/jdk/sun/util/calendar/zi/tzdata/southamerica
- test/jdk/sun/util/calendar/zi/tzdata/systemv
- test/jdk/sun/util/calendar/zi/tzdata/zone.tab
- test/jdk/sun/util/calendar/zi/tzdata_jdk/gmt
- test/jdk/sun/util/calendar/zi/tzdata_jdk/jdk11_full_backward

Changeset: 4c0b21c9994e
Author:    rpatil
Date:      2019-08-07 13:00 +0100
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/4c0b21c9994e

8228469: (tz) Upgrade time-zone data to tzdata2019b
Reviewed-by: naoto, martin

! make/data/tzdata/VERSION
! make/data/tzdata/africa
! make/data/tzdata/antarctica
! make/data/tzdata/asia
! make/data/tzdata/australasia
! make/data/tzdata/europe
! make/data/tzdata/factory
! make/data/tzdata/northamerica
! make/data/tzdata/pacificnew
! make/data/tzdata/southamerica
! make/data/tzdata/systemv
! make/data/tzdata/zone.tab
! src/java.base/share/classes/sun/util/calendar/ZoneInfoFile.java
! test/jdk/java/util/TimeZone/TimeZoneTest.java

Changeset: 181366829708
Author:    redestad
Date:      2019-08-19 06:13 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/181366829708

8229773: Resolve permissions for code source URLs lazily
Reviewed-by: alanb, mullan, rriggs, dfuchs

! make/jdk/src/classes/build/tools/classlist/HelloClasslist.java
! src/java.base/share/classes/java/lang/System.java
! src/java.base/share/classes/java/security/CodeSource.java
! src/java.base/share/classes/jdk/internal/loader/BuiltinClassLoader.java
+ src/java.base/share/classes/sun/security/util/LazyCodeSourcePermissionCollection.java

Changeset: 6651ff78e2ff
Author:    clanger
Date:      2019-09-16 09:21 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/6651ff78e2ff

8230850: Test sun/tools/jcmd/TestProcessHelper.java fails intermittently
Reviewed-by: stuefe, cjplummer, sgehwolf

! test/jdk/sun/tools/jcmd/TestProcessHelper.java

Changeset: ee7128cf507a
Author:    bpb
Date:      2019-09-13 16:03 -0700
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/ee7128cf507a

8230085: (fs) FileStore::isReadOnly is always true on macOS Catalina
Reviewed-by: alanb

! src/java.base/macosx/classes/sun/nio/fs/BsdFileStore.java
! src/java.base/macosx/classes/sun/nio/fs/BsdNativeDispatcher.java
! src/java.base/macosx/native/libnio/fs/BsdNativeDispatcher.c
! src/java.base/unix/classes/sun/nio/fs/UnixNativeDispatcher.java

Changeset: c5091c754c12
Author:    goetz
Date:      2019-09-25 07:52 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/c5091c754c12

Added tag jdk-11.0.5+9 for changeset ee7128cf507a

! .hgtags

Changeset: 980d5f5db466
Author:    shade
Date:      2019-09-25 08:33 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/980d5f5db466

Merge

! .hgtags
- make/jdk/src/classes/build/tools/tzdb/ZoneRules.java
- test/jdk/sun/util/calendar/zi/tzdata/VERSION
- test/jdk/sun/util/calendar/zi/tzdata/africa
- test/jdk/sun/util/calendar/zi/tzdata/antarctica
- test/jdk/sun/util/calendar/zi/tzdata/asia
- test/jdk/sun/util/calendar/zi/tzdata/australasia
- test/jdk/sun/util/calendar/zi/tzdata/backward
- test/jdk/sun/util/calendar/zi/tzdata/etcetera
- test/jdk/sun/util/calendar/zi/tzdata/europe
- test/jdk/sun/util/calendar/zi/tzdata/factory
- test/jdk/sun/util/calendar/zi/tzdata/gmt
- test/jdk/sun/util/calendar/zi/tzdata/iso3166.tab
- test/jdk/sun/util/calendar/zi/tzdata/jdk11_backward
- test/jdk/sun/util/calendar/zi/tzdata/leapseconds
- test/jdk/sun/util/calendar/zi/tzdata/northamerica
- test/jdk/sun/util/calendar/zi/tzdata/pacificnew
- test/jdk/sun/util/calendar/zi/tzdata/solar87
- test/jdk/sun/util/calendar/zi/tzdata/solar88
- test/jdk/sun/util/calendar/zi/tzdata/solar89
- test/jdk/sun/util/calendar/zi/tzdata/southamerica
- test/jdk/sun/util/calendar/zi/tzdata/systemv
- test/jdk/sun/util/calendar/zi/tzdata/zone.tab
- test/jdk/sun/util/calendar/zi/tzdata_jdk/gmt
- test/jdk/sun/util/calendar/zi/tzdata_jdk/jdk11_full_backward

Changeset: 0d1de220c233
Author:    shade
Date:      2019-09-25 08:33 +0200
URL:       https://hg.openjdk.java.net/shenandoah/jdk11/rev/0d1de220c233

Added tag shenandoah-jdk-11.0.5+9 for changeset 980d5f5db466

! .hgtags


From rkennke at redhat.com  Wed Sep 25 11:53:05 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 25 Sep 2019 13:53:05 +0200
Subject: RFR (S) 8231410: Shenandoah: clone barrier should use base pointer
In-Reply-To: <fe24bfd6-7a13-168c-444b-6ba4265068ce@redhat.com>
References: <fe24bfd6-7a13-168c-444b-6ba4265068ce@redhat.com>
Message-ID: <f89b3304-851b-7799-7fb9-835ed503d10c@redhat.com>

I'd suggest passing the interior ptrs and length too, and copy only the 
payload (avoids touching the src-size and src/dst headers):

http://cr.openjdk.java.net/~rkennke/JDK-8231410/webrev.03/

Passes TestClone 32bit here. Will also run both 64/32bit 
hotspot_gc_shenandoah now.

Roman

> Bug:
>    https://bugs.openjdk.java.net/browse/JDK-8231410
> 
> This is reproducible with x86_32, but the bug is generic, introduced by JDK-8231086.
> ShenandoahRuntime::shenandoah_clone_barrier expects src to be the base pointer for the clone barrier
> to act. C2, however, passes in the interior ptrs to the object contents. This leads to crashes, but
> surprisingly only on x86_32.
> 
> Fix:
>    https://cr.openjdk.java.net/~shade/8231410/webrev.02/
> 
> Testing: {x86_32, x86_64, aarch64} hotspot_gc_shenandoah; new regression test
> 

From shade at redhat.com  Wed Sep 25 12:01:40 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 25 Sep 2019 14:01:40 +0200
Subject: RFR (S) 8231410: Shenandoah: clone barrier should use base pointer
In-Reply-To: <f89b3304-851b-7799-7fb9-835ed503d10c@redhat.com>
References: <fe24bfd6-7a13-168c-444b-6ba4265068ce@redhat.com>
 <f89b3304-851b-7799-7fb9-835ed503d10c@redhat.com>
Message-ID: <a76f7a93-1728-bbf4-0fff-86af5be40b37@redhat.com>

On 9/25/19 1:53 PM, Roman Kennke wrote:
> I'd suggest passing the interior ptrs and length too, and copy only the payload (avoids touching the
> src-size and src/dst headers):
> 
> http://cr.openjdk.java.net/~rkennke/JDK-8231410/webrev.03/

Ok, fine. I don't see the fault in touching oop->size(), but whatever.

Please match argument names in declaration and definition of clone_barrier. Also, stray printing.

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Wed Sep 25 12:13:59 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 25 Sep 2019 14:13:59 +0200
Subject: RFR (S) 8231410: Shenandoah: clone barrier should use base pointer
In-Reply-To: <a76f7a93-1728-bbf4-0fff-86af5be40b37@redhat.com>
References: <fe24bfd6-7a13-168c-444b-6ba4265068ce@redhat.com>
 <f89b3304-851b-7799-7fb9-835ed503d10c@redhat.com>
 <a76f7a93-1728-bbf4-0fff-86af5be40b37@redhat.com>
Message-ID: <cf881e0f-8916-54d5-d2ab-9a1c15159f4e@redhat.com>

I guess it's more about not touching headers. Ultimately it's a little 
bit of overkill, but I am suspicious of clone() because I noticed some 
benchmarks make heavy use of it. The runtime is only touched on >32 or 
unknown numbers of fields though. Anyhow, I think it doesn't hurt to 
touch less memory while copying, especially because the compiled 
setup-code computes all those interior pointers and counts for us 
already anyway.

I removed printing, fixed the signatures and also added include for 
copy.hpp:

http://cr.openjdk.java.net/~rkennke/JDK-8231410/webrev.04/

Running full test suites. Ok, given passing tests?

Roman

> On 9/25/19 1:53 PM, Roman Kennke wrote:
>> I'd suggest passing the interior ptrs and length too, and copy only the payload (avoids touching the
>> src-size and src/dst headers):
>>
>> http://cr.openjdk.java.net/~rkennke/JDK-8231410/webrev.03/
> 
> Ok, fine. I don't see the fault in touching oop->size(), but whatever.
> 
> Please match argument names in declaration and definition of clone_barrier. Also, stray printing.
> 

From shade at redhat.com  Wed Sep 25 13:27:43 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 25 Sep 2019 15:27:43 +0200
Subject: RFR (S) 8231410: Shenandoah: clone barrier should use base pointer
In-Reply-To: <cf881e0f-8916-54d5-d2ab-9a1c15159f4e@redhat.com>
References: <fe24bfd6-7a13-168c-444b-6ba4265068ce@redhat.com>
 <f89b3304-851b-7799-7fb9-835ed503d10c@redhat.com>
 <a76f7a93-1728-bbf4-0fff-86af5be40b37@redhat.com>
 <cf881e0f-8916-54d5-d2ab-9a1c15159f4e@redhat.com>
Message-ID: <4a5008ad-0c1a-dcb9-4ced-419fbc75e504@redhat.com>

On 9/25/19 2:13 PM, Roman Kennke wrote:
> I guess it's more about not touching headers. Ultimately it's a little bit of overkill, but I am
> suspicious of clone() because I noticed some benchmarks make heavy use of it. The runtime is only
> touched on >32 or unknown numbers of fields though. Anyhow, I think it doesn't hurt to touch less
> memory while copying, especially because the compiled setup-code computes all those interior
> pointers and counts for us already anyway.
> 
> I removed printing, fixed the signatures and also added include for copy.hpp:
> 
> http://cr.openjdk.java.net/~rkennke/JDK-8231410/webrev.04/

I missed this the last time around: are we good with having jlong* in the signatures? That seems to
be the implementation detail for the actual copy. We are passing the addresses there, and even
though they should be aligned to 8, they are not necessarily jlong*-s. It seems the older way of
passing oopDesc* is just as good?

> Running full test suites. Ok, given passing tests?

Yeah.

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Wed Sep 25 14:57:58 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 25 Sep 2019 16:57:58 +0200
Subject: RFR (S) 8231410: Shenandoah: clone barrier should use base pointer
In-Reply-To: <4a5008ad-0c1a-dcb9-4ced-419fbc75e504@redhat.com>
References: <fe24bfd6-7a13-168c-444b-6ba4265068ce@redhat.com>
 <f89b3304-851b-7799-7fb9-835ed503d10c@redhat.com>
 <a76f7a93-1728-bbf4-0fff-86af5be40b37@redhat.com>
 <cf881e0f-8916-54d5-d2ab-9a1c15159f4e@redhat.com>
 <4a5008ad-0c1a-dcb9-4ced-419fbc75e504@redhat.com>
Message-ID: <1458fb19-22a7-fc87-ba68-684034484db2@redhat.com>

>> I guess it's more about not touching headers. Ultimately it's a little bit of overkill, but I am
>> suspicious of clone() because I noticed some benchmarks make heavy use of it. The runtime is only
>> touched on >32 or unknown numbers of fields though. Anyhow, I think it doesn't hurt to touch less
>> memory while copying, especially because the compiled setup-code computes all those interior
>> pointers and counts for us already anyway.
>>
>> I removed printing, fixed the signatures and also added include for copy.hpp:
>>
>> http://cr.openjdk.java.net/~rkennke/JDK-8231410/webrev.04/
> 
> I missed this the last time around: are we good with having jlong* in the signatures? That seems to
> be the implementation detail for the actual copy. We are passing the addresses there, and even
> though they should be aligned to 8, they are not necessarily jlong*-s. It seems the older way of
> passing oopDesc* is just as good?

I change the signatures to take void*, and cast to jlong* before calling 
the copy routine:

http://cr.openjdk.java.net/~rkennke/JDK-8231410/webrev.05/

Still passing all tests 64/32 bit.

Ok now?



From shade at redhat.com  Wed Sep 25 17:41:46 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 25 Sep 2019 19:41:46 +0200
Subject: RFR (S) 8231410: Shenandoah: clone barrier should use base pointer
In-Reply-To: <1458fb19-22a7-fc87-ba68-684034484db2@redhat.com>
References: <fe24bfd6-7a13-168c-444b-6ba4265068ce@redhat.com>
 <f89b3304-851b-7799-7fb9-835ed503d10c@redhat.com>
 <a76f7a93-1728-bbf4-0fff-86af5be40b37@redhat.com>
 <cf881e0f-8916-54d5-d2ab-9a1c15159f4e@redhat.com>
 <4a5008ad-0c1a-dcb9-4ced-419fbc75e504@redhat.com>
 <1458fb19-22a7-fc87-ba68-684034484db2@redhat.com>
Message-ID: <a74a6ae0-ef2a-70b5-7027-12009338842d@redhat.com>

On 9/25/19 4:57 PM, Roman Kennke wrote:
> http://cr.openjdk.java.net/~rkennke/JDK-8231410/webrev.05/

Looks good.

I tested it on my x86_32 cases, and it works. Pushed.

-- 
Thanks,
-Aleksey


From mark.reinhold at oracle.com  Wed Sep 25 18:48:36 2019
From: mark.reinhold at oracle.com (mark.reinhold at oracle.com)
Date: Wed, 25 Sep 2019 11:48:36 -0700
Subject: RFR: JDK-8231086: Shenandoah: Stronger invariant for
 object-arraycopy
In-Reply-To: <a2e053ac-c0a5-e44e-291b-e484e12fe000@redhat.com>
References: <5891bb2e-52ba-b3af-c89a-dfb60ac4e4ac@redhat.com>
 <20190924163459.120313957@eggemoggin.niobe.net>
 <c5262ebc-cfd4-cc17-fa59-b6e6ac3f64eb@redhat.com>
 <a2e053ac-c0a5-e44e-291b-e484e12fe000@redhat.com>
Message-ID: <20190925114836.36816618@eggemoggin.niobe.net>

2019/9/25 3:36:55 -0700, Roman Kennke <rkennke at redhat.com>:
> We identified and fixed the problem. See:
> 
> https://mail.openjdk.java.net/pipermail/shenandoah-dev/2019-September/010626.html
> 
> and:
> https://bugs.openjdk.java.net/browse/JDK-8231447
> 
> Thanks for raising attention to this issue!

Sure thing!

- Mark

From gnu.andrew at redhat.com  Thu Sep 26 06:30:21 2019
From: gnu.andrew at redhat.com (Andrew John Hughes)
Date: Thu, 26 Sep 2019 07:30:21 +0100
Subject: [RFR] [8u] 8u232-b07 Upstream Sync
Message-ID: <fb0d5cd4-3e81-82b3-679e-401610acbc38@redhat.com>

Webrevs: https://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b07/

Merge changesets:

http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b07/corba/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b07/jaxp/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b07/jaxws/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b07/jdk/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b07/hotspot/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b07/langtools/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b07/nashorn/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b07/root/merge.changeset

Changes in aarch64-shenandoah-jdk8u232-b07:
  - S8038392: Generating prelink cache breaks JAVA 'jinfo' utility
normal behaviour
  - S8143072: [JVMCI] Port JVMCI to AArch64
  - S8231366: Shenandoah: Shenandoah String Dedup thread is not properly
initialized

Main issues of note:
8143072 & 8231366 are already upstream, but included in this tag. Hence
the files show up in the HotSpot webrev, but without any changeset
credits. 8143072 is not actually a port of JVMCI at all, but a small bug
fix.

diffstat for root
 b/.hgtags |    1 +
 1 file changed, 1 insertion(+)

diffstat for corba
 b/.hgtags |    1 +
 1 file changed, 1 insertion(+)

diffstat for jaxp
 b/.hgtags |    1 +
 1 file changed, 1 insertion(+)

diffstat for jaxws
 b/.hgtags |    1 +
 1 file changed, 1 insertion(+)

diffstat for langtools
 b/.hgtags |    1 +
 1 file changed, 1 insertion(+)

diffstat for nashorn
 b/.hgtags |    1 +
 1 file changed, 1 insertion(+)

diffstat for jdk
 b/.hgtags |    1 +
 1 file changed, 1 insertion(+)

diffstat for hotspot
 b/.hgtags                      |    1 +
 b/agent/src/os/linux/ps_proc.c |   41
++++++++++++++++++++++++++++++++++++-----
 2 files changed, 37 insertions(+), 5 deletions(-)

Successfully built on x86, x86_64, s390, s390x, ppc, ppc64, ppc64le &
aarch64.

Ok to push?
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew


From shade at redhat.com  Thu Sep 26 07:06:10 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 26 Sep 2019 09:06:10 +0200
Subject: [aarch64-port-dev ] [RFR] [8u] 8u232-b07 Upstream Sync
In-Reply-To: <fb0d5cd4-3e81-82b3-679e-401610acbc38@redhat.com>
References: <fb0d5cd4-3e81-82b3-679e-401610acbc38@redhat.com>
Message-ID: <c7ebe3ab-33a1-3e96-d0e7-f41c4a1eec67@redhat.com>

On 9/26/19 8:30 AM, Andrew John Hughes wrote:
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b07/corba/merge.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b07/jaxp/merge.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b07/jaxws/merge.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b07/jdk/merge.changeset

Look trivially good.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b07/hotspot/merge.changeset

Looks good.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b07/langtools/merge.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b07/nashorn/merge.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b07/root/merge.changeset
Look trivially good.

Thumbs up! Good to go.

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Fri Sep 27 18:16:28 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Fri, 27 Sep 2019 20:16:28 +0200
Subject: RFR: JDK-8231499: Shenandoah:
 compiler/arraycopy/TestDefaultMethodArrayCloneDeoptC2 fails
Message-ID: <266f1086-dab9-f0fc-3315-9798fedd31af@redhat.com>

Recent arraycopy changes breaks compilation of C2 arraycopy intrinsic. 
It fails silently, so you only notice degradation of performance.

Apparently the register allocator barfs on the 4 arguments (I suppose 
sending both the address and the base of that address is a little bit 
funny).

Fix is to fall back to what Aleksey original proposed and only send src 
and dst object base pointer, and let runtime figure out the rest.

Bug:
https://bugs.openjdk.java.net/browse/JDK-8231499
Webrev:
http://cr.openjdk.java.net/~rkennke/JDK-8231499/webrev.00/

Testing: hotspot_gc_shenandoah (x86_64 and x86_32) and testcase that is 
provided in the bug report, all pass.

Ok?

Roman


From rkennke at redhat.com  Fri Sep 27 22:45:53 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Sat, 28 Sep 2019 00:45:53 +0200
Subject: RFR: JDK-8231499: Shenandoah:
 compiler/arraycopy/TestDefaultMethodArrayCloneDeoptC2 fails
In-Reply-To: <266f1086-dab9-f0fc-3315-9798fedd31af@redhat.com>
References: <266f1086-dab9-f0fc-3315-9798fedd31af@redhat.com>
Message-ID: <adc3d23d-6326-d5c5-b50f-3db15b51948f@redhat.com>

Here comes a better approach.

Instead of doing one call into runtime, and then check heapstable there, 
then maybe do a call to the clone-barrier, and then do another 
unconditional call to the copy-routine there, let's do this instead:

1. check heap-stable in compiled code, and call to runtime clone-barrier 
only when heap is unstable
2. runtime clone-barrier *only* fixes the src object. it does not 
actually copy anything
3. unconditionally call into the usual optimized copy routine from 
compiled code; that only copies the payload without touching headers

I think this is the best approach so far:
- It keeps the fast-path slim (heapstable-check + fast-copy)
- Copying is optimized and only touches the absolute minimum of memory 
(important for small object clones)


Webrev:
http://cr.openjdk.java.net/~rkennke/JDK-8231499/webrev.01/

Testing: I've thrown a whole bunch of tests at it:
- hotspot_gc_shenandoah (x86_64, x86_32)
- the failing test from the bugreport
- a full successful run of specjvm with fastdebug and 
+AbortVMOnCompilationFailure

Can I please get a review?

Thanks,
Roman


> Recent arraycopy changes breaks compilation of C2 arraycopy intrinsic. 
> It fails silently, so you only notice degradation of performance.
> 
> Apparently the register allocator barfs on the 4 arguments (I suppose 
> sending both the address and the base of that address is a little bit 
> funny).
> 
> Fix is to fall back to what Aleksey original proposed and only send src 
> and dst object base pointer, and let runtime figure out the rest.
> 
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8231499
> Webrev:
> http://cr.openjdk.java.net/~rkennke/JDK-8231499/webrev.00/
> 
> Testing: hotspot_gc_shenandoah (x86_64 and x86_32) and testcase that is 
> provided in the bug report, all pass.
> 
> Ok?
> 
> Roman


From shade at redhat.com  Mon Sep 30 09:54:06 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 30 Sep 2019 11:54:06 +0200
Subject: RFR: JDK-8231499: Shenandoah:
 compiler/arraycopy/TestDefaultMethodArrayCloneDeoptC2 fails
In-Reply-To: <adc3d23d-6326-d5c5-b50f-3db15b51948f@redhat.com>
References: <266f1086-dab9-f0fc-3315-9798fedd31af@redhat.com>
 <adc3d23d-6326-d5c5-b50f-3db15b51948f@redhat.com>
Message-ID: <1c88eabe-e9c0-a861-cc05-37b174e39a88@redhat.com>

On 9/28/19 12:45 AM, Roman Kennke wrote:
> Webrev:
> http://cr.openjdk.java.net/~rkennke/JDK-8231499/webrev.01/

*) Synopsis should be updated? I think something like:
 "Shenandoah: Fix and simplify clone barrier"

*) Is there no way to reuse ShenandoahBarrierC2Support::test_heap_stable somehow?

If not, this is my round of cleanups on top of that patch:
  https://cr.openjdk.java.net/~shade/shenandoah/8231499-shade-cleanup.patch

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Mon Sep 30 10:47:02 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 30 Sep 2019 12:47:02 +0200
Subject: RFR: JDK-8231499: Shenandoah: Fix and simplify clone barrier
In-Reply-To: <1c88eabe-e9c0-a861-cc05-37b174e39a88@redhat.com>
References: <266f1086-dab9-f0fc-3315-9798fedd31af@redhat.com>
 <adc3d23d-6326-d5c5-b50f-3db15b51948f@redhat.com>
 <1c88eabe-e9c0-a861-cc05-37b174e39a88@redhat.com>
Message-ID: <4326ae4c-25aa-32cb-0d69-c7a8cff70e5e@redhat.com>

Hi Alexsey,

>> Webrev:
>> http://cr.openjdk.java.net/~rkennke/JDK-8231499/webrev.01/
> 
> *) Synopsis should be updated? I think something like:
>  "Shenandoah: Fix and simplify clone barrier"

Right. Thanks!

> *) Is there no way to reuse ShenandoahBarrierC2Support::test_heap_stable somehow?

I don't think so. test_heap_stable() uses PhaseIdealLoop,
clone-expansion uses PhaseMacroExpand. Abstracting this would make
things even more complicated.

> If not, this is my round of cleanups on top of that patch:
>   https://cr.openjdk.java.net/~shade/shenandoah/8231499-shade-cleanup.patch

Thanks!

Folded patch:
http://cr.openjdk.java.net/~rkennke/JDK-8231499/webrev.03/

Would like to have Roland look at it too.

Thanks,
Roman


From shade at redhat.com  Mon Sep 30 12:14:25 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 30 Sep 2019 14:14:25 +0200
Subject: [11u] RFC 8231405: [Shenandoah] guarantee(d != NULL) failed: Null
 dominator info
Message-ID: <6973f2bc-157f-e04a-4bc4-372886c34d05@redhat.com>

Hi,

This is the question for Andrew Hughes, as we have reached the CPU work already. We have this
critical bugfix in Shenandoah/C2 that we would like to have in 11.0.5:
  https://bugs.openjdk.java.net/browse/JDK-8231405
  https://hg.openjdk.java.net/jdk/jdk/rev/222a91b9438a

The patch applies cleanly, but we are usually prepend the synopsis with "[backport]" to disambiguate
from the jdk-updates/jdk11u backports:
  "[backport] 8231405: [Shenandoah] guarantee(d != NULL) failed: Null dominator info"

I ran hotspot_gc_shenandoah, tier1, tier2 (with Shenandoah), jdk_security (with Shenandoah).

Can we have it? If yes, there are several ways to do this:

 a) Push the changeset to CPU forests directly, and then wait for the entire bundle to appear in
sh/jdk11 with the CPU patchset. Pros: it would get into CPU without additional fuzz. Cons: it would
not get tested with our public 11u nightlies, until the CPU patchset arrives.

 b) Push the changeset to sh/jdk11, pull the sh/jdk to CPU forests. Pros: it would be exposed to
users before the CPU release through our 11u nightlies. Cons: the later CPU merge would be against
that public changeset, not against shenandoah-jdk-11.0.5+9.

Thoughts?

-- 
Thanks,
-Aleksey


From rwestrel at redhat.com  Mon Sep 30 12:53:02 2019
From: rwestrel at redhat.com (Roland Westrelin)
Date: Mon, 30 Sep 2019 14:53:02 +0200
Subject: RFR: JDK-8231499: Shenandoah: Fix and simplify clone barrier
In-Reply-To: <4326ae4c-25aa-32cb-0d69-c7a8cff70e5e@redhat.com>
References: <266f1086-dab9-f0fc-3315-9798fedd31af@redhat.com>
 <adc3d23d-6326-d5c5-b50f-3db15b51948f@redhat.com>
 <1c88eabe-e9c0-a861-cc05-37b174e39a88@redhat.com>
 <4326ae4c-25aa-32cb-0d69-c7a8cff70e5e@redhat.com>
Message-ID: <87zhim3pzl.fsf@redhat.com>


> http://cr.openjdk.java.net/~rkennke/JDK-8231499/webrev.03/

Looks good to me.

Roland.

From rkennke at redhat.com  Mon Sep 30 13:12:19 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 30 Sep 2019 15:12:19 +0200
Subject: RFR: JDK-8231583: Shenandoah fails with finagle-http
Message-ID: <996d7d26-4c18-62fd-ff57-76f1dddfd5c5@redhat.com>

We're seeing failure with the finagle-http workload in renaissance
benchmarks.

The problem is caused by ShBSA::resolve_forward_pointer_not_null()
trying to borrow a register. In order to do so, it pushes rscratch1, and
later pops it again. This clashes when dst also happens to be rscratch1,
in this case the pop would restore the original value.

We need the register allocator to allocate an extra tmp reg for this. C1
should be good because rscratch1 is never used by register allocation there.

The whole cmpxchg-oop sequence can be simplified a lot. Maybe we can
reduce tmp register usage there?

Bug:
https://bugs.openjdk.java.net/browse/JDK-8231583
Webrev:
http://cr.openjdk.java.net/~rkennke/JDK-8231583/webrev.00/

Testing: the failing test now passes. hotspot_gc_shenandoah is good too.

Ok?

Roman


From shade at redhat.com  Mon Sep 30 13:32:38 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 30 Sep 2019 15:32:38 +0200
Subject: RFR: JDK-8231583: Shenandoah fails with finagle-http
In-Reply-To: <996d7d26-4c18-62fd-ff57-76f1dddfd5c5@redhat.com>
References: <996d7d26-4c18-62fd-ff57-76f1dddfd5c5@redhat.com>
Message-ID: <229ca151-528b-8f4e-031b-fa1bd84e3053@redhat.com>

On 9/30/19 3:12 PM, Roman Kennke wrote:
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8231583
> Webrev:
> http://cr.openjdk.java.net/~rkennke/JDK-8231583/webrev.00/

Awww.

Please change the synopsis to reflect what is being done, not the symptom of it. Suggestion:
  Shenandoah: register clash in SBSA::resolve_forwarding_pointer borrowing

I believe we are better off just fixing the borrowing scheme, like (not heavily tested):

diff -r 6902d5acd5e8 src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp
--- a/src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp   Mon Sep 30
10:19:03 2019 +0200
+++ b/src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp   Mon Sep 30
15:30:52 2019 +0200
@@ -212,7 +212,12 @@
     // No free registers available. Make one useful.
     tmp = rscratch1;
+    if (tmp == dst) {
+      tmp = rscratch2;
+    }
     __ push(RegSet::of(tmp), sp);
   }

+  assert_different_registers(tmp, dst);
+
   Label done;
   __ ldr(tmp, Address(dst, oopDesc::mark_offset_in_bytes()));
diff -r 6902d5acd5e8 src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp
--- a/src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp   Mon Sep 30 10:19:03
2019 +0200
+++ b/src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp   Mon Sep 30 15:30:52
2019 +0200
@@ -272,7 +272,12 @@
     // No free registers available. Make one useful.
     tmp = LP64_ONLY(rscratch1) NOT_LP64(rdx);
+    if (tmp == dst) {
+      tmp = LP64_ONLY(rscratch2) NOT_LP64(rcx);
+    }
     __ push(tmp);
   }

+  assert_different_registers(dst, tmp);
+
   Label done;
   __ movptr(tmp, Address(dst, oopDesc::mark_offset_in_bytes()));


-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Mon Sep 30 14:57:25 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 30 Sep 2019 16:57:25 +0200
Subject: RFR: JDK-8231583: Shenandoah: Fix register clash in
 SBSA::resolve_forwarding_pointer() borrowing
In-Reply-To: <229ca151-528b-8f4e-031b-fa1bd84e3053@redhat.com>
References: <996d7d26-4c18-62fd-ff57-76f1dddfd5c5@redhat.com>
 <229ca151-528b-8f4e-031b-fa1bd84e3053@redhat.com>
Message-ID: <2f995643-c3dd-a1ec-09b5-8ab0c1d4c6fb@redhat.com>

Hi Aleksey,

>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8231583
>> Webrev:
>> http://cr.openjdk.java.net/~rkennke/JDK-8231583/webrev.00/
> 
> Awww.
> 
> Please change the synopsis to reflect what is being done, not the symptom of it. Suggestion:
>   Shenandoah: register clash in SBSA::resolve_forwarding_pointer borrowing

Right. Changed to:
Shenandoah: Fix register clash in SBSA::resolve_forwarding_pointer()
borrowing

> I believe we are better off just fixing the borrowing scheme, like (not heavily tested):
> 
> diff -r 6902d5acd5e8 src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp
> --- a/src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp   Mon Sep 30
> 10:19:03 2019 +0200
> +++ b/src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp   Mon Sep 30
> 15:30:52 2019 +0200
> @@ -212,7 +212,12 @@
>      // No free registers available. Make one useful.
>      tmp = rscratch1;
> +    if (tmp == dst) {
> +      tmp = rscratch2;
> +    }
>      __ push(RegSet::of(tmp), sp);
>    }
> 
> +  assert_different_registers(tmp, dst);
> +
>    Label done;
>    __ ldr(tmp, Address(dst, oopDesc::mark_offset_in_bytes()));
> diff -r 6902d5acd5e8 src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp
> --- a/src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp   Mon Sep 30 10:19:03
> 2019 +0200
> +++ b/src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp   Mon Sep 30 15:30:52
> 2019 +0200
> @@ -272,7 +272,12 @@
>      // No free registers available. Make one useful.
>      tmp = LP64_ONLY(rscratch1) NOT_LP64(rdx);
> +    if (tmp == dst) {
> +      tmp = LP64_ONLY(rscratch2) NOT_LP64(rcx);
> +    }
>      __ push(tmp);
>    }
> 
> +  assert_different_registers(dst, tmp);
> +
>    Label done;
>    __ movptr(tmp, Address(dst, oopDesc::mark_offset_in_bytes()));
> 
> 

Yeah.
I took it a little further and removed the tmp argument to
resolve_forwarding_pointer() altogether because we have no caller that
passes anything interesting to it.

http://cr.openjdk.java.net/~rkennke/JDK-8231583/webrev.01/

I believe aarch64 should be good (and should actually not require
borrowing) because rscratch1 is not used by the register allocators there.

Ok now?

Roman


From shade at redhat.com  Mon Sep 30 15:33:30 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 30 Sep 2019 17:33:30 +0200
Subject: RFR: JDK-8231583: Shenandoah: Fix register clash in
 SBSA::resolve_forwarding_pointer() borrowing
In-Reply-To: <2f995643-c3dd-a1ec-09b5-8ab0c1d4c6fb@redhat.com>
References: <996d7d26-4c18-62fd-ff57-76f1dddfd5c5@redhat.com>
 <229ca151-528b-8f4e-031b-fa1bd84e3053@redhat.com>
 <2f995643-c3dd-a1ec-09b5-8ab0c1d4c6fb@redhat.com>
Message-ID: <43626b96-7c3d-5a1b-df9f-e3900ce2742a@redhat.com>

On 9/30/19 4:57 PM, Roman Kennke wrote:
> http://cr.openjdk.java.net/~rkennke/JDK-8231583/webrev.01/

I believe at this point we should be doing a very safe change that does not include collateral cleanups:
  http://cr.openjdk.java.net/~shade/8231583/webrev.01/

Testing: hotspot_gc_shenandoah {x86_32, x86_64, aarch64}

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Mon Sep 30 15:52:22 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 30 Sep 2019 17:52:22 +0200
Subject: RFR: JDK-8231583: Shenandoah: Fix register clash in
 SBSA::resolve_forwarding_pointer() borrowing
In-Reply-To: <43626b96-7c3d-5a1b-df9f-e3900ce2742a@redhat.com>
References: <996d7d26-4c18-62fd-ff57-76f1dddfd5c5@redhat.com>
 <229ca151-528b-8f4e-031b-fa1bd84e3053@redhat.com>
 <2f995643-c3dd-a1ec-09b5-8ab0c1d4c6fb@redhat.com>
 <43626b96-7c3d-5a1b-df9f-e3900ce2742a@redhat.com>
Message-ID: <07cdb113-bd3b-60c4-86a2-c008cd6b6fec@redhat.com>

Yeah, looks good. I also tested this with the original failing testcase,
and it was good.

Thanks,
Roman

> On 9/30/19 4:57 PM, Roman Kennke wrote:
>> http://cr.openjdk.java.net/~rkennke/JDK-8231583/webrev.01/
> 
> I believe at this point we should be doing a very safe change that does not include collateral cleanups:
>   http://cr.openjdk.java.net/~shade/8231583/webrev.01/
> 
> Testing: hotspot_gc_shenandoah {x86_32, x86_64, aarch64}
> 


From gnu.andrew at redhat.com  Mon Sep 30 19:22:28 2019
From: gnu.andrew at redhat.com (Andrew John Hughes)
Date: Mon, 30 Sep 2019 20:22:28 +0100
Subject: [11u] RFC 8231405: [Shenandoah] guarantee(d != NULL) failed: Null
 dominator info
In-Reply-To: <6973f2bc-157f-e04a-4bc4-372886c34d05@redhat.com>
References: <6973f2bc-157f-e04a-4bc4-372886c34d05@redhat.com>
Message-ID: <4ddb4be8-50ae-b645-aeac-b00626ff8c33@redhat.com>



On 30/09/2019 13:14, Aleksey Shipilev wrote:
> Hi,
> 
> This is the question for Andrew Hughes, as we have reached the CPU work already. We have this
> critical bugfix in Shenandoah/C2 that we would like to have in 11.0.5:
>   https://bugs.openjdk.java.net/browse/JDK-8231405
>   https://hg.openjdk.java.net/jdk/jdk/rev/222a91b9438a
> 
> The patch applies cleanly, but we are usually prepend the synopsis with "[backport]" to disambiguate
> from the jdk-updates/jdk11u backports:
>   "[backport] 8231405: [Shenandoah] guarantee(d != NULL) failed: Null dominator info"
> 
> I ran hotspot_gc_shenandoah, tier1, tier2 (with Shenandoah), jdk_security (with Shenandoah).
> 
> Can we have it? If yes, there are several ways to do this:
> 
>  a) Push the changeset to CPU forests directly, and then wait for the entire bundle to appear in
> sh/jdk11 with the CPU patchset. Pros: it would get into CPU without additional fuzz. Cons: it would
> not get tested with our public 11u nightlies, until the CPU patchset arrives.
> 
>  b) Push the changeset to sh/jdk11, pull the sh/jdk to CPU forests. Pros: it would be exposed to
> users before the CPU release through our 11u nightlies. Cons: the later CPU merge would be against
> that public changeset, not against shenandoah-jdk-11.0.5+9.
> 
> Thoughts?
> 

The second option, b, makes sense to me. I don't really follow the con
for that; there are plenty of instances where Shenandoah changes have
gone in between merges. I think a bit of noise on a webrev is
outweighted by the testing and visibility it would get in the public repos.

As to the viability of the fix itself, it's Shenandoah-only code that it
affects, so I'll leave that call up to you.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew


From shade at redhat.com  Mon Sep 30 19:25:39 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 30 Sep 2019 21:25:39 +0200
Subject: [11u] RFC 8231405: [Shenandoah] guarantee(d != NULL) failed: Null
 dominator info
In-Reply-To: <4ddb4be8-50ae-b645-aeac-b00626ff8c33@redhat.com>
References: <6973f2bc-157f-e04a-4bc4-372886c34d05@redhat.com>
 <4ddb4be8-50ae-b645-aeac-b00626ff8c33@redhat.com>
Message-ID: <729e0193-50a8-9d51-d063-6468267ea514@redhat.com>

On 9/30/19 9:22 PM, Andrew John Hughes wrote:
> The second option, b, makes sense to me. I don't really follow the con
> for that; there are plenty of instances where Shenandoah changes have
> gone in between merges. I think a bit of noise on a webrev is
> outweighted by the testing and visibility it would get in the public repos.

Agreed. The "con" was mostly about not having a clear "tag" that CPU forest is based on, but I guess
that is a minor nuisance at this juncture, as CPU forests are probably tested at their "tip" anyway.
Which would include public fixes after we pull them in.

> As to the viability of the fix itself, it's Shenandoah-only code that it
> affects, so I'll leave that call up to you.
Right. We are going to have another small fix tomorrow, and then we would ask to pull new sh/jdk11
to the CPU forest, OK?

-- 
Thanks,
-Aleksey


From gnu.andrew at redhat.com  Mon Sep 30 19:28:03 2019
From: gnu.andrew at redhat.com (Andrew John Hughes)
Date: Mon, 30 Sep 2019 20:28:03 +0100
Subject: [11u] RFC 8231405: [Shenandoah] guarantee(d != NULL) failed: Null
 dominator info
In-Reply-To: <729e0193-50a8-9d51-d063-6468267ea514@redhat.com>
References: <6973f2bc-157f-e04a-4bc4-372886c34d05@redhat.com>
 <4ddb4be8-50ae-b645-aeac-b00626ff8c33@redhat.com>
 <729e0193-50a8-9d51-d063-6468267ea514@redhat.com>
Message-ID: <3a392b20-7d22-6739-e84d-f35b4e1f589a@redhat.com>



On 30/09/2019 20:25, Aleksey Shipilev wrote:
> On 9/30/19 9:22 PM, Andrew John Hughes wrote:
>> The second option, b, makes sense to me. I don't really follow the con
>> for that; there are plenty of instances where Shenandoah changes have
>> gone in between merges. I think a bit of noise on a webrev is
>> outweighted by the testing and visibility it would get in the public repos.
> 
> Agreed. The "con" was mostly about not having a clear "tag" that CPU forest is based on, but I guess
> that is a minor nuisance at this juncture, as CPU forests are probably tested at their "tip" anyway.
> Which would include public fixes after we pull them in.
> 
>> As to the viability of the fix itself, it's Shenandoah-only code that it
>> affects, so I'll leave that call up to you.
> Right. We are going to have another small fix tomorrow, and then we would ask to pull new sh/jdk11
> to the CPU forest, OK?
> 

Sounds good.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew


From shade at redhat.com  Mon Sep 30 19:54:58 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 30 Sep 2019 21:54:58 +0200
Subject: [11u] Critical backports to sh/jdk11
Message-ID: <d71b9289-0be1-9056-e6ee-7122fd2c7301@redhat.com>

https://cr.openjdk.java.net/~shade/shenandoah/backports/jdk11-20190930/webrev.01/

This backports these critical fixes to sh/jdk11:
 [backport] 8231405: [Shenandoah] guarantee(d != NULL) failed: Null dominator info
 [backport] 8231583: Shenandoah: Fix register clash in SBSA::resolve_forwarding_pointer() borrowing

Both patches apply cleanly. I'll wait a bit for jdk/jdk nightlies to catch up with these.

Testing: hotspot_gc_shenandoah, tier1, tier2 (with Shenandoah), jdk_security (with Shenandoah),
selected benchmarks

-- 
Thanks,
-Aleksey


From simone.bordet at gmail.com  Mon Sep 30 20:13:02 2019
From: simone.bordet at gmail.com (Simone Bordet)
Date: Mon, 30 Sep 2019 22:13:02 +0200
Subject: Shenandoah 2.0
Message-ID: <CAFWmRJ05LDbNYdx9T-PjcTYLyw=_T_9wyDi4951OTpeKgUu+yg@mail.gmail.com>

Hi,

I am updating my Shenandoah slides for a couple of upcoming conferences.
Would be great if you can skim over to confirm if they are correct.
https://speakerdeck.com/simonebordet/concurrent-gcs-zgc-and-shenandoah

I would like to ask how do one knows what version of JDK has
Shenandoah 2.0 (i.e. LRB + FwdPtr removal).
I know that 13 has it, I guess 12 does not (right?), but what versions
of 11 and 8 have it?
Only RH builds and only available via RH Linux (i.e. no generic Linux
builds with Shenandoah 2.0)? Windows? MacOS?

Thanks!

-- 
Simone Bordet
---
Finally, no matter how good the architecture and design are,
to deliver bug-free software with optimal performance and reliability,
the implementation technique must be flawless.   Victoria Livschitz

From rkennke at redhat.com  Mon Sep 30 20:16:15 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 30 Sep 2019 22:16:15 +0200
Subject: [11u] Critical backports to sh/jdk11
In-Reply-To: <d71b9289-0be1-9056-e6ee-7122fd2c7301@redhat.com>
References: <d71b9289-0be1-9056-e6ee-7122fd2c7301@redhat.com>
Message-ID: <f6e8c6c1-9173-7fab-475b-b3d5f5e4e452@redhat.com>

The backports look good. Thanks!

Roman


> https://cr.openjdk.java.net/~shade/shenandoah/backports/jdk11-20190930/webrev.01/
> 
> This backports these critical fixes to sh/jdk11:
>  [backport] 8231405: [Shenandoah] guarantee(d != NULL) failed: Null dominator info
>  [backport] 8231583: Shenandoah: Fix register clash in SBSA::resolve_forwarding_pointer() borrowing
> 
> Both patches apply cleanly. I'll wait a bit for jdk/jdk nightlies to catch up with these.
> 
> Testing: hotspot_gc_shenandoah, tier1, tier2 (with Shenandoah), jdk_security (with Shenandoah),
> selected benchmarks
> 


From rkennke at redhat.com  Mon Sep 30 20:25:10 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 30 Sep 2019 22:25:10 +0200
Subject: Shenandoah 2.0
In-Reply-To: <CAFWmRJ05LDbNYdx9T-PjcTYLyw=_T_9wyDi4951OTpeKgUu+yg@mail.gmail.com>
References: <CAFWmRJ05LDbNYdx9T-PjcTYLyw=_T_9wyDi4951OTpeKgUu+yg@mail.gmail.com>
Message-ID: <2d926edf-67b6-4828-f26e-8f6d38c4148b@redhat.com>



> I am updating my Shenandoah slides for a couple of upcoming conferences.
> Would be great if you can skim over to confirm if they are correct.
> https://speakerdeck.com/simonebordet/concurrent-gcs-zgc-and-shenandoah

Nice! I'll look over it.

> I would like to ask how do one knows what version of JDK has
> Shenandoah 2.0 (i.e. LRB + FwdPtr removal).
> I know that 13 has it, I guess 12 does not (right?)

That's correct.

>, but what versions
> of 11 and 8 have it?
> Only RH builds and only available via RH Linux (i.e. no generic Linux
> builds with Shenandoah 2.0)? Windows? MacOS?

RHEL (and derivatives, CentOS, Fedora, etc) ship Shenandoah, but none
has '2.0' yet. LRB+friends will be released with 11.0.5. I'm currently
working on 8, no date yet, though. We're also working on upstreaming to
11u (and later maybe 8u), but also not date yet.

Roman


From simone.bordet at gmail.com  Mon Sep 30 20:33:59 2019
From: simone.bordet at gmail.com (Simone Bordet)
Date: Mon, 30 Sep 2019 22:33:59 +0200
Subject: Shenandoah 2.0
In-Reply-To: <2d926edf-67b6-4828-f26e-8f6d38c4148b@redhat.com>
References: <CAFWmRJ05LDbNYdx9T-PjcTYLyw=_T_9wyDi4951OTpeKgUu+yg@mail.gmail.com>
 <2d926edf-67b6-4828-f26e-8f6d38c4148b@redhat.com>
Message-ID: <CAFWmRJ22YiXT+PKoOXFVUE4ALP5pPE_2Nbn+yVY7P7wDQnwV7Q@mail.gmail.com>

Hi,

On Mon, Sep 30, 2019 at 10:25 PM Roman Kennke <rkennke at redhat.com> wrote:
> RHEL (and derivatives, CentOS, Fedora, etc) ship Shenandoah, but none
> has '2.0' yet.

Oh.

> LRB+friends will be released with 11.0.5.

Which 11.0.5? OpenJDK's official repo (at
https://hg.openjdk.java.net/jdk-updates/jdk11u/, but I doubt) or RH
repo?
I ask because 11 is maintained by RH so it would not be impossible to
imagine that the Shenandoah code ends up in the OpenJDK official repo.
Although I think that it's most likely that it'll stay on a RH repo.
Is this RH repo public, so that I would be able to clone it and build
11.0.5 with Shenandoah 2.0 myself?

> I'm currently
> working on 8, no date yet, though. We're also working on upstreaming to
> 11u (and later maybe 8u), but also not date yet.

By "upstreaming" you mean from a RH repo to the official OpenJDK repo?

Thanks!

-- 
Simone Bordet
---
Finally, no matter how good the architecture and design are,
to deliver bug-free software with optimal performance and reliability,
the implementation technique must be flawless.   Victoria Livschitz

From rkennke at redhat.com  Mon Sep 30 20:35:26 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 30 Sep 2019 22:35:26 +0200
Subject: Shenandoah 2.0
In-Reply-To: <CAFWmRJ05LDbNYdx9T-PjcTYLyw=_T_9wyDi4951OTpeKgUu+yg@mail.gmail.com>
References: <CAFWmRJ05LDbNYdx9T-PjcTYLyw=_T_9wyDi4951OTpeKgUu+yg@mail.gmail.com>
Message-ID: <e70b7092-ea42-4e57-f1cf-a49974c9b78e@redhat.com>

Regarding the traversal mode. It only has a single concurrent phase that
does all of marking, compacting and updating-references in a single
pass. It is book-ended by a pause each, similar to init-mark and
final-update-refs pause to do initialize the traversal and to do some
bookkeeping and cleanup stuff. The liveness data of one cycle feeds into
the cset decisions of the subsequent cycle. To be honest, I am not sure
this whole slide needs to exist or only serves to confuse people (even
more).

I'd probably add one or two comparison slides at the end that highlights
the pros and cons of each one. That's what people usually want to know:
'which concurrent GC is for me?'

Thanks a lot!
Roman


> Hi,
> 
> I am updating my Shenandoah slides for a couple of upcoming conferences.
> Would be great if you can skim over to confirm if they are correct.
> https://speakerdeck.com/simonebordet/concurrent-gcs-zgc-and-shenandoah
> 
> I would like to ask how do one knows what version of JDK has
> Shenandoah 2.0 (i.e. LRB + FwdPtr removal).
> I know that 13 has it, I guess 12 does not (right?), but what versions
> of 11 and 8 have it?
> Only RH builds and only available via RH Linux (i.e. no generic Linux
> builds with Shenandoah 2.0)? Windows? MacOS?
> 
> Thanks!
> 


From rkennke at redhat.com  Mon Sep 30 20:38:21 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 30 Sep 2019 22:38:21 +0200
Subject: Shenandoah 2.0
In-Reply-To: <CAFWmRJ22YiXT+PKoOXFVUE4ALP5pPE_2Nbn+yVY7P7wDQnwV7Q@mail.gmail.com>
References: <CAFWmRJ05LDbNYdx9T-PjcTYLyw=_T_9wyDi4951OTpeKgUu+yg@mail.gmail.com>
 <2d926edf-67b6-4828-f26e-8f6d38c4148b@redhat.com>
 <CAFWmRJ22YiXT+PKoOXFVUE4ALP5pPE_2Nbn+yVY7P7wDQnwV7Q@mail.gmail.com>
Message-ID: <827f8c08-4b14-ba5d-4719-aa11da49d786@redhat.com>



Am 30.09.19 um 22:33 schrieb Simone Bordet:
> Hi,
> 
> On Mon, Sep 30, 2019 at 10:25 PM Roman Kennke <rkennke at redhat.com> wrote:
>> RHEL (and derivatives, CentOS, Fedora, etc) ship Shenandoah, but none
>> has '2.0' yet.
> 
> Oh.
> 
>> LRB+friends will be released with 11.0.5.
> 
> Which 11.0.5? OpenJDK's official repo (at
> https://hg.openjdk.java.net/jdk-updates/jdk11u/, but I doubt) or RH
> repo?

The "Red Hat" (e.g. Shenandoah project) repo:
https://hg.openjdk.java.net/shenandoah-jdk/jdk11/

and builds derived from it (e.g. RHEL, Fedora & derivatives)

> I ask because 11 is maintained by RH so it would not be impossible to
> imagine that the Shenandoah code ends up in the OpenJDK official repo.
> Although I think that it's most likely that it'll stay on a RH repo.
> Is this RH repo public, so that I would be able to clone it and build
> 11.0.5 with Shenandoah 2.0 myself?

Yes, see link above.

>> I'm currently
>> working on 8, no date yet, though. We're also working on upstreaming to
>> 11u (and later maybe 8u), but also not date yet.
> 
> By "upstreaming" you mean from a RH repo to the official OpenJDK repo?

Yes, indeed. At least that is the plan, it'll be subject to review and
process and it's only there when it's there. :-)

Roman


From shade at redhat.com  Mon Sep 30 20:43:35 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 30 Sep 2019 22:43:35 +0200
Subject: Shenandoah 2.0
In-Reply-To: <827f8c08-4b14-ba5d-4719-aa11da49d786@redhat.com>
References: <CAFWmRJ05LDbNYdx9T-PjcTYLyw=_T_9wyDi4951OTpeKgUu+yg@mail.gmail.com>
 <2d926edf-67b6-4828-f26e-8f6d38c4148b@redhat.com>
 <CAFWmRJ22YiXT+PKoOXFVUE4ALP5pPE_2Nbn+yVY7P7wDQnwV7Q@mail.gmail.com>
 <827f8c08-4b14-ba5d-4719-aa11da49d786@redhat.com>
Message-ID: <4e659139-5da3-9a2f-682b-74542b17fa34@redhat.com>

On 9/30/19 10:38 PM, Roman Kennke wrote:
> The "Red Hat" (e.g. Shenandoah project) repo:
> https://hg.openjdk.java.net/shenandoah-jdk/jdk11/

That would be:
  https://hg.openjdk.java.net/shenandoah/jdk11/

...among all other Shenandoah repos:
  https://hg.openjdk.java.net/shenandoah/

shenandoah/jdk11 is "downstream" from the "upstream" one here:
  https://hg.openjdk.java.net/jdk-updates/jdk11u

-- 
Thanks,
-Aleksey


From simone.bordet at gmail.com  Mon Sep 30 21:01:36 2019
From: simone.bordet at gmail.com (Simone Bordet)
Date: Mon, 30 Sep 2019 23:01:36 +0200
Subject: Shenandoah 2.0
In-Reply-To: <e70b7092-ea42-4e57-f1cf-a49974c9b78e@redhat.com>
References: <CAFWmRJ05LDbNYdx9T-PjcTYLyw=_T_9wyDi4951OTpeKgUu+yg@mail.gmail.com>
 <e70b7092-ea42-4e57-f1cf-a49974c9b78e@redhat.com>
Message-ID: <CAFWmRJ3gXnCXdBs71Z4GfFpka=2wHKL1xr7+YkfovnP_TbL0rA@mail.gmail.com>

Hi,

On Mon, Sep 30, 2019 at 10:35 PM Roman Kennke <rkennke at redhat.com> wrote:
>
> Regarding the traversal mode. It only has a single concurrent phase that
> does all of marking, compacting and updating-references in a single
> pass. It is book-ended by a pause each, similar to init-mark and
> final-update-refs pause to do initialize the traversal and to do some
> bookkeeping and cleanup stuff. The liveness data of one cycle feeds into
> the cset decisions of the subsequent cycle.

Yes I tried to capture that into slide 53.
Is it correct?

> To be honest, I am not sure
> this whole slide needs to exist or only serves to confuse people (even
> more).

Oh. I thought it was ok to have 1 slide about traversal for completeness.
Why you think it's confusing?
And why you say "even more"?
I'd be happy to clarify or remove confusing stuff.
My thinking is that since ZGC and Shenandoah can piggyback Remapping
onto the next Marking, coalescing 2 phases (that I explained in
previous slides already), it's not a big deal to coalesce 3 (and it's
just 1 slide for completeness).

> I'd probably add one or two comparison slides at the end that highlights
> the pros and cons of each one.

"Each one" as in comparison between ZGC and Shenandoah, or "each one"
as in comparison between non-traversal and traversal?

> That's what people usually want to know:
> 'which concurrent GC is for me?'

My experience is typically divided in 2 here, at the ends of the spectrum.
Many don't care at all - give them ZGC or Shenandoah to replace
G1/CMS/Parallel because "it's better" and they switch blindly.
Few are GC maniacs and put 42 command line options to tune everything
because they read so on StackOverflow.
Those that can tell apart ZGC and Shenandoah may have some idea
already of what's better for their use case, but again they are savvy
enough to try both and actually verify what's better for them.

Honestly I can't tell myself.
I like better ZGC for simplicity than Shenandoah.
OTOH, I think Shenandoah is more sophisticated and may deal/degrade
better in edge cases (pacing, degenerate and full).
Plus Shenandoah is available in many architectures, OSes, Java versions.

In edge cases, I'd feel more confident in enlarging the heap than
trying to tune edge cases.
If both GCs are slightly overprovisioned in heap size (so that they
never reach danger zone), GC pauses are basically a solved problem, so
either ZGC or Shenandoah will do the job.
I may be grossly oversimplifying here, but I'm open to hear opinions
from the source ;)

Thanks!

-- 
Simone Bordet
---
Finally, no matter how good the architecture and design are,
to deliver bug-free software with optimal performance and reliability,
the implementation technique must be flawless.   Victoria Livschitz

From rkennke at redhat.com  Mon Sep 30 21:24:30 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 30 Sep 2019 23:24:30 +0200
Subject: Shenandoah 2.0
In-Reply-To: <CAFWmRJ3gXnCXdBs71Z4GfFpka=2wHKL1xr7+YkfovnP_TbL0rA@mail.gmail.com>
References: <CAFWmRJ05LDbNYdx9T-PjcTYLyw=_T_9wyDi4951OTpeKgUu+yg@mail.gmail.com>
 <e70b7092-ea42-4e57-f1cf-a49974c9b78e@redhat.com>
 <CAFWmRJ3gXnCXdBs71Z4GfFpka=2wHKL1xr7+YkfovnP_TbL0rA@mail.gmail.com>
Message-ID: <92c31568-f4ff-668a-b1e3-feab16bd168f@redhat.com>

Hi Simone,

>> Regarding the traversal mode. It only has a single concurrent phase that
>> does all of marking, compacting and updating-references in a single
>> pass. It is book-ended by a pause each, similar to init-mark and
>> final-update-refs pause to do initialize the traversal and to do some
>> bookkeeping and cleanup stuff. The liveness data of one cycle feeds into
>> the cset decisions of the subsequent cycle.
> 
> Yes I tried to capture that into slide 53.
> Is it correct?

If I understand the slide correctly, then not. It still looks like there
3 phase, with overlap. It is really just one phase:

idle -> STW-init -> traversal (mark+evac+update) -> STW-end -> idle

and so on.

>> To be honest, I am not sure
>> this whole slide needs to exist or only serves to confuse people (even
>> more).
> 
> Oh. I thought it was ok to have 1 slide about traversal for completeness.
> Why you think it's confusing?
> And why you say "even more"?

Because concurrent GCs are confusing to begin with (what with moving
objects from under you feet while you go). Doing all in 1 phase is even
more so.

> I'd be happy to clarify or remove confusing stuff.

It's not you or your slides, it's the subject matter. If you like it,
leave Traversal GC in.

>> I'd probably add one or two comparison slides at the end that highlights
>> the pros and cons of each one.
> 
> "Each one" as in comparison between ZGC and Shenandoah

yes

>, or "each one"
> as in comparison between non-traversal and traversal?

no

>> That's what people usually want to know:
>> 'which concurrent GC is for me?'
> 
> My experience is typically divided in 2 here, at the ends of the spectrum.
> Many don't care at all - give them ZGC or Shenandoah to replace
> G1/CMS/Parallel because "it's better" and they switch blindly.
> Few are GC maniacs and put 42 command line options to tune everything
> because they read so on StackOverflow.
> Those that can tell apart ZGC and Shenandoah may have some idea
> already of what's better for their use case, but again they are savvy
> enough to try both and actually verify what's better for them.

Well, such slides would help the former 2 categories of users to become
more educated, and may also have something new for the experts in
category 3, I'd think :-)

> Honestly I can't tell myself.
> I like better ZGC for simplicity than Shenandoah.

>From users perspective, both are pretty much -XX:+UseZGC or
-XX:+UseShenandoahGC and not much to configure. Even power users will
rarely need much tuning, so yeah.

> OTOH, I think Shenandoah is more sophisticated and may deal/degrade
> better in edge cases (pacing, degenerate and full).
> Plus Shenandoah is available in many architectures, OSes, Java versions.

yeah, and compressed oops is a big deal for some users.

> In edge cases, I'd feel more confident in enlarging the heap than
> trying to tune edge cases.
> If both GCs are slightly overprovisioned in heap size (so that they
> never reach danger zone), GC pauses are basically a solved problem, so
> either ZGC or Shenandoah will do the job.
> I may be grossly oversimplifying here, but I'm open to hear opinions
> from the source ;)

Yeah that's pretty much it. Shenandoah's pacing/degrading helps with
avoiding the edge-cases even with tight heaps, there's not much to tune
for this either.

I hope this clarifies a little.

Roman


From fw at deneb.enyo.de  Mon Sep 30 21:46:07 2019
From: fw at deneb.enyo.de (Florian Weimer)
Date: Mon, 30 Sep 2019 23:46:07 +0200
Subject: Shenandoah 2.0
In-Reply-To: <2d926edf-67b6-4828-f26e-8f6d38c4148b@redhat.com> (Roman Kennke's
 message of "Mon, 30 Sep 2019 22:25:10 +0200")
References: <CAFWmRJ05LDbNYdx9T-PjcTYLyw=_T_9wyDi4951OTpeKgUu+yg@mail.gmail.com>
 <2d926edf-67b6-4828-f26e-8f6d38c4148b@redhat.com>
Message-ID: <87blv1fof4.fsf@mid.deneb.enyo.de>

* Roman Kennke:

>>, but what versions
>> of 11 and 8 have it?
>> Only RH builds and only available via RH Linux (i.e. no generic Linux
>> builds with Shenandoah 2.0)? Windows? MacOS?
>
> RHEL (and derivatives, CentOS, Fedora, etc) ship Shenandoah, but none
> has '2.0' yet.

That's for java-11-openjdk, right?  java-latest-openjdk has it because
it corresponds to OpenJDK 13 (at time of writing).  Or does
updates-testing not count? 8-)