RFR (XS) 8230425: Shenandoah forces +UseNUMAInterleaving even after explicitly disabled

Aleksey Shipilev shade at redhat.com
Mon Sep 2 08:31:26 UTC 2019


Bug:
  https://bugs.openjdk.java.net/browse/JDK-8230425

Shenandoah enables NUMA when possible, but it also unconditionally sets UseNUMAInterleaving, which
is not correct and overrides user setting.

Fix:

diff -r a333fdeb8de0 src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
--- a/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp   Fri Aug 30 09:37:41 2019 +0200
+++ b/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp   Mon Sep 02 10:29:49 2019 +0200
@@ -65,5 +65,7 @@
   if (FLAG_IS_DEFAULT(UseNUMA)) {
     FLAG_SET_DEFAULT(UseNUMA, true);
-    FLAG_SET_DEFAULT(UseNUMAInterleaving, true);
+    if (FLAG_IS_DEFAULT(UseNUMAInterleaving)) {
+      FLAG_SET_DEFAULT(UseNUMAInterleaving, true);
+    }
   }

Testing: manual testing, hotspot_gc_shenandoah

-- 
Thanks,
-Aleksey



More information about the shenandoah-dev mailing list