RFR: sh/jdk11 assert failure because IfNode input is a Phi

Aleksey Shipilev shade at redhat.com
Mon Sep 2 15:38:54 UTC 2019


On 9/2/19 5:29 PM, Roland Westrelin wrote:
>> This seems to be partially backporting this change, right?
>>   8213381: Hook to allow GC to inject Node::Ideal() calls
> 
> Yes.

I have just requested the backport for it. It should be in 11.0.6.

>> We would need to pick that up in 11.0.6 to minimize upstream differences. The current patch seems
>> okay for sh/jdk11, as it is pretty straight-forward. If we want to be extra-clean, I'd wait for
>> 8213381 backport to arrive via 11u.
> 
> I'm fine with that but we will have to remember that we need to undo the
> previous fix too.

Meahwhile, I think we are clear to push your patch to sh/jdk11, even though it means accepting a bit
of upstream deviation. We already have it with BarrierSetC2::ideal_node nearby.

Roman, do you concur?

-- 
Thanks,
-Aleksey



More information about the shenandoah-dev mailing list