RFR: JDK-8231087: Shenandoah: Self-fixing references
Aleksey Shipilev
shade at redhat.com
Wed Sep 18 15:07:32 UTC 2019
On 9/18/19 4:00 PM, Roman Kennke wrote:
> Incremental diff:
> http://cr.openjdk.java.net/~rkennke/JDK-8231087/webrev.01.diff/
> Full:
> http://cr.openjdk.java.net/~rkennke/JDK-8231087/webrev.01/
*) shenandoah_globals.hpp:
Please make sure indenting on L396-397 matches other options:
395 diagnostic(bool, ShenandoahSelfFixing, true, \
396 "Fix references with load reference barrier. Disabling this " \
397 "might degrade performance.") \
...for example:
381 diagnostic(bool, ShenandoahOptimizeStaticFinals, true, \
382 "Optimize barriers on static final fields. " \
383 "Turn it off for maximum compatibility with reflection or JNI " \
384 "code that manipulates final fields.") \
Otherwise looks good. No need for another review.
--
Thanks,
-Aleksey
More information about the shenandoah-dev
mailing list