RFR (XS) 8242228: Shenandoah: remove unused ShenandoahCollectionSet methods
Aleksey Shipilev
shade at redhat.com
Mon Apr 6 16:44:35 UTC 2020
RFE:
https://bugs.openjdk.java.net/browse/JDK-8242228
Fix:
diff -r 5461ecb40ab4 src/hotspot/share/gc/shenandoah/shenandoahCollectionSet.cpp
--- a/src/hotspot/share/gc/shenandoah/shenandoahCollectionSet.cpp Mon Apr 06 18:39:02 2020 +0200
+++ b/src/hotspot/share/gc/shenandoah/shenandoahCollectionSet.cpp Mon Apr 06 18:44:12 2020 +0200
@@ -94,21 +94,4 @@
}
-bool ShenandoahCollectionSet::add_region_check_for_duplicates(ShenandoahHeapRegion* r) {
- if (!is_in(r)) {
- add_region(r);
- return true;
- } else {
- return false;
- }
-}
-
-void ShenandoahCollectionSet::remove_region(ShenandoahHeapRegion* r) {
- assert(ShenandoahSafepoint::is_at_shenandoah_safepoint(), "Must be at a safepoint");
- assert(Thread::current()->is_VM_thread(), "Must be VMThread");
- assert(is_in(r), "Not in collection set");
- _cset_map[r->index()] = 0;
- _region_count --;
-}
-
void ShenandoahCollectionSet::clear() {
assert(ShenandoahSafepoint::is_at_shenandoah_safepoint(), "Must be at a safepoint");
diff -r 5461ecb40ab4 src/hotspot/share/gc/shenandoah/shenandoahCollectionSet.hpp
--- a/src/hotspot/share/gc/shenandoah/shenandoahCollectionSet.hpp Mon Apr 06 18:39:02 2020 +0200
+++ b/src/hotspot/share/gc/shenandoah/shenandoahCollectionSet.hpp Mon Apr 06 18:44:12 2020 +0200
@@ -57,8 +57,4 @@
// Add region to collection set
void add_region(ShenandoahHeapRegion* r);
- bool add_region_check_for_duplicates(ShenandoahHeapRegion* r);
-
- // Remove region from collection set
- void remove_region(ShenandoahHeapRegion* r);
// MT version
Testing: hotspot_gc_shenandoah
--
Thanks,
-Aleksey
More information about the shenandoah-dev
mailing list