[15] RFR(T) 8242370: Enable JFR TestGCPhaseConcurrent test for Shenandoah

Zhengyu Gu zgu at redhat.com
Wed Apr 8 13:55:00 UTC 2020


Hi Stefan,

Thanks for pointing out. I am taking your patch.

Okay to push?

-Zhengyu

On 4/8/20 9:25 AM, Stefan Karlsson wrote:
> Hi Zhengyu,
> 
> Unfortunately, this patch breaks the dispatching of the tests if the 
> user specifies the the GC to test.
> 
> For example:
> makec ../build/fastdebug test 
> TEST=test/jdk/jdk/jfr/event/gc/detailed/TestGCPhaseConcurrent.java 
> JTREG="JAVA_OPTIONS=-XX:+UseZGC"
> 
> Will try to run the Shenandoah run line with both -XX:+UseZGC and 
> -XX:+UseShenandoahGC.
> 
> You need to split this up into separate run like this:
> https://cr.openjdk.java.net/~stefank/8242370/webrev.01/
> 
> Thanks,
> StefanK
> 
> On 2020-04-08 14:46, Zhengyu Gu wrote:
>> JDK-8241984 fixed top level concurrent event in Shenandoah, let's 
>> enable this test to ensure no regression in the future.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8242370
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8242370/webrev.00/
>>
>> Test:
>>    TestGCPhaseConcurrent.java test on Linux x86_64
>>
>>
>> Thanks,
>>
>> -Zhengyu
>>
> 



More information about the shenandoah-dev mailing list