[15] RFR 8243323: Shenandoah: Recycle immediate garbage before concurrent class unloading

Aleksey Shipilev shade at redhat.com
Wed Apr 22 19:17:50 UTC 2020


On 4/22/20 9:16 PM, Zhengyu Gu wrote:
> On 4/22/20 2:13 PM, Aleksey Shipilev wrote:
>> On 4/22/20 5:07 PM, Zhengyu Gu wrote:
>>>> *) This is awkward, why does it piggyback on is_concurrent_weak_root_in_progress? It should probably
>>>> have its own flag, and that flag should only be set when SCR::should_do_concurrent_class_unloading()
>>>> is true.
>>
>> ...
>>
>>> http://cr.openjdk.java.net/~zgu/JDK-8243323/webrev.01/
>>
>> Looks better. It still does not answer the question why don't we do the separate flag for
>> concurrent_class_unloading (see above), which AFAIU would eliminate awkwardness like this:
>>
> 
> I am thinking about degen entry after weak roots, to avoid trying to 
> evacuate nmethod metadata, which may be fruitless. So, these code will 
> need to further be tweaked ...
> 
> Let's wait to see if we need another flag, ok?

All right, fine then.

-- 
Thanks,
-Aleksey



More information about the shenandoah-dev mailing list