RFR (XS) 8243465: Shenandoah: ditch unused pause_other, conc_other counters

Aleksey Shipilev shade at redhat.com
Thu Apr 23 06:55:24 UTC 2020


RFE:
  https://bugs.openjdk.java.net/browse/JDK-8243465

Spotted another leftover. There are two counters: pause_other, conc_other that are unused. They were
there to cater for quick development work, but then every time we just added the temporary counters
instead. We should remove these for clarity.

Fix:

diff -r a829b346e89f src/hotspot/share/gc/shenandoah/shenandoahPhaseTimings.hpp
--- a/src/hotspot/share/gc/shenandoah/shenandoahPhaseTimings.hpp        Thu Apr 23 08:44:49 2020 +0200
+++ b/src/hotspot/share/gc/shenandoah/shenandoahPhaseTimings.hpp        Thu Apr 23 08:54:34 2020 +0200
@@ -145,8 +145,4 @@
                                                                                        \
   f(conc_uncommit,                                  "Concurrent Uncommit")             \
-                                                                                       \
-  /* Unclassified */                                                                   \
-  f(pause_other,                                    "Pause Other")                     \
-  f(conc_other,                                     "Concurrent Other")                \
   // end

Testing: hotspot_gc_shenandoah

-- 
Thanks,
-Aleksey



More information about the shenandoah-dev mailing list