RFR: JDK-8241007 Shenandoah: remove ShenandoahCriticalControlThreadPriority support

Nikola Grcevski Nikola.Grcevski at microsoft.com
Sat Aug 8 18:40:23 UTC 2020


Thanks so much Aditya!

I've removed the test and updated the webrev:

Webrev: http://cr.openjdk.java.net/~burban/nikola/JDK-8241007/webrev0.0/

Cheers,
Nikola

-----Original Message-----
From: Aditya Mandaleeka <adityam at microsoft.com> 
Sent: August 8, 2020 12:11 PM
To: Nikola Grcevski <Nikola.Grcevski at microsoft.com>; shenandoah-dev at openjdk.java.net
Subject: RE: RFR: JDK-8241007 Shenandoah: remove ShenandoahCriticalControlThreadPriority support

Hey Nikola,

The code change looks good to me. There's also a test you'll need to
remove: gc/shenandoah/options/TestCriticalControlThreadPriority.java.

Thanks,
Aditya

-----Original Message-----
From: shenandoah-dev <shenandoah-dev-retn at openjdk.java.net> On Behalf Of Nikola Grcevski
Sent: Friday, August 7, 2020 8:08 AM
To: shenandoah-dev at openjdk.java.net
Subject: RFR: JDK-8241007 Shenandoah: remove ShenandoahCriticalControlThreadPriority support

Hello Shenandoah-dev, 

Please review this small change that removes the ShenandoahCriticalControlThreadPriority option and its usage:

Webrev: http://cr.openjdk.java.net/~burban/nikola/JDK-8241007/webrev0.0/
JBS: https://bugs.openjdk.java.net/browse/JDK-8241007

I've tested build on both slowdebug and release and I ran few GC heavy workloads with it.

If the change looks good, I'll need a sponsor please.

Thank you!
Nikola




More information about the shenandoah-dev mailing list