[16] RFR: 8241574: Shenandoah: remove ShenandoahAssertToSpaceClosure

Aleksey Shipilev shade at redhat.com
Mon Aug 10 06:35:40 UTC 2020


On 8/6/20 4:06 PM, Charlie Gracie wrote:
> Please review this small change that removes the unused ShenandoahAssertToSpaceClosure
> closure. JDK 8223774 [1] removed the last use of this closure.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8241574
> Webrev: http://cr.openjdk.java.net/~burban/cgracie/remove_closure/webrev0.0/

Looks fine.

Process wrinkles:
 - The upstream changes need to be reviewed at hotspot-gc-dev@, possibly cc'ing shenandoah-dev at .
CC'ed myself.
 - The webrev is misformatted. Notably, "Patch of changes:" is a garbage link, and _that_ is usually
what is used by sponsors to apply the whole change. I had to reassemble the patch from individual
file patches.

I'll sponsor.

-- 
Thanks,
-Aleksey



More information about the shenandoah-dev mailing list