RFR: 8251451: Shenandoah: Remark ObjectSynchronizer roots with I-U
Roman Kennke
rkennke at redhat.com
Wed Aug 12 13:02:28 UTC 2020
On Wed, 2020-08-12 at 08:47 -0400, Zhengyu Gu wrote:
> Hmmm... seems that it duplicated thread remarking work also ...
Why? Can you explain?
Thanks,
Roman
>
> -Zhengyu
>
> On 8/12/20 6:42 AM, Aleksey Shipilev wrote:
> > On 8/12/20 12:36 PM, Roman Kennke wrote:
> > > http://cr.openjdk.java.net/~rkennke/JDK-8251451/webrev.01/
> >
> > Yes, that's better. The indenting is off, though: lots of space
> > before "_claimed", and "public" is
> > moved. Should be:
> >
> > private:
> > ShenandoahConcurrentMark* _cm;
> > TaskTerminator* _terminator;
> > bool _dedup_string;
> > ShenandoahSharedFlag _claimed_syncroots;
> >
> > public:
> > ShenandoahFinalMarkingTask(ShenandoahConcurrentMark* cm,
> > TaskTerminator* terminator, bool
> > dedup_string) :
> >
> > No need for another review.
> >
More information about the shenandoah-dev
mailing list