[11] RFR: Cease support for shenandoah/jdk11

[Aditya Mandaleeka]

A couple of minor comments on the wording of the warning:

- "This JDK would not get" -> "This JDK will not get"
- "from the vendor that has Shenandoah enabled" -> "from a vendor that has Shenandoah enabled"
- My preference would be to have an Oxford comma after "functionality" but I'll leave that up to you :) .

Other than that, this looks good to me.

-Aditya

-----Original Message-----
From: shenandoah-dev <shenandoah-dev-retn at openjdk.java.net> On Behalf Of Roman Kennke
Sent: Wednesday, August 12, 2020 1:18 AM
To: Aleksey Shipilev <shade at redhat.com>; shenandoah-dev at openjdk.java.net
Subject: Re: [11] RFR: Cease support for shenandoah/jdk11

Sounds good to me!

Thanks,
Roman

On Wed, 2020-08-12 at 09:52 +0200, Aleksey Shipilev wrote:
> 	Error verifying signature: Cannot verify message signature:
> Incorrect message format
> I think it is time to sunset the sh/jdk11 repository, like we did for
> sh/jdk12:
>   
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhg.o
> penjdk.java.net%2Fshenandoah%2Fjdk12%2Frev%2F4436df5d798c&data=02%
> 7C01%7Cadityam%40microsoft.com%7C479acc72f1a442322d4908d83e9853cf%7C72
> f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637328171246957401&sdata=
> wYhzM%2F%2F88awSp%2F6VcMsNmRQrR9BECYx7YRtiIzVcV%2BY%3D&reserved=0
> 
> sh/jdk11 only difference against jdk11 upstream are tags and enabling 
> Shenandoah during build:
>   
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbuil
> ds.shipilev.net%2Fpatch-openjdk-shenandoah-jdk11%2F&data=02%7C01%7
> Cadityam%40microsoft.com%7C479acc72f1a442322d4908d83e9853cf%7C72f988bf
> 86f141af91ab2d7cd011db47%7C1%7C0%7C637328171246957401&sdata=pcGyCZ
> %2BMu%2F%2FybaWL7ute86oZ3ZZ18h%2BS6WFa5R9RQLw%3D&reserved=0
> 
> Let's add this patch to sh/jdk11:
> 
> diff -r 4f528121104a
> src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
> --- a/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp   Wed
> Aug 12 09:19:23 2020 +0200
> +++ b/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp   Wed
> Aug 12 09:42:36 2020 +0200
> @@ -29,10 +29,19 @@
>  #include "utilities/defaultStream.hpp"
> 
>  void ShenandoahArguments::initialize() {
> +  log_warning(gc)("*************************************************
> *************************");
> +  log_warning(gc)("*  Shenandoah/JDK 11 is now maintained in
> upstream OpenJDK 11.           *");
> +  log_warning(gc)("*  This JDK would not get security, functionality
> or performance fixes.  *");
> +  log_warning(gc)("*  Use this build at your own
> risk.                                      *");
> +  log_warning(gc)("*                                                
>                         *");
> +  log_warning(gc)("*  For the latest version, use the most recent
> OpenJDK 11 update release *");
> +  log_warning(gc)("*  from the vendor that has Shenandoah enabled in
> their builds.          *");
> +  log_warning(gc)("*************************************************
> *************************");
> +
>  #if !(defined AARCH64 || defined AMD64 || defined IA32)
>    vm_exit_during_initialization("Shenandoah GC is not supported on 
> this platform.");  #endif
> 
> Testing: sh/jdk11 builds, observing the warning message
>