[11] RFR: Cease support for shenandoah/jdk11

Roman Kennke rkennke at redhat.com
Wed Aug 12 16:43:03 UTC 2020


Yes, that looks good to me!

Thanks,
Roman

On Wed, 2020-08-12 at 17:23 +0200, Aleksey Shipilev wrote:
> On 8/12/20 5:18 PM, Aditya Mandaleeka wrote:
> > A couple of minor comments on the wording of the warning:
> > 
> > - "This JDK would not get" -> "This JDK will not get"
> > - "from the vendor that has Shenandoah enabled" -> "from a vendor
> > that has Shenandoah enabled"
> > - My preference would be to have an Oxford comma after
> > "functionality" but I'll leave that up to you :) .
> > 
> > Other than that, this looks good to me.
> Okay, let's push this then?
> 
> diff -r 21ab376eb1e7
> src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
> --- a/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp   Wed
> Aug 12 09:53:25 2020 +0200
> +++ b/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp   Wed
> Aug 12 17:23:36 2020 +0200
> @@ -31,15 +31,15 @@
>  #include "utilities/defaultStream.hpp"
> 
>  void ShenandoahArguments::initialize() {
>    log_warning(gc)("*************************************************
> *************************");
>    log_warning(gc)("*  Shenandoah/JDK 11 is now maintained in
> upstream OpenJDK 11.           *");
> -  log_warning(gc)("*  This JDK would not get security, functionality
> or performance fixes.  *");
> +  log_warning(gc)("*  This JDK will not get security, functionality,
> or performance fixes.  *");
>    log_warning(gc)("*  Use this build at your own
> risk.                                      *");
>    log_warning(gc)("*                                                
>                         *");
>    log_warning(gc)("*  For the latest version, use the most recent
> OpenJDK 11 update release *");
> -  log_warning(gc)("*  from the vendor that has Shenandoah enabled in
> their builds.          *");
> +  log_warning(gc)("*  from a vendor that has Shenandoah enabled in
> their builds.            *");
>    log_warning(gc)("*************************************************
> *************************");
> 
>  #if !(defined AARCH64 || defined AMD64 || defined IA32)
>    vm_exit_during_initialization("Shenandoah GC is not supported on
> this platform.");
>  #endif
> 
> 



More information about the shenandoah-dev mailing list