RFR: 8257641: Shenandoah: Query is_at_shenandoah_safepoint() from control thread should return false [v2]

Zhengyu Gu zgu at openjdk.java.net
Thu Dec 3 15:43:17 UTC 2020


On Thu, 3 Dec 2020 15:22:33 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update
>
> src/hotspot/share/gc/shenandoah/shenandoahUtils.hpp line 153:
> 
>> 151:     // Shenandoah GC specific safepoints are scheduled by control thread,
>> 152:     // so that, querying from control thread can not happen during those
>> 153:     // safepoints.
> 
> Consider this wording:
> 
>     // Shenandoah GC specific safepoints are scheduled by control thread.
>     // So if we are enter here from control thread, then we are definitely not
>     // at Shenandoah safepoint, but at something else.

Updated accordingly.

Thanks, Aleksey.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1600


More information about the shenandoah-dev mailing list