RFR: 8258239: Shenandoah: Used wrong closure to mark concurrent roots
Roman Kennke
rkennke at openjdk.java.net
Mon Dec 14 15:31:57 UTC 2020
On Mon, 14 Dec 2020 15:20:42 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:
> During concurrent mark phase, there should not have forwarded objects. Therefore, it should use ShenandoahMarkRefsClosure to mark concurrent roots, instead of ShenandoahMarkResolveRefsClosure.
>
> Note: this is *not* a correctness bug, but performance one, as ShenandoahMarkResolveRefsClosure closure unnecessarily resolves forwarding pointers, where always resolved to themselves.
>
> - [x] hotspot_gc_shenandoah
Looks good to me!
-------------
Marked as reviewed by rkennke (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1768
More information about the shenandoah-dev
mailing list