RFR (sh/jdk8): Backport: JDK-8231086: Shenandoah: Stronger invariant for object-arraycopy

Aleksey Shipilev shade at redhat.com
Thu Feb 20 18:58:47 UTC 2020


On 2/20/20 7:43 PM, Roman Kennke wrote:
> http://cr.openjdk.java.net/~rkennke/JDK-8231086-jdk8/webrev.01/

Okay, brief look:

*) src/cpu/aarch64/vm/stubGenerator_aarch64.cpp
   src/cpu/x86/vm/stubGenerator_x86_32.cpp

 Should new switch cases be protected by  #if INCLUDE_ALL_GCS too?

*) ShenandoahBarrierSet::arraycopy_pre_work implementation: indenting is off, is this from original
changeset?

*) I believe test is misplaced. Did that test even run?
  test/hotspot/jtreg/gc/shenandoah/compiler/TestClone.java
should be
  test/gc/shenandoah/compiler/TestClone.java

-- 
Thanks,
-Aleksey



More information about the shenandoah-dev mailing list