RFR: Refine ShenandoahEvacLockGranularity default and bounds check

[Aleksey Shipilev]

On 7/6/20 5:40 PM, Roman Kennke wrote:
> http://cr.openjdk.java.net/~rkennke/evac-lock-args/webrev.00/

Couple of nits:

*) Would you like to test -XX:ShenandoahEvacLockGranularity=0 as well, as long as you are testing
the option boundaries?

*) There is no need to declare "private static void test()", you might as well do it in "main()".

*) Argument indent is a bit wrong, should be another space before "proper" at L618:

 617    byte_size_in_proper_unit(locking_card_size), proper_unit_for_byte_size(locking_card_size),
 618    byte_size_in_proper_unit(RegionSizeBytes),  proper_unit_for_byte_size(RegionSizeBytes));

*) I think this message is too broad:

  616     err_msg message("1 << (ShenandoahEvacLockGranularity + LogHeapWordSize) (" SIZE_FORMAT
"%s) should be lower than region size (" SIZE_FORMAT "%s).",

Suggestion:

err_msg message("Evac locking card size (" SIZE_FORMAT "%s) should be lower than region size ("
SIZE_FORMAT "%s).",

No need for another review.

-- 
Thanks,
-Aleksey