RFR(sh/jdk11): Shenandoah: Isolate Shenandoah-specific aarch64 changes

Roman Kennke rkennke at redhat.com
Tue Jul 7 12:24:36 UTC 2020


On Tue, 2020-07-07 at 14:03 +0200, Aleksey Shipilev wrote:
> On 7/7/20 10:36 AM, Roman Kennke wrote:
> > This isolates the remaining shared-code changes in aarch64 in
> > shenandoah/jdk11. The intention is that when building without
> > Shenandoah, it'd compile the exact same code as current upstream
> > jdk11u, and that it is obvious from the vs-upstream-patch that it
> > does.
> > 
> > http://cr.openjdk.java.net/~rkennke/shjdk11-isolate-aarch64/webrev.00/
> 
> This:
> 
>  876 #if INCLUDE_SHENANDOAHGC
>  877   if (UseShenandoahGC) {
>  878     __ load_mirror(r10, rmethod);
>  879     __ stp(r10, zr, Address(sp, 4 * wordSize));
>  880   } else {
>  881 #endif
>  882   __ load_mirror(rscratch1, rmethod);
>  883   __ stp(rscratch1, zr, Address(sp, 4 * wordSize));
>  884   SHENANDOAHGC_ONLY(})
> 
> ...is probably just:
> 
>  #if INCLUDE_SHENANDOAHGC
>    if (UseShenandoahGC) {
>      __ load_mirror(r10, rmethod);
>      __ stp(r10, zr, Address(sp, 4 * wordSize));
>    } else
>  #else
>    {
>      __ load_mirror(rscratch1, rmethod);
>      __ stp(rscratch1, zr, Address(sp, 4 * wordSize));
>    }
>  #endif
> 
> 
> Otherwise looks good.
> 

Thanks! I pushed it with the suggested change.

Roman



More information about the shenandoah-dev mailing list