RFR(sh/jdk11): Shenandoah: Move markBitMap.* and parallelCleaning.* to shenandoah subdirectory

Roman Kennke rkennke at redhat.com
Tue Jul 7 14:40:19 UTC 2020


> On 7/7/20 4:29 PM, Roman Kennke wrote:
> > > *) In other JDKs, we have:
> > >  ./src/hotspot/share/gc/shenandoah/shenandoahParallelCleaning.inl
> > > ine.
> > > hpp
> > >  ./src/hotspot/share/gc/shenandoah/shenandoahParallelCleaning.hpp
> > >  ./src/hotspot/share/gc/shenandoah/shenandoahParallelCleaning.cpp
> > > 
> > > It is probably better to match the names?
> > 
> > We *also* have them in sh/jdk11. No I'd rather keep them named as
> > they
> > are, also makes backporting a little easier (if we ever need to
> > backport from gc/shared variants of later JDKs).
> 
> Oh... Eh... It looks to me those need to be merged together at some
> point.
> 

I don't know. Seems to make more sense to leave them as they are in
sh/jdk11, they are still separate in later JDKs (and really shared with
G1).

> > Can I push webrev.00 ?
> 
> All right, fine. (Although I think sh/jdk11 is still closed for 11u
> release)

Ok, I will clarify with Andrew Hughes before pushing. (I already pushed
the aarch64-cleanup so if that's a problem, we need to be careful with
tags or back-out that change).

Thanks,
Roman



More information about the shenandoah-dev mailing list