RFR: 8249877: Shenandoah: Report number of dead weak oops during STW weak roots

Roman Kennke rkennke at redhat.com
Wed Jul 22 14:49:37 UTC 2020


On Wed, 2020-07-22 at 10:07 -0400, Zhengyu Gu wrote:
> Second thought, you may just want to call 
> _weak_processing_task.report_num_dead() in 
> ShenandoahParallelWeakRootsCleaningTask's destructor.
> 

Right, that would be cleaner. I already pushed the change, I filed a
new one for this:

https://bugs.openjdk.java.net/browse/JDK-8249884

Thanks,
Roman

> Thanks,
> 
> -Zhengyu
> 
> 
> 
> On 7/22/20 9:15 AM, Zhengyu Gu wrote:
> > Looks good.
> > 
> > Thanks,
> > 
> > -Zhengyu
> > 
> > On 7/22/20 8:55 AM, Roman Kennke wrote:
> > > MemberNameLeak test is failing when running in STW mode, because
> > > ResolvedMethodTable never receives a gc_notification() call,
> > > which is
> > > usually done by calling report_num_dead() on the corresponding
> > > oop-
> > > storage. We do that in concurrent-weak-processing, but apparently
> > > not
> > > during STW weak processing.
> > > 
> > > Bug:
> > > https://bugs.openjdk.java.net/browse/JDK-8249877
> > > Webrev:
> > > http://cr.openjdk.java.net/~rkennke/JDK-8249877/webrev.00/
> > > 
> > > Testing: hotspot_gc_shenandoah, MemberNameLeak.java, tier1 &
> > > tier2
> > > without regressions.
> > > 
> > > Ok?
> > > 
> > > 
> > > 



More information about the shenandoah-dev mailing list