RFR: 8231668: Remove ForceDynamicNumberOfGCThreads
Aditya Mandaleeka
adityam at microsoft.com
Fri Mar 13 19:41:28 UTC 2020
Thank you both for the reviews, and thanks for sponsoring, Aleksey!
-Aditya
-----Original Message-----
From: Aleksey Shipilev <shade at redhat.com>
Sent: Friday, March 13, 2020 5:32 AM
To: Thomas Schatzl <thomas.schatzl at oracle.com>; Aditya Mandaleeka <adityam at microsoft.com>; Severin Gehwolf <sgehwolf at redhat.com>; hotspot-gc-dev at openjdk.java.net; shenandoah-dev <shenandoah-dev at openjdk.java.net>
Subject: Re: RFR: 8231668: Remove ForceDynamicNumberOfGCThreads
On 3/13/20 10:44 AM, Aleksey Shipilev wrote:
> On 3/13/20 10:38 AM, Thomas Schatzl wrote:
>> looks good. Please fix the copyright dates for the tests as well
>> since you did so for other files too already. No need for a re-review.
>
> +1, I would update those before pushing. Aditya, you don't need to do anything else.
>
>> Aleksey, will you sponsor the patch, or should I do it?
>
> Sure, I will sponsor it.
Copyright lines updated; jdk-submit is clean, hotspot_gc_shenandoah is clean.
Pushed:
https://hg.openjdk.java.net/jdk/jdk/rev/367b1f73904c
jcheck initially rejected the push, because:
remote: [jcheck b8f3bac16fc8 2019-03-12 09:27:17 -0700]
remote:
remote: > Changeset: 58392:8ac108cd32af
remote: > Author: shade
remote: > Date: 2020-03-13 13:22
remote: >
remote: > 8231668: Remove ForceDynamicNumberOfGCThreads
remote: > Reviewed-by: shade, tschatzl
remote: > Contributed-by: Aditya Mandaleeka <adityam at microsoft.com>
remote:
remote: Invalid contributor attribution
The email should have been proper one, with @.
--
Thanks,
-Aleksey
More information about the shenandoah-dev
mailing list