RFR: 8241081: Shenandoah: Do not modify update-watermark concurrently
Aleksey Shipilev
shade at redhat.com
Tue Mar 17 11:37:36 UTC 2020
On 3/17/20 12:33 PM, Roman Kennke wrote:
>>> Webrev:
>>> http://cr.openjdk.java.net/~rkennke/JDK-8241081/webrev.02/
>>
>> Looks good.
>>
>> One tiny thing: can you please read _update_watermark into local field, assert that value and return
>> the same one? Instead of doing effectively three memory accesses, which might disagree.
>
> Ok like this?
>
> http://cr.openjdk.java.net/~rkennke/JDK-8241081/webrev.03/
Yes.
--
Thanks,
-Aleksey
More information about the shenandoah-dev
mailing list