RFR (XS) 8241842: Shenandoah: inline ShenandoahHeapRegion::region_number

Aleksey Shipilev shade at redhat.com
Mon Mar 30 12:58:28 UTC 2020


RFE:
  https://bugs.openjdk.java.net/browse/JDK-8241842

ShenandoahHeapRegion::region_number is used on a few hotpaths, and should be inlined.

Fix:

diff -r 8aa307793ffe src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp
--- a/src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp  Mon Mar 30 14:49:17 2020 +0200
+++ b/src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp  Mon Mar 30 14:57:23 2020 +0200
@@ -78,8 +78,4 @@
 }

-size_t ShenandoahHeapRegion::region_number() const {
-  return _region_number;
-}
-
 void ShenandoahHeapRegion::report_illegal_transition(const char *method) {
   ResourceMark rm;
diff -r 8aa307793ffe src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp
--- a/src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp  Mon Mar 30 14:49:17 2020 +0200
+++ b/src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp  Mon Mar 30 14:57:23 2020 +0200
@@ -354,5 +354,7 @@
   }

-  size_t region_number() const;
+  inline size_t region_number() const {
+    return _region_number;
+  }

   // Allocation (return NULL if full)

Testing: hotspot_gc_shenandoah

-- 
Thanks,
-Aleksey



More information about the shenandoah-dev mailing list