[aarch64-port-dev ] [RFR] [8u] 8u262-b01 Upstream Sync

Aleksey Shipilev shade at redhat.com
Tue May 5 09:38:06 UTC 2020


On 5/5/20 7:39 AM, Andrew John Hughes wrote:
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u252-b01/corba/merge.changeset

Looks trivially good.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u262-b01/jaxp/merge.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u262-b01/jaxws/merge.changeset

Looks good.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u262-b01/jdk/merge.changeset

Huge JFR merge, looks good.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u262-b01/hotspot/merge.changeset

Huge JFR merge.

Not sure about this change:

diff --git a/src/share/vm/gc_implementation/shenandoah/shenandoahGCTraceTime.cpp
b/src/share/vm/gc_implementation/shenandoah/shenandoahGCTraceTime.cpp
--- a/src/share/vm/gc_implementation/shenandoah/shenandoahGCTraceTime.cpp
+++ b/src/share/vm/gc_implementation/shenandoah/shenandoahGCTraceTime.cpp
@@ -33,7 +33,7 @@
 #include "runtime/thread.inline.hpp"
 #include "runtime/timer.hpp"
 #include "utilities/ostream.hpp"
-#include "utilities/ticks.inline.hpp"
+#include "utilities/ticks.hpp"

It looks to me that .inline.hpp is always safe to include instead of .hpp. Changing it the other way
around may introduce build failures?

Otherwise looks fine.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u262-b01/langtools/merge.changeset

Looks good.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u262-b01/nashorn/merge.changeset

Looks good.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u262-b01/root/merge.changeset

Looks good.

> Ok to push?

Apart from the Shenandoah include question, the whole bunch looks good.

-- 
Thanks,
-Aleksey



More information about the shenandoah-dev mailing list