[aarch64-port-dev ] [RFR] [8u] 8u262-b01 Upstream Sync

Aleksey Shipilev shade at redhat.com
Wed May 6 09:12:37 UTC 2020


On 5/6/20 2:40 AM, Andrew John Hughes wrote:
> On 05/05/2020 10:38, Aleksey Shipilev wrote:
>> On 5/5/20 7:39 AM, Andrew John Hughes wrote:
>> Not sure about this change:
>>
>> diff --git a/src/share/vm/gc_implementation/shenandoah/shenandoahGCTraceTime.cpp
>> b/src/share/vm/gc_implementation/shenandoah/shenandoahGCTraceTime.cpp
>> --- a/src/share/vm/gc_implementation/shenandoah/shenandoahGCTraceTime.cpp
>> +++ b/src/share/vm/gc_implementation/shenandoah/shenandoahGCTraceTime.cpp
>> @@ -33,7 +33,7 @@
>>  #include "runtime/thread.inline.hpp"
>>  #include "runtime/timer.hpp"
>>  #include "utilities/ostream.hpp"
>> -#include "utilities/ticks.inline.hpp"
>> +#include "utilities/ticks.hpp"
>>
>> It looks to me that .inline.hpp is always safe to include instead of .hpp. Changing it the other way
>> around may introduce build failures?
>>
>> Otherwise looks fine.
> 
> Not when it doesn't exist :-)

Ah, okay then :D

-- 
Thanks,
-Aleksey



More information about the shenandoah-dev mailing list