On 5/11/20 8:24 PM, Zhengyu Gu wrote: > Looks good. Thanks. > While you are there: > > 150 if (!heap->is_concurrent_weak_root_in_progress()) { > 151 return; > 152 } I would prefer if that removal was done separately. -- Thanks, -Aleksey