[8] RFR: 2020-05-18, Bulk backports to sh/jdk8

[Zhengyu Gu]

Nit:

1)
130 void ShenandoahPhaseTimings::set_cycle_data(Phase phase, double time) {
  131 #ifdef ASSERT
  132   double d = _cycle_data[phase];
  133   assert(d == uninitialized(), err_msg("Should not be set yet: %s, 
current value: %lf", phase_name(phase), d));
  134 #endif
  135   _cycle_data[phase] = time;
  136 }
  137
  138

Double empty lines

2)
106 void 
ShenandoahStringDedup::parallel_oops_do(ShenandoahPhaseTimings::Phase 
phase, OopClosure* cl) {
  107   _queues->parallel_oops_do(cl);
  108   _table->parallel_oops_do(cl);
  109   _thread->parallel_oops_do(cl);


Timing for queue and table are added in a separate backport, but seems 
to miss for thread. It is a 8u specific.

Otherwise, looks good.

Thanks,

-Zhengyu


On 5/18/20 8:40 AM, Aleksey Shipilev wrote:
> https://cr.openjdk.java.net/~shade/shenandoah/backports/jdk8u-20200518/webrev.01/
> 
> This mostly backports the new logging to sh/jdk8:
>    [backport] 8243494: Shenandoah: set counters once per cycle
>    [backport] 8225216: gc/logging/TestMetaSpaceLog.java doesn't work for Shenandoah
>    [backport] 8239786: Shenandoah: print per-cycle statistics
>    [backport] 8243848: Shenandoah: Windows build fails after JDK-8239786
>    [backport] 8243573: Shenandoah: rename GCParPhases and related code
>    [backport] 8244180: Shenandoah: carry Phase to ShWorkerTimingsTracker explicitly
>    [backport] 8244226: Shenandoah: per-cycle statistics contain worker data from previous cycles
>    [backport] 8244326: Shenandoah: global statistics should not accept bogus samples
> 
> It took significant time to adjust the patches for 8u, so please review carefully.
> 
> Testing: hotspot_gc_shenandoah {fastdebug,release}, eyeballing the gc logs
>