RFR: 8255762: Shenandoah: Consolidate/streamline interpreter LRBs [v2]
Roman Kennke
rkennke at openjdk.java.net
Tue Nov 3 11:15:57 UTC 2020
On Tue, 3 Nov 2020 09:04:46 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>>
>> A few touch-ups
>
> src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp line 307:
>
>> 305: assert(tmp1 != dst, "");
>> 306: assert(tmp1 != src.base(), "");
>> 307: assert(tmp1 != src.index(), "");
>
> Is this just `assert_different_registers(tmp1, dst, src.base(), src.index())`, or am I missing something?
Not quite. dst can still legitimately be src.base(). Also, assert_different_registers() is somewhat unpractical because it fails in the wrong place. Anyhow, I rewrote it to be more succinct.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1010
More information about the shenandoah-dev
mailing list