RFR: 8255606: Enable concurrent stack processing on x86_32 platforms [v2]
Aleksey Shipilev
shade at openjdk.java.net
Tue Nov 3 12:16:01 UTC 2020
On Fri, 30 Oct 2020 12:14:55 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:
>> 8255606: Enable concurrent stack processing on x86_32 platforms
>
> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix jump direction
I have minor comments.
src/hotspot/cpu/x86/x86_32.ad line 656:
> 654: st->print_cr("POPL EBP"); st->print("\t");
> 655: if (do_polling() && C->is_method_compilation()) {
> 656: st->print("cmpptr rsp, poll_offset[thread] \n\t"
Let's say `CMPL` here? I don't think we reference `cmpptr` in outputs here. Also, note every instruction is capitalized in `x86_32.ad`.
src/hotspot/cpu/x86/x86_64.ad line 933:
> 931: if (do_polling() && C->is_method_compilation()) {
> 932: st->print("\t");
> 933: st->print_cr("cmpptr rsp, poll_offset[r15_thread] \n\t"
Ditto, leave `cmpq` here.
-------------
Changes requested by shade (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/945
More information about the shenandoah-dev
mailing list