RFR: 8255665: C2 should aggressively remove temporary hook nodes [v2]

[Tobias Hartmann]

On Mon, 2 Nov 2020 18:41:04 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Tobias Hartmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Restored handling of constant nodes
>
> src/hotspot/share/opto/cfgnode.cpp line 2308:
> 
>> 2306:           igvn->_worklist.remove(hook);
>> 2307:         }
>> 2308:         hook->destruct();
> 
> I think we should pass PhaseGVN* into destruct() and do removal from worklist there because it looks like repetitive pattern. Also we can take Compile pointer from PhaseGVN instead of calling Compile::current():
> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/node.cpp#L584

Thanks Vladimir, that's a good suggestion. I've updated the PR accordingly.

-------------

PR: https://git.openjdk.java.net/jdk/pull/994