RFR: 8256011: Shenandoah: Don't resurrect finalizably reachable objects [v4]

Roman Kennke rkennke at openjdk.java.net
Tue Nov 10 12:20:14 UTC 2020


> In the weak-LRB we currently return referents when it is 'marked', that is when it's either reachable strongly or through a finalizable object. This means a finalizable object can be resurrected by Reference.get(), which is wrong. Only truly strongly reachable objects should be returned by Reference.get() during weak-reference-processing. 
> 
> I had to reconsider the way we call into runtime-LRBs from generated code for these reasons:
>  - We need to distinguish phantom, weak and strong reference strength, and native vs in-heap access. Those are two orthogonal dimensions
>  - We can have strong and phantom native referents, and strong and weak in-heap referents
>  - Native referents are never compressed
> 
> Note that this depends on PR#1140.
> 
> Testing:
>  - [x] hotspot_gc_shenandoah
>  - [x] tier1 +UseShenandoahGC +ShenandoahVerify
>  - [ ] tier2 +UseShenandoahGC +ShenandoahVerify

Roman Kennke has updated the pull request incrementally with five additional commits since the last revision:

 - Whitespace changes
 - Mask decorators in hash/cmp, not in ctor
 - Use ShBarrierSet::is_strong_access() in CmpP optimization
 - separate code-paths for phantom- and weak-access in runtime-LRB
 - Give different name to different LRB runtime calls

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1109/files
  - new: https://git.openjdk.java.net/jdk/pull/1109/files/8d979eea..ac2674f5

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1109&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1109&range=02-03

  Stats: 33 lines in 4 files changed: 16 ins; 5 del; 12 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1109.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1109/head:pull/1109

PR: https://git.openjdk.java.net/jdk/pull/1109


More information about the shenandoah-dev mailing list