RFR: Generation affiliation transitions for heap regions. [v3]
Roman Kennke
rkennke at openjdk.java.net
Tue Nov 17 21:27:22 UTC 2020
On Tue, 17 Nov 2020 13:40:39 GMT, Bernd Mathiske <bmathiske at openjdk.org> wrote:
>> Preparatory renaming generation->affiliation since we will want to have a class called ShenandoahGeneration that is not an enum. The next PR will build on this. It will be a big refactoring that pulls code out of the ShenandoahHeap class and puts it into generation-specific classes that are subclasses of ShenandoahGeneration.
>>
>> The Affiliation declaration still sits in AllocRequest and not in ShenandoahHeapRegion or ShenandoahGeneration for the same reason as before: it is hard to get anything to compile in other combinations of what goes where. I tried.
>>
>> The card table update code in the set_affiliation() will be revised and augmented later, but seems OK as a first step.
>
> Bernd Mathiske has updated the pull request incrementally with one additional commit since the last revision:
>
> Add missing precomiled header include for Windows builds.
Looks good to me! Thanks!
-------------
Marked as reviewed by rkennke (Reviewer).
PR: https://git.openjdk.java.net/shenandoah/pull/7
More information about the shenandoah-dev
mailing list