RFR: 8256415: Shenandoah: Should evacuate/update codecache concurrently when class unloading is off [v3]

Zhengyu Gu zgu at openjdk.java.net
Wed Nov 18 00:32:26 UTC 2020


On Tue, 17 Nov 2020 21:46:05 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update comment
>
> src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 1746:
> 
>> 1744:       if (!is_degenerated_gc_in_progress()) {
>> 1745:         // We need to arm nmethods for concurrent codecache process, regardless concurrent
>> 1746:         // class unloading
> 
> Comment should probably not refer to previous implementations. Future readers will not see the connection there.

Thanks for reviewing.

Comment updated to "Arm nmethods for concurrent codecache processing."

-------------

PR: https://git.openjdk.java.net/jdk/pull/1271


More information about the shenandoah-dev mailing list