RFR: 8254320: Shenandoah: C2 native LRB should activate for non-cset objects [v2]

Roman Kennke rkennke at openjdk.java.net
Mon Oct 12 10:57:28 UTC 2020


On Mon, 12 Oct 2020 10:38:39 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Roman Kennke has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since
>> the last revision:
>>  - Merge remote-tracking branch 'upstream/master' into 8254320
>>  - 8254320: Shenandoah: C2 native LRB should activate for non-cset objects
>
> src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp line 1345:
> 
>> 1343:     // Wires !in_cset(obj) to slot 2 of region and phis
>> 1344:     Node* not_cset_ctrl = NULL;
>> 1345:     if (!lrb->is_native()) {
> 
> I think it deserves a comment why LRB-native is special.

Yup, I added a comment there. Thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/580


More information about the shenandoah-dev mailing list